xcm: fix for DenyThenTry Barrier (#7169)
Resolves (partially): https://github.com/paritytech/polkadot-sdk/issues/7148 (see _Problem 1 - `ShouldExecute` tuple implementation and `Deny` filter tuple_) This PR changes the behavior of `DenyThenTry` from the pattern `DenyIfAllMatch` to `DenyIfAnyMatch` for the tuple. I would expect the latter is the right behavior so make the fix in place, but we can also add a dedicated Impl with the legacy one untouched. ## TODO - [x] add unit-test for `DenyReserveTransferToRelayChain` - [x] add test and investigate/check `DenyThenTry` as discussed [here](https://github.com/paritytech/polkadot-sdk/pull/6838#discussion_r1914553990) and update documentation if needed --------- Co-authored-by:Branislav Kontur <bkontur@gmail.com> Co-authored-by:
Francisco Aguirre <franciscoaguirreperez@gmail.com> Co-authored-by: command-bot <> Co-authored-by:
Clara van Staden <claravanstaden64@gmail.com> Co-authored-by:
Adrian Catangiu <adrian@parity.io>
parent
db3ff60b
Showing
- Cargo.lock 2 additions, 0 deletionsCargo.lock
- cumulus/parachains/runtimes/bridge-hubs/common/Cargo.toml 6 additions, 0 deletionscumulus/parachains/runtimes/bridge-hubs/common/Cargo.toml
- cumulus/parachains/runtimes/bridge-hubs/common/src/barriers.rs 57 additions, 0 deletions...us/parachains/runtimes/bridge-hubs/common/src/barriers.rs
- cumulus/parachains/runtimes/bridge-hubs/common/src/lib.rs 2 additions, 0 deletionscumulus/parachains/runtimes/bridge-hubs/common/src/lib.rs
- cumulus/parachains/runtimes/bridge-hubs/common/tests/tests.rs 85 additions, 0 deletions...lus/parachains/runtimes/bridge-hubs/common/tests/tests.rs
- polkadot/xcm/xcm-builder/src/barriers.rs 6 additions, 8 deletionspolkadot/xcm/xcm-builder/src/barriers.rs
- polkadot/xcm/xcm-builder/src/tests/barriers.rs 232 additions, 0 deletionspolkadot/xcm/xcm-builder/src/tests/barriers.rs
- polkadot/xcm/xcm-builder/src/tests/mock.rs 4 additions, 3 deletionspolkadot/xcm/xcm-builder/src/tests/mock.rs
- polkadot/xcm/xcm-executor/src/traits/mod.rs 1 addition, 1 deletionpolkadot/xcm/xcm-executor/src/traits/mod.rs
- polkadot/xcm/xcm-executor/src/traits/should_execute.rs 64 additions, 0 deletionspolkadot/xcm/xcm-executor/src/traits/should_execute.rs
- prdoc/pr_7169.prdoc 14 additions, 0 deletionsprdoc/pr_7169.prdoc
Please register or sign in to comment