Skip to content
Snippets Groups Projects
  • Michal Kucharczyk's avatar
    frame-support: sp-runtime dependency updated (serde) (#2907) · c8112e2c
    Michal Kucharczyk authored
    `frame-support` crate compilation fails (reported by @koute):
    
    ```
    $ cargo check --no-default-features --target=wasm32-unknown-unknown
    
    error[E0277]: the trait bound `GC: Serialize` is not satisfied
        --> substrate/frame/support/src/genesis_builder_helper.rs:32:24
         |
    32   |     serde_json::to_string(&GC::default())
         |     --------------------- ^^^^^^^^^^^^^^ the trait `Serialize` is not implemented for `GC`
         |     |
         |     required by a bound introduced by this call
         |
    note: required by a bound in `serde_json::to_string`
        --> /home/kou/.cargo/registry/src/index.crates.io-6f17d22bba15001f/serde_json-1.0.111/src/ser.rs:2209:17
         |
    2207 | pub fn to_string<T>(value: &T) -> Result<String>
         |        --------- required by a bound in this function
    2208 | where
    2209 |     T: ?Sized + Serialize,
         |                 ^^^^^^^^^ required by this bound in `to_string`
    help: consider further restricting this bound
         |
    30   |     GC: BuildGenesisConfig + Default + serde::Serialize,
         |                                      ++++++++++++++++++
    ```
    
    This PR should fix this.
    
    For all runtimes `sp-runtime/serde` feature was likely enabled by this
    (and few other pallets):
    
    https://github.com/paritytech/polkadot-sdk/blob/f2a750ee/substrate/frame/system/Cargo.toml#L27
    Unverified
    c8112e2c
Code owners
Assign users and groups as approvers for specific file changes. Learn more.
This project manages its dependencies using Cargo. Learn more