Skip to content
  • Branislav Kontur's avatar
    Remove `(rococo/westend)-runtime` deps from testnet AssetHubs (#1979) · c284a931
    Branislav Kontur authored
    ## Problem
    
    This PR addresses the issue with testnet AssetHub builds, which was
    discovered during the execution of `bot bench`.
    
    https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/4038738
    ```
         Compiling asset-hub-rococo-runtime-wasm v1.0.0 (/builds/parity/mirrors/polkadot-sdk/target/production/wbuild/asset-hub-rococo-runtime)
      warning: Linking globals named 'Core_version': symbol multiply defined!
      error: failed to load bitcode of module "rococo_runtime-8799ee884447805a.rococo_runtime.0bc572b8-cgu.0.rcgu.o": 
      warning: `asset-hub-rococo-runtime-wasm` (lib) generated 1 warning
      error: could not compile `asset-hub-rococo-runtime-wasm` (lib) due to previous error; 1 warning emitted
    ```
    
    https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/4038739
    ```
    Compiling asset-hub-westend-runtime-wasm v1.0.0 (/builds/parity/mirrors/polkadot-sdk/target/production/wbuild/asset-hub-westend-runtime)
      warning: Linking globals named 'Core_version': symbol multiply defined!
      error: failed to load bitcode of module "westend_runtime-86d7844430f97d5c.westend_runtime.b7678d03-cgu.0.rcgu.o": 
      warning: `asset-hub-westend-runtime-wasm` (lib) generated 1 warning
      error: could not compile `asset-hub-westend-runtime-wasm` (lib) due to previous error; 1 warning emitted
    ```
    
    ## Solution
    
    - Removed dependencies on `rococo-runtime` and `westend-runtime`
    introduced by [this
    PR](https://github.com/paritytech/polkadot-sdk/pull/1234/files#diff-a86375df98e04ca3cce1ea35c40257a222e2d5087f5f528ff33307678b78dc2dR534-R550).
    - Replaced `<rococo_runtime::Treasury as PalletInfoAccess>::index()`
    with `rococo_runtime_constants::TREASURY_PALLET_ID`.
    - Added `check_treasury_pallet_id` to the relay runtimes to ensure that
    the constant is aligned with the pallet id.
    - Added "Rococo Treasury" to the waived locations (that will not be
    charged fees in the executor) for `BridgeHubRococo` (to be aligned with
    AssetHubs).
    
    ## References
    
    [Full element discussion
    here](https://matrix.to/#/!JUeaZUiYbdrvzvtwSL:parity.io/$2PnjYMsWRjR7M3oOfGuRI0XkjdoqJLtRcAPVcDLuLVg?via=parity.io&via=web3.foundation).
    
    ---------
    
    Co-authored-by: command-bot <>
    c284a931