Skip to content
  1. Apr 06, 2021
  3. Apr 01, 2021
    • Hernando Castano's avatar
      Weights for `pallet-bridge-grandpa` (#815) · 1a89b1ec
      Hernando Castano authored 
      * Add benchmarking skeleton

* Allow runtime to indicate concrete header type for benches

* Set up skeleton for benchmark tests

* Play around with mutating bench header

* Create a working test for benchmarking

* Add benches related to enacting authority set changes

* Add bench for checking effect of prec-commits/vote ancestries

* Use new `no_std` test utils in benchmarks

* Support pallet instances in benchmarking

* Use correct benchmarking instance macro

* Add instance to runtime benchmark helper impl

* Start using new justification creation API

* Allow mock header's number to be specified

* Set up benches with correct fork/depth parameters

* Use new pallet name during runtime bench setup

* Use correct `set_id` in tests

* Limit number of forks as workaround to get tests passing

* Use number of authorities which matches number of forks

* Make sure test post-conditions are checked properly

* Only read `CurrentAuthoritySet` from storage once

* Add combined benchmark for `submit_finality_proof`

* Add bench test

* Introduce config bounds related to justification verification

* Use config consts from pallet in benchmarking

* Return data relevant to benchmarks from helper functions

* Annotate `submit_finality_proof` with autogenerated weights

* Return actual weight after call execution

* Ignore Clippy warnings in bench template

* Update benchmark template

* Use `test-utils` to create test headers

* Clarify that helper is only for messages benches

* Add more documentation to benches

* Update TODOs

* Clarify return types in comment

* Fix pallet name post-merge

* Update NOTE to a TODO item

* Indicate that Config params are max values, not actual values

* Change Config validator count type to be `u32`

* Return decoded justification instead of fields

* Add missing trait bounds for tests

* Correctly issue weight refund

Thanks for spotting this Tomek!

* Update comment

* Add note about SESSION_LENGTH

* Fix benchmarking code
      1a89b1ec
    • Hernando Castano's avatar
      Use GrandpaJustification instead of Vec<u8> in Pallet API (#847) · ca98d090
      Hernando Castano authored 
      * Stop passing raw encoded justifications to pallet API

By having the API accept a struct-ified justification we are able to
better utilize the justifications fields for weight calculations.

* Update relayer code to use decoded justifications

* Add justification to `expect()` statement

* Fix some imports

* Make justification wrapper contain decoded justification

* Rename some fields

* Get rid of warnings

* Appease Clippy

* Only decode justification once at init time

* Remove unnecessary method

* Remove justification wrapper

This became kinda unnecessary since we could implement the FinalityProof
trait on GrandpaJustification directly.
      ca98d090
    • Tomasz Drwięga's avatar
      Make relay CLI generic (#849) · 2a07bd5f
      Tomasz Drwięga authored 
      

* Start generalizing rialto-millau commands.

* cargo fmt --all

* Introduce generic balance.

* Unify message payloads.

* cargo fmt --all

* init - generic

* Attempt to unify send message.

* Start moving things around.

* cargo fmt --all

* Move init-bridge.

* cargo fmt --all

* Improve UX of bridge argument.

* Fix clippy.

* Fix docs and scripts.

* Add docs.

* Apply suggestions from code review

Co-authored-by: default avatarHernando Castano <[email protected]>

* Fix copyright.

* Add issue numbers.

* More todos.

* Update comments.

Co-authored-by: default avatarHernando Castano <[email protected]>
      2a07bd5f
  5. Mar 25, 2021
  7. Mar 23, 2021
    • Hernando Castano's avatar
      Rename Finality Verifier and Call Dispatch Pallets (#838) · 38666462
      Hernando Castano authored 
      * Rename `pallet-finality-verifier` to `pallet-bridge-grandpa`

* Missed some CamelCase ones

* Update logging target in GRANDPA pallet

* Rename `pallet-bridge-call-dispatch` to `pallet-bridge-dispatch`

* Rename the dispatch pallet folder

* Update logging target in Dispatch pallet

* Missed a couple

* Format the repo

* Stop listing individual pallets in Compose logs

* Use correct pallet name in module doc comments

* Add `pallet-bridge-dispatch` to README project layout

* Sort crate names in TOML files

* Rename `pallet-bridge-grandpa` runtime Call alias
      38666462
    • Tomasz Drwięga's avatar
      Flatten back the structure (#837) · 7ed84892
      Tomasz Drwięga authored 
      * Remove chains.

* Move relay clients.

* Flatten generic.

* Fix fmt.
      7ed84892
  9. Mar 22, 2021
  11. Mar 18, 2021
    • Hernando Castano's avatar
      Make Test Helpers `no_std` Compatible (#823) · b7410cad
      Hernando Castano authored 
      * Use `sp-application-crypto` when generating test justifications

* Try to justifications tests compiling

* Try using `ed25519_dalek` for justification creation

* Small cleanup

* Correctly generate a Keypair

The public key didn't correspond to what would be derived
with the given private key.

* Remove enum index hack

* Clean up test account helper functions

* Fix tests in `pallet-finality-verifier`

* Get `pallet-substrate-bridge` tests compiling again

* Use the correct keyring in justification tests

* Clean up Keyring related code a bit

* Appease Clippy

* Remove unused import

* Use keyring variants directly

* Remove unecessary From implementation
      b7410cad
  13. Mar 16, 2021
    • Svyatoslav Nikolsky's avatar
      updat jsonrpsee (#828) · a82b5f88
      Svyatoslav Nikolsky authored
      a82b5f88
    • Svyatoslav Nikolsky's avatar
      Sync Westend to Millau (#824) · 314f9f7d
      Svyatoslav Nikolsky authored 
      * make finality verifier pallet instantiable

* add second instance of finality verifier pallet to the Millau runtime

* add Westend -> Millau headers relay

* use wss to connect to public westend nodes

* initialize with best_finalized_block

* typo

* Revert "initialize with best_finalized_block"

This reverts commit 954ed283.

* pass VoterSet by ref

* new bridge initialization code

* loop upper bound

* Polkadot -> Westend

* fixed tests compilation

* default-features

* assert
      314f9f7d
  15. Mar 12, 2021
  17. Mar 10, 2021
    • Tomasz Drwięga's avatar
      Add Westend & Rococo primitives (#808) · b9b6daa5
      Tomasz Drwięga authored 
      * Move chain primitives to a sub-folder.

* Update workspace members.

* Extract core parts of polkadot.

* cargo fmt --all

* Remove TODO.

* cargo fmt --all

* Fix crate names.

* Add to the latest API.

* cargo fmt --all

* Add nested lock files to ignore (generated during cargo fmt)

* Fix compilation.

* cargo fmt --all

* Fix ignore pattern.

* Address review comments.
      b9b6daa5
  19. Mar 09, 2021
  21. Mar 08, 2021
  23. Mar 04, 2021
    • Svyatoslav Nikolsky's avatar
      Migrate to jsonrpsee v2 (#787) · 727848da
      Svyatoslav Nikolsky authored 
      

* POC jsonrpsee v2

* POC update ws client

* connect to eth nodes using ws

* fix for subscriptions

* reverted unncecessary changes

* reference jsonrpsee from crates.io

* fixed eth port in deployments

* fmt

* order deps

* remove unnecessary comment

* clone is no longer required for subscriptions

* treat RpcError::Internal as connection error

* resubscribe on terminate

* Update deployments/bridges/poa-rialto/entrypoints/poa-exchange-tx-generator-entrypoint.sh

Co-authored-by: default avatarNiklas Adolfsson <[email protected]>
Co-authored-by: default avatarHernando Castano <[email protected]>
      727848da
    • Hernando Castano's avatar
      Unify Substrate Bridge Pallet with Finality Verifier (#783) · bb7ed3c0
      Hernando Castano authored 
      * Add relevant storage items from Substrate pallet

* Add function for importing finalized headers to storage

* Remove unused getter functions

* Add GenesisConfig to pallet

* Add initialization extrinsic

* Add operational extrinsic

* Get existing finality verifier tests compiling again

* Add tests for pallet initialization

* Add tests related to pallet's operational status

* Update tests which were using `pallet-substrate-bridge`

* Add tests related to header imports

* Use wrapper function when init-ing some tests

* Add prefix to tests related to rate limiter

* Fix failed compilation related to GenesisConfig

* Add some documentation

* Change some extrinsics to be Operational

* Add public interface to pallet

* Implement runtime APIs for finality-verifier pallet

* Justify use of `expect` when importing headers

* Reject headers with forced changes

* Add weight to initialize extrinsic

* Remove TODO which will be addressed later

* Move succesful import log to correct location

* Expand proof for when `best_finalized` is fetched

* Move check for newer finalized blocks earlier in pipeline

* Rename `ConflictingFork` error to be more generic

* Only compute finality_target's hash once

* Add missing documentation to Runtime APIs

* Add TODO about using `set_id` from `ScheduledChange` digest
      bb7ed3c0
  25. Mar 03, 2021
  27. Mar 01, 2021
  29. Feb 27, 2021
  31. Feb 25, 2021
  33. Feb 24, 2021
  35. Feb 22, 2021
  37. Feb 16, 2021
  39. Feb 10, 2021
    • Svyatoslav Nikolsky's avatar
      Account proof size in weight formula (#679) · 15b27e38
      Svyatoslav Nikolsky authored 
      

* fix broken message lane benchmarks

* proof-size related benchmarks

* impl Size for proof parameters

* include proof weight into weight formula

* left TODO

* fixed proof size

* WeightInfoExt::receive_messages_proof_weight

* charge for extra message bytes delivery in send_message

* removed default impl of WeightsInfoExt

* moved weight formulas to WeightInfoExt

* receive_messages_proof_outbound_lane_state_overhead is included twice in weight

* typo

* typo

* fixed TODO

* more asserts

* started wotk on message-lane documentation

* expected_extra_storage_proof_size() is actually expected in delivery confirmation tx

* update README.md

* ensure_able_to_receive_confirmation

* test rialto message lane weights

* removed TODO

* removed unnecessary trait requirements

* fixed arguments

* fix compilation

* decreased basic delivery tx weight

* fmt

* clippy

* Update modules/message-lane/src/benchmarking.rs

Co-authored-by: default avatarHernando Castano <[email protected]>

* structs

* Update primitives/millau/src/lib.rs

Co-authored-by: default avatarHernando Castano <[email protected]>

* removed readme.md

* removed obsolete trait bounds

* Revert "removed readme.md"

This reverts commit 50b7376a

.

* Update bin/runtime-common/src/messages.rs

Co-authored-by: default avatarTomasz Drwięga <[email protected]>

* Update bin/runtime-common/src/messages.rs

Co-authored-by: default avatarTomasz Drwięga <[email protected]>

* Update bin/runtime-common/src/messages.rs

Co-authored-by: default avatarTomasz Drwięga <[email protected]>

* Update bin/runtime-common/src/messages.rs

Co-authored-by: default avatarTomasz Drwięga <[email protected]>

* Update bin/runtime-common/src/messages.rs

Co-authored-by: default avatarTomasz Drwięga <[email protected]>

* Update bin/runtime-common/src/messages.rs

Co-authored-by: default avatarTomasz Drwięga <[email protected]>

* Update bin/runtime-common/src/messages.rs

Co-authored-by: default avatarTomasz Drwięga <[email protected]>

* PreComputedSize

Co-authored-by: default avatarHernando Castano <[email protected]>
Co-authored-by: default avatarTomasz Drwięga <[email protected]>
      15b27e38
    • Hernando Castano's avatar
      Stop Importing Full Header Chain (#707) · aa7b797d
      Hernando Castano authored 
      * Make AncestryProof type more flexible

* Only import single finalized header instead of a chain

* Fix unchecked header import tests

* Add option for limiting ancestry proof size

* Update finality verifier Config in runtimes

* Update some documentation

* Fix Clippy warning

* Allow AncestryChecker to return proof size

Stops us from abusing the `Size` trait

* Remove Size impl for Vec<T>

* Remove size contraints for ancestry proofs

With different proof types its unclear how to "size" should be interpreted,
so we remove this requirement all together to avoid confusion.
      aa7b797d
  41. Feb 09, 2021
  43. Feb 03, 2021
    • Hernando Castano's avatar
      Wire Finality Verifier Pallet Into Runtimes (#696) · 43336fb8
      Hernando Castano authored 
      * Add Finality Verifier pallet to runtimes

* Implement simple ancestry checker

* Use the new checker in runtimes

* Remove unused import warning

* Bump max allowed ancestry proof size

* Add a few optimization suggestions when verifying ancestry

* Use session length as upper bound for ancestry proof size

* Remove unused time units
      43336fb8