- May 28, 2019
-
-
Luke Schoen authored
* Update Send transaction UI so "amount" field can be 0, since some users may want to just send some data (i.e. https://github.com/chainx-org/ChainX/issues/66) * Set the default amount value to be 0 and not required * Update Send transaction UI to support "data" field in hex (with 0x prefix) * Use a hard-coded Gas Limit of 200,000 when user provides hex "data" value * Remove logic that doesn't make sense (i.e. `else if (amountBn.isZero()) {`) * Update validation messages * Add support for Blockscout link when user using Goerli testnet * Update internationalisation * Use custom `isHexString` function instead of the ethereumjs-util's version. The ethereumjs-util's version is used by MyCrypto and doesn't work properly. * Tested on Goerli testnet by creating two accounts, requesting Goerli tokens, running with `--chain goerli` appended to the end (i.e. `"start": "cross-env ELECTRON_START_URL=http://localhost:3000 electron-webpack dev --chain goerli",` in fether/packages/fether-electron/package.json), and sending a transaction with the high gas price, the hex data. For example, for ChainX convert your ChainX Address (UTF8 chars) into Hex code (i.e. copy/paste it at https://www.browserling.com/tools/utf8-to-hex, for example "helloworld" becomes => `\x68\x65\x6c\x6c\x6f\x20\x77\x6f\x72\x6c\x64`, and remove the `\x`, => `68656c6c6f20776f726c64` => then prepend 0x => `0x68656c6c6f20776f726c64` and add that to the "data" field), then send the transaction, and when the transaction is successful go to the Blockscout link and you'll see under "Raw Input" ("Input Data" on Etherscan) that you can switch between viewing it in UTF8 or Hex, i.e. https://blockscout.com/eth/goerli/tx/0x7eaec61ce7753fd4c80aec4509c49942b53986585e4864e18134806bffb25f10/internal_transactions) * TODO - update Parity Signer to show "data" field value if it doesn't already
-
- Apr 15, 2019
-
-
Luke Schoen authored
feat: Relates to #360. Only allow import from Parity Signer chain account matching current chain. ETC support (#483) * feat: Relates to #360. Only allow import from Parity Signer chain account matching current chain. ETC support * review-fix: Refer to non-Parity chain names in the UI. Add console.error * review-fix: Do not need to chcek health status before calling chainId RPC of light.js on pages accessed through navigation * review-fix: Rename function name that matches current chain id with imported chain id of address * review-fix: Remove unnecessary function * review-fix: Rename function to accountAlreadyExists * review-fix: Remove FIXME. See https://github.com/paritytech/fether/pull/483#discussion_r270834847 * review-fix: Refactor to use util functions isEtcChainId, chainIdToString, isNotErc20TokenAddress * fix: Fix typo in comment * review-fix: Change wording of parity phrase comment * review-fix: Do not clear isImport as not account related * fix: Clear error so error when recover from seed phrase not still shown if then click to recover from QR code * fix: Rename so signerChainId correctly destructured and not undefined * review-fix: Remove async/await from clear * fix: Avoid mapping signer chain id to chain name since too much maintenance with Parity Ethereum * review-fix: Remove await from createAccountStore * tests: Add colour to fether-react tests * refactor: No need to parseInt on the signerChainId * refactor: Use isNotErc20TokenAddress * refactor: Use isNotErc20TokenAddress again * refactor: Add isErc20TokenAddress util so more readable * fix: Replace valueOf with .eq. Fix so obtain BN from props * refactor: Combine into single if statement when checking if valid Eth/Etc address * refactor: Update utils without unnecessary return block
-
- Apr 12, 2019
-
-
Luke Schoen authored
* chore: Update to latest React 16.8.3 to requirements of react-i18next * feat: Scaffold basic translation with English and German * feat: Relates to #402. German translation fully working * fix: Switch back to English by default * fix: Allow user to switch between languages in preferences of context menu * feat: Translate the context menus * refactor: Remove German language. Add as separate PR * refactor: Remove blank line * docs: Update Readme with Internationalisation Add New language instructions * docs: Update Readme with Known Issues and Usage instructions * review-fix: Disabled tooltip Please fill out this field. Add High and Low tx speed * review-fix: Update license headers to be 2019 instead of 2018 * review-fix: Change ns1 to fether-electron and fether-react. Use pino.debug * fix: Add missing i18n conversion for macOS Edit menu * review-fix: Remove unused i18next browser languagedetector dependency * merge latest from master and fix conflicts * merge latest master and fix conflicts. TODO do not expose remote * fix: Do not expose remote. Only expose add and remove listener, and reload via bridge * feat: Convert new release available text to i18n
-
- Apr 09, 2019
-
-
Amaury Martiny authored
* Bump light.js to use getTxByHash * Use .hash instead of .txHash
-
- Apr 08, 2019
-
-
Amaury Martiny authored
* Revert @parity/* bump * Fix blockscout link * Pass down ws-origins flag * Fix again: use transactionHash * Update maintainers * Fix broken image in prod
-
Luke Schoen authored
* feat: Security aspects for fether-electron. See #124 * feat: Add Source Maps support * docs: Add Source Maps guide to Readme * feat: Add webpack-build-notifier add-on with custom Webpack config * fix: Remove duplicate dependency * WIP * WIP * review-fix: Configure CSP depending on NODE_ENV * fix: Fix worker-src for the camera in production * review-fix: Remove unnecessary config of source maps dependency * Use preload script as buffer between main and renderer processes (#463) * fix: Remove is-electron since now using preload script * fix: Remove old preload script * fix: Do not expose electron, remote, or require to web app * fix: Add newline * feat: Single Fether instance lock * fix: Move preload to static folder so works with binary * review-fix: Remove fix for webview since not used. Add comment incase used in future. Fix other event handling code * review-fix: Add optional opt-in to using Webpack notifier plugin by running with NOTIFIER=true yarn start * review-fix: Use pino.debug instead of console.log * review-fix: Add worker-src blob to CSP in development for webcam * review-fix: Update handling of untrusted urls and sessions and certificates * review-fix: Convert to WSS. Move CSP into array like in Parity-JS Shell. Update CSP * review-fix: Update CSP to avoid duplication * review-fix: Remove from new-window event listener that which applies to additional new BrowserWindows since not applicable * review-fix: Combined pino logs * review-fix: Change to parsedUrl.href instead of origin. Fix trusted urls for dev * fix: Remote https 127.0.0.1 in prod * review-fix: Move WebpackBuildNotifier images so not in binary. Fix ico file * fix: Remove console.logs * refactor: Cleanup so can merge. Extract for inclusion in separate PR * review-fix: Remove debugging notes since better in wiki * review-fix: Remove other lines due to move to wiki * fix comment * review-fix: Remove setPermissionRequestHandler since not know if need. Move to https://hackmd.io/O1FA34BuSNyJoPV1Cu3L0A * review-fix: Move CSP debugging into onHeadersReceived * review-fix: Fix isParityRunningStatus * review-fix: Replace parse-url with Node.js url parser * review-fix: Remove parse-url from dependencies * fix: Fix logic in setCertificateVerifyProc * WIP * review-fix: Dynamically add WS port from CLI to trusted * review-fix: Update comments with security warnings * merge latest from master and fix conflicts * chore: Remove useless console.log * misc: See commit details * Remove --ws-origins from CLI, hard-code instead * Remove --ws-interface from CLI, hard-code instead * Ignore --ws-interface and --ws-origins flags in CLI * Add hard-coded default trusted WS interface to window.bridge * Add default WS port to window.bridge * WIP - start implementing isDev. See FIXME for future work required * review-fix: Use appIsPackaged instead of NODE_ENV * fix: Add IS_PROD to constants and assign appIsPackaged to it. Expose it to frontend so no longer use NODE_ENV * feat: Add wiki Fether FAQ to trusted urls since required by PR #482 * fix: Fix untrusted blockscout.com error in setCertificateVerifyProc * review-fix: fix blocked image hosting and external blockscout urls * review-fix: trust github token icons * review-fix: Rename network to fetherNetwork so custom config avoids naming conflict * review-fix: Remove duplicate pino.debug for CSP * review-fix: Remove WsSecure until wss and certificates implemented * review-fix: Update config to show Electron security warnings in all environments * review-fix: Remove use of wsInterface * refactor: Refactor tests inside describe blocks * tests: Add chrome dev tools to tests for trusted urls * review-fix: Use NODE_ENV and Electron app.isPackaged * fix: Rebuild yarn.lock * fix: Fix linting to arg passed to correct script * review-fix: Remove ws-origins flag and trusted ws origins * test: Fix failing test * review-fix: Remove package-lock.json * fix: Use NODE_ENV consistently instead of process.defaultApp * fix: Change to hash instead of transactionHash for blockscout
-
- Mar 28, 2019
-
-
Thibaut Sardan authored
* add script to manually fetch tokens from github.com/ethereum-lists/tokens over IPFS * remove ts files from linting * remove ts files from test to fix CI * WIP token image * improve token default image * Test the pipe with hardcoded IPFS addresses * add comments * add --use-hardcoded-addresses argument * shorten things up with a spread * address comments * fix test and address comment
-
- Mar 26, 2019
-
-
Luke Schoen authored
-
- Mar 25, 2019
-
-
Amaury Martiny authored
* Show parity/light.js's logs too * Remove txCount from withAccount * withBalance shows component immeidately * Play around * Make it work * Cleaner code * Remove 'Loading account tokens...' modal * Re-order import * Optimize code * Fix regression * Fix typo * Luke's grumbles * Put "checking..." when fetching async values * Show gas error on amount field
-
- Mar 21, 2019
-
-
Axel Chalon authored
* Parity Ethereum bundling * Grumbles; update light.js * Grumbles * Merge in PR#394 ac-upd-post: refactor sendStore post/postRaw * Download highest version matching requirement rather than latest beta * Rename RequireVersion to RequireParityVersion * Grumbles * Change Parity version requirement to ~2.4.1 * Fix --no-run-parity with Parity already running * Grumble Co-Authored-By: axelchalon <[email protected]>
-
- Mar 12, 2019
-
-
Amaury Martiny authored
-
- Feb 25, 2019
-
-
Luke Schoen authored
-
Thibaut Sardan authored
-
- Feb 21, 2019
-
-
Thibaut Sardan authored
-
Thibaut Sardan authored
-
- Feb 20, 2019
-
-
Thibaut Sardan authored
-
- Feb 15, 2019
-
-
Axel Chalon authored
-
- Feb 08, 2019
-
-
Luke Schoen authored
-
Luke Schoen authored
-
- Feb 07, 2019
-
-
Luke Schoen authored
* Change health states to node-internet, node, and sync * Change from using STATUS symbol states to using a status object that contains the different states with their status * Show chain name and percentage in modals too
-
Luke Schoen authored
-
Luke Schoen authored
-
Luke Schoen authored
Summary of actions performed: * App.js routes * AccountsList * New functionality - `<RequireHealthOverlay require='connected-offline'>` * Note: we need to be connected even for the AccountsList page since most accounts actually come from parity-ethereum (as pointed out by @amaurymartiny). New functionality (@amaurymartiny proposal) uses additional 'connected-offline' state so if we are connected to the node but not to the internet we can show the AccountsList page * Accounts (token list page) * Retain existing functionality - `<RequireHealthOverlay require='sync'>` * Create Account / Import Account * New functionality - `<RequireHealthOverlay require='connected-offline'>` * Backup Account * New functionality - `<RequireHealthOverlay require='connected-offline'>` * Onboarding * New functionality - no overlay since not wrapping App.js * Search tokens (Whitelist) * Retain existing functionality - `<RequireHealthOverlay require='sync'>` * Send.js routes * TxForm, Unlock, TxQrCode, ScanSignedTx, SignedTxSummary * Retain existing functionality - `<RequireHealthOverlay require='sync'>` * Sent * Retain existing functionality by wrapping the individual component instead of App.js with: `<RequireHealthOverlay require='connected' fullscreen>` * Note: `RequireHealthOverlay` has two states: * `require='connected-offline` no alert/overlay when user connected to a local node but not connected to the internet * `require='connected'` shows full screen alert when the user is not connected to the node and and not connected to the internet * `require='sync'` shows when the user is not sync * Note: Only the Sent component has a fullscreen overlay * Note: This wraps everything related to eth/token/balance/transfer with `require='sync'` * Note: We are not wrapping App.js anymore since when using both `<RequireHealthOverlay require='connected' fullscreen>` in addition to wrapping other components such as Accounts.js with `<RequireHealthOverlay require='connected-offline'>` doesn't allow it. Instead just wrap individual components
-
- Feb 05, 2019
-
-
Luke Schoen authored
review-fix: Remove value from To since already initialValue. Modify existing initialValue for Amount
-
- Feb 04, 2019
-
-
Luke Schoen authored
-
Luke Schoen authored
review-fix: Use react-final-form field to connect to state. Change from defaultValue to value to overcome warning
-
- Feb 03, 2019
-
-
Luke Schoen authored
-
Luke Schoen authored
-
Luke Schoen authored
-
- Jan 24, 2019
-
-
Luke Schoen authored
-
Luke Schoen authored
fix: Fix SignedTxSummary page for Parity Signer tx so it shows amount field similar to on Unlock summary for non-Signer tx
-
Luke Schoen authored
* Remove `decimals`, `onClick`, and `tokens` props from TokenAddress as was only required on TokenBalance * Update SignedTxSummary so "To" input field is above "Amount" * Explicitely pass down `drawers` prop since it is used by Card component * Remove incorrect `handleClick` from TokenAddress component, as that was functionality from TokenBalance
-
- Jan 23, 2019
-
-
Luke Schoen authored
-
Luke Schoen authored
-
Luke Schoen authored
-
Luke Schoen authored
-
- Jan 22, 2019
-
-
Luke Schoen authored
* Add `isEstimatingTxFee` so we can check if all values including `gas` are available without actually having to calculate the tx fee and incorporate into estimateTxFee method * Display and disable the "Checking..." button if the `isEstimatingTxFee` returns false (i.e. `gas` still undefined) * Note: The bug associated with #361 appears to be Parity Signer-specific. If the user can click "Scan" before the `gas` has been calculated, then when it tries to go to the paritytech/fether/packages/fether-react/src/Send/TxQrCode/TxQrCode.js, where it calls `getRlp()` to get the value for the rlp prop of the QrSigner component, which calls `transactionToRlp(this.tx)` to get the RLP of the unsigned tx that is provided as an argument paritytech/fether/packages/fether-react/src/stores/sendStore.js, it crashes if `this.tx` contains a `gas` property that's undefined. So we need to prevent the user from being able to click "Scan" before the `gas` property has been determined. We do this by disabling the button and displaying "Checking..." until `isEstimatingTxFee` returns true, and only then do we display "Scan" and enable the button
-
Luke Schoen authored
-
- Jan 21, 2019
-
-
Axel Chalon authored
for good measure
-
Luke Schoen authored
-