Skip to content
Commit 95452ee3 authored by Luke Schoen's avatar Luke Schoen Committed by Thibaut Sardan
Browse files

feat: Relates to #360. Only allow import from Parity Signer chain account...

feat: Relates to #360. Only allow import from Parity Signer chain account matching current chain. ETC support (#483)

* feat: Relates to #360. Only allow import from Parity Signer chain account matching current chain. ETC support

* review-fix: Refer to non-Parity chain names in the UI. Add console.error

* review-fix: Do not need to chcek health status before calling chainId RPC of light.js on pages accessed through navigation

* review-fix: Rename function name that matches current chain id with imported chain id of address

* review-fix: Remove unnecessary function

* review-fix: Rename function to accountAlreadyExists

* review-fix: Remove FIXME. See https://github.com/paritytech/fether/pull/483#discussion_r270834847

* review-fix: Refactor to use util functions isEtcChainId, chainIdToString, isNotErc20TokenAddress

* fix: Fix typo in comment

* review-fix: Change wording of parity phrase comment

* review-fix: Do not clear isImport as not account related

* fix: Clear error so error when recover from seed phrase not still shown if then click to recover from QR code

* fix: Rename so signerChainId correctly destructured and not undefined

* review-fix: Remove async/await from clear

* fix: Avoid mapping signer chain id to chain name since too much maintenance with Parity Ethereum

* review-fix: Remove await from createAccountStore

* tests: Add colour to fether-react tests

* refactor: No need to parseInt on the signerChainId

* refactor: Use isNotErc20TokenAddress

* refactor: Use isNotErc20TokenAddress again

* refactor: Add isErc20TokenAddress util so more readable

* fix: Replace valueOf with .eq. Fix so obtain BN from props

* refactor: Combine into single if statement when checking if valid Eth/Etc address

* refactor: Update utils without unnecessary return block
parent 9ab36c49
Pipeline #35598 passed with stages
in 10 minutes and 57 seconds
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment