* Revert "Fix not downloading old blocks (#8642)"

This reverts commit d1934363.

* Make sure only one thread actually imports old blocks.

* Add some trace timers.

* Bring back pending hashes set.

* Separate locks so that queue can happen while we are importing.

* Address grumbles.

* Disallow unsigned transactions in case EIP-86 is disabled

* Add tests for verification

* Add disallow unsigned transactions test in machine

Wei Tang authored Jun 05, 2018 and Marek Kotewicz committed Jun 05, 2018

* Fix evmbin compilation

* Move features declaration to dependencies

* rpc: fix address formatting in TransactionRequest Display

* rpc: use unwrap_or_else when no to address provided

* Mark test helpers and test-only specs as cfg(test)

* Use test-probe to conditionally compile test helpers

* Remove test probe and directly use features tag

* Remove AccountProvider Result, it's always `Ok`

* Remove unnecessary clones

* Remove redundant `Ok`

Niklas Adolfsson authored Jun 04, 2018 and Marek Kotewicz committed Jun 04, 2018

* Update `add_license` script

* run script

* add `remove duplicate lines script` and run it

* Revert changes `English spaces`

* strip whitespaces

* Revert `GPL` in files with `apache/mit license`

* don't append `gpl license` in files with other lic

* Don't append `gpl header` in files with other lic.

* re-ran script

* include c and cpp files too

* remove duplicate header

* rebase nit

Wei Tang authored Jun 01, 2018 and Andrew Jones committed Jun 01, 2018

* Remove public node related settings

* Fix tests

* Unwrap accounts provider in all rpc apis

* Unwrap AccountProvider in all cli places

* Fix rpc tests

Benjamin Kampmann authored Jun 01, 2018 and Marek Kotewicz committed Jun 01, 2018

* Custom Error Messages on ENFILE and EMFILE IO Errors

Add custom mapping of ENFILE and EMFILE IO Errors (Failure because of missing system resource) right when chaining ioError into ::util::Network::Error to improve Error Messages given to user

Note: Adds libc as a dependency to util/network

* Use assert-matches for more readable tests

* Fix Wording and consistency

Afri Schoedon authored Jun 01, 2018 and Marek Kotewicz committed Jun 01, 2018

* ci: Remove check for shared libraries in gitlab script

* ci: allow android arm build to fail

Jim Posen authored Jun 01, 2018 and Marek Kotewicz committed Jun 01, 2018

* network-devp2p: Test for discovery bucket insertion.

All test values are randomly generated and the assertions are checked manually.
Test fails because distance metric is implemented incorrectly.

* network-devp2p: Fix discovery distance function.

The Kademlia distance function (XOR) was implemented incorrectly as a population count.

* network-devp2p: Refactor nearest_node_entries to be on instance.

Optimizations are possible with more access to the discovery state.

* network-devp2p: Fix loss of precision in nearest_node_entries.

* network-devp2p: More efficient nearest node search.

The discovery algorithm to identify the nearest k nodes does not need to scan
all entries in all buckets.

David authored Jun 01, 2018 and Marek Kotewicz committed Jun 01, 2018

* Lots of println to figure out what eth_getBlockByNumber does/should do

* Remove debugging

* Print warnings when fetching pending blocks

When calling `eth_getBlockByNumber` with `pending`, we now print a deprecation warning and:

* if a pending block is found, use it to respond
* if no pending block is found, respond as if if was a request for `Latest`

Addresses issue #8703 (not sure if it's enough to close it tbh)

Piping `curl` to `bash` while **disabling** certificate verification can lead to security problems.

* fix some nits using clippy

* fix tests

Additionally as to the port, the new  command line option
now allows the user to specify the network interface the P2P-Parity
listens, too. With support for 'all' and 'local' like in all other
versions of this flag. Default is 'all' (aka ).

ordian authored May 30, 2018 and Marek Kotewicz committed May 30, 2018

* Add a deadlock detection thread

Expose it under a feature flag:
`cargo build --features "deadlock_detection"`

* Address Nicklas's comments

Nicolas Gotchac authored May 29, 2018 and ordian committed May 29, 2018

* Shutdown the Snapshot Service when shutting down the runner

* Rename `service` to `client_service`

* Fix tests

David authored May 28, 2018 and Niklas Adolfsson committed May 28, 2018

On nightly rust passing `public_url` works but that breaks on stable. This works for both.

Tomasz Drwięga authored May 28, 2018 and Niklas Adolfsson committed May 28, 2018

* Make dev chain more foundation-like and enable wasm.

* Fix compilation warnings.

Benjamin Kampmann authored May 25, 2018 and Marek Kotewicz committed May 25, 2018

fixes #8184

* Set the request index to that of the current request

When setting up the chain of (two) requests to look up a block by hash, the second need to refer to the first. This fixes an issue where the back ref was set to the subsequent request, not the current one. When the requests are executed we loop through them in order and ensure the requests that should produce headers all match up. We do this by index so they better be right.

In other words: off by one.

- Update interfaces affected by unsafe-expose
- replace `{{ }}` as this  throws an error in Jekyll (wiki)

* Update ethereum-types so `{:#x}` applies 0x prefix