Skip to content
  1. Jan 26, 2021
  2. Jan 25, 2021
    • ordian's avatar
      impl approval distribution (#2160) · ab606e14
      ordian authored
      * initial impl approval distribution
      
      * initial tests and fixes
      
      * batching seems difficult: different peers have different needs
      
      * bridge: fix test after merge
      
      * some guide updates
      
      * only send assignments to peers who know about the block
      
      * fix a test, add approvals test
      
      * simplify
      
      * do not send assignment to peers for finalized blocks
      
      * guide: protocol input and output
      
      * one more test
      
      * more comments, logs, initial metrics
      
      * fix a typo
      
      * one more thing: early return when reimporting a thing locally
      ab606e14
  3. Jan 18, 2021
    • asynchronous rob's avatar
      Approval Voting Database (#2162) · a4c418a5
      asynchronous rob authored
      
      
      * skeleton
      
      * skeleton aux-schema module
      
      * start approval types
      
      * start aux schema with aux store
      
      * doc
      
      * finish basic types
      
      * start approval types
      
      * doc
      
      * finish basic types
      
      * write out schema types
      
      * add debug and codec impls to approval types
      
      * add debug and codec impls to approval types
      
      also add some key computation
      
      * add debug and codec impls to approval types
      
      * getters for block and candidate entries
      
      * grumbles
      
      * remove unused AssignmentId
      
      * load_decode utility
      
      * implement DB clearing
      
      * function for adding new block entry to aux store
      
      * start `canonicalize` implementation
      
      * more skeleton
      
      * finish implementing canonicalize
      
      * tag TODO
      
      * implement a test AuxStore
      
      * add allow(unused)
      
      * basic loading and deleting test
      
      * block_entry test function
      
      * add a test for `add_block_entry`
      
      * ensure range is exclusive at end
      
      * test clear()
      
      * test that add_block sets children
      
      * add a test for canonicalize
      
      * Update node/core/approval-voting/src/aux_schema/mod.rs
      
      Co-authored-by: default avatarPeter Goodspeed-Niklaus <[email protected]>
      
      * Update node/core/approval-voting/src/aux_schema/tests.rs
      
      Co-authored-by: default avatarPeter Goodspeed-Niklaus <[email protected]>
      
      * Update node/core/approval-voting/src/aux_schema/mod.rs
      
      Co-authored-by: default avatarPeter Goodspeed-Niklaus <[email protected]>
      
      Co-authored-by: default avatarPeter Goodspeed-Niklaus <[email protected]>
      a4c418a5
    • dependabot[bot]'s avatar
      Bump futures from 0.3.11 to 0.3.12 (#2281) · 5e695473
      dependabot[bot] authored
      
      
      Bumps [futures](https://github.com/rust-lang/futures-rs) from 0.3.11 to 0.3.12.
      - [Release notes](https://github.com/rust-lang/futures-rs/releases)
      - [Changelog](https://github.com/rust-lang/futures-rs/blob/master/CHANGELOG.md)
      - [Commits](https://github.com/rust-lang/futures-rs/compare/0.3.11...0.3.12)
      
      Signed-off-by: default avatardependabot[bot] <[email protected]>
      
      Co-authored-by: default avatardependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
      5e695473
  4. Jan 15, 2021
    • dependabot[bot]'s avatar
      Bump futures from 0.3.10 to 0.3.11 (#2273) · 3849a08e
      dependabot[bot] authored
      
      
      Bumps [futures](https://github.com/rust-lang/futures-rs) from 0.3.10 to 0.3.11.
      - [Release notes](https://github.com/rust-lang/futures-rs/releases)
      - [Changelog](https://github.com/rust-lang/futures-rs/blob/master/CHANGELOG.md)
      - [Commits](https://github.com/rust-lang/futures-rs/compare/0.3.10...0.3.11)
      
      Signed-off-by: default avatardependabot[bot] <[email protected]>
      
      Co-authored-by: default avatardependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
      3849a08e
    • Fedor Sakharov's avatar
      Availability recovery subsystem (#2122) · 030502a0
      Fedor Sakharov authored
      * Adds message types
      
      * Add code skeleton
      
      * Adds subsystem code.
      
      * Adds a first test
      
      * Adds interaction result to availability_lru
      
      * Use LruCache instead of a HashMap
      
      * Whitespaces to tabs
      
      * Do not ignore errors
      
      * Change error type
      
      * Add a timeout to chunk requests
      
      * Add custom errors and log them
      
      * Adds replace_availability_recovery method
      
      * recovery_threshold computed by erasure crate
      
      * change core to std
      
      * adds docs to error type
      
      * Adds a test for invalid reconstruction
      
      * refactors interaction run into multiple methods
      
      * Cleanup AwaitedChunks
      
      * Even more fixes
      
      * Test that recovery with wrong root is an error
      
      * Break to launch another requests
      
      * Styling fixes
      
      * Add SessionIndex to API
      
      * Proper relay parents for MakeRequest
      
      * Remove validator_discovery and use message
      
      * Remove a stream on exhaustion
      
      * On cleanup free the request streams
      
      * Fix merge and refactor
      030502a0
  5. Jan 14, 2021
  6. Jan 13, 2021
  7. Jan 12, 2021
  8. Jan 05, 2021
  9. Dec 28, 2020
  10. Dec 07, 2020
  11. Dec 03, 2020
  12. Nov 30, 2020
  13. Nov 24, 2020
  14. Nov 17, 2020
    • ordian's avatar
      update most of the dependencies (#1946) · 31fb8fed
      ordian authored
      * update tiny-keccak to 0.2
      
      * update deps except bitvec and shared_memory
      
      * fix some warning after futures upgrade
      
      * remove useless package rename caused by bug in cargo-upgrade
      
      * revert parity-util-mem *
      
      * remove unused import
      
      * cargo update
      
      * remove all renames on parity-scale-codec
      
      * remove the leftovers
      
      * remove unused dep
      31fb8fed
  15. Oct 31, 2020
    • Bastian Köcher's avatar
      Adds test parachain adder collator (#1864) · 8cadebb7
      Bastian Köcher authored
      
      
      * start working on building the real overseer
      
      Unfortunately, this fails to compile right now due to an upstream
      failure to compile which is probably brought on by a recent upgrade
      to rustc v1.47.
      
      * fill in AllSubsystems internal constructors
      
      * replace fn make_metrics with Metrics::attempt_to_register
      
      * update to account for #1740
      
      * remove Metrics::register, rename Metrics::attempt_to_register
      
      * add 'static bounds to real_overseer type params
      
      * pass authority_discovery and network_service to real_overseer
      
      It's not straightforwardly obvious that this is the best way to handle
      the case when there is no authority discovery service, but it seems
      to be the best option available at the moment.
      
      * select a proper database configuration for the availability store db
      
      * use subdirectory for av-store database path
      
      * apply Basti's patch which avoids needing to parameterize everything on Block
      
      * simplify path extraction
      
      * get all tests to compile
      
      * Fix Prometheus double-registry error
      
      for debugging purposes, added this to node/subsystem-util/src/lib.rs:472-476:
      
      ```rust
      Some(registry) => Self::try_register(registry).map_err(|err| {
      	eprintln!("PrometheusError calling {}::register: {:?}", std::any::type_name::<Self>(), err);
      	err
      }),
      ```
      
      That pointed out where the registration was failing, which led to
      this fix. The test still doesn't pass, but it now fails in a new
      and different way!
      
      * authorities must have authority discovery, but not necessarily overseer handlers
      
      * fix broken SpawnedSubsystem impls
      
      detailed logging determined that using the `Box::new` style of
      future generation, the `self.run` method was never being called,
      leading to dropped receivers / closed senders for those subsystems,
      causing the overseer to shut down immediately.
      
      This is not the final fix needed to get things working properly,
      but it's a good start.
      
      * use prometheus properly
      
      Prometheus lets us register simple counters, which aren't very
      interesting. It also allows us to register CounterVecs, which are.
      With a CounterVec, you can provide a set of labels, which can
      later be used to filter the counts.
      
      We were using them wrong, though. This pattern was repeated in a
      variety of places in the code:
      
      ```rust
      // panics with an cardinality mismatch
      let my_counter = register(CounterVec::new(opts, &["succeeded", "failed"])?, registry)?;
      my_counter.with_label_values(&["succeeded"]).inc()
      ```
      
      The problem is that the labels provided in the constructor are not
      the set of legal values which can be annotated, but a set of individual
      label names which can have individual, arbitrary values.
      
      This commit fixes that.
      
      * get av-store subsystem to actually run properly and not die on first signal
      
      * typo fix: incomming -> incoming
      
      * don't disable authority discovery in test nodes
      
      * Fix rococo-v1 missing session keys
      
      * Update node/core/av-store/Cargo.toml
      
      * try dummying out av-store on non-full-nodes
      
      * overseer and subsystems are required only for full nodes
      
      * Reduce the amount of warnings on browser target
      
      * Fix two more warnings
      
      * InclusionInherent should actually have an Inherent module on rococo
      
      * Ancestry: don't return genesis' parent hash
      
      * Update Cargo.lock
      
      * fix broken test
      
      * update test script: specify chainspec as script argument
      
      * Apply suggestions from code review
      
      Co-authored-by: default avatarBastian Köcher <[email protected]>
      
      * Update node/service/src/lib.rs
      
      Co-authored-by: default avatarBastian Köcher <[email protected]>
      
      * node/service/src/lib: Return error via ? operator
      
      * post-merge blues
      
      * add is_collator flag
      
      * prevent occasional av-store test panic
      
      * simplify fix; expand application
      
      * run authority_discovery in Role::Discover when collating
      
      * distinguish between proposer closed channel errors
      
      * add IsCollator enum, remove is_collator CLI flag
      
      * improve formatting
      
      * remove nop loop
      
      * Fix some stuff
      
      * Adds test parachain adder collator
      
      * Add sudo to Rococo, change session length to 30 seconds and some renaming
      
      * Update to the latest changes on master
      
      * Some fixes
      
      * Fix compilation
      
      * Update parachain/test-parachains/adder/collator/src/lib.rs
      
      Co-authored-by: default avatarSergei Shulepov <[email protected]>
      
      * Review comments
      
      * Downgrade transaction version
      
      * Fixes
      
      * MOARE
      
      * Register notification protocols
      
      * utils: remove unused error
      
      * av-store: more resilient to some errors
      
      * address review nits
      
      * address more review nits
      
      Co-authored-by: default avatarPeter Goodspeed-Niklaus <[email protected]>
      Co-authored-by: default avatarAndronik Ordian <[email protected]>
      Co-authored-by: default avatarFedor Sakharov <[email protected]>
      Co-authored-by: default avatarRobert Habermeier <[email protected]>
      Co-authored-by: default avatarPeter Goodspeed-Niklaus <[email protected]>
      Co-authored-by: default avatarMax Inden <[email protected]>
      Co-authored-by: default avatarSergey Shulepov <[email protected]>
      Co-authored-by: default avatarSergei Shulepov <[email protected]>
      8cadebb7
    • Fedor Sakharov's avatar
      A real overseer feature (#1892) · 20a8a61e
      Fedor Sakharov authored
      
      
      * A real overseer feature
      
      * Fix build without feature
      
      * Update node/service/src/lib.rs
      
      Co-authored-by: default avatarBastian Köcher <[email protected]>
      
      Co-authored-by: default avatarRobert Habermeier <[email protected]>
      Co-authored-by: default avatarBastian Köcher <[email protected]>
      20a8a61e
  16. Oct 28, 2020
  17. Oct 27, 2020
  18. Oct 25, 2020
  19. Oct 08, 2020
    • Peter Goodspeed-Niklaus's avatar
      Remove old service, 3rd try (#1776) · ba0d1a32
      Peter Goodspeed-Niklaus authored
      * Remove old service, 3rd try
      
      i.e.
      Revert "Revert "Remove Old Service, 2nd try (#1732)" (#1758)"
      
      This reverts commit c80f7b6b
      
      .
      
      Closes #1757.
      
      We now have some evidence that the polkadot validator was producing
      blocks after all; the reason the blocks_constructed metric was 0 was
      that as a new metric it hadn't yet been incorporated into that
      branch's codebase. See
      https://github.com/paritytech/polkadot/issues/1757#issuecomment-700977602
      
      As this PR is based on a newer `master` branch than the previous one,
      that should hopefully no longer be an issue.
      
      * paras trait now has an Origin type
      
      * initial work running a two node local net
      
      * use the right incantations so the nodes produce blocks together
      
      * improve internal documentation
      
      Co-authored-by: default avatarBastian Köcher <[email protected]>
      ba0d1a32
  20. Oct 07, 2020
  21. Oct 06, 2020
  22. Oct 05, 2020
  23. Sep 28, 2020
  24. Sep 18, 2020
    • Peter Goodspeed-Niklaus's avatar
      c68aee35
    • Peter Goodspeed-Niklaus's avatar
      Remove service, migrate all to service-new (#1630) · af14ea54
      Peter Goodspeed-Niklaus authored
      * import rococo into chain-spec
      
      * make a few stabs at moving forward
      
      * wip: rococo readme
      
      * remove /service crate
      
      - Move the chain-spec files to node-service
      - update sufficient cargo files that polkadot-service-new builds
      - not everything else builds yet
      
      * wip: chase down some build errors in polkadot-cli
      
      There's a lot more to go, but some progress has happened.
      
      * make more progress getting polkadot-cli to build
      
      * don't ignore polkadot.json within the res directory
      
      * don't recreate pathbufs
      
      * Prepare Polkadot to be used by Cumulus
      
      This begins to make Polkadot usable from Cumulus.
      
      * Remove old test
      
      * migrate new_chain_ops fix from /service
      
      * partially remove node/test-service
      
      * Reset some changes
      
      * Revert "partially remove node/test-service"
      
      This reverts commit 7b8f9ba5.
      
      * WIP: replace v0 ParachainHost impl with v1 for test runtime
      
      This is necessary because one of the current errors when building
      the test service boils down to:
      
      the trait bound `polkadot_test_runtime::RuntimeApiImpl<...>`:
        `polkadot_primitives::v1::ParachainHost<...>` is not satisfied
      
      This is WIP because it appears to be causing some std leakage into
      the wasm environment, or something; the compiler is currently
      complaining about duplicate definitions of `panic_handler` and `oom`.
      Presumably I have to identify all std types (Vec etc) and replace
      them with sp_std equivalents.
      
      * fix test runtime build
      
      it wasn't std leakage, after all
      
      * bump westend spec version
      
      * use service-new as service within cli
      
      * to revert: demo that forwarding the test runtime to the real impl blows up
      
      * Revert "to revert: demo that forwarding the test runtime to the real impl blows up"
      
      This reverts commit 68d2f385.
      
      * Revert "Revert "to revert: demo that forwarding the test runtime to the real impl blows up""
      
      This reverts commit 04cb1cbf.
      
      Might have just forgotten to disable default features
      
      * More reverts
      
      * MOARE
      
      * plug in the runtime as the generic instantiation
      
      This feels closer to a solution, but it still has problems: in particular,
      it's assumed that Runtime implements all appropriate Trait traits,
      which this one apparently does not.
      
      * implement necessary traits to get the test runtime compiling
      
      This is almost certainly not correct in some way; it really
      looks like I need to mess with the construct_runtime! macro
      somehow, to inject the inclusion trait's event type as a Event
      variant. Still, better lock down this changeset while it all
      compiles.
      
      * add inclusion::Event as variant into Event enum
      
      * implement unimplemented bits in kusama
      
      * implement unimplemented bits in polkadot runtime
      
      * implement unimplemented bits in westend runtime
      
      * migrate client upgrades from master
      
      * update test service with new node changes
      
      * package metadata--that wasn't intended to be removed
      
      * add parachains v1 modules to each runtime
      
      It's not clear what precisely this does, but it's probably the right
      thing to do.
      
      * enable cli to opt out of full node features
      
      * adjust rococo chainspec per example
      
      https://github.com/paritytech/polkadot/blob/26f1fa47
      
      /service/src/chain_spec.rs#L362
      
      * try to fix Cargo.lock
      
      Co-authored-by: default avatarBastian Köcher <[email protected]>
      Co-authored-by: default avatarAndronik Ordian <[email protected]>
      af14ea54
  25. Sep 16, 2020
  26. Sep 10, 2020
  27. Sep 08, 2020
    • Peter Goodspeed-Niklaus's avatar
      implement candidate selection subsystem (#1645) · 6c874ed4
      Peter Goodspeed-Niklaus authored
      
      
      * choose the straightforward candidate selection algorithm for now
      
      * add draft implementation of candidate selection
      
      * fix typo in summary
      
      * more properly report misbehaving collators
      
      * describe how CandidateSelection subsystem becomes aware of candidates
      
      * revise candidate selection / collator protocol interaction pattern
      
      * implement rest of candidate selection per the guide
      
      * review: resolve nits
      
      * start writing test suite, harness
      
      * implement first test
      
      * add second test
      
      * implement third test
      
      Co-authored-by: default avatarBernhard Schuster <[email protected]>
      6c874ed4
  28. Aug 26, 2020
  29. Aug 24, 2020
  30. Aug 18, 2020
    • asynchronous rob's avatar
      Implement validation data refactor (#1585) · 8c881e45
      asynchronous rob authored
      
      
      * update primitives
      
      * correct parent_head field
      
      * make hrmp field pub
      
      * refactor validation data: runtime
      
      * refactor validation data: messages
      
      * add arguments to full_validation_data runtime API
      
      * port runtime API
      
      * mostly port over candidate validation
      
      * remove some parameters from ValidationParams
      
      * guide: update candidate validation
      
      * update candidate outputs
      
      * update ValidationOutputs in primitives
      
      * port over candidate validation
      
      * add a new test for no-transient behavior
      
      * update util runtime API wrappers
      
      * candidate backing
      
      * fix missing imports
      
      * change some fields of validation data around
      
      * runtime API impl
      
      * update candidate validation
      
      * fix backing tests
      
      * grumbles from review
      
      * fix av-store tests
      
      * fix some more crates
      
      * fix provisioner tests
      
      * fix availability distribution tests
      
      * port collation-generation to new validation data
      
      * fix overseer tests
      
      * Update roadmap/implementers-guide/src/node/utility/candidate-validation.md
      
      Co-authored-by: default avatarPeter Goodspeed-Niklaus <[email protected]>
      
      Co-authored-by: default avatarPeter Goodspeed-Niklaus <[email protected]>
      8c881e45