1. Sep 10, 2020
  2. Sep 08, 2020
  3. Aug 26, 2020
  4. Aug 24, 2020
  5. Aug 18, 2020
    • asynchronous rob's avatar
      Implement validation data refactor (#1585) · 8c881e45
      asynchronous rob authored
      
      
      * update primitives
      
      * correct parent_head field
      
      * make hrmp field pub
      
      * refactor validation data: runtime
      
      * refactor validation data: messages
      
      * add arguments to full_validation_data runtime API
      
      * port runtime API
      
      * mostly port over candidate validation
      
      * remove some parameters from ValidationParams
      
      * guide: update candidate validation
      
      * update candidate outputs
      
      * update ValidationOutputs in primitives
      
      * port over candidate validation
      
      * add a new test for no-transient behavior
      
      * update util runtime API wrappers
      
      * candidate backing
      
      * fix missing imports
      
      * change some fields of validation data around
      
      * runtime API impl
      
      * update candidate validation
      
      * fix backing tests
      
      * grumbles from review
      
      * fix av-store tests
      
      * fix some more crates
      
      * fix provisioner tests
      
      * fix availability distribution tests
      
      * port collation-generation to new validation data
      
      * fix overseer tests
      
      * Update roadmap/implementers-guide/src/node/utility/candidate-validation.md
      
      Co-authored-by: default avatarPeter Goodspeed-Niklaus <[email protected]>
      
      Co-authored-by: default avatarPeter Goodspeed-Niklaus <[email protected]>
      8c881e45
  6. Aug 17, 2020
    • Peter Goodspeed-Niklaus's avatar
      implement collation generation subsystem (#1557) · e750a825
      Peter Goodspeed-Niklaus authored
      * start sketching out a collation generation subsystem
      
      * invent a basic strategy for double initialization
      
      * clean up warnings
      
      * impl util requests from runtime assuming a context instead of a FromJob sender
      
      * implement collation generation algorithm from guide
      
      * update AllMessages in tests
      
      * fix trivial review comments
      
      * remove another redundant declaration from merge
      
      * filter availability cores by para_id
      
      * handle new activations each in their own async task
      
      * update guide according to the actual current implementation
      
      * add initialization to guide
      
      * add general-purpose subsystem_test_harness helper
      
      * write first handle_new_activations test
      
      * add test that handle_new_activations filters local_validation_data requests
      
      * add (failing) test of collation distribution message sending
      
      * rustfmt
      
      * broken: work on fixing sender test
      
      Unfortunately, for reasons that are not yet clear, despite the public key
      and checked data being identical, the signer is not producing an identical
      signature. This commit produces this output (among more):
      
      signing with  Public(c4733ab0bbe3ba4c096685d1737a7f498cdbdd167a767d04a21dc7df12b8c858 (5GWHUNm5...))
      checking with Public(c4733ab0bbe3ba4c096685d1737a7f498cdbdd167a767d04a21dc7df12b8c858 (5GWHUNm5...))
      signed payload:  [4, 4, 4, 4, 4, 4, 4, 4, 4, 4, 4, 4, 4, 4, 4, 4, 4, 4, 4, 4, 4, 4, 4, 4, 4, 4, 4, 4, 4, 4, 4, 4, 10, 0, 0, 0, c7, e5, c0, 64, 7a, db, fe, 44, 81, e5, 51, 11, 79, 9f, a5, 63, 93, 94, 3c, c4, 36, c6, 30, 36, c2, c5, 44, a2, 1b, db, b7, 82, 3, 17, a, 2e, 75, 97, b7, b7, e3, d8, 4c, 5, 39, 1d, 13, 9a, 62, b1, 57, e7, 87, 86, d8, c0, 82, f2, 9d, cf, 4c, 11, 13, 14]
      checked payload: [4, 4, 4, 4, 4, 4, 4, 4, 4, 4, 4, 4, 4, 4, 4, 4, 4, 4, 4, 4, 4, 4, 4, 4, 4, 4, 4, 4, 4, 4, 4, 4, 10, 0, 0, 0, c7, e5, c0, 64, 7a, db, fe, 44, 81, e5, 51, 11, 79, 9f, a5, 63, 93, 94, 3c, c4, 36, c6, 30, 36, c2, c5, 44, a2, 1b, db, b7, 82, 3, 17, a, 2e, 75, 97, b7, b7, e3, d8, 4c, 5, 39, 1d, 13, 9a, 62, b1, 57, e7, 87, 86, d8, c0, 82, f2, 9d, cf, 4c, 11, 13, 14]
      
      * fix broken test
      
      * collation function returns commitments hash
      
      It doesn't look like we use the actual commitments data anywhere, and
      it's not obvious if there are any fields of `CandidateCommitments`
      not available to the collator, so this commit just assigns them the
      entire responsibility of generating the hash.
      
      * add missing overseer impls
      
      * calculating erasure coding is polkadot's responsibility, not cumulus
      
      * concurrentize per-relay_parent requests
      e750a825
  7. Aug 13, 2020
    • asynchronous rob's avatar
      Remove v0 parachains runtime (#1501) · ae5990c7
      asynchronous rob authored
      * remove v0 parachains modules and switch to v1 primitives
      
      * get tests compiling for runtime-common
      
      * remove registrar module
      
      * Add a dummy module
      
      * remove runtime-parachains
      
      * mostly remove old parachains code from polkadot-runtime
      
      * remove slots::Trait implementation
      
      * remove sp_std prelude import
      
      * add a ZeroSizedTypeDifferentiator to dummy
      
      * finish porting over polkadot runtime
      
      * ZeroSizedTypeDifferentiator was actually unnecessary
      
      * westend
      
      * kusama
      
      * test-runtime (no dummy modules)
      
      * fix warning
      
      * fix chain-specs
      
      * fix test-service
      
      * test-client
      
      * remove dead import
      
      * remove unused needed_extrinsics parameter
      
      * runtimes compile
      
      * remove rococo-v0
      
      * remove remaining references to Rococo
      
      * bump versions
      ae5990c7
  8. Aug 12, 2020
    • asynchronous rob's avatar
      Network bridge refactoring impl (#1537) · 1e9c0540
      asynchronous rob authored
      * update networking types
      
      * port over overseer-protocol message types
      
      * Add the collation protocol to network bridge
      
      * message sending
      
      * stub for ConnectToValidators
      
      * add some helper traits and methods to protocol types
      
      * add collator protocol message
      
      * leaves-updating
      
      * peer connection and disconnection
      
      * add utilities for dispatching multiple events
      
      * implement message handling
      
      * add an observedrole enum with equality and no sentry nodes
      
      * derive partial-eq on network bridge event
      
      * add PartialEq impls for network message types
      
      * add Into implementation for observedrole
      
      * port over existing network bridge tests
      
      * add some more tests
      
      * port bitfield distribution
      
      * port over bitfield distribution tests
      
      * add codec indices
      
      * port PoV distribution
      
      * port over PoV distribution tests
      
      * port over statement distribution
      
      * port over statement distribution tests
      
      * update overseer and service-new
      
      * address review comments
      
      * port availability distribution
      
      * port over availability distribution tests
      1e9c0540
  9. Aug 10, 2020
  10. Aug 07, 2020
  11. Aug 06, 2020
    • Peter Goodspeed-Niklaus's avatar
      implement provisioner (#1473) · a39d8803
      Peter Goodspeed-Niklaus authored
      * sketch out provisioner basics
      
      * handle provisionable data
      
      * stub out select_inherent_data
      
      * split runtime APIs into sub-chapters to improve linkability
      
      * explain SignedAvailabilityBitfield semantics
      
      * add internal link to further documentation
      
      * some more work figuring out how the provisioner can do its thing
      
      * fix broken link
      
      * don't import enum variants where it's one layer deep
      
      * make request_availability_cores a free fn in util
      
      * document more precisely what should happen on block production
      
      * finish first-draft implementation of provisioner
      
      * start working on the full and proper backed candidate selection rule
      
      * Pass number of block under construction via RequestInherentData
      
      * Revert "Pass number of block under construction via RequestInherentData"
      
      This reverts commit 850fe62c.
      
      That initially looked like the better approach--it spent the time
      budget for fetching the block number in the proposer, instead of
      the provisioner, and that felt more appropriate--but it turns out
      not to be obvious how to get the block number of the block under
      construction from within the proposer. The Chain API may be less
      ideal, but it should be easier to implement.
      
      * wip: get the block under production from the Chain API
      
      * add ChainApiMessage to AllMessages
      
      * don't break the run loop if a provisionable data channel closes
      
      * clone only those backed candidates which are coherent
      
      * propagate chain_api subsystem through various locations
      
      * add delegated_subsystem! macro to ease delegating subsystems
      
      Unfortunately, it doesn't work right:
      
      ```
      error[E0446]: private type `CandidateBackingJob` in public interface
         --> node/core/backing/src/lib.rs:775:1
          |
      86  | struct CandidateBackingJob {
          | - `CandidateBackingJob` declared as private
      ...
      775 | delegated_subsystem!(CandidateBackingJob as CandidateBackingSubsystem);
          | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ can't leak private type
      ```
      
      I'm not sure precisely what's going wrong, here; I suspect the problem is
      the use of `$job as JobTrait>::RunArgs` and `::ToJob`; the failure would be
      that it's not reifying the types to verify that the actual types are public,
      but instead referring to them via `CandidateBackingJob`, which is in fact private;
      that privacy is the point.
      
      Going to see if I can generic my way out of this, but we may be headed for a
      quick revert here.
      
      * fix delegated_subsystem
      
      The invocation is a bit more verbose than I'd prefer, but it's also
      more explicit about what types need to be public. I'll take it as a win.
      
      * add provisioning subsystem; reduce public interface of provisioner
      
      * deny missing docs in provisioner
      
      * refactor core selection per code review suggestion
      
      This is twice as much code when measured by line, but IMO it is
      in fact somewhat clearer to read, so overall a win.
      
      Also adds an improved rule for selecting availability bitfields,
      which (unlike the previous implementation) guarantees that the
      appropriate postconditions hold there.
      
      * fix bad merge double-declaration
      
      * update guide with (hopefully) complete provisioner candidate selection procedure
      
      * clarify candidate selection algorithm
      
      * Revert "clarify candidate selection algorithm"
      
      This reverts commit c68a02ac.
      
      * clarify candidate selection algorithm
      
      * update provisioner to implement candidate selection per the guide
      
      * add test that no more than one bitfield is selected per validator
      
      * add test that each selected bitfield corresponds to an occupied core
      
      * add test that more set bits win conflicts
      
      * add macro for specializing runtime requests; specailize all runtime requests
      
      * add tests harness for select_candidates tests
      
      * add first real select_candidates test, fix test_harness
      
      * add mock overseer and test that success is possible
      
      * add test that the candidate selection algorithm picks the right ones
      
      * make candidate selection test somewhat more stringent
      a39d8803
  12. Aug 04, 2020
    • Bastian Köcher's avatar
      Add Rococo test network (#1363) · 5fd6440a
      Bastian Köcher authored
      * Add Rococo test network
      
      * Correct license header
      
      * Add bootNodes address
      
      * Fix compile errors
      
      * Change bootNodes
      
      * Change rococo bootNodes
      
      * Add new bootNodes
      
      * Fix bootNodes typo
      
      * Remove public telemetry
      
      * Add rococo-local chain spec
      
      * Remove staking
      
      * Remove staking from chain spec
      
      * use rococo-staging chain spec and preserve bootnodes
      
      * Same but with --raw
      
      * update chain name and remove telemetry
      
      * Empty commit to re-trigger CI
      
      * Fix revision (temp. until I merge master)
      
      * Revert to branch = master to avoid conflicts
      
      * Revert to branch = master to avoid conflicts
      
      * Disable test (temp)
      
      * Revert to branch = master to avoid conflicts
      
      * Revert to branch = master to avoid conflicts
      
      * Change bootNodes IPs for second rococo network
      
      * Revert "Disable test (temp)"
      
      This reverts commit a159f12e
      
      .
      
      * Revert purchase
      
      * Update chain spec
      
      * FUUU
      
      * Update service/src/lib.rs
      
      Co-authored-by: default avatarRobert Habermeier <[email protected]>
      
      * Update runtime/rococo/src/lib.rs
      
      Co-authored-by: default avatarRobert Habermeier <[email protected]>
      
      * Fix compilation
      
      Co-authored-by: default avatarEvaldo <[email protected]>
      Co-authored-by: default avatarDavid Dorgan <[email protected]>
      Co-authored-by: default avatarCecile Tonglet <[email protected]>
      Co-authored-by: default avatarRobert Habermeier <[email protected]>
      5fd6440a
  13. Aug 02, 2020
  14. Jul 31, 2020
    • Fedor Sakharov's avatar
      Parachains-runtime (#1505) · eca01a8c
      Fedor Sakharov authored
      * Initial commit
      
      * v0 to v1 primitives and remove attestations
      
      * Review fixes
      
      * implement candidate_events
      
      * remove dead code
      eca01a8c
    • ordian's avatar
      Chain API subsystem (#1498) · d4022633
      ordian authored
      * chain-api subsystem skeleton
      
      * chain-api subsystem: draft impl
      
      * chain-api subsystem: mock testclient
      
      * chain-api subsystem: impl HeaderBacked for TestClient
      
      * chain-api subsystem: impl basic tests
      
      * chain-api subsystem: tiny guide
      
      * chain-api subsystem: rename ChainApiRequestMessage to ChainApiMessage
      
      * chain-api subsystem: add the page to the ToC
      
      * chain-api subsystem: proper error type
      
      * chain-api subsystem: impl ancestors request
      
      * chain-api subsystem: tests for ancestors request
      
      * guide: fix ancestor return type
      
      * runtime-api subsystem: remove unused dep
      
      * fix fmt
      
      * fix outdated comment
      
      * chain-api subsystem: s/format/to_string
      
      * lower-case subsystem names
      
      * chain-api subsystem: resolve Finalized todo
      
      * chain-api subsystem: remove TODO
      
      * extract request errors into a module
      
      * remove caching TODO
      
      * fix imports
      d4022633
  15. Jul 30, 2020
    • asynchronous rob's avatar
      Candidate Validation Subsystem (#1432) · cdb5c408
      asynchronous rob authored
      * skeleton for candidate-validation
      
      * add to workspace
      
      * implement candidate validation logic
      
      * guide: note occupied-core assumption for candidate validation
      
      * adjust message doc
      
      * wire together `run` asynchronously
      
      * add a Subsystem implementation
      
      * clean up a couple warnings
      
      * fix compilation errors due to merge
      
      * improve candidate-validation.md
      
      * remove old reference to subsystem-test helpers crate
      
      * update Cargo.lock
      
      * add a couple new Runtime API methods
      
      * add a candidate validation message
      
      * fetch validation data from the chain state
      
      * some tests for assumption checking
      
      * make spawn_validate_exhaustive mockable
      
      * more tests on the error handling side
      
      * fix all other grumbles except for wasm validation API change
      
      * wrap a SpawnNamed in candidate-validation
      
      * warn
      
      * amend guide
      
      * squanch warning
      
      * remove duplicate after merge
      cdb5c408
    • asynchronous rob's avatar
      Implement the Runtime API subsystem (#1494) · f772196f
      asynchronous rob authored
      * type defaults for ParachainHost
      
      * add ValidationCode message
      
      * implement core loop of runtime API subsystem
      
      * subsystem trait implementation for runtime API subsystem
      
      * implement a mock runtime API
      
      * some tests that ensure requests are forwarded to runtime API correctly
      
      * fix dependency grumbles
      
      * improve RuntimeApiError API
      f772196f
  16. Jul 29, 2020
  17. Jul 27, 2020
    • Fedor Sakharov's avatar
      Availability store subsystem (#1404) · b838b386
      Fedor Sakharov authored
      * Initial commit
      
      * WIP
      
      * Make atomic transactions
      
      * Remove pruning code
      
      * Fix build and add a Nop to bridge
      
      * Fixes from review
      
      * Move config struct around for clarity
      
      * Rename constructor and warn on missing docs
      
      * Fix a test and rename a message
      
      * Fix some more reviews
      
      * Obviously failed to rebase cleanly
      b838b386
  18. Jul 24, 2020
  19. Jul 23, 2020
    • Peter Goodspeed-Niklaus's avatar
      implement bitfield signing subsystem (#1364) · 8217ca67
      Peter Goodspeed-Niklaus authored
      
      
      * update guide to reduce confusion and TODOs
      
      * work from previous bitfield signing effort
      
      There were large merge issues with the old bitfield signing PR, so
      we're just copying all the work from that onto this and restarting.
      
      Much of the existing work will be discarded because we now have better
      tools available, but that's fine.
      
      * start rewriting bitfield signing in terms of the util module
      
      * implement construct_availability_bitvec
      
      It's not an ideal implementation--we can make it much more concurrent--
      but at least it compiles.
      
      * implement the unimplemented portions of bitfield signing
      
      * get core availability concurrently, not sequentially
      
      * use sp-std instead of std for a parachain item
      
      * resolve type inference failure caused by multiple From impls
      
      * handle bitfield signing subsystem & Allmessages variant in overseer
      
      * fix more multi-From inference issues
      
      * more concisely handle overflow
      
      Co-authored-by: default avatarAndronik Ordian <[email protected]>
      
      * Revert "resolve type inference failure caused by multiple From impls"
      
      This reverts commit 7fc77805.
      
      * Revert "fix more multi-From inference issues"
      
      This reverts commit f14ffe58
      
      .
      
      * impl From<i32> for ParaId
      
      * handle another instance of AllSubsystems
      
      * improve consistency when returning existing options
      
      Co-authored-by: default avatarAndronik Ordian <[email protected]>
      8217ca67
    • Bernhard Schuster's avatar
      implement bitfield distribution subsystem (#1368) · 08fcbda4
      Bernhard Schuster authored
      
      
      * feat bitfield distribution
      
      * feat bitfield distribution part 2
      
      * pair programming with rustc & cargo
      
      * lets go
      
      * move bitfield-distribution to the node/network folder
      
      * shape shifting
      
      * lunchtime
      
      * ignore the two fn recursion for now
      
      * step by step
      
      * triplesteps
      
      * bandaid commit
      
      * unordered futures magic
      
      * chore
      
      * reword markdown
      
      * clarify
      
      * lacks abortable processing impl details
      
      * slimify
      
      * fix: warnings and avoid ctx.clone() improve comments
      
      * review comments
      
      * fix details
      
      * make sure outgoing messages are tracked
      
      * fix name
      
      * fix subsystem
      
      * partial test impl
      
      * relax context bounds
      
      * test
      
      * X
      
      * X
      
      * initial test
      
      * fix relay_message not tracked when origin is self
      
      * fix/guide: grammar
      
      Co-authored-by: default avatarRobert Habermeier <[email protected]>
      
      * work around missing Eq+PartialEq
      
      * fix: add missing message to provisioner
      
      * unify per_job to job_data
      
      * fix/review: part one
      
      * fix/review: more grumbles
      
      * fix/review: track incoming messages per peer
      
      * fix/review: extract fn, avoid nested matches
      
      * fix/review: more tests, simplify test
      
      * fix/review: extend tests to cover more cases
      
      * chore/rename: Tracker -> ProtocolState
      
      * chore check and comment rewording
      
      * feat test: invalid peer message
      
      * remove ignored test cases and unused macros
      
      * fix master merge fallout + warnings
      
      Co-authored-by: default avatarRobert Habermeier <[email protected]>
      08fcbda4
  20. Jul 22, 2020
  21. Jul 21, 2020
    • Gavin Wood's avatar
      Enable transfers (#1443) · b481d6c0
      Gavin Wood authored
      * Enable transfers
      
      Also quash any conviction from Referendum Zero; Sudo was always
      going to have been removed so lock-voting doesn't make sense in
      this case.
      
      * Add test for migration; remove superfluous comment.
      
      * Fixes
      
      * Bump
      
      * Weekly elections
      v0.8.18
      b481d6c0
    • Peter Goodspeed-Niklaus's avatar
      Add test suite and minor refinements to the utility subsystem (#1403) · cc2d7afd
      Peter Goodspeed-Niklaus authored
      * get conclude signal working properly; don't allocate a vector
      
      * wip: add test suite / example / explanation for using utility subsystem
      
      Unfortunately, the test fails right now for reasons which seem
      very odd. Just have to keep poking at it.
      
      * explicitly import everything
      
      * fix subsystem-util test
      
      The root problem here was two-fold:
      
      - there was a circular dependency from subsystem -> test-helpers/subsystem ->
        subsystem
      - cfg(test) doesn't propagate between crates
      
      The solution: move the subsystem test helpers into a sub-module
      within subsystem. Publicly export them from the previous location
      so no other code breaks.
      
      Doing this has an additional benefit: it ensures that no production
      code can ever accidentally use the subsystem helpers, as they are compile-
      gated on cfg(test).
      
      * fully commit to moving test helpers into a subsystem module
      
      * add some more tests
      
      * get rid of log tests in favor of real error forwarding
      
      It's not obvious whether we'll ever really want to chase down
      these errors outside a testing context, but having the capability
      won't hurt.
      
      * fix issue which caused test to hang on osx
      
      * only require that job errors are PartialEq when testing
      
      also fix polkadot-node-core-backing tests
      
      * get rid of any notion of partialeq
      
      * rethink testing
      
      Combine tests of starting and stopping job: leaving a test executor
      with a job running was pretty clearly the cause of the sometimes-hang.
      
      Also, add a timeout so tests _can't_ hang anymore; they just fail
      after a while.
      
      * rename fwd_errors -> forward_errors
      
      * warn on error propagation failure
      
      * fix unused import leftover from merge
      
      * derive eq for subsystemerror
      cc2d7afd
  22. Jul 20, 2020
    • Gavin Wood's avatar
      Remove Sudo (#1437) · 29fea4e4
      Gavin Wood authored
      * Remove Sudo
      
      NOTE: To ensure minimal index changes to pre-existing pallet deployments,
      this is done with a "swap_remove" style; the previous last pallet
      (Purchase), which is hitherto unused, has been shifted into the old index
      of Sudo.
      
      * Remove CC1 designation.
      
      * Fixes
      
      * Bump
      
      * Fixes
      
      * Fixes
      
      * Fixes
      
      * Fixes
      
      * Fixes
      
      * Fixes
      
      * Fixes
      
      * Fixes
      
      * Fixes
      
      * Fixes
      v0.8.17
      29fea4e4
    • Gavin Wood's avatar
      Bump version, enable full governance (#1433) · 4a997abe
      Gavin Wood authored
      v0.8.16
      4a997abe
  23. Jul 14, 2020
  24. Jul 09, 2020
    • Fedor Sakharov's avatar
      CandidateBackingSubsystem (#1312) · 6aa5bfba
      Fedor Sakharov authored
      * Updates guide for CandidateBacking
      
      * Move assignment types to primitives
      
      * Initial implementation.
      
      * More functionality
      
      * use assert_matches
      
      * Changes to report misbehaviors
      
      * Some fixes after a review
      
      * Remove a blank line
      
      * Update guide and some types
      
      * Adds run_job function
      
      * Some comments and refactorings
      
      * Fix review
      
      * Remove warnings
      
      * Use summary in kicking off validation
      
      * Parallelize requests
      
      * Validation provides local and global validation params
      
      * Test issued validity tracking
      
      * Nits from review
      6aa5bfba
    • Cecile Tonglet's avatar
      Make a test crate to make the runtime-test usable (#1258) · 3f8cfb7d
      Cecile Tonglet authored
      Fixes #833
      3f8cfb7d
  25. Jul 08, 2020
    • asynchronous rob's avatar
      Implement PoV Distribution Subsystem (#1344) · b651e4af
      asynchronous rob authored
      * introduce candidatedescriptor type
      
      * add PoVDistribution message type
      
      * loosen bound on PoV Distribution to account for equivocations
      
      * re-export some types from the messages module
      
      * begin PoV Distribution subsystem
      
      * remove redundant index from PoV distribution
      
      * define state machine for pov distribution
      
      * handle overseer signals
      
      * set up control flow
      
      * remove `ValidatorStatement` section
      
      * implement PoV fetching
      
      * implement distribution logic
      
      * add missing `
      
      * implement some network bridge event handlers
      
      * stub for message processing, handle our view change
      
      * control flow for handling messages
      
      * handle `awaiting` message
      
      * handle any incoming PoVs and redistribute
      
      * actually provide a subsystem implementation
      
      * remove set-builder notation
      
      * begin testing PoV distribution
      
      * test that we send awaiting messages only to peers with same view
      
      * ensure we distribute awaited PoVs to peers on view changes
      
      * test that peers can complete fetch and are rewarded
      
      * test some reporting logic
      
      * ensure peer is reported for flooding
      
      * test punishing peers diverging from awaited protocol
      
      * test that we eagerly complete peers' awaited PoVs based on what we receive
      
      * test that we prune the awaited set after receiving
      
      * expand pov-distribution in guide to match a change I made
      
      * remove unneeded import
      b651e4af
  26. Jul 06, 2020
    • asynchronous rob's avatar
      Implement the Statement Distribution Subsystem (#1326) · 8348cc4c
      asynchronous rob authored
      * set up data types and control flow for statement distribution
      
      * add some set-like methods to View
      
      * implement sending to peers
      
      * start fixing equivocation handling
      
      * Add a section to the statement distribution subsystem on equivocations and flood protection
      
      * fix typo and amend wording
      
      * implement flood protection
      
      * have peer knowledge tracker follow when peer first learns about a candidate
      
      * send dependents after circulating
      
      * add another TODO
      
      * trigger send in one more place
      
      * refactors from review
      
      * send new statements to candidate backing
      
      * instantiate active head data with runtime API values
      
      * track our view changes and peer view changes
      
      * apply a benefit to peers who send us statements we want
      
      * remove unneeded TODO
      
      * add some comments and improve Hash implementation
      
      * start tests and fix `note_statement`
      
      * test active_head seconding logic
      
      * test that the per-peer tracking logic works
      
      * test per-peer knowledge tracker
      
      * test that peer view updates lead to messages being sent
      
      * test statement circulation
      
      * address review comments
      
      * have view set methods return references
      8348cc4c
  27. Jul 05, 2020
    • Peter Goodspeed-Niklaus's avatar
      implement custom proposer (#1320) · 69ce9ff3
      Peter Goodspeed-Niklaus authored
      
      
      * network bridge skeleton
      
      * move some primitives around and add debug impls
      
      * protocol registration glue & abstract network interface
      
      * add send_msgs to subsystemctx
      
      * select logic
      
      * transform different events into actions and handle
      
      * implement remaining network bridge state machine
      
      * start test skeleton
      
      * make network methods asynchronous
      
      * extract subsystem out to subsystem crate
      
      * port over overseer to subsystem context trait
      
      * fix minimal example
      
      * fix overseer doc test
      
      * update network-bridge crate
      
      * write a subsystem test-helpers crate
      
      * write a network test helper for network-bridge
      
      * set up (broken) view test
      
      * Revamp network to be more async-friendly and not require Sync
      
      * fix spacing
      
      * fix test compilation
      
      * insert side-channel for actions
      
      * Add some more message types to AllMessages
      
      * introduce a test harness
      
      * impl ProvideInherent for InclusionInherent
      
      * reduce import churn; correct expect message
      
      * move inclusion inherent identifier into primitives
      
      It's not clear precisely why this is desired, but it's a pattern
      I've seen in several places, so I'm going this to be on the
      safe side. Worst case, we can revert this commit pretty easily.
      
      * bump kusama spec_version to placate CI
      
      * copy sc_basic_authorship::{ProposerFactory, Proposer}
      
      We have from the problem description:
      
      > This Proposer will require an OverseerHandle to make requests via.
      
      That's next on the plate.
      
      * use polkadot custom proposer instead of basic-authorship one
      
      * add some tests
      
      * ensure service compiles and passes tests
      
      * fix typo
      
      * fix service-new compilation
      
      * Subsystem test helpers send messages synchronously
      
      * remove smelly action inspector
      
      * remove superfluous let binding
      
      * fix warnings
      
      * add license header
      
      * empty commit; maybe github will notice the one with changes
      
      * Update node/network/bridge/src/lib.rs
      
      Co-authored-by: default avatarPeter Goodspeed-Niklaus <[email protected]>
      
      * add sanity check to only include valid inherents
      
      * stub: encapsulate block production mechanics instead of copying them
      
      The goal is to end up with something like what's in
      validation::block_production::*, which encapsulates
      basic block production mechanics. This is a better idea than
      just straight-up copying those mechanics.
      
      * partial implementation of propose fn
      
      Doesn't actually compile yet; need to bring in some other
      commits to ensure ProvisionerMessage is a thing, and also
      figure out how to get the block hash given the current
      context.
      
      * fix compilation
      
      * clear a few more compile errors
      
      * finish fn propose
      
      * broken: add timeout to proposal
      
      * add timeout to proposal
      
      * guide: provisioner is responsible for selecting parachain candidates
      
      * implement ProvisionerMessage::RequestInherentData & update fn propose
      
      * impl CreateProposer::init; clean up
      
      * impl std::error::Error for Error
      
      * document error-handling rationale
      
      * cause polkadot-service-new to compile correctly
      
      * Move potentially-blocking call from fn init -> fn propose
      
      This means that we can wrap the delayed call into the same
      timeout check used elsewhere.
      
      * document struct Proposer
      
      * extract provisioner data fetch
      
      This satisfies two requirements:
      
      - only applies the timeout to actually fetching the provisioner data,
        not to constructing the block after
      - simplifies the problem of injecting default data if we could not
        get the real provisioner data in time.
      
      Co-authored-by: default avatarRobert Habermeier <[email protected]>
      Co-authored-by: default avatarGavin Wood <[email protected]>
      69ce9ff3
  28. Jul 03, 2020
  29. Jul 01, 2020
  30. Jun 30, 2020
    • asynchronous rob's avatar
      Implement Network Bridge (#1280) · eaae8653
      asynchronous rob authored
      
      
      * network bridge skeleton
      
      * move some primitives around and add debug impls
      
      * protocol registration glue & abstract network interface
      
      * add send_msgs to subsystemctx
      
      * select logic
      
      * transform different events into actions and handle
      
      * implement remaining network bridge state machine
      
      * start test skeleton
      
      * make network methods asynchronous
      
      * extract subsystem out to subsystem crate
      
      * port over overseer to subsystem context trait
      
      * fix minimal example
      
      * fix overseer doc test
      
      * update network-bridge crate
      
      * write a subsystem test-helpers crate
      
      * write a network test helper for network-bridge
      
      * set up (broken) view test
      
      * Revamp network to be more async-friendly and not require Sync
      
      * fix spacing
      
      * fix test compilation
      
      * insert side-channel for actions
      
      * Add some more message types to AllMessages
      
      * introduce a test harness
      
      * add some tests
      
      * ensure service compiles and passes tests
      
      * fix typo
      
      * fix service-new compilation
      
      * Subsystem test helpers send messages synchronously
      
      * remove smelly action inspector
      
      * remove superfluous let binding
      
      * fix warnings
      
      * Update node/network/bridge/src/lib.rs
      
      Co-authored-by: default avatarPeter Goodspeed-Niklaus <[email protected]>
      
      * fix compilation
      
      Co-authored-by: default avatarPeter Goodspeed-Niklaus <[email protected]>
      eaae8653
  31. Jun 26, 2020