Skip to content
  1. Aug 23, 2020
  2. Aug 21, 2020
    • ordian's avatar
      jobs: don't early exit when there are no jobs (#1621) · 26493b44
      ordian authored
      * jobs: don't early exit when there are no jobs
      
      * utils: fix merged test
      
      * utils: less verbose
      
      * utils: add an assert subsystem is running
      
      * utils: use TimeoutExt from test-helpers
      
      * test-helpers: use TimeoutExt
      26493b44
    • ordian's avatar
      utils: handle race condition gracefully (#1583) · 8e4e79f5
      ordian authored
      * utils: handle race condition gracefully
      
      * utils: add a test
      
      * update Cargo.lock
      
      * utils: remove a warning
      
      * utils: init logger in tests
      
      * utils: update the outdated comment
      
      * util: wait for both subsystem and test_future to finish
      
      * Revert "util: wait for both subsystem and test_future to finish"
      
      This reverts commit 075b3924.
      8e4e79f5
  3. Aug 20, 2020
  4. Aug 19, 2020
  5. Aug 18, 2020
    • Ximin Luo's avatar
    • Jeff Burdges's avatar
      Initial guide text for approvals and especially approvals assignments (#1518) · 7fcefb84
      Jeff Burdges authored
      
      
      * Initial guide modifications for approvals
      
      * Split approval assignments keys and approval votes keys
      
      This should avoid the political problems with validator operators
      wnting everything to be a remote signer.
      
      * Update roadmap/implementers-guide/src/runtime/validity.md
      
      Co-authored-by: default avatarRobert Habermeier <[email protected]>
      
      * Update roadmap/implementers-guide/src/node/validity/assignments.md
      
      Co-authored-by: default avatarRobert Habermeier <[email protected]>
      
      * Update roadmap/implementers-guide/src/node/validity/assignments.md
      
      Co-authored-by: default avatarRobert Habermeier <[email protected]>
      
      * Update roadmap/implementers-guide/src/node/validity/assignments.md
      
      Co-authored-by: default avatarRobert Habermeier <[email protected]>
      
      * Update roadmap/implementers-guide/src/node/validity/assignments.md
      
      Co-authored-by: default avatarRobert Habermeier <[email protected]>
      
      * Update roadmap/implementers-guide/src/node/validity/assignments.md
      
      Co-authored-by: default avatarRobert Habermeier <[email protected]>
      
      * Update roadmap/implementers-guide/src/node/validity/assignments.md
      
      Co-authored-by: default avatarRobert Habermeier <[email protected]>
      
      * Update roadmap/implementers-guide/src/node/validity/assignments.md
      
      Co-authored-by: default avatarRobert Habermeier <[email protected]>
      
      * Update roadmap/implementers-guide/src/node/validity/approvals.md
      
      Co-authored-by: default avatarhndnklnc <[email protected]>
      
      * Update roadmap/implementers-guide/src/node/validity/approvals.md
      
      Co-authored-by: default avatarhndnklnc <[email protected]>
      
      * Update roadmap/implementers-guide/src/runtime/validity.md
      
      Co-authored-by: default avatarRobert Habermeier <[email protected]>
      
      * Not sure where these go..
      
      * Update roadmap/implementers-guide/src/node/validity/approvals.md
      
      Co-authored-by: default avatarRobert Habermeier <[email protected]>
      
      * Local clock leniency
      
      * Explain HSM blabla
      
      * double word
      
      * Clarify okasing things on-chain
      
      * Assignments integration with relative time
      
      * minor tweaks
      
      * Clarify structure and work savings
      
      * Use included more
      
      * Cleanup and paramaters
      
      See https://github.com/w3f/research-internal/issues/515
      
      * More on GRANDPA
      
      * Explain relay equivocation relevance
      
      * Address postponement and on-chain verification somewhat
      
      * small bit more explination
      
      * just use ed25519 here: could -> should
      
      * spelling
      
      Co-authored-by: default avatarRobert Habermeier <[email protected]>
      Co-authored-by: default avatarhndnklnc <[email protected]>
      7fcefb84
    • asynchronous rob's avatar
      Implement validation data refactor (#1585) · 8c881e45
      asynchronous rob authored
      
      
      * update primitives
      
      * correct parent_head field
      
      * make hrmp field pub
      
      * refactor validation data: runtime
      
      * refactor validation data: messages
      
      * add arguments to full_validation_data runtime API
      
      * port runtime API
      
      * mostly port over candidate validation
      
      * remove some parameters from ValidationParams
      
      * guide: update candidate validation
      
      * update candidate outputs
      
      * update ValidationOutputs in primitives
      
      * port over candidate validation
      
      * add a new test for no-transient behavior
      
      * update util runtime API wrappers
      
      * candidate backing
      
      * fix missing imports
      
      * change some fields of validation data around
      
      * runtime API impl
      
      * update candidate validation
      
      * fix backing tests
      
      * grumbles from review
      
      * fix av-store tests
      
      * fix some more crates
      
      * fix provisioner tests
      
      * fix availability distribution tests
      
      * port collation-generation to new validation data
      
      * fix overseer tests
      
      * Update roadmap/implementers-guide/src/node/utility/candidate-validation.md
      
      Co-authored-by: default avatarPeter Goodspeed-Niklaus <[email protected]>
      
      Co-authored-by: default avatarPeter Goodspeed-Niklaus <[email protected]>
      8c881e45
    • Sergey Pepyakin's avatar
      Implementer's Guide: Make HRMP use upward message kinds (#1591) · 31f7ef9b
      Sergey Pepyakin authored
      
      
      * Draft HRMP related message types
      
      * Make HRMP use upward message kinds
      
      * Incorporate changes into messaging.md
      
      * Make docs a bit more clear
      
      * Clarify remove "D"
      
      * Update roadmap/implementers-guide/src/messaging.md
      
      Co-authored-by: default avatarBernhard Schuster <[email protected]>
      
      * Update roadmap/implementers-guide/src/runtime/router.md
      
      Co-authored-by: default avatarBernhard Schuster <[email protected]>
      
      * Update router.md
      
      * Update roadmap/implementers-guide/src/runtime/router.md
      
      Co-authored-by: default avatarRobert Habermeier <[email protected]>
      
      Co-authored-by: default avatarBernhard Schuster <[email protected]>
      Co-authored-by: default avatarRobert Habermeier <[email protected]>
      31f7ef9b
    • ordian's avatar
      initial prometheus metrics (#1536) · 804958ab
      ordian authored
      * service-new: cosmetic changes
      
      * overseer: draft of prometheus metrics
      
      * metrics: update active_leaves metrics
      
      * metrics: extract into functions
      
      * metrics: resolve XXX
      
      * metrics: it's ugly, but it works
      
      * Bump Substrate
      
      * metrics: move a bunch of code around
      
      * Bumb substrate again
      
      * metrics: fix a warning
      
      * fix a warning in runtime
      
      * metrics: statements signed
      
      * metrics: statements impl RegisterMetrics
      
      * metrics: refactor Metrics trait
      
      * metrics: add Metrics assoc type to JobTrait
      
      * metrics: move Metrics trait to util
      
      * metrics: fix overseer
      
      * metrics: fix backing
      
      * metrics: fix candidate validation
      
      * metrics: derive Default
      
      * metrics: docs
      
      * metrics: add stubs for other subsystems
      
      * metrics: add more stubs and fix compilation
      
      * metrics: fix doctest
      
      * metrics: move to subsystem
      
      * metrics: fix candidate validation
      
      * metrics: bitfield signing
      
      * metrics: av store
      
      * metrics: chain API
      
      * metrics: runtime API
      
      * metrics: stub for avad
      
      * metrics: candidates seconded
      
      * metrics: ok I gave up
      
      * metrics: provisioner
      
      * metrics: remove a clone by requiring Metrics: Sync
      
      * metrics: YAGNI
      
      * metrics: remove another TODO
      
      * metrics: for later
      
      * metrics: add parachain_ prefix
      
      * metrics: s/signed_statement/signed_statements
      
      * utils: add a comment for job metrics
      
      * metrics: address review comments
      
      * metrics: oops
      
      * metrics: make sure to save files before commit 😅
      
      
      
      * use _total suffix for requests metrics
      
      Co-authored-by: default avatarMax Inden <[email protected]>
      
      * metrics: add tests for overseer
      
      * update Cargo.lock
      
      * overseer: add a test for CollationGeneration
      
      * collation-generation: impl metrics
      
      * collation-generation: use kebab-case for name
      
      * collation-generation: add a constructor
      
      Co-authored-by: default avatarGav Wood <[email protected]>
      Co-authored-by: default avatarAshley Ruglys <[email protected]>
      Co-authored-by: default avatarMax Inden <[email protected]>
      804958ab
    • Shawn Tabrizi's avatar
      Companion for Substrate 6868 (WeightInfo for System, Utility, and Timestamp) (#1606) · 62b9d4a5
      Shawn Tabrizi authored
      * fix compile warning
      
      * remove tests for weights
      
      * add custom weights
      
      * "Update Substrate"
      
      Co-authored-by: parity-processbot <>
      62b9d4a5
  6. Aug 17, 2020
    • Sergey Pepyakin's avatar
    • ordian's avatar
      a91b117c
    • ordian's avatar
      overseer: fix build (#1596) · c61d9076
      ordian authored
      * overseer: add a test for CollationGeneration
      
      * fix build
      c61d9076
    • Wei Tang's avatar
      Companion PR for #6862 (#1564) · c435c187
      Wei Tang authored
      
      
      * Companion PR for #6862
      
      * Check in Cargo.lock for CI
      
      * "Update Substrate"
      
      * update substrate
      
      Co-authored-by: parity-processbot <>
      Co-authored-by: default avatarAndré Silva <[email protected]>
      c435c187
    • Peter Goodspeed-Niklaus's avatar
      implement collation generation subsystem (#1557) · e750a825
      Peter Goodspeed-Niklaus authored
      * start sketching out a collation generation subsystem
      
      * invent a basic strategy for double initialization
      
      * clean up warnings
      
      * impl util requests from runtime assuming a context instead of a FromJob sender
      
      * implement collation generation algorithm from guide
      
      * update AllMessages in tests
      
      * fix trivial review comments
      
      * remove another redundant declaration from merge
      
      * filter availability cores by para_id
      
      * handle new activations each in their own async task
      
      * update guide according to the actual current implementation
      
      * add initialization to guide
      
      * add general-purpose subsystem_test_harness helper
      
      * write first handle_new_activations test
      
      * add test that handle_new_activations filters local_validation_data requests
      
      * add (failing) test of collation distribution message sending
      
      * rustfmt
      
      * broken: work on fixing sender test
      
      Unfortunately, for reasons that are not yet clear, despite the public key
      and checked data being identical, the signer is not producing an identical
      signature. This commit produces this output (among more):
      
      signing with  Public(c4733ab0bbe3ba4c096685d1737a7f498cdbdd167a767d04a21dc7df12b8c858 (5GWHUNm5...))
      checking with Public(c4733ab0bbe3ba4c096685d1737a7f498cdbdd167a767d04a21dc7df12b8c858 (5GWHUNm5...))
      signed payload:  [4, 4, 4, 4, 4, 4, 4, 4, 4, 4, 4, 4, 4, 4, 4, 4, 4, 4, 4, 4, 4, 4, 4, 4, 4, 4, 4, 4, 4, 4, 4, 4, 10, 0, 0, 0, c7, e5, c0, 64, 7a, db, fe, 44, 81, e5, 51, 11, 79, 9f, a5, 63, 93, 94, 3c, c4, 36, c6, 30, 36, c2, c5, 44, a2, 1b, db, b7, 82, 3, 17, a, 2e, 75, 97, b7, b7, e3, d8, 4c, 5, 39, 1d, 13, 9a, 62, b1, 57, e7, 87, 86, d8, c0, 82, f2, 9d, cf, 4c, 11, 13, 14]
      checked payload: [4, 4, 4, 4, 4, 4, 4, 4, 4, 4, 4, 4, 4, 4, 4, 4, 4, 4, 4, 4, 4, 4, 4, 4, 4, 4, 4, 4, 4, 4, 4, 4, 10, 0, 0, 0, c7, e5, c0, 64, 7a, db, fe, 44, 81, e5, 51, 11, 79, 9f, a5, 63, 93, 94, 3c, c4, 36, c6, 30, 36, c2, c5, 44, a2, 1b, db, b7, 82, 3, 17, a, 2e, 75, 97, b7, b7, e3, d8, 4c, 5, 39, 1d, 13, 9a, 62, b1, 57, e7, 87, 86, d8, c0, 82, f2, 9d, cf, 4c, 11, 13, 14]
      
      * fix broken test
      
      * collation function returns commitments hash
      
      It doesn't look like we use the actual commitments data anywhere, and
      it's not obvious if there are any fields of `CandidateCommitments`
      not available to the collator, so this commit just assigns them the
      entire responsibility of generating the hash.
      
      * add missing overseer impls
      
      * calculating erasure coding is polkadot's responsibility, not cumulus
      
      * concurrentize per-relay_parent requests
      e750a825
    • ordian's avatar
      Add spawn_blocking to SubsystemContext (#1570) · 474b72a5
      ordian authored
      * subsystem: add spawn_blocking to SubsystemContext
      
      * candidate-validation: use spawn_blocking for exhaustive tasks
      474b72a5
  7. Aug 15, 2020
  8. Aug 14, 2020
  9. Aug 13, 2020
  10. Aug 12, 2020
    • Max Inden's avatar
      service/src/lib: Update authority discovery construction (#1563) · f73f2a86
      Max Inden authored
      * service/src/lib: Update authority discovery construction
      
      https://github.com/paritytech/substrate/pull/6760 introduces the concept
      of an authority discovery `Service` allowing one to communicate with an
      authority discovery `Worker`, e.g. to learn the `Multiaddr`s for a given
      `AuthorityId`.
      
      Along with the new `Service` structure it also alters the authority
      discovery constructor to return both a worker and a service. This
      commit adjusts the callside of the constructor, ignoring the `Service`
      for now.
      
      * "Update Substrate"
      
      * Revert ""Update Substrate""
      
      This reverts commit 04fb79c4.
      
      * Update Substrate
      
      Co-authored-by: parity-processbot <>
      f73f2a86
    • Sergey Pepyakin's avatar
      Update .editorconfig to what we have in practice (#1545) · c78c2b46
      Sergey Pepyakin authored
      While editing the impl guide markdowns I tried to be inline with what seemingly more
      common way to indent them: spaces. However, despite that I changed it kept reseting.
      Turned out the culprit is the .editorconfig file.
      
      This commit addresses this issue. I didn't try to deduplicate the rules since
      I found that the formal specification is a bit ambigious and it is not a big
      deal anyway.
      c78c2b46
    • mattrutherford's avatar
      Companion PR for substrate #6672 (#1560) · 48678513
      mattrutherford authored
      
      
      * update Cargo.lock
      
      * "Update Substrate"
      
      Co-authored-by: default avatarMatt Rutherford <[email protected]>
      Co-authored-by: parity-processbot <>
      48678513
    • Federico Gimenez's avatar
      305355d5
    • asynchronous rob's avatar
      Network bridge refactoring impl (#1537) · 1e9c0540
      asynchronous rob authored
      * update networking types
      
      * port over overseer-protocol message types
      
      * Add the collation protocol to network bridge
      
      * message sending
      
      * stub for ConnectToValidators
      
      * add some helper traits and methods to protocol types
      
      * add collator protocol message
      
      * leaves-updating
      
      * peer connection and disconnection
      
      * add utilities for dispatching multiple events
      
      * implement message handling
      
      * add an observedrole enum with equality and no sentry nodes
      
      * derive partial-eq on network bridge event
      
      * add PartialEq impls for network message types
      
      * add Into implementation for observedrole
      
      * port over existing network bridge tests
      
      * add some more tests
      
      * port bitfield distribution
      
      * port over bitfield distribution tests
      
      * add codec indices
      
      * port PoV distribution
      
      * port over PoV distribution tests
      
      * port over statement distribution
      
      * port over statement distribution tests
      
      * update overseer and service-new
      
      * address review comments
      
      * port availability distribution
      
      * port over availability distribution tests
      1e9c0540
    • Dan Forbes's avatar
      Augment Implementer's Guide XCMP docs (#1569) · fb831768
      Dan Forbes authored
      
      
      * Augment Implementer's Guide XCMP docs
      
      * Remove the note about the third category
      
      * Make Cross-Chain Message Passing a h3
      
      Co-authored-by: default avatarSergei Shulepov <[email protected]>
      fb831768
  11. Aug 11, 2020
    • Bastian Köcher's avatar
      Support `build-spec` for other chains than Polkadot (#1567) · 78c8a646
      Bastian Köcher authored
      
      
      * Support `build-spec` for other chains than Polkadot
      
      The problem when building a chain specification is that you require the
      native runtime to parse the json file (assuming the chain spec is not
      raw yet). Before this pr we could only overwrite the native runtime when
      running the node using `force_*`. This pr now adds support to load the
      native runtime when the filename starts with the name of the chain. So,
      when usng `build-spec --chain rococo-something-else.jon` it will use the
      rococo native runtime to load the chain spec.
      
      * Apply suggestions from code review
      
      Co-authored-by: default avatarAndronik Ordian <[email protected]>
      
      Co-authored-by: default avatarAndronik Ordian <[email protected]>
      78c8a646
  12. Aug 10, 2020
  13. Aug 07, 2020