- Jul 07, 2020
-
-
asynchronous rob authored* rename implementor's guide to implementer's guide * fix typos in more places
-
- Jul 06, 2020
-
-
asynchronous rob authored
* set up data types and control flow for statement distribution * add some set-like methods to View * implement sending to peers * start fixing equivocation handling * Add a section to the statement distribution subsystem on equivocations and flood protection * fix typo and amend wording * implement flood protection * have peer knowledge tracker follow when peer first learns about a candidate * send dependents after circulating * add another TODO * trigger send in one more place * refactors from review * send new statements to candidate backing * instantiate active head data with runtime API values * track our view changes and peer view changes * apply a benefit to peers who send us statements we want * remove unneeded TODO * add some comments and improve Hash implementation * start tests and fix `note_statement` * test active_head seconding logic * test that the per-peer tracking logic works * test per-peer knowledge tracker * test that peer view updates lead to messages being sent * test statement circulation * address review comments * have view set methods return references
-
- Jul 05, 2020
-
-
Peter Goodspeed-Niklaus authored
* network bridge skeleton * move some primitives around and add debug impls * protocol registration glue & abstract network interface * add send_msgs to subsystemctx * select logic * transform different events into actions and handle * implement remaining network bridge state machine * start test skeleton * make network methods asynchronous * extract subsystem out to subsystem crate * port over overseer to subsystem context trait * fix minimal example * fix overseer doc test * update network-bridge crate * write a subsystem test-helpers crate * write a network test helper for network-bridge * set up (broken) view test * Revamp network to be more async-friendly and not require Sync * fix spacing * fix test compilation * insert side-channel for actions * Add some more message types to AllMessages * introduce a test harness * impl ProvideInherent for InclusionInherent * reduce import churn; correct expect message * move inclusion inherent identifier into primitives It's not clear precisely why this is desired, but it's a pattern I've seen in several places, so I'm going this to be on the safe side. Worst case, we can revert this commit pretty easily. * bump kusama spec_version to placate CI * copy sc_basic_authorship::{ProposerFactory, Proposer} We have from the problem description: > This Proposer will require an OverseerHandle to make requests via. That's next on the plate. * use polkadot custom proposer instead of basic-authorship one * add some tests * ensure service compiles and passes tests * fix typo * fix service-new compilation * Subsystem test helpers send messages synchronously * remove smelly action inspector * remove superfluous let binding * fix warnings * add license header * empty commit; maybe github will notice the one with changes * Update node/network/bridge/src/lib.rs Co-authored-by:Peter Goodspeed-Niklaus <[email protected]> * add sanity check to only include valid inherents * stub: encapsulate block production mechanics instead of copying them The goal is to end up with something like what's in validation::block_production::*, which encapsulates basic block production mechanics. This is a better idea than just straight-up copying those mechanics. * partial implementation of propose fn Doesn't actually compile yet; need to bring in some other commits to ensure ProvisionerMessage is a thing, and also figure out how to get the block hash given the current context. * fix compilation * clear a few more compile errors * finish fn propose * broken: add timeout to proposal * add timeout to proposal * guide: provisioner is responsible for selecting parachain candidates * implement ProvisionerMessage::RequestInherentData & update fn propose * impl CreateProposer::init; clean up * impl std::error::Error for Error * document error-handling rationale * cause polkadot-service-new to compile correctly * Move potentially-blocking call from fn init -> fn propose This means that we can wrap the delayed call into the same timeout check used elsewhere. * document struct Proposer * extract provisioner data fetch This satisfies two requirements: - only applies the timeout to actually fetching the provisioner data, not to constructing the block after - simplifies the problem of injecting default data if we could not get the real provisioner data in time. Co-authored-by:
Robert Habermeier <[email protected]> Co-authored-by:
Gavin Wood <[email protected]>
-
- Jun 24, 2020
-
-
Sergey Pepyakin authored
* Experiment with graphwiz * Convert parachain overview diagrams * add install note for mdbook-graphviz Co-authored-by:
-
- Jun 22, 2020
-
-
asynchronous rob authored
* rejig candidate types a bit * adjust doc * describe basic PoV distribution * replace some straggling html links * address grumbles from review and fix links
-
- Jun 20, 2020
-
-
Peter Goodspeed-Niklaus authored
* add signed wrapper, typedef SignedStatement * typedef SignedAvailabilityBitfield * implement Signed wrapper This is strictly an addition as of this commit; nothing is yet changed in existing behavior. * inline getters, remove review comment * move EncodeAs, Signed from node::primitives to primitives::parachain * Refactor SignedAvailabilityBitfield to use Signed * don't double-encode real payload This isn't an ideal solution, because it depends on the implementation details of how SCALE encodes tuples, but OTOH that behavior seems unlikely to change anytime soon. * fix build errors * cause the runtime to build properly with the new changes Not sure why cargo check didn't catch this earlier; oh well. * fix runtime tests and separate SignedStatement from SignedFullStatement * better explain why CompactStatement exists Co-authored-by:
-
Sergey Pepyakin authored
* Add mdbook-linkcheck * Convert todo to not a link * Fix external glossary link * Fix various broken links * Mass replace: s/.html/.md/ * My sloppy attempt to add a gitlab CI check
-
- Jun 18, 2020
-
-
asynchronous rob authored
* add availability bitfield types to primitives * begin inclusion module * use GitHub issue link for limitation * fix some compiler errors * integrate validators into initializer * add generic signing context * make signing-context more generic * fix issues with inclusion module * add TODO * guide: add validators and session index to inclusion * guide: add session index to change notification * implement session change logic * add BackedCandidate type * guide: refine inclusion pipeline * guide: rename group_on to group_validators * guide: add check about collator for parathread * guide: add last_code_upgrade to paras and use in inclusion * implement Paras::last_code_upgrade * implement most checks in process_candidates * make candidate receipt structs more generic * make BackedCandidate struct more generic * use hash param, not block number * check that candidate is in context of the parent block * include inclusion module in initializer * implement enact-candidate * check that only occupied cores have bits set * finish implementing bitfield processing * restructure consistency checks on candidates * make some more primitives generic * signature checking logic for backed candidates * finish implementing process_candidates * implement collect_pending * add some trait implementations to primitives * implement InclusionInherent and squash warnings * test bitfield signing checks * rename parachain head to para_head * fix note_new_head bug in paras * test bitfield enactment in inclusion * helpers for candidate checks * add test for most candidate checks * add test for backing setting storage * test session change logic * remove extraneous type parameter * remove some allow(unused)s * extract threshold computation to const fn * remove some more allow(unused)s * improve doc * add debug assertion * fix primitive test compilation * tag unanimous variant as unused
-
Fedor Sakharov authored
* Router module initial commit * Add the router.md itself * Enqueue only on enact_candidate * Initialization concerns * Ignore the snippet * Update roadmap/implementors-guide/src/runtime/router.md Co-authored-by:
-
- Jun 17, 2020
-
-
asynchronous rob authored
* introduce polkadot-node-primitives * guide: change statement distribution message types * guide: remove variant from `CandidateSelectionMessage` * add a few more message types * add TODOs * Almost all messages * NewBackedCandidate notification * Formatting * Use AttestedCandidate as BackedCandidate * Update node/primitives/src/lib.rs Co-authored-by:
Fedor Sakharov <[email protected]> Co-authored-by:
-
asynchronous rob authored
* types chapter & candidate types * Factor out some message types * backing and availability types. * spacing * finish thought * info on signed payloads * update links * explicit wrapper types * add remaining message types * add runtime API subsystem * adjust language * tweak candidate validation message * find homes for some misfit types * embed abridged within full candidate receipt * Update roadmap/implementors-guide/src/SUMMARY.md Co-authored-by:
-
Peter Goodspeed-Niklaus authored
* first pass updating candidate validation module in the guide * expand candidate validation functionality section * add candidate fetch; validation requires PoV to be provided * remove candidate fetch
-
- Jun 16, 2020
-
-
Peter Goodspeed-Niklaus authored
* small tweaks to candidate selection * clarify the nature of inputs
-
Fabio Lama authored
* adjust to relative links * additional adjustment to relative link * link directly to file * link directly to file
-
- Jun 15, 2020
-
-
Peter Goodspeed-Niklaus authored
* update provisioner subsystem Closes #1143 * update with answers to the questions posed by previous todos * add misbehavior reports, disputes to provisioner messages * expand on the protocol * updates per code review
-
- Jun 11, 2020
-
-
asynchronous rob authored
* scheduler module skeleton * update scheduler skeleton to match latest version of guide * better session change notification * add mock randomness and fix test compilation * shuffle validators into groups * finish implementing session change logic for scheduler * tweak core assignment type to track retries of parathread * reframe queued parathread core as offset * implement initialzation and finalization routines * implement parathread claim queuing * implement core_para * implement the group_validators routine and fix errors * add a reason for freeing cores * implement `schedule` function * add some docs to the scheduled function * implement `occupied` helper * implement availability predicate * fix some warnings * integrate scheduler into initializer * integrate scheduler into mock module * avoid conflict with Substrate's scheduler storage * add parathreads index to paras module * implement parathreads map in paras module * add is_parathread to paras * test adding parathread claim * test that you cannot add claims when no parathread cores exist * check session change parathread queue pruning * test validator shuffling * add allow_unused to scheduler items * add test for scheduling * add some more tests for scheduling logic * test core rotation * check parathread claim pruning after retries * add bound notes * Apply suggestions from code review Co-authored-by:
Bernhard Schuster <[email protected]> * more suggestions from review * test availability predicate, add box to please compiler * add changes to guide Co-authored-by:
-
Peter Goodspeed-Niklaus authored
* move old implementers' guide, add skeleton of new * Split the old implementers' guide into the new one's sections This is mostly a straightforward copying operation, moving the appropriate sections from the old guide to the new. However, there are certain differences between the old text and the new: - removed horizontal rules between the sections - promoted headers appropriately within each section - deleted certain sections which were in the old guide's ToC but which were not actually present in the old guide. - added Peer Set Manager to the new ToC * remove description headers It is redundant and unnecessary. Descriptions fall directly under the top-level header for any given section. * add stub description of the backing module * add stub description for the availability module * add stub description for collators * add stub description for validity * add stub description for utility * highlight TODO and REVIEW comments * add guide readme describing how to use mdbook * fix markdownlint lints * re-title parachains overview * internal linking for types * module and subsystem internal links * .gitignore should have a trailing newline * node does not have modules, just subsystems
-
- Jun 10, 2020
-
-
asynchronous rob authored
* define subsystems skeleton * Create a blank section for each subsystem in the initial batch * write out basics for most subsystems * define network bridge subsystem * integrate network bridge into network systems * Apply suggestions from code review some nits Co-authored-by:
Max Inden <[email protected]> * clean up wording Co-authored-by:
-
asynchronous rob authored
* define subsystems skeleton * Create a blank section for each subsystem in the initial batch * write out basics for most subsystems * Update roadmap/implementors-guide/guide.md clean up language Co-authored-by:
-
Peter Goodspeed-Niklaus authored
* expand subsystems descriptions independent of subsystems overview The subsystems overview in https://github.com/paritytech/polkadot/pull/1161 is a very useful reference for what subsystems need to talk to each other, when, and why; it helps us design the actual messages. However, administratively, it belongs in a different PR. This commit brings in all the changes made there so far as a base for an independent PR. * Reorder subsystem descriptions, add some messages Update ordering of subsystem descriptions to rough order of use, mirroring the order in the overview document. Added some message types. Added OverseerSignal variants to several types, such that each subsystem only needs to listen for a single type. * add some more message types, Statement Distribution overview * add more detail on Statement Distribution, Misbehavior Arbitration * intentionally punt MA details for a future PR * reduce duplication from overseer signal handling * reword for clarity * clarify: other modules and subsystems also get to talk to the network * finish current work on candidate selection * update candidate backing subsystem description according to current thought * update mechanism for candidate backing to report collator misbehavior to candidate selection * sketch out the peer receipt state machine * Fix typo in roadmap/implementors-guide/guide.md Co-authored-by:
-
- Jun 05, 2020
-
-
asynchronous rob authored
* clarify exception to communication rule for responses * add note about outside world * write up my understanding of local and remote disputes * clean up secondary checker language * amend to match Jeff's notes
-
- Jun 04, 2020
-
-
Peter Goodspeed-Niklaus authored
* migrate subsystem expansion PR from w3f/research As the file at this new location included changes not present in https://github.com/w3f/research/pull/87, this is effectively a rebase, applied manually. I believe that I have successfully retained all of, and only, the intended changes. * add section on collators * note why the overseer is the terminal message point for the validation subsystem * add detail about how the validitiy system gets PoV blocks * rename to Validity Subsystems Overview * get rid of changes to the implementor's guide I think it makes most sense to track and review the subsystems overview in a different PR than the one which adds content to the implementor's guide. * punt misbehavior arbitration details to the future * empty commit to rerun CI
-
- Jun 02, 2020
-
-
asynchronous rob authored
* note pruning of orphan blocks in the overseer description * remove note about finalization events being maybe not needed
-
asynchronous rob authored
* file structure and initializer skeleton * ensure session changes happen before initialization * add a couple tests for initializer flow * integrate with session handling * configuration update logic * configuration methods * move test mock to its own module * integrate configuration into initializer * add note about initialization order * integrate configuration module into mock * add some tests for config module * paras module storage * implement paras session change operation * amend past code pruning to fully cover acceptance period * update guide again * do pruning of historical validation code * add weight to initialization * integrate into mock & leave notes for next session * clean up un-ended sentence * alter test to account for double index in past code meta * port over code-at logic test * clarify checking for conflicting code upgrades * add genesis for paras, include in mock, ensure incoming paras are processed * note on return value of `validation_code_at` * implement paras routines from implementor's guide * bring over some existing tests and begin porting * port over code upgrade tests * test parachain registration * test code_at with intermediate block * fix warnings * clean up docs and extract to separate struct * adjust implementor's guide to include replacementtimes * kill stray println * rename expected_at to applied_after * rewrite ParaPastCodeMeta to avoid reversal * clarify and test interface of validation_code_at * make FutureCode optional * rename do_old_code_pruning * add comment on Option<()> to answer FAQ * address some more grumbles
-
- Jun 01, 2020
-
-
asynchronous rob authored
* remove old runtime requirements section * reorganize guide and improve ToC
-
- May 29, 2020
-
-
asynchronous rob authored
* remove redundant resize instruction from guide * amend past code pruning to fully cover acceptance period * update guide again * note on return value of `validation_code_at` * rename execution cores to availability cores * clarify terminology * add ReplacementTimes to the guide * fully decouple inclusion and scheduler * clarify parathread scheduling substantially * clarify validator group selection
-
- May 28, 2020
-
-
asynchronous rob authored
-
- May 25, 2020
-
-
asynchronous rob authored
* include implementor's guide in this repo * most updated guide
-
- Apr 02, 2020
-
-
asynchronous rob authored
* add dummy parachains.toml * flesh out parachains.toml * finish phase-1 rendering * render to svg instead * put graphviz svg through sanitizer so github can render * return to PNG
-
- Jan 14, 2020
-
-
asynchronous rob authored
* rough draft of parachains roadmap * flesh out first 2 phases * Fix typo Co-Authored-By:
Bastian Köcher <[email protected]> * Fix typos and add clarifications Co-Authored-By:
-
