1. Aug 19, 2020
  2. Aug 18, 2020
    • ordian's avatar
      Merge branch 'master' into ao-job-manager-dont-bring-down-subsystem-on-race-condition · 473587a5
      ordian authored
      * master:
        initial prometheus metrics (#1536)
        Companion for Substrate 6868 (WeightInfo for System, Utility, and Timestamp) (#1606)
        Promote `HrmpChannelId` and supply more docs (#1595)
        move AssignmentKind and CoreAssigment to scheduler (#1571)
        overseer: fix build (#1596)
      473587a5
    • ordian's avatar
      initial prometheus metrics (#1536) · 804958ab
      ordian authored
      * service-new: cosmetic changes
      
      * overseer: draft of prometheus metrics
      
      * metrics: update active_leaves metrics
      
      * metrics: extract into functions
      
      * metrics: resolve XXX
      
      * metrics: it's ugly, but it works
      
      * Bump Substrate
      
      * metrics: move a bunch of code around
      
      * Bumb substrate again
      
      * metrics: fix a warning
      
      * fix a warning in runtime
      
      * metrics: statements signed
      
      * metrics: statements impl RegisterMetrics
      
      * metrics: refactor Metrics trait
      
      * metrics: add Metrics assoc type to JobTrait
      
      * metrics: move Metrics trait to util
      
      * metrics: fix overseer
      
      * metrics: fix backing
      
      * metrics: fix candidate validation
      
      * metrics: derive Default
      
      * metrics: docs
      
      * metrics: add stubs for other subsystems
      
      * metrics: add more stubs and fix compilation
      
      * metrics: fix doctest
      
      * metrics: move to subsystem
      
      * metrics: fix candidate validation
      
      * metrics: bitfield signing
      
      * metrics: av store
      
      * metrics: chain API
      
      * metrics: runtime API
      
      * metrics: stub for avad
      
      * metrics: candidates seconded
      
      * metrics: ok I gave up
      
      * metrics: provisioner
      
      * metrics: remove a clone by requiring Metrics: Sync
      
      * metrics: YAGNI
      
      * metrics: remove another TODO
      
      * metrics: for later
      
      * metrics: add parachain_ prefix
      
      * metrics: s/signed_statement/signed_statements
      
      * utils: add a comment for job metrics
      
      * metrics: address review comments
      
      * metrics: oops
      
      * metrics: make sure to save files before commit 😅
      
      
      
      * use _total suffix for requests metrics
      
      Co-authored-by: default avatarMax Inden <[email protected]>
      
      * metrics: add tests for overseer
      
      * update Cargo.lock
      
      * overseer: add a test for CollationGeneration
      
      * collation-generation: impl metrics
      
      * collation-generation: use kebab-case for name
      
      * collation-generation: add a constructor
      
      Co-authored-by: default avatarGav Wood <[email protected]>
      Co-authored-by: default avatarAshley Ruglys <[email protected]>
      Co-authored-by: default avatarMax Inden <[email protected]>
      804958ab
    • Shawn Tabrizi's avatar
      Companion for Substrate 6868 (WeightInfo for System, Utility, and Timestamp) (#1606) · 62b9d4a5
      Shawn Tabrizi authored
      * fix compile warning
      
      * remove tests for weights
      
      * add custom weights
      
      * "Update Substrate"
      
      Co-authored-by: parity-processbot <>
      62b9d4a5
  3. Aug 17, 2020
    • Sergey Pepyakin's avatar
    • ordian's avatar
      a91b117c
    • ordian's avatar
      overseer: fix build (#1596) · c61d9076
      ordian authored
      * overseer: add a test for CollationGeneration
      
      * fix build
      c61d9076
    • ordian's avatar
      update Cargo.lock · ccd8f788
      ordian authored
      ccd8f788
    • ordian's avatar
      Merge branch 'master' into ao-job-manager-dont-bring-down-subsystem-on-race-condition · 91f1024c
      ordian authored
      * master:
        Companion PR for #6862 (#1564)
        implement collation generation subsystem (#1557)
        Add spawn_blocking to SubsystemContext (#1570)
        Companion PR for #6846 (#1568)
        overseer: add a test to ensure all subsystem receive msgs (#1590)
        Implementer's Guide: Flesh out more details for upward messages (#1556)
        Make parachain validation wasm executor functional (#1574)
        Use async test helper to simplify node testing (#1578)
        guide: validation data refactoring (#1576)
        Remove v0 parachains runtime (#1501)
        [CI] Add github token to generate-release-text (#1581)
        Allow using any polkadot client instead of enum Client (#1575)
        service/src/lib: Update authority discovery construction (#1563)
      91f1024c
    • Wei Tang's avatar
      Companion PR for #6862 (#1564) · c435c187
      Wei Tang authored
      
      
      * Companion PR for #6862
      
      * Check in Cargo.lock for CI
      
      * "Update Substrate"
      
      * update substrate
      
      Co-authored-by: parity-processbot <>
      Co-authored-by: default avatarAndré Silva <[email protected]>
      c435c187
    • Peter Goodspeed-Niklaus's avatar
      implement collation generation subsystem (#1557) · e750a825
      Peter Goodspeed-Niklaus authored
      * start sketching out a collation generation subsystem
      
      * invent a basic strategy for double initialization
      
      * clean up warnings
      
      * impl util requests from runtime assuming a context instead of a FromJob sender
      
      * implement collation generation algorithm from guide
      
      * update AllMessages in tests
      
      * fix trivial review comments
      
      * remove another redundant declaration from merge
      
      * filter availability cores by para_id
      
      * handle new activations each in their own async task
      
      * update guide according to the actual current implementation
      
      * add initialization to guide
      
      * add general-purpose subsystem_test_harness helper
      
      * write first handle_new_activations test
      
      * add test that handle_new_activations filters local_validation_data requests
      
      * add (failing) test of collation distribution message sending
      
      * rustfmt
      
      * broken: work on fixing sender test
      
      Unfortunately, for reasons that are not yet clear, despite the public key
      and checked data being identical, the signer is not producing an identical
      signature. This commit produces this output (among more):
      
      signing with  Public(c4733ab0bbe3ba4c096685d1737a7f498cdbdd167a767d04a21dc7df12b8c858 (5GWHUNm5...))
      checking with Public(c4733ab0bbe3ba4c096685d1737a7f498cdbdd167a767d04a21dc7df12b8c858 (5GWHUNm5...))
      signed payload:  [4, 4, 4, 4, 4, 4, 4, 4, 4, 4, 4, 4, 4, 4, 4, 4, 4, 4, 4, 4, 4, 4, 4, 4, 4, 4, 4, 4, 4, 4, 4, 4, 10, 0, 0, 0, c7, e5, c0, 64, 7a, db, fe, 44, 81, e5, 51, 11, 79, 9f, a5, 63, 93, 94, 3c, c4, 36, c6, 30, 36, c2, c5, 44, a2, 1b, db, b7, 82, 3, 17, a, 2e, 75, 97, b7, b7, e3, d8, 4c, 5, 39, 1d, 13, 9a, 62, b1, 57, e7, 87, 86, d8, c0, 82, f2, 9d, cf, 4c, 11, 13, 14]
      checked payload: [4, 4, 4, 4, 4, 4, 4, 4, 4, 4, 4, 4, 4, 4, 4, 4, 4, 4, 4, 4, 4, 4, 4, 4, 4, 4, 4, 4, 4, 4, 4, 4, 10, 0, 0, 0, c7, e5, c0, 64, 7a, db, fe, 44, 81, e5, 51, 11, 79, 9f, a5, 63, 93, 94, 3c, c4, 36, c6, 30, 36, c2, c5, 44, a2, 1b, db, b7, 82, 3, 17, a, 2e, 75, 97, b7, b7, e3, d8, 4c, 5, 39, 1d, 13, 9a, 62, b1, 57, e7, 87, 86, d8, c0, 82, f2, 9d, cf, 4c, 11, 13, 14]
      
      * fix broken test
      
      * collation function returns commitments hash
      
      It doesn't look like we use the actual commitments data anywhere, and
      it's not obvious if there are any fields of `CandidateCommitments`
      not available to the collator, so this commit just assigns them the
      entire responsibility of generating the hash.
      
      * add missing overseer impls
      
      * calculating erasure coding is polkadot's responsibility, not cumulus
      
      * concurrentize per-relay_parent requests
      e750a825
    • ordian's avatar
      Add spawn_blocking to SubsystemContext (#1570) · 474b72a5
      ordian authored
      * subsystem: add spawn_blocking to SubsystemContext
      
      * candidate-validation: use spawn_blocking for exhaustive tasks
      474b72a5
  4. Aug 15, 2020
  5. Aug 14, 2020
  6. Aug 13, 2020
  7. Aug 12, 2020
    • Max Inden's avatar
      service/src/lib: Update authority discovery construction (#1563) · f73f2a86
      Max Inden authored
      * service/src/lib: Update authority discovery construction
      
      https://github.com/paritytech/substrate/pull/6760 introduces the concept
      of an authority discovery `Service` allowing one to communicate with an
      authority discovery `Worker`, e.g. to learn the `Multiaddr`s for a given
      `AuthorityId`.
      
      Along with the new `Service` structure it also alters the authority
      discovery constructor to return both a worker and a service. This
      commit adjusts the callside of the constructor, ignoring the `Service`
      for now.
      
      * "Update Substrate"
      
      * Revert ""Update Substrate""
      
      This reverts commit 04fb79c4.
      
      * Update Substrate
      
      Co-authored-by: parity-processbot <>
      f73f2a86
    • Sergey Pepyakin's avatar
      Update .editorconfig to what we have in practice (#1545) · c78c2b46
      Sergey Pepyakin authored
      While editing the impl guide markdowns I tried to be inline with what seemingly more
      common way to indent them: spaces. However, despite that I changed it kept reseting.
      Turned out the culprit is the .editorconfig file.
      
      This commit addresses this issue. I didn't try to deduplicate the rules since
      I found that the formal specification is a bit ambigious and it is not a big
      deal anyway.
      c78c2b46
    • mattrutherford's avatar
      Companion PR for substrate #6672 (#1560) · 48678513
      mattrutherford authored
      
      
      * update Cargo.lock
      
      * "Update Substrate"
      
      Co-authored-by: default avatarMatt Rutherford <[email protected]>
      Co-authored-by: parity-processbot <>
      48678513
    • Federico Gimenez's avatar
      305355d5
    • asynchronous rob's avatar
      Network bridge refactoring impl (#1537) · 1e9c0540
      asynchronous rob authored
      * update networking types
      
      * port over overseer-protocol message types
      
      * Add the collation protocol to network bridge
      
      * message sending
      
      * stub for ConnectToValidators
      
      * add some helper traits and methods to protocol types
      
      * add collator protocol message
      
      * leaves-updating
      
      * peer connection and disconnection
      
      * add utilities for dispatching multiple events
      
      * implement message handling
      
      * add an observedrole enum with equality and no sentry nodes
      
      * derive partial-eq on network bridge event
      
      * add PartialEq impls for network message types
      
      * add Into implementation for observedrole
      
      * port over existing network bridge tests
      
      * add some more tests
      
      * port bitfield distribution
      
      * port over bitfield distribution tests
      
      * add codec indices
      
      * port PoV distribution
      
      * port over PoV distribution tests
      
      * port over statement distribution
      
      * port over statement distribution tests
      
      * update overseer and service-new
      
      * address review comments
      
      * port availability distribution
      
      * port over availability distribution tests
      1e9c0540
    • Dan Forbes's avatar
      Augment Implementer's Guide XCMP docs (#1569) · fb831768
      Dan Forbes authored
      
      
      * Augment Implementer's Guide XCMP docs
      
      * Remove the note about the third category
      
      * Make Cross-Chain Message Passing a h3
      
      Co-authored-by: default avatarSergei Shulepov <[email protected]>
      fb831768
  8. Aug 11, 2020
    • Bastian Köcher's avatar
      Support `build-spec` for other chains than Polkadot (#1567) · 78c8a646
      Bastian Köcher authored
      
      
      * Support `build-spec` for other chains than Polkadot
      
      The problem when building a chain specification is that you require the
      native runtime to parse the json file (assuming the chain spec is not
      raw yet). Before this pr we could only overwrite the native runtime when
      running the node using `force_*`. This pr now adds support to load the
      native runtime when the filename starts with the name of the chain. So,
      when usng `build-spec --chain rococo-something-else.jon` it will use the
      rococo native runtime to load the chain spec.
      
      * Apply suggestions from code review
      
      Co-authored-by: default avatarAndronik Ordian <[email protected]>
      
      Co-authored-by: default avatarAndronik Ordian <[email protected]>
      78c8a646
  9. Aug 10, 2020
  10. Aug 07, 2020
  11. Aug 06, 2020
    • Peter Goodspeed-Niklaus's avatar
      implement provisioner (#1473) · a39d8803
      Peter Goodspeed-Niklaus authored
      * sketch out provisioner basics
      
      * handle provisionable data
      
      * stub out select_inherent_data
      
      * split runtime APIs into sub-chapters to improve linkability
      
      * explain SignedAvailabilityBitfield semantics
      
      * add internal link to further documentation
      
      * some more work figuring out how the provisioner can do its thing
      
      * fix broken link
      
      * don't import enum variants where it's one layer deep
      
      * make request_availability_cores a free fn in util
      
      * document more precisely what should happen on block production
      
      * finish first-draft implementation of provisioner
      
      * start working on the full and proper backed candidate selection rule
      
      * Pass number of block under construction via RequestInherentData
      
      * Revert "Pass number of block under construction via RequestInherentData"
      
      This reverts commit 850fe62c.
      
      That initially looked like the better approach--it spent the time
      budget for fetching the block number in the proposer, instead of
      the provisioner, and that felt more appropriate--but it turns out
      not to be obvious how to get the block number of the block under
      construction from within the proposer. The Chain API may be less
      ideal, but it should be easier to implement.
      
      * wip: get the block under production from the Chain API
      
      * add ChainApiMessage to AllMessages
      
      * don't break the run loop if a provisionable data channel closes
      
      * clone only those backed candidates which are coherent
      
      * propagate chain_api subsystem through various locations
      
      * add delegated_subsystem! macro to ease delegating subsystems
      
      Unfortunately, it doesn't work right:
      
      ```
      error[E0446]: private type `CandidateBackingJob` in public interface
         --> node/core/backing/src/lib.rs:775:1
          |
      86  | struct CandidateBackingJob {
          | - `CandidateBackingJob` declared as private
      ...
      775 | delegated_subsystem!(CandidateBackingJob as CandidateBackingSubsystem);
          | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ can't leak private type
      ```
      
      I'm not sure precisely what's going wrong, here; I suspect the problem is
      the use of `$job as JobTrait>::RunArgs` and `::ToJob`; the failure would be
      that it's not reifying the types to verify that the actual types are public,
      but instead referring to them via `CandidateBackingJob`, which is in fact private;
      that privacy is the point.
      
      Going to see if I can generic my way out of this, but we may be headed for a
      quick revert here.
      
      * fix delegated_subsystem
      
      The invocation is a bit more verbose than I'd prefer, but it's also
      more explicit about what types need to be public. I'll take it as a win.
      
      * add provisioning subsystem; reduce public interface of provisioner
      
      * deny missing docs in provisioner
      
      * refactor core selection per code review suggestion
      
      This is twice as much code when measured by line, but IMO it is
      in fact somewhat clearer to read, so overall a win.
      
      Also adds an improved rule for selecting availability bitfields,
      which (unlike the previous implementation) guarantees that the
      appropriate postconditions hold there.
      
      * fix bad merge double-declaration
      
      * update guide with (hopefully) complete provisioner candidate selection procedure
      
      * clarify candidate selection algorithm
      
      * Revert "clarify candidate selection algorithm"
      
      This reverts commit c68a02ac.
      
      * clarify candidate selection algorithm
      
      * update provisioner to implement candidate selection per the guide
      
      * add test that no more than one bitfield is selected per validator
      
      * add test that each selected bitfield corresponds to an occupied core
      
      * add test that more set bits win conflicts
      
      * add macro for specializing runtime requests; specailize all runtime requests
      
      * add tests harness for select_candidates tests
      
      * add first real select_candidates test, fix test_harness
      
      * add mock overseer and test that success is possible
      
      * add test that the candidate selection algorithm picks the right ones
      
      * make candidate selection test somewhat more stringent
      a39d8803
    • Sergey Pepyakin's avatar
      Implementer's guide: downward messages and HRMP, take 2 (#1503) · 864fff12
      Sergey Pepyakin authored
      
      
      * First stab at downward messages.
      
      That also includes a notion of horizontal messages.
      
      * Add some structure to the router.
      
      * Update `ValidationOutputs`
      
      * Add `processed_downward_messages` to `ValidationOutputs`.
      
      Forgot to check that in.
      
      * s/AccountId/ParaId
      
      * DownwardMessage::ParachainSpecfic
      
      * s/ensure_horizontal_messages_fits/ensure_horizontal_messages_fit
      
      * Clarify that Router called for each candidate
      
      * Update the preamble for Router.
      
      * Rewrite the relay-chain extrinsic routines
      
      * Update gloassary
      
      * Add DMP to the glossary
      
      * If the queue is empty, `processed_downward_messages` can be 0
      
      * WIP
      
      * Add condemned list
      
      * Pivot to message-storing channel based HRMP
      
      * Finished draft
      
      * Tidy up
      
      * Remove a duplicate glossary entry
      
      * Fix typo
      
      * Fix wording to emphasize that the channel is unidirectional
      
      * Proper decrement `HrmpOpenChannelRequestCount`
      
      * Add a comment for `HrmpOpenChannelRequestCount`.
      
      * Remove old configuration values.
      
      * Be more specific about the para{chain,thread} hrmp chan limits.
      
      * Fix indentation so the lists are rendendered properly
      
      * "to answer **the**" question instead of "a"
      
      * Add a missing call to `check_processed_downward_messages`
      
      * Clean more stuff during offboarding
      
      * Fix typo
      
      * Fix typo for the config
      
      * Add a call to `prune_dmq`
      
      * Add explicit invariants for ingress/egress indexes
      
      * Add comments for the sender/reciever deposit config fields
      
      * Document various fields and structs in Router module
      
      * More docs
      
      * Missing docs in Candidate.md
      
      * Tabs to spaces in router.md
      
      * Apply Rob's suggestion
      
      * Add the hrmp_ prefix to the router messages
      
      * Those are entry points
      
      * Use SessionIndex type for the `age` field
      
      * Use a struct to represent `HrmpChannelId`
      
      * Put only MQCs into the LocalValidationData
      
      * Close request can be initiated by the runtime directly
      
      * Close request can be initiated by the runtime directly
      
      * tabs/spaces
      
      * Maintain the list of the outgoing paras in Router
      
      * Update roadmap/implementers-guide/src/runtime/inclusion.md
      
      Co-authored-by: default avatarRobert Habermeier <[email protected]>
      
      * fix typo
      
      * Remove an unnecessary pair of code quotes
      
      Co-authored-by: default avatarRobert Habermeier <[email protected]>
      864fff12