- May 15, 2020
-
-
Benjamin Kampmann authored
-
- May 12, 2020
-
-
Pierre Krieger authored
* Allow passing multiple --log CLI options * Comment typo
-
- May 06, 2020
-
-
Igor Matuszewski authored
* client: Replace `unsafe_rpc_expose` with an `RpcMethods` enum which can be either Default, Safe or Unsafe. The idea is to have the following: | | --rpc-external=false | --rpc-external=true | |--------------------- |------------------- |----------------- | | --rpc-methods=Default | | unsafe calls denied | | --rpc-methods=Safe | unsafe calls denied | unsafe calls denied | | --rpc-methods=Unsafe | | | Since the previous `unsafe-rpc-expose` option was confusing. * client: Only warn against exposing externally unsafe RPC method set * Apply suggestions from code review Co-Authored-By: Cecile Tonglet <[email protected]> * cli: Rephrase doc comment for rpc_methods config * Improve debuggability of build_spec_works ...by printing to stderr the stderr of the command. This is normally suppressed for succesful tests but not for failing ones - if that's the case then it's useful to see the test failure reason inline rather than having to execute the command separately ourselves. * Rename RpcMethods::{Default => Auto} variant * Update bin/node/cli/tests/build_spec_works.rs Co-authored-by: Benjamin Kampmann <[email protected]> Co-authored-by: Cecile Tonglet <[email protected]> Co-authored-by: Bastian Köcher <[email protected]>
-
- Apr 30, 2020
-
-
Bastian Köcher authored
* Export state cli * More work * Fix tests * Make it work * Fix compilation * Apply suggestions from code review
-
Arkadiy Paronyan authored
* purge-chain accepts --db option * print DB info on startup * Small refactoring * Added back &self * Add DatabaseParams for PurgeChain, ImportParams and ExportBlocks * Don't force default value * Remove unused fields * Update client/cli/src/commands/export_blocks_cmd.rs * Fix stuff Co-authored-by: Cecile Tonglet <[email protected]> Co-authored-by: Bastian Köcher <[email protected]>
-
- Apr 28, 2020
-
-
Web3 Philosopher authored
* Drop client from sc-network and sc-client-db, move LongestChain to sc-client-api * move leaves, cht, in_mem to sc-client-api, drop client from sc-finality-grandpa * drop sc-service from sc-rpc * drop sc-service from sc-consensus-aura * drop sc-client from manual-seal and babe * drop sc-client from utils/frame/rpc/system and utils/frame/benchmarking-cli * drop sc-client from bin/node and bin/node-template * drop sc-client * fix tests * remove check -p sc-client from gitlab.yml * fix warnings * fixes ui test * fix light client tests * adds associated Client type to AbstractService * adds UsageProvider to Client * fixed ui test, again * tried and failed to get node-cli to compile for wasm * thanks to tomaka for helping me get node-cli to compile for wasmm * ui test pls pas
🙏🏾 * all tests passing 🪄 * no_run documentation code * rm -f documentation code * ClientProvider * fix mega trait * move LongestChain to sc-consensus, use adds minimal bounds to AbstractService::Client * adds license to sc-consensus Co-authored-by: Benjamin Kampmann <[email protected]>
-
- Apr 27, 2020
-
-
André Silva authored
-
- Apr 24, 2020
-
-
Bernhard Schuster authored
Co-Authored-By: Kian Paimani <[email protected]> Co-Authored-By: Tomasz Drwięga <[email protected]>
-
- Apr 20, 2020
-
-
Igor Matuszewski authored
* sc-cli: Use type-safe constructors for RPC/Prometheus interfaces * service: Simplify rpc handler creation Could probably be further simplifies once [this][commit] lands. [commit]: https://github.com/paritytech/jsonrpc/commit/20485387ed06a48f1a70bf4d609a7cde6cf0accf * service: Streamline some HTTP & WS server start logic * client: Introduce a simple RPC policy mechanism * rpc/system: Check unsafe RPCs * rpc/offchain: Check unsafe RPCs * rpc/author: Check unsafe RPCs
-
- Apr 17, 2020
-
-
Ashley authored
* Make network_config_path an Option * Fix network tests * Use None as the network config path * Fix cli * Don't make PathBuf an Option in a cli context
-
- Apr 15, 2020
-
-
Gavin Wood authored
* Introduce trait * The trait * Generic * Basic impls. * Remove unneeded bounds * Minor changes * Switch over to the new DB trait * Integrated parity-db and added CLI for db selection * Default impl. * Fix logs. * Started integrating subdb * Apply suggestions from code review Co-Authored-By: Cecile Tonglet <[email protected]> * Apply suggestions from code review Co-Authored-By: Nikolay Volf <[email protected]> * Enable subdb * Bump parity-db * Fixed CLI macro * Fixed browser build * Fixed features * Sort out features * Use parity-db from crates.io * Typo Co-authored-by: arkpar <[email protected]> Co-authored-by: Cecile Tonglet <[email protected]> Co-authored-by: Nikolay Volf <[email protected]>
-
- Apr 07, 2020
-
-
Cecile Tonglet authored
* WIP Forked at: 2afecf81 Parent branch: origin/master * Rename IntoConfiguration to CliConfiguration * Renamed into_configuration to create_configuration * WIP Forked at: 2afecf81 Parent branch: origin/master * WIP Forked at: 2afecf81 Parent branch: origin/master * Move keystore params to its own module * Use in-memory keystore even for build-spec * Enforce proper value for node name * dev_key_seed * Telemetry endpoints * rustfmt * Converted all RunCmd * rustfmt * Added export-blocks * Missed something * Removed config_path in NetworkConfiguration (not used) * Fixed warnings * public_addresses is used but never set, keeping it * Merge Configuration.node and NetworkConfiguration.node_name ...because they are the same thing * Added: import-blocks * Adding a proc_macro to help impl SubstrateCli * WIP Forked at: 2afecf81 Parent branch: origin/master * WIP Forked at: 2afecf81 Parent branch: origin/master * WIP Forked at: 2afecf81 Parent branch: origin/master * Re-export spec_factory from sc_cli * Re-added all the commands * Refactored node_key_params * Fixed previous refucktoring * Clean-up and removed full_version() * Renamed get_is_dev to not confuse with Configuration field * Fixed sc-cli-derive example * Fixing tests * Fixing tests and removing some (will re-add later) * Fixing more tests * Removes the need of type parameter * Converting bin/node and simplifying API * Converting more * Converting last command * WIP Forked at: 2afecf81 Parent branch: origin/master * Fixing tests and added default for WasmExecutionMethod * Fixing stuff * Fixed something I broke oops * Update Cargo.lock * Moving things around * Convert everything to Result * Added new macros to simplify the impl of CliConfiguration * Added a macro to generate CliConfiguration automatically for subcommands * Revert... too many macros (this one is not really useful) This reverts commit 9c516dd3 . * Renamed is_dev to get_is_dev Good enough for now * Fixed name roles (this is plural, not singular) * Clean-up * Re-export NodeKeyConfig and TelemetryEndpoints from sc_service * Improve styling/formatting * Added copyrights * Added doc and fixed warnings * Added myself to code owners * Yes it is needed according to the history * Revert formatting * Fixing conflict * Updated build.rs * Cargo.lock * Clean-up * Update client/cli-derive/Cargo.toml Co-Authored-By: Seun Lanlege <[email protected]> * Fail if using proc_macro and build.rs is not set properly * Dropped all get_ in front of methods * Clean-up * Fixing proc macro missing env var * Get the configuration inside the Runtime (needed for polkadot) * Clean-up * Get is_dev from argument like the others * Get chain ID instead of chain spec from shared params * &self is passed to spec_factory/load_spec * Wrong text * Fix example * Officialize macro and made a cool doc * Renamed spec_factory to load_spec (substrate_cli_configuration) * Removed not so useful ChainSpec * Renamed SubstrateCLI to SubstrateCli * Added changelog for impl_version being full now * Renamed Runtime to Runner * Update changelog to show example * Removed option on database cache size * WIP Forked at: 2afecf81 Parent branch: origin/master * Fix on removal of option * typo * Clean-up imports * Added info in Cargo.toml * typo * remarks * Moved function for build.rs to substrate-build-script-utils * Fixed example & test of cli-derive * Moved function for build.rs to substrate-build-script-utils * Renamed substrate_cli_configuration to substrate_cli oops It implements SubstrateCli not CliConfiguration! * Added documentation and wrapper macro * Removed option on database cache size * Removed option on database cache size * Clean-up * Reduce risk of errors due to typos * Removed option on database cache size * Added NOTE as suggested * Added doc as suggested * Fixed test * typo * renamed runtime to runner * Fixed weird argument * More commas * Moved client/cli-derive to client/cli/derive * Added 7 tests for the macros * Improve error message * Upgrade assert_cmd * Fixing missing stuff * Fixed unused import * Improve SubstrateCli doc * Applied suggestions * Fix and clean-up imports * Started replacing macros WIP * WIP Forked at: 2afecf81 Parent branch: origin/master * WIP Forked at: 2afecf81 Parent branch: origin/master * WIP Forked at: 2afecf81 Parent branch: origin/master * Started removing substrate_cli * WIP Forked at: 2afecf81 Parent branch: origin/master * WIP Forked at: 2afecf81 Parent branch: origin/master * WIP Forked at: 2afecf81 Parent branch: origin/master * fixed bug introduced while refactoring * Renamed NetworkConfigurationParams to NetworkParams for consistency sake * Fixed test * Update client/cli/src/commands/runcmd.rs Co-Authored-By: Bastian Köcher <[email protected]> * Update client/cli/src/commands/runcmd.rs Co-Authored-By: Bastian Köcher <[email protected]> * Update client/cli/src/commands/export_blocks_cmd.rs Co-Authored-By: Bastian Köcher <[email protected]> * Update client/cli/src/commands/check_block_cmd.rs Co-Authored-By: Bastian Köcher <[email protected]> * Update bin/node/cli/src/command.rs Co-Authored-By: Bastian Köcher <[email protected]> * Update bin/node/cli/src/command.rs Co-Authored-By: Bastian Köcher <[email protected]> * Update client/cli/src/commands/export_blocks_cmd.rs Co-Authored-By: Bastian Köcher <[email protected]> * Revert "Update client/cli/src/commands/export_blocks_cmd.rs" This reverts commit 59067769. * Revert "Update client/cli/src/commands/check_block_cmd.rs" This reverts commit f705f42b. * Revert "Update client/cli/src/commands/export_blocks_cmd.rs" This reverts commit 8d57c055. * Revert "Update client/cli/src/commands/runcmd.rs" This reverts commit 93e74cf5. * Revert "Update client/cli/src/commands/runcmd.rs" This reverts commit 11d527ba . * Update client/cli/src/commands/export_blocks_cmd.rs Co-Authored-By: Bastian Köcher <[email protected]> * Update client/cli/src/commands/import_blocks_cmd.rs Co-Authored-By: Bastian Köcher <[email protected]> * Update client/cli/src/commands/purge_chain_cmd.rs Co-Authored-By: Bastian Köcher <[email protected]> * Changed ::sc_cli to $crate in the macro * fixed tests * fixed conflicts * Fixing test * Update client/cli/src/commands/purge_chain_cmd.rs Co-Authored-By: Bastian Köcher <[email protected]> * Update client/cli/src/params/pruning_params.rs Co-Authored-By: Bastian Köcher <[email protected]> * Remove comment as suggested * Apply suggestion * Update client/cli/src/commands/purge_chain_cmd.rs Co-Authored-By: Bastian Köcher <[email protected]> * Update client/cli/src/commands/purge_chain_cmd.rs Co-Authored-By: Bastian Köcher <[email protected]> * Update client/cli/src/commands/purge_chain_cmd.rs Co-Authored-By: Bastian Köcher <[email protected]> * Update utils/frame/benchmarking-cli/src/command.rs Co-Authored-By: Bastian Köcher <[email protected]> * Update client/cli/src/runner.rs Co-Authored-By: Bastian Köcher <[email protected]> * Update client/cli/src/runner.rs Co-Authored-By: Bastian Köcher <[email protected]> * Update client/cli/src/runner.rs Co-Authored-By: Bastian Köcher <[email protected]> * Update client/cli/src/params/pruning_params.rs Co-Authored-By: Bastian Köcher <[email protected]> * Update client/cli/src/params/node_key_params.rs Co-Authored-By: Bastian Köcher <[email protected]> * Update client/cli/src/params/network_params.rs Co-Authored-By: Bastian Köcher <[email protected]> * Update client/cli/src/lib.rs Co-Authored-By: Bastian Köcher <[email protected]> * Update client/cli/src/config.rs Co-Authored-By: Bastian Köcher <[email protected]> * Added doc * Fixed error introduced after applying suggestion * Revert "Update client/cli/src/params/pruning_params.rs" This reverts commit 0574d06a . * Print error * Apply suggestions from code review * Remove useless Results * Fixed CI failing on polkadot approval Co-authored-by: Seun Lanlege <[email protected]> Co-authored-by: Bastian Köcher <[email protected]>
-
- Mar 21, 2020
-
-
joe petrowski authored
* minor fixes to CLI arg docs * Update client/cli/src/params/shared_params.rs Co-authored-by: Bastian Köcher <[email protected]>
-
- Mar 11, 2020
-
-
Arkadiy Paronyan authored
* ChainSpec trait * Apply suggestions from code review Co-Authored-By: Bastian Köcher <[email protected]> * Added docs * Fixed build * Fixed build Co-authored-by: Bastian Köcher <[email protected]>
-
- Feb 21, 2020
-
-
Cecile Tonglet authored
Related to #4776 Related to https://github.com/paritytech/polkadot/pull/832 To summarize the changes: 1. I did not manage to validate with types the service's Configuration. But I did reduce the possibility of errors by moving all the "fill" functions to their respective structopts 2. I split params.rs to multiple modules: one module params for just CLI parameters and one module commands for CLI subcommands (and RunCmd). Every command and params are in their own file so things are grouped better together and easier to remove 3. I removed the run and run_subcommand helpers as they are not helping much anymore. Running a command is always a set of 3 commands: 1. init 2. update config 3. run. This still allow the user to change the config before arguments get parsed or right after. 4. I added tests for all subcommands. 5. [deleted] Overall the aim is to improve the situation with the Configuration and the ...
-