Skip to content
  1. Jun 08, 2020
    • Subsocial's avatar
      Fix typo: eror -> error (#6293) · f2c8b88d
      Subsocial authored
      f2c8b88d
    • Hernando Castano's avatar
      Use Subscription Manager from `jsonrpc-pubsub`: The Sequel (#6254) · 3cb05a1e
      Hernando Castano authored
      
      
      * Bump jsonrpc pubsub, core, http, and ws
      
      Right now these are the packages which _need_ to be updated
      so I can just the latest `jsonrpc-pubsub` code. Once a release
      it cut upstream the rest of the dependencies should be updated
      as well.
      
      * Use jsonrpc-pubsub's SubscriptionManager
      
      This places sc-rpc-api::Subscriptions
      
      * Bump jsonrpc-core outside of sc-rpc-*
      
      * Update client/rpc tests
      
      Right now one of the `author` tests is failing, I
      need to think a bit about how best to fix it.
      
      * Remove Subscriptions manager
      
      There's no need for this implementation since we're
      using the one from `jsonrpc-pubsub` now
      
      * Fix author RPC test
      
      This test used to check for a numerial subscription ID,
      whereas now it uses a string based ID which is the default
      provided by `jsonrpc-pubsub`'s subscription manager.
      
      * Remove unused NumericIdProvider
      
      * Add missing bracket
      
      Removed one too many with that last one, lol
      
      * Bump `jsonrpc` to v14.2
      
      There's an exception though. `jsonrpc-derive` cannot be bumped
      past v14.0.5 just yet since it has a dependency on `quote` pinned
      to v1.0.1. This means that at the moment it won't build on Substrate
      since it's using v1.0.3.
      
      * Track `jsonrpc-derive` master branch
      
      * Bump `quote` version to v1.0.6
      
      * Bump `jsonrpc-derive` to v14.2.1
      
      This includes support for `quote` v1.0.6
      
      * Use exact version for jsonrpc crates
      
      Doing this to make sure any updates in jsonrpc don't
      accidently trickle down to Polkadot.
      
      Co-authored-by: default avatarAndré Silva <[email protected]>
      3cb05a1e
    • pscott's avatar
      Make all features explicit (#6267) · a5bf77de
      pscott authored
      
      
      * make all features explicit
      
      * Change to -feature suffix to with- prefix
      
      * Add newline at the end of the Cargo.toml file
      
      * Remove rhd feature
      
      * Remove some features from Cargo.toml
      
      * Remove test-helpers feature in tx pool
      
      * Return db_open_error("with-"..
      
      Co-authored-by: default avatarBastian Köcher <[email protected]>
      
      * Rename subdb feature to with-subdb
      
      Co-authored-by: default avatarBastian Köcher <[email protected]>
      
      * Remove 'strict' feature and cfg_attr
      
      * Check for with-subdb feature instead of subdb
      
      Co-authored-by: default avatarBastian Köcher <[email protected]>
      a5bf77de
    • Boqin Qin's avatar
    • Bastian Köcher's avatar
      Fix transaction pruning in tx-pool (#6276) · 9fe0da54
      Bastian Köcher authored
      The `tree_route` generated by the import notification is only from the
      old best block to the new best parent. This means, it does not contain
      the new best block in `enacted()`. We need to prune the transactions of
      the new best block "manually" to fix this bug.
      
      Besides that, this pr also changed the `id` parameter of the `NewBlock`
      chain event to `hash`. The hash of a block is unique in contrast to the
      block number. (Block id can either be number or hash)
      9fe0da54
  2. Jun 06, 2020
  3. Jun 05, 2020
  4. Jun 04, 2020
  5. Jun 03, 2020
  6. Jun 02, 2020
  7. Jun 01, 2020
  8. May 29, 2020
  9. May 28, 2020
    • Bastian Köcher's avatar
      Wasm-builder `runtime-wasm` feature (#6177) · 5b4ed426
      Bastian Köcher authored
      * Enable the `runtime-wasm` for wasm builds
      
      This enables the `runtime-wasm` feature for wasm builds. The feature is
      not mandatory and will only be activated if it exists in the
      `Cargo.toml`.
      
      * Fix compilation
      
      * Update docs
      
      * Uprgade version
      
      * Apply suggestions from code review
      5b4ed426
    • Bernhard Schuster's avatar
      offchain storage lock (#6010) · d65e6443
      Bernhard Schuster authored
      
      
      * feat/offchain/storage: add remove interface method
      
      * feat/offchain/storeage: add remote to StorageValueRef
      
      * feat/offchain/storage: add storage lock
      
      * fix/review: Apply suggestions from code review
      
      Co-authored-by: default avatarTomasz Drwięga <[email protected]>
      Co-authored-by: default avatarPeter Goodspeed-Niklaus <[email protected]>
      
      * refactor/offchain/storage/lock: introduce `Lockable` trait part 1 of 2
      
      * chore/offchain/rename: _remove -> clean
      
      * feat/offchain/storage/lock: add TimeAndBlock based part 2 of 2
      
      * fix/offchain/storage/lock: block and time expiry must be && not ||
      
      * chore/offchain/storage: minor fmt doc comments
      
      * doc/comment: prefer markdown emphasis over CAPS
      
      * doc/comment: rewrap multiline module level docs
      
      * doc/comment: rephrase
      
      * impl sleep_until and use the actual time for the test env
      
      * feat/test: add more tests, ignore some sample impl doctests
      
      * fix/review: Apply suggestions from code review
      
      Co-authored-by: default avatarNikolay Volf <[email protected]>
      
      * doc/comment: better description
      
      * fix/review: Apply suggestions from code review
      
      Co-authored-by: default avatarNikolay Volf <[email protected]>
      
      * chore/storage: lifetime cleanup
      
      * fix/cleanup: trait bounds, cargo-spellcheck + extra explanations
      
      * fix/doc: periods +-
      
      * fix/review: Apply suggestions from code review
      
      Co-authored-by: default avatarTomasz Drwięga <[email protected]>
      
      * cleanup: remove explicit lifetime bound, copy -> clone
      
      * fix/review: make trait Lockable contain only static, try_lock should not return Err(Option<L>),
      
      * chore/lifetimes: remove a couple of lifetime bounds which the compiler can figure out
      
      * refactor: migrate to an instant based
      
      * fix/feedback: fix, reduce, rename, docs update pending
      
      * docs/reword: adjust to changed code
      
      * fix/offchain/testing: timestamp and sleep_until shall not block
      
      * chore/lines: lines must < 100 chars
      
      * fix/docs: add missing pub field doc comments
      
      * refactor/x: try_lock does not need to return an Option<_>
      
      * refactor/simplify: a better way of waiting for a lock to resolve
      
      * docs: consistency
      
      * fix/line: < 100
      
      * fix/doctest/use: avoid crate::
      
      * fix/doctest: *
      
      * fix/review: remove unused trait bound
      
      * fix/review: pretty by const fn
      
      * fix/review: reduce default timeout to 20s
      
      * docs: grammar
      
      * fix/review: add with_block_deadline
      
      * doc: revamp BlockNumberProvider documentation to be less frame centric
      
      * chore: fmt
      
      * docs: add missing doc comment
      
      Co-authored-by: default avatarBernhard Schuster <[email protected]>
      Co-authored-by: default avatarTomasz Drwięga <[email protected]>
      Co-authored-by: default avatarPeter Goodspeed-Niklaus <[email protected]>
      Co-authored-by: default avatarNikolay Volf <[email protected]>
      d65e6443
  10. May 27, 2020
  11. May 26, 2020
  12. May 25, 2020
  13. May 23, 2020
  14. May 22, 2020
    • pscott's avatar
      Add JSON format to import blocks and set it as default (#5816) · 9aa7b8f8
      pscott authored
      
      
      * Add BlockStream Enum and utility fn
      
      * WIP: Modify import closure to work with BlockStream
      
      * Fix trait bounds
      
      * Working prototype
      
      * Revamp block importing
      
      * Add export_import_flow tests
      
      * Add comments and clean code
      
      * Add more comments in the import fn
      
      * Add link code to import function
      
      * Add condition when returning Ready(Ok(()) to make sure we've imported every block
      
      * Add check for imported blocks in JSON case
      
      * Use rest pattern
      
      * Fix compilation error for undeclared variable
      
      * Add polling and waker before pending
      
      * Print read_block_count instead of count
      
      * Simplify binary cli option with structopt
      
      * Update test to reflect changes in CLI api
      
      * Change Stream to take SignedBlock<B> instead of B
      
      * Add comments to BlockStream
      
      * Move out logic to smaller functions for clearer code
      
      * Remove result over import_blocks return type
      
      * Check for error in command output rather than simply checking command exit status
      
      * Revamp export/import/revert testing
      
      * Fix minor typos and formatting errors
      
      Co-authored-by: default avatarBastian Köcher <[email protected]>
      
      * Remove unnecessary if condition in terminating condition
      
      Co-authored-by: default avatarBastian Köcher <[email protected]>
      
      * Explicit error instead of returning it as a string
      
      Co-authored-by: default avatarBastian Köcher <[email protected]>
      
      * Pass BlockStream to log_importing_status_updates and simplify matching arms for block stream
      
      * Use .contains() instead of regex match
      
      * Line break in match block; return future::ready instead of poll_fn
      
      * Update Cargo.lock
      
      * Add check so that queue doesn't grow too big
      
      * Use Iterator instead of Stream
      
      * Remove allow dead_code
      
      * Remove outdated comments
      
      Co-authored-by: default avatarBastian Köcher <[email protected]>
      
      * Return Errors instead of logging them
      
      * Simplify match arms
      
      Co-authored-by: default avatarBastian Köcher <[email protected]>
      
      * Remove check before terminating block import
      
      * Apply suggestions from code review
      
      * Check that queue is not full BEFORE calling
      
      * Revert "Remove check before terminating block import"
      
      This reverts commit 377823c0
      
      .
      
      * Improve unit tests to make sure we actually import blocks
      
      * Remove Unpin implementation for BlockIter
      
      * Add prototype of enum for ImportStates
      
      * Add working prototype for StateMachine
      
      * Add comments for clearer code
      
      * Add sleep before calling Waker when waiting for import queue
      
      * Add Speedometer
      
      * add dbg!(&log) for test debugging
      
      * Fix lines with more than 100 cols
      
      * Fix regex capture for test
      
      * Update regexes to take to capture the whole number
      
      * Rename Cmd to Command
      
      Co-authored-by: default avatarGavin Wood <[email protected]>
      
      * Actually rename Cmd to Command
      
      * Apply suggestions from code review
      
      Co-authored-by: default avatarGavin Wood <[email protected]>
      
      * Fix compilation errors for tests
      
      * Fix compilation errors from code review suggestion
      
      * Update bin/node/cli/tests/export_import_flow.rs
      
      Co-authored-by: default avatarBastian Köcher <[email protected]>
      Co-authored-by: default avatarGavin Wood <[email protected]>
      Co-authored-by: default avatarBenjamin Kampmann <[email protected]>
      9aa7b8f8
    • Igor Matuszewski's avatar
      Fix some flaky offchain HTTP tests (#6038) · 2e8a0c08
      Igor Matuszewski authored
      * http: Use assert_eq in tests for better debuggability
      
      * http: Use matches! macro instead of if let ...
      
      * http: Simplify some bits and pieces
      
      * http: Don't answer immediately in HTTP test server
      
      Sometimes it can happen that we receive the response immediately
      when testing the HTTP api due to kernel scheduling. Because of it, we
      add a marginal 10ms async-friendly delay to minimize the risk.
      
      * http: Use the same async runtime when testing HTTP API/worker
      
      * http: Return a future Delay only for non-zero Duration
      
      This allows to short-circuit in the response_wait logic and only
      send/not wait for response.
      2e8a0c08