1. Jun 09, 2020
  2. Jun 08, 2020
    • Bastian Köcher's avatar
      Fix transaction pruning in tx-pool (#6276) · 9fe0da54
      Bastian Köcher authored
      The `tree_route` generated by the import notification is only from the
      old best block to the new best parent. This means, it does not contain
      the new best block in `enacted()`. We need to prune the transactions of
      the new best block "manually" to fix this bug.
      
      Besides that, this pr also changed the `id` parameter of the `NewBlock`
      chain event to `hash`. The hash of a block is unique in contrast to the
      block number. (Block id can either be number or hash)
      9fe0da54
  3. Jun 05, 2020
  4. May 27, 2020
  5. May 21, 2020
    • André Silva's avatar
      babe: treat epoch_authorship RPC method as unsafe (#6069) · 14d89b7b
      André Silva authored
      * service: pass DenyUnsafe to rpc extensions
      
      * node: add DenyUnsafe to rpc full node dependencies
      
      * client: fix whitespace in rpc policy file
      
      * babe: treat epochAuthorship rpc method as unsafe
      
      * babe: add test for unsafe rpc method
      
      * babe: rename babe rpc handler
      
      * service: traitify rpc extension builder
      
      * service: make the rpc extensions builder api non-breaking
      
      * service: revert changes from light node rpc extensions builder
      
      * node: remove unnecessary type in service creation
      
      * service: cleanup with_rpc_extensions implementation
      
      * service: add missing docs to RpcExtensionBuilder
      14d89b7b
  6. May 18, 2020
  7. May 15, 2020
  8. May 14, 2020
  9. May 13, 2020
    • Bastian Köcher's avatar
      Handle clap errors manually and don't reset `SIGPIPE` (#6012) · 525dc61d
      Bastian Köcher authored
      Instead of resetting `SIGPIPE` to the system default handler, we now
      handle a clap error manually and ignore any error when writing to
      `stdout`/`stderr`. In this way, the node does not silently stops when it
      encounters a `SIGPIPE` in normal mode and we still support piping of the
      cli output.
      525dc61d
  10. May 06, 2020
    • André Silva's avatar
      grandpa: report equivocations (#3868) · a2512e83
      André Silva authored
      * session: runtime api for generating session membership proofs
      
      * grandpa: add runtime api for creating equivocation report txs
      
      * grandpa: submit signed equivocation report transactions
      
      * grandpa: use proper equivocation report type
      
      * grandpa: report equivocations
      
      * grandpa: validate equivocation proof
      
      * grandpa: update to finality-grandpa 0.9.1
      
      * grandpa: fix encoding of session membership proof
      
      * grandpa: initialize set id session mapping for genesis session
      
      * grandpa: fix bug in set_id session validation
      
      * fix compilation
      
      * cleanup from merge conflicts
      
      * cleanup crate tomls
      
      * grandpa: refactor equivocation handling to separate trait
      
      * node-template: fix compilation
      
      * fix test compilation
      
      * bump finality-grandpa to v0.10.2
      
      * rpc: fix runtime version test
      
      * CHERRY-PICK #4200: Add documentation to SubmitSignedTransaction and actually make it work
      
      Squashed commit of the following:
      
      commit dc8d71c3
      Author: Tomasz Drwięga <[email protected]>
      Date:   Tue Dec 3 16:29:33 2019 +0100
      
          Split the method to avoid confusing type error message.
      
      commit 0c4c0378
      Author: Tomasz Drwięga <[email protected]>
      Date:   Tue Dec 3 16:19:55 2019 +0100
      
          Make accounts optional, fix logic.
      
      commit d715f645
      Author: Tomasz Drwięga <[email protected]>
      Date:   Tue Dec 3 10:06:20 2019 +0100
      
          Remove warning.
      
      commit 3f38218a
      Merge: f85b8903 368318c9
      Author: Tomasz Drwięga <[email protected]>
      Date:   Tue Dec 3 07:08:05 2019 +0100
      
          Merge branch 'master' into td-signed-transactions
      
      commit f85b8903
      Merge: f8c95403 d8d5da2c
      Author: Tomasz Drwięga <[email protected]>
      Date:   Mon Dec 2 13:57:25 2019 +0100
      
          Merge branch 'master' into td-signed-transactions
      
      commit f8c95403
      Author: Tomasz Drwięga <[email protected]>
      Date:   Mon Nov 25 17:34:52 2019 +0100
      
          Forgotten import.
      
      commit a645b90d
      Author: Tomasz Drwięga <[email protected]>
      Date:   Mon Nov 25 17:32:10 2019 +0100
      
          Fix naming and bounds.
      
      commit bc28c605
      Author: Tomasz Drwięga <[email protected]>
      Date:   Mon Nov 25 17:01:05 2019 +0100
      
          Add documentation to signed transactions and actually make them work.
      
      * grandpa: skip block initialization on report submission method
      
      * primitives: allow transaction pool access by default for offchain calls
      
      * grandpa: unused parameters
      
      * grandpa: remove unused method
      
      * grandpa: enable equivocation reporting
      
      * grandpa: add workaround for parameter encoding
      
      * grandpa: fix localized_payload calls in tests
      
      * fix submit_report_equivocation_extrinsic in runtimes
      
      * node: fix submit transaction test compilation
      
      * node: bump spec_version
      
      * rpc: fix api version test
      
      * grandpa: allow custom equivocation offence type
      
      * grandpa: add test for authorities::next_change_height
      
      * grandpa: cleanup report_equivocation function
      
      * node: move reporting app crypto to node-primitives
      
      * grandpa: move equivocation traits to own module
      
      * grandpa: rename app-crypto crate import
      
      * grandpa: export equivocation types
      
      * node: bump spec_version
      
      * grandpa: rename EquivocationReport to EquivocationProof
      
      * grandpa: add missing docs to primitives
      
      * grandpa: add missing docs to equivocation
      
      * node: fix compilation
      
      * grandpa: add missing docs to pallet
      
      * node: bump spec_version
      
      * fix whitespace
      
      * grandpa: return error on offence reporting
      
      * grandpa: expose session and validator count in proofs through traits
      
      * grandpa: use strong key in module KeyOwnerProofSystem
      
      * grandpa: move key ownership proof to grandpa runtime api
      
      * grandpa: remove unnecessary cloning when checking equivocation proof
      
      * grandpa: make report_equivocation a method in Environment
      
      * support: implement KeyOwnerProofSystem for ()
      
      * grandpa: move KeyOwnerProofSystem to module trait
      
      * test-utils: fix runtime compilation
      
      * grandpa: fix test compilation
      
      * grandpa: fix test compilation after merge
      
      * grandpa: simplify transaction submission types
      
      * grandpa: validate equivocation report in signed extension
      
      * client: fix test
      
      * node: use ValidateEquivocationReport signed extension
      
      * grandpa: expose key ownership proof under opaque type
      
      * grandpa: better docs on key ownership proofs
      
      * grandpa: add note about signed extension
      
      * grandpa: add ValidateEquivocationReport::new
      
      * grandpa: remove skip_initialize_block from runtime api
      
      * grandpa: use new offchain transaction submission API
      
      * grandpa: take set_id in generate_key_ownership_proof
      
      * grandpa: update to finality-grandpa v0.12.2
      
      * grandpa: cleanup usages of AuthoritySet::current
      
      * grandpa: fix test
      
      * grandpa: add mocking utilities for equivocation reporting
      
      * grandpa: add test for equivocation reporting
      
      * grandpa: move SetIdSession initialization
      
      * grandpa: add more tests
      
      * node: enable historical session manager
      
      * node: bump spec_version
      
      * node: use strong key types in KeyOwnerProofSystem definitions
      
      * grandpa: export GrandpaEquivocationOffence type
      a2512e83
  11. May 05, 2020
  12. May 04, 2020
    • Jon Häggblad's avatar
      Expose GRANDPA round state through RPC (#5375) · c0ccc24d
      Jon Häggblad authored
      
      
      * grandpa: wire up basic RPC call
      
      * grandpa: make it compile against GRANDPA with expose round state
      
      * grandpa: use shared voter state to expose RPC endpoint
      
      * grandpa: restructure into nested structs
      
      * grandpa: return background rounds too
      
      * grandpa: return error when endpoint not ready
      
      * grandpa: collect grandpa rpc deps
      
      * grandpa: decide to use concrete AuthorityId in finality-grandpa-rpc
      
      * grandpa: remove unncessary type annotation
      
      * grandpa: move error code to const
      
      * grandpa: remove unnecessary WIP comment
      
      * grandpa: remove Id type parameter for SharedVoterState
      
      * grandpa: update tests to add shared_voter_state in parameters
      
      * grandpa: remove old deprecated test
      
      * grandpa: fix getting the correct set_id
      
      * grandpa: make SharedVoterState a struct
      
      * grandpa: wrap shared_voter_state in rpc_setup
      
      * grandpa: replace spaces with tabs
      
      * grandpa: limit RwLock write attempt to 1 sec
      
      * grandpa: add missing doc comments and remove some pub
      
      * Apply suggestions from code review
      
      Co-Authored-By: default avatarTomasz Drwięga <[email protected]>
      Co-Authored-By: default avatarHernando Castano <[email protected]>
      
      * grandpa: update function name call after change in finality-grandpa
      
      * grandpa: group pub use and only export voter::report
      
      * grandpa: add missing docs
      
      * grandpa: extract out structs used for json serialization
      
      * grandpa: stick to u32 for fields intended for js
      
      * grandpa: move Error type to its own file
      
      * grandpa: group pub use better
      
      * Apply code review suggestion
      
      Co-authored-by: default avatarBastian Köcher <[email protected]>
      
      * grandpa: use correct version of finality-granpda in rpc crate
      
      * grandpa: add back basic rpc unit test
      
      * grandpa: replace SharedVoterState::new() with empty()
      
      * node: cleanup grandpa::SharedVoterState usage in macro
      
      * grandpa: remove VoterState error variant
      
      * grandpa: enable missing futures compat feature
      
      * grandpa: fix typo in error variant
      
      * grandpa: remove test_utils
      
      * grandpa: allow mocking rpc handler components
      
      * grandpa: rename serialized to report in rpc module
      
      * grandpa: add proper test for RPC
      
      * grandpa: update to finality-grandpa v0.12.1
      
      Co-authored-by: default avatarAndré Silva <[email protected]>
      Co-authored-by: default avatarDemi Obenour <[email protected]>
      Co-authored-by: default avatarTomasz Drwięga <[email protected]>
      Co-authored-by: default avatarHernando Castano <[email protected]>
      Co-authored-by: default avatarBastian Köcher <[email protected]>
      c0ccc24d
    • Bastian Köcher's avatar
      Expose that `BasicQueue` expects blocking spawn (#5860) · 30394132
      Bastian Köcher authored
      * Expose that `BasicQueue` expects blocking spawn
      
      Up to now `BasicQueue` expected a closure that to spawn a `Future`.
      This was expected to be a closure that spawns a blocking future.
      However, this wasn't documented anywhere. This pr introduces a new trait
      `SpawnBlocking` that exposes this requirement to the outside.
      
      * Feedback
      30394132
  13. Apr 29, 2020
  14. Apr 28, 2020
    • Web3 Philosopher's avatar
      Move sc-client into sc-service (#5502) · fc6d55c9
      Web3 Philosopher authored
      * Drop client from sc-network and sc-client-db, move LongestChain to sc-client-api
      
      * move leaves, cht, in_mem to sc-client-api, drop client from sc-finality-grandpa
      
      * drop sc-service from sc-rpc
      
      * drop sc-service from sc-consensus-aura
      
      * drop sc-client from manual-seal and babe
      
      * drop sc-client from utils/frame/rpc/system and utils/frame/benchmarking-cli
      
      * drop sc-client from bin/node and bin/node-template
      
      * drop sc-client
      
      * fix tests
      
      * remove check -p sc-client from gitlab.yml
      
      * fix warnings
      
      * fixes ui test
      
      * fix light client tests
      
      * adds associated Client type to AbstractService
      
      * adds UsageProvider to Client
      
      * fixed ui test, again
      
      * tried and failed to get node-cli to compile for wasm
      
      * thanks to tomaka for helping me get node-cli to compile for wasmm
      
      * ui test pls pas 🙏🏾
      
      
      
      * all tests passing 🪄
      
      * no_run documentation code
      
      * rm -f documentation code
      
      * ClientProvider
      
      * fix mega trait
      
      * move LongestChain to sc-consensus, use adds minimal bounds to AbstractService::Client
      
      * adds license to sc-consensus
      
      Co-authored-by: default avatarBenjamin Kampmann <[email protected]>
      fc6d55c9
  15. Apr 24, 2020
  16. Apr 22, 2020
  17. Apr 20, 2020
  18. Apr 17, 2020
  19. Apr 16, 2020
    • Max Inden's avatar
      client/authority-discovery: Allow to be run by sentry node (#5568) · 75134a2f
      Max Inden authored
      
      
      * client/authority-discovery: Allow to be run by sentry node
      
      When run as a sentry node, the authority discovery module does not
      publish any addresses to the dht, but still discovers validators and
      sentry nodes of validators.
      
      * client/authority-discovery/src/lib: Wrap lines at 100 characters
      
      * client/authority-discovery: Remove TODO and unused import
      
      * client/authority-discovery: Pass role to new unit tests
      
      * client/authority-discovery: Apply suggestions
      
      Co-Authored-By: default avatarAndré Silva <[email protected]>
      
      * bin/node/cli/src/service: Use expressions instead of statements
      
      Co-authored-by: default avatarAndré Silva <[email protected]>
      75134a2f
  20. Apr 14, 2020
  21. Apr 13, 2020
  22. Apr 09, 2020
  23. Apr 08, 2020
  24. Apr 07, 2020
    • Cecile Tonglet's avatar
      CLI: refactoring: remove Options from sc_service::Configuration's fields (#5271) · b0efaa2c
      Cecile Tonglet authored
      * WIP
      
      Forked at: 2afecf81
      Parent branch: origin/master
      
      * Rename IntoConfiguration to CliConfiguration
      
      * Renamed into_configuration to create_configuration
      
      * WIP
      
      Forked at: 2afecf81
      Parent branch: origin/master
      
      * WIP
      
      Forked at: 2afecf81
      Parent branch: origin/master
      
      * Move keystore params to its own module
      
      * Use in-memory keystore even for build-spec
      
      * Enforce proper value for node name
      
      * dev_key_seed
      
      * Telemetry endpoints
      
      * rustfmt
      
      * Converted all RunCmd
      
      * rustfmt
      
      * Added export-blocks
      
      * Missed something
      
      * Removed config_path in NetworkConfiguration (not used)
      
      * Fixed warnings
      
      * public_addresses is used but never set, keeping it
      
      * Merge Configuration.node and NetworkConfiguration.node_name
      
      ...because they are the same thing
      
      * Added: import-blocks
      
      * Adding a proc_macro to help impl SubstrateCli
      
      * WIP
      
      Forked at: 2afecf81
      Parent branch: origin/master
      
      * WIP
      
      Forked at: 2afecf81
      Parent branch: origin/master
      
      * WIP
      
      Forked at: 2afecf81
      Parent branch: origin/master
      
      * Re-export spec_factory from sc_cli
      
      * Re-added all the commands
      
      * Refactored node_key_params
      
      * Fixed previous refucktoring
      
      * Clean-up and removed full_version()
      
      * Renamed get_is_dev to not confuse with Configuration field
      
      * Fixed sc-cli-derive example
      
      * Fixing tests
      
      * Fixing tests and removing some (will re-add later)
      
      * Fixing more tests
      
      * Removes the need of type parameter
      
      * Converting bin/node and simplifying API
      
      * Converting more
      
      * Converting last command
      
      * WIP
      
      Forked at: 2afecf81
      Parent branch: origin/master
      
      * Fixing tests and added default for WasmExecutionMethod
      
      * Fixing stuff
      
      * Fixed something I broke oops
      
      * Update Cargo.lock
      
      * Moving things around
      
      * Convert everything to Result
      
      * Added new macros to simplify the impl of CliConfiguration
      
      * Added a macro to generate CliConfiguration automatically for subcommands
      
      * Revert... too many macros (this one is not really useful)
      
      This reverts commit 9c516dd3
      
      .
      
      * Renamed is_dev to get_is_dev
      
      Good enough for now
      
      * Fixed name roles (this is plural, not singular)
      
      * Clean-up
      
      * Re-export NodeKeyConfig and TelemetryEndpoints from sc_service
      
      * Improve styling/formatting
      
      * Added copyrights
      
      * Added doc and fixed warnings
      
      * Added myself to code owners
      
      * Yes it is needed according to the history
      
      * Revert formatting
      
      * Fixing conflict
      
      * Updated build.rs
      
      * Cargo.lock
      
      * Clean-up
      
      * Update client/cli-derive/Cargo.toml
      
      Co-Authored-By: default avatarSeun Lanlege <[email protected]>
      
      * Fail if using proc_macro and build.rs is not set properly
      
      * Dropped all get_ in front of methods
      
      * Clean-up
      
      * Fixing proc macro missing env var
      
      * Get the configuration inside the Runtime (needed for polkadot)
      
      * Clean-up
      
      * Get is_dev from argument like the others
      
      * Get chain ID instead of chain spec from shared params
      
      * &self is passed to spec_factory/load_spec
      
      * Wrong text
      
      * Fix example
      
      * Officialize macro and made a cool doc
      
      * Renamed spec_factory to load_spec (substrate_cli_configuration)
      
      * Removed not so useful ChainSpec
      
      * Renamed SubstrateCLI to SubstrateCli
      
      * Added changelog for impl_version being full now
      
      * Renamed Runtime to Runner
      
      * Update changelog to show example
      
      * Removed option on database cache size
      
      * WIP
      
      Forked at: 2afecf81
      Parent branch: origin/master
      
      * Fix on removal of option
      
      * typo
      
      * Clean-up imports
      
      * Added info in Cargo.toml
      
      * typo
      
      * remarks
      
      * Moved function for build.rs to substrate-build-script-utils
      
      * Fixed example & test of cli-derive
      
      * Moved function for build.rs to substrate-build-script-utils
      
      * Renamed substrate_cli_configuration to substrate_cli oops
      
      It implements SubstrateCli not CliConfiguration!
      
      * Added documentation and wrapper macro
      
      * Removed option on database cache size
      
      * Removed option on database cache size
      
      * Clean-up
      
      * Reduce risk of errors due to typos
      
      * Removed option on database cache size
      
      * Added NOTE as suggested
      
      * Added doc as suggested
      
      * Fixed test
      
      * typo
      
      * renamed runtime to runner
      
      * Fixed weird argument
      
      * More commas
      
      * Moved client/cli-derive to client/cli/derive
      
      * Added 7 tests for the macros
      
      * Improve error message
      
      * Upgrade assert_cmd
      
      * Fixing missing stuff
      
      * Fixed unused import
      
      * Improve SubstrateCli doc
      
      * Applied suggestions
      
      * Fix and clean-up imports
      
      * Started replacing macros WIP
      
      * WIP
      
      Forked at: 2afecf81
      Parent branch: origin/master
      
      * WIP
      
      Forked at: 2afecf81
      Parent branch: origin/master
      
      * WIP
      
      Forked at: 2afecf81
      Parent branch: origin/master
      
      * Started removing substrate_cli
      
      * WIP
      
      Forked at: 2afecf81
      Parent branch: origin/master
      
      * WIP
      
      Forked at: 2afecf81
      Parent branch: origin/master
      
      * WIP
      
      Forked at: 2afecf81
      
      
      Parent branch: origin/master
      
      * fixed bug introduced while refactoring
      
      * Renamed NetworkConfigurationParams to NetworkParams for consistency sake
      
      * Fixed test
      
      * Update client/cli/src/commands/runcmd.rs
      
      Co-Authored-By: default avatarBastian Köcher <[email protected]>
      
      * Update client/cli/src/commands/runcmd.rs
      
      Co-Authored-By: default avatarBastian Köcher <[email protected]>
      
      * Update client/cli/src/commands/export_blocks_cmd.rs
      
      Co-Authored-By: default avatarBastian Köcher <[email protected]>
      
      * Update client/cli/src/commands/check_block_cmd.rs
      
      Co-Authored-By: default avatarBastian Köcher <[email protected]>
      
      * Update bin/node/cli/src/command.rs
      
      Co-Authored-By: default avatarBastian Köcher <[email protected]>
      
      * Update bin/node/cli/src/command.rs
      
      Co-Authored-By: default avatarBastian Köcher <[email protected]>
      
      * Update client/cli/src/commands/export_blocks_cmd.rs
      
      Co-Authored-By: default avatarBastian Köcher <[email protected]>
      
      * Revert "Update client/cli/src/commands/export_blocks_cmd.rs"
      
      This reverts commit 59067769.
      
      * Revert "Update client/cli/src/commands/check_block_cmd.rs"
      
      This reverts commit f705f42b.
      
      * Revert "Update client/cli/src/commands/export_blocks_cmd.rs"
      
      This reverts commit 8d57c055.
      
      * Revert "Update client/cli/src/commands/runcmd.rs"
      
      This reverts commit 93e74cf5.
      
      * Revert "Update client/cli/src/commands/runcmd.rs"
      
      This reverts commit 11d527ba
      
      .
      
      * Update client/cli/src/commands/export_blocks_cmd.rs
      
      Co-Authored-By: default avatarBastian Köcher <[email protected]>
      
      * Update client/cli/src/commands/import_blocks_cmd.rs
      
      Co-Authored-By: default avatarBastian Köcher <[email protected]>
      
      * Update client/cli/src/commands/purge_chain_cmd.rs
      
      Co-Authored-By: default avatarBastian Köcher <[email protected]>
      
      * Changed ::sc_cli to $crate in the macro
      
      * fixed tests
      
      * fixed conflicts
      
      * Fixing test
      
      * Update client/cli/src/commands/purge_chain_cmd.rs
      
      Co-Authored-By: default avatarBastian Köcher <[email protected]>
      
      * Update client/cli/src/params/pruning_params.rs
      
      Co-Authored-By: default avatarBastian Köcher <[email protected]>
      
      * Remove comment as suggested
      
      * Apply suggestion
      
      * Update client/cli/src/commands/purge_chain_cmd.rs
      
      Co-Authored-By: default avatarBastian Köcher <[email protected]>
      
      * Update client/cli/src/commands/purge_chain_cmd.rs
      
      Co-Authored-By: default avatarBastian Köcher <[email protected]>
      
      * Update client/cli/src/commands/purge_chain_cmd.rs
      
      Co-Authored-By: default avatarBastian Köcher <[email protected]>
      
      * Update utils/frame/benchmarking-cli/src/command.rs
      
      Co-Authored-By: default avatarBastian Köcher <[email protected]>
      
      * Update client/cli/src/runner.rs
      
      Co-Authored-By: default avatarBastian Köcher <[email protected]>
      
      * Update client/cli/src/runner.rs
      
      Co-Authored-By: default avatarBastian Köcher <[email protected]>
      
      * Update client/cli/src/runner.rs
      
      Co-Authored-By: default avatarBastian Köcher <[email protected]>
      
      * Update client/cli/src/params/pruning_params.rs
      
      Co-Authored-By: default avatarBastian Köcher <[email protected]>
      
      * Update client/cli/src/params/node_key_params.rs
      
      Co-Authored-By: default avatarBastian Köcher <[email protected]>
      
      * Update client/cli/src/params/network_params.rs
      
      Co-Authored-By: default avatarBastian Köcher <[email protected]>
      
      * Update client/cli/src/lib.rs
      
      Co-Authored-By: default avatarBastian Köcher <[email protected]>
      
      * Update client/cli/src/config.rs
      
      Co-Authored-By: default avatarBastian Köcher <[email protected]>
      
      * Added doc
      
      * Fixed error introduced after applying suggestion
      
      * Revert "Update client/cli/src/params/pruning_params.rs"
      
      This reverts commit 0574d06a
      
      .
      
      * Print error
      
      * Apply suggestions from code review
      
      * Remove useless Results
      
      * Fixed CI failing on polkadot approval
      
      Co-authored-by: default avatarSeun Lanlege <[email protected]>
      Co-authored-by: default avatarBastian Köcher <[email protected]>
      b0efaa2c
  25. Apr 03, 2020
    • Pierre Krieger's avatar
      Split the Roles in three types (#5520) · 525cb7a1
      Pierre Krieger authored
      
      
      * Split the Roles bitfield in three
      
      * Forgot to include some changes
      
      * Fix cli test
      
      * More test fixes
      
      * Oh God, merging master broke other tests
      
      * Didn't run the doctests
      
      * Address review
      
      * I'm trying to fix the build blindly because it's taking a good hour to compile on my machine
      
      * Address some review
      
      * Also update the peerset's API to make sense
      
      * Fix peerset tests
      
      * Fix browser node
      
      * client: distinguish between local and network authority
      
      Co-authored-by: default avatarAndré Silva <[email protected]>
      525cb7a1
  26. Apr 02, 2020
  27. Apr 01, 2020
    • Gavin Wood's avatar
      A few missing emojies (#5490) · 8b304e49
      Gavin Wood authored
      * A few missing emojies
      
      * P2p message emojis
      
      * Add a bit of colour
      
      * format
      
      * Introduce a couple of spaces
      
      * Some spaces
      8b304e49
  28. Mar 31, 2020
  29. Mar 29, 2020
  30. Mar 27, 2020
  31. Mar 26, 2020
    • Kian Paimani's avatar
      Offchain Phragmén BREAKING. (#4517) · d1238423
      Kian Paimani authored
      * Initial skeleton for offchain phragmen
      
      * Basic compact encoding decoding for results
      
      * add compact files
      
      * Bring back Self::ensure_storage_upgraded();
      
      * Make staking use compact stuff.
      
      * First seemingly working version of reduce, full of todos
      
      * Everything phragmen related works again.
      
      * Signing made easier, still issues.
      
      * Signing from offchain compile fine 😎
      
      * make compact work with staked asssignment
      
      * Evaluation basics are in place.
      
      * Move reduce into crate. Document stuff
      
      * move reduce into no_std
      
      * Add files
      
      * Remove other std deps. Runtime compiles
      
      * Seemingly it is al stable; cycle implemented but not integrated.
      
      * Add fuzzing code.
      
      * Cleanup reduce a bit more.
      
      * a metric ton of tests for staking; wip 🔨
      
      * Implement a lot more of the tests.
      
      * wip getting the unsigned stuff to work
      
      * A bit gleanup for unsigned debug
      
      * Clean and finalize compact code.
      
      * Document reduce.
      
      * Still problems with signing
      
      * We officaly duct taped the transaction submission stuff. 🤓
      
      * Deadlock with keys again
      
      * Runtime builds
      
      * Unsigned test works 🙌
      
      * Some cleanups
      
      * Make all the tests compile and stuff
      
      * Minor cleanup
      
      * fix more merge stuff
      
      * Most tests work again.
      
      * a very nasty bug in reduce
      
      * Fix all integrations
      
      * Fix more todos
      
      * Revamp everything and everything
      
      * Remove bogus test
      
      * Some review grumbles.
      
      * Some fixes
      
      * Fix doc test
      
      * loop for submission
      
      * Fix cli, keyring etc.
      
      * some cleanup
      
      * Fix staking tests again
      
      * fix per-things; bring patches from benchmarking
      
      * better score prediction
      
      * Add fuzzer, more patches.
      
      * Some fixes
      
      * More docs
      
      * Remove unused generics
      
      * Remove max-nominator footgun
      
      * Better fuzzer
      
      * Disable it 
      
      
      
      * Bump.
      
      * Another round of self-review
      
      * Refactor a lot
      
      * More major fixes in perThing
      
      * Add new fuzz file
      
      * Update lock
      
      * fix fuzzing code.
      
      * Fix nominator retain test
      
      * Add slashing check
      
      * Update frame/staking/src/tests.rs
      
      Co-Authored-By: default avatarJoshy Orndorff <[email protected]>
      
      * Some formatting nits
      
      * Review comments.
      
      * Fix cargo file
      
      * Almost all tests work again
      
      * Update frame/staking/src/tests.rs
      
      Co-Authored-By: default avatarthiolliere <[email protected]>
      
      * Fix review comments
      
      * More review stuff
      
      * Some nits
      
      * Fix new staking / session / babe relation
      
      * Update primitives/phragmen/src/lib.rs
      
      Co-Authored-By: default avatarthiolliere <[email protected]>
      
      * Update primitives/phragmen/src/lib.rs
      
      Co-Authored-By: default avatarthiolliere <[email protected]>
      
      * Update primitives/phragmen/compact/src/lib.rs
      
      Co-Authored-By: default avatarthiolliere <[email protected]>
      
      * Some doc updates to slashing
      
      * Fix derive
      
      * Remove imports
      
      * Remove unimplemented tests
      
      * nits
      
      * Remove dbg
      
      * Better fuzzing params
      
      * Remove unused pref map
      
      * Deferred Slashing/Offence for offchain Phragmen  (#5151)
      
      * Some boilerplate
      
      * Add test
      
      * One more test
      
      * Review comments
      
      * Fix build
      
      * review comments
      
      * fix more
      
      * fix build
      
      * Some cleanups and self-reviews
      
      * More minor self reviews
      
      * Final nits
      
      * Some merge fixes.
      
      * opt comment
      
      * Fix build
      
      * Fix build again.
      
      * Update frame/staking/fuzz/fuzz_targets/submit_solution.rs
      
      Co-Authored-By: default avatarGavin Wood <[email protected]>
      
      * Update frame/staking/src/slashing.rs
      
      Co-Authored-By: default avatarGavin Wood <[email protected]>
      
      * Update frame/staking/src/offchain_election.rs
      
      Co-Authored-By: default avatarGavin Wood <[email protected]>
      
      * Fix review comments
      
      * fix test
      
      * === 🔑
      
       Revamp without staking key.
      
      * final round of changes.
      
      * Fix cargo-deny
      
      * Update frame/staking/src/lib.rs
      
      Co-Authored-By: default avatarGavin Wood <[email protected]>
      
      Co-authored-by: default avatarJoshy Orndorff <[email protected]>
      Co-authored-by: default avatarthiolliere <[email protected]>
      Co-authored-by: default avatarGavin Wood <[email protected]>
      d1238423
    • pscott's avatar
      TelemetryEndpoints must be valid MutliAddr URL (#5069) · fe23d880
      pscott authored
      
      
      * Check for url validity when creating TelemetryEndpoints
      
      * Update code that used TelemetryEndpoints::new()
      
      * Update commennts that referred to TelemetryEndpoints::new()
      
      * Add tests for telemetry
      
      * Fix typo and fix code in docs
      
      * Return error on failing to override telemetry
      
      * Use expect instead of suppressing errors on must-be-valid telemetry endpoints
      
      * Update telemetry unit tests to use expect instead of unwrap
      
      * Implement custom deserializer for TelemetryEndpoints
      
      * Fix typo
      
      * Apply suggestions from code review
      
      Co-authored-by: default avatarBastian Köcher <[email protected]>
      fe23d880
  32. Mar 17, 2020
  33. Mar 16, 2020
    • Wei Tang's avatar
      epoch-changes: separate epoch header with epoch data (#4881) · d299fed3
      Wei Tang authored
      
      
      * fork-tree: prune returns all pruned node data
      
      * epoch-changes: split EpochHeader vs epoch data
      
      * EpochChanges::viable_epoch and add missing comments
      
      * Incoperate the new epoch_changes interface for BABE
      
      * Fix BABE tests
      
      * Fix fork-tree pruning issue
      
      * Fix tests
      
      * Fix pruning algorithm
      
      * fork-tree: implement map function for mapping one value type to another
      
      * Add migration script for new epoch changes scheme
      
      * Update utils/fork-tree/src/lib.rs
      
      Co-Authored-By: default avatarAndré Silva <[email protected]>
      
      * Update client/consensus/slots/src/lib.rs
      
      Co-Authored-By: default avatarAndré Silva <[email protected]>
      
      * Remove authorities_len.is_none check, which is duplicate of unwrap_or(false)
      
      * Update client/consensus/epochs/src/lib.rs
      
      Co-Authored-By: default avatarAndré Silva <[email protected]>
      
      * Update client/consensus/epochs/src/lib.rs
      
      Co-Authored-By: default avatarAndré Silva <[email protected]>
      
      * No trailing ; for return statement
      
      * Use VERSION_KEY for migration
      
      * Fix issues that removed nodes are not properly added into removed list
      
      * Add comments indicating end_slot is non-inclusive
      
      * fork-tree: use &mut F for map type declaration
      
      * Add tests for v0 epoch_changes migration
      
      * Fix babe RPC tests
      
      Co-authored-by: default avatarAndré Silva <[email protected]>
      d299fed3
  34. Mar 12, 2020
  35. Mar 11, 2020