Skip to content
  1. Jun 26, 2020
  2. Jun 25, 2020
  3. Jun 24, 2020
  4. Jun 23, 2020
    • Cecile Tonglet's avatar
      Ensure the listen addresses are consistent with the transport (#6436) · d59281fa
      Cecile Tonglet authored
      * Initial commit
      
      Forked at: 0c42ceda
      
      
      No parent branch.
      
      * Ensure the listen addresses are consistent with the transport
      
      * Update client/network/src/error.rs
      
      * Update client/network/src/service.rs
      
      * Better implementation
      
      * Fix bad previous impl
      
      * add boot_nodes
      
      * reserved nodes
      
      * test boot nodes
      
      * reserved nodes tests
      
      * add public_addresses and make specific error type
      
      * Update client/network/src/error.rs
      
      Co-authored-by: default avatarPierre Krieger <[email protected]>
      
      Co-authored-by: default avatarPierre Krieger <[email protected]>
      d59281fa
    • Max Inden's avatar
      client/network/service: Add primary dimension to connection metrics (#6472) · 4c03656a
      Max Inden authored
      * client/network/service: Add primary dimension to connection metrics
      
      Two nodes can be interconnected via one or more connections. The first
      of those connections is called the primary connection.
      
      This commit adds another dimension to the
      `sub_libp2p_connections_{closed,opened}_total` metrics to differentiate
      primary and non-primary connections being opened / closed.
      
      By intuition more than one connection between two nodes is rare.
      Tracking the fact whether a connection is primary or not will help prove
      or disprove this intuition.
      
      * .maintain/monitoring: Ensure to sum over all connections_closed variants
      
      * client/network/service: Rename is_primary to is_first
      
      * client/network/service: Split by metric name with two additional metrics
      
      * Revert ".maintain/monitoring: Ensure to sum over all connections_closed variants"
      
      This reverts commit 2d2f93e4.
      
      * client/network/service: Remove labels from distinct metrics
      4c03656a
    • Ashley's avatar
      Fix the browser node and ensure it doesn't colour the informant output (#6457) · ad7b5ef7
      Ashley authored
      * Fix browser informant
      
      * Fix documentation
      
      * Add an informant_output_format function to the cli config
      
      * Wrap informant output format in an option
      
      * Revert batch verifier
      
      * Remove wasm-timer from primitives io cargo lock
      
      * Drop informant_output_format function
      
      * derive debug for output format
      ad7b5ef7
    • Cecile Tonglet's avatar
      impl Debug for sc_service::Configuration (#6400) · 6221146c
      Cecile Tonglet authored
      * Initial commit
      
      Forked at: d735e4d0
      
      
      No parent branch.
      
      * Make sc_service::Configuration derive Debug
      
      * Replace task_executor fn's input by proper TaskExecutor type (cleaner)
      
      * impl From<Fn> for TaskExecutor
      
      * Update client/cli/src/runner.rs
      
      * Add some doc, examples and tests
      
      * Replace Deref by fn spawn as suggested
      
      Co-authored-by: default avatarBastian Köcher <[email protected]>
      6221146c
    • pscott's avatar
      Optimize offchain worker api by re-using http-client (#6454) · fed834c8
      pscott authored
      * Fix typo in offchain's docs
      
      * Use Self keyword in AsyncApi::new()
      
      * Move httpclient to be part of OffchainWorkers to optimize block import
      
      * Fix compilation errors for tests
      
      * Add wrapper struct for HyperClient
      
      * Use lazy_static share SharedClient amongst OffchainWorkers. Remove the need to raise the fd limit
      
      * Revert "Use lazy_static share SharedClient amongst OffchainWorkers. Remove the need to raise the fd limit"
      
      This reverts commit 7af97498.
      
      * Add lazy_static for tests
      fed834c8
    • Roman Borschel's avatar
      Avoid panic on dropping a `sc_network::service::out_events::Receiver`. (#6458) · 19826b97
      Roman Borschel authored
      * Avoid panic on dropping a `Receiver`.
      
      * CI
      19826b97
  5. Jun 22, 2020
  6. Jun 21, 2020
  7. Jun 19, 2020
    • Bastian Köcher's avatar
      Fix Babe secondary plain slots claiming (#6451) · 80323210
      Bastian Köcher authored
      We need to check that the public key of an authority exists in our
      keystore before we can successfully claim a plain secondary slot.
      80323210
    • Arkadiy Paronyan's avatar
      Validate encoding of extrinsics passed to runtime (#6442) · d0ab405f
      Arkadiy Paronyan authored
      * Validate encoding of extrinsics passed to runtime
      
      * Bump codec version explicitly
      d0ab405f
    • Nikolay Volf's avatar
      add network propagated metrics (#6438) · c8c16d18
      Nikolay Volf authored
      c8c16d18
    • Max Inden's avatar
      client/authority-discovery: Compare PeerIds and not Multihashes (#6414) · 4c67aeec
      Max Inden authored
      In order to tell whether an address is the local nodes address the
      authority discovery module previously compared the Multihash within the
      `p2p` Multiaddr protocol.
      
      rust-libp2p recently switched to a new PeerId representation (see [1]).
      Multihashes of the same PeerId in the new and the old format don't
      equal.
      
      Instead of comparing the Multihashes, this patch ensures the module
      compares the PeerIds
      
      [1] https://github.com/libp2p/rust-libp2p/issues/555
      4c67aeec
    • Bastian Köcher's avatar
      Update sync chain info on own block import (#6424) · 26aec420
      Bastian Köcher authored
      Before we only updated the chain info of sync when we have imported
      something using the import queue. However, if you import your own
      blocks, this is not done using the import queue and so sync is not
      updated. If we don't do this, it can lead to sync switching to "major
      sync" mode because sync is not informed about new blocks. This
      especially happens on Cumulus, where a collator is selected multiple
      times to include its block into the relay chain and thus, sync switches
      to major sync mode while the node is still building blocks.
      26aec420
    • Cecile Tonglet's avatar
      More descriptive error message when invalid slot duration is used (#6430) · a2c493d4
      Cecile Tonglet authored
      * Initial commit
      
      Forked at: d735e4d0
      No parent branch.
      
      * Errors if slot_duration is zero
      
      * Errors if slot_duration is zero
      
      * Revert "Errors if slot_duration is zero"
      
      This reverts commit a9e9820e
      
      .
      
      * Update client/consensus/slots/src/lib.rs
      
      Co-authored-by: default avatarBastian Köcher <[email protected]>
      a2c493d4
    • Bastian Köcher's avatar
      Track last blocks in informant display (#6429) · 97583766
      Bastian Köcher authored
      This implements tracking of the last seen blocks in informant display
      to prevent printing the import message twice. In Cumulus we first import
      blocks as part of the block building with `new_best == false` and set
      the best block after we know which one was included by the relay chain.
      This leads to printing the import messages two times. This pr solves the
      problem by track the latest seen blocks to not print the message twice.
      97583766
  8. Jun 18, 2020
    • Pierre Krieger's avatar
      7a4bd762
    • Rakan Alhneiti's avatar
      Babe VRF Signing in keystore (#6225) · 9b08492e
      Rakan Alhneiti authored
      * Introduce trait
      
      * Implement VRFSigner in keystore
      
      * Use vrf_sign from keystore
      
      * Convert output to VRFInOut
      
      * Simplify conversion
      
      * vrf_sign secondary slot using keystore
      
      * Fix RPC call to claim_slot
      
      * Use Public instead of Pair
      
      * Check primary threshold in signer
      
      * Fix interface to return error
      
      * Move vrf_sign to BareCryptoStore
      
      * Fix authorship_works test
      
      * Fix BABE logic leaks
      
      * Acquire a read lock once
      
      * Also fix RPC acquiring the read lock once
      
      * Implement a generic way to construct VRF Transcript
      
      * Use make_transcript_data to call sr25519_vrf_sign
      
      * Make sure VRFTranscriptData is serializable
      
      * Cleanup
      
      * Move VRF to it's own module
      
      * Implement & test VRF signing in testing module
      
      * Remove leftover
      
      * Fix feature requirements
      
      * Revert removing vec macro
      
      * Drop keystore pointer to prevent deadlock
      
      * Nitpicks
      
      * Add test to make sure make_transcript works
      
      * Fix mismatch in VRF transcript
      
      * Add a test to verify transcripts match in babe
      
      * Return VRFOutput and VRFProof from keystore
      9b08492e
    • Pierre Krieger's avatar
      44978b9b
    • Arkadiy Paronyan's avatar
      Revert "Block packet size limit" · 0bb3001a
      Arkadiy Paronyan authored
      This reverts commit 9a5892e1.
      0bb3001a
    • Arkadiy Paronyan's avatar
      Block packet size limit · 9a5892e1
      Arkadiy Paronyan authored
      9a5892e1
    • mattrutherford's avatar
      Runtime interface to add support for tracing from wasm (#6381) · 81ba3e28
      mattrutherford authored
      
      
      * Add span recording to tracing implementation
      
      * Add tracing proxy
      
      * switch to rustc_hash::FxHashMap
      
      * Replace lazy_static and hashmap with thread_local and vec.
      
      * fix marking valid span as invalid while removing invalid spans
      
      * refactor, add wasm_tracing module in `support`
      
      * update registered spans
      
      * tidy up
      
      * typos
      
      * refactor
      
      * update flag name to signal lost trace - `is_valid_trace`
      
      * update flag name to signal lost trace - `is_valid_trace`
      
      * update docs
      
      * update docs
      
      * Use tracing Field recording to store the actual `name` and `target`
      from wasm traces.
      
      * fix debug log in subscriber + small refactor
      
      * add tests
      
      * handle misuse in case trying to exit span not held
      
      * Implement filter for wasm traces, simplify field recording for primitive types
      
      * remove superfluous warning
      
      * update docs
      
      * Update primitives/tracing/src/proxy.rs
      
      Co-authored-by: default avatarKian Paimani <[email protected]>
      
      * Apply suggestions from code review
      
      Co-authored-by: default avatarBastian Köcher <[email protected]>
      
      * update docs, apply suggestions
      
      * move Proxy from thread_local to `Extension`, rename macro
      
      * fix test
      
      * unify native & wasm span macro calls
      
      * implement wasm tracing control facility in primitives and frame
      
      * add cli flag `--wasm-tracing`
      
      * fix
      
      * switch to `Option<u4>` (possible performance degradation), switch
      to static mut bool
      
      * performance improvement using u64 vs Option<u64>
      
      * performance improvement moving concat to client
      
      * update docs
      
      * Update client/cli/src/params/import_params.rs
      
      Co-authored-by: default avatarCecile Tonglet <[email protected]>
      
      * performance improvement
      
      * Revert "performance improvement"
      
      This reverts commit cff0aa26
      
      .
      
      * small refactor
      
      * formatting
      
      * bump impl_version
      
      * Update client/cli/src/config.rs
      
      Co-authored-by: default avatarBastian Köcher <[email protected]>
      
      * update docs
      
      * small fixes, remove pub static
      
      * nit
      
      * add integration tests and refactor Subscriber
      
      * tests
      
      * revert formatting
      
      * try fix test that works locally but not in CI
      
      * try fix test that works locally but not in CI
      
      * debug test that works locally but not in CI
      
      * fix test that works locally but not in CI
      
      * remove pub visibility from bool in runtime
      
      * make TracingSpanGuard #[cfg(not(feature = "std"))], update docs, comments
      
      * make TracingProxy drop implementation conditional on !empty state
      
      * add docs for TraceHandler
      
      * remove blank line
      
      * update expect message
      
      * update tests
      
      * rename cli option to tracing_enable_wasm
      
      * rename cli option to tracing_enable_wasm
      
      * fix
      
      * ensure wasm-tracing features are wasm only
      
      * bump impl_version
      
      * bump impl_version
      
      * add `"pallet-scheduler/std"` to `[features]` `std` in node/runtime
      
      * refactor service to remove sp_tracing dependency
      
      * refactor: line width, trait bounds
      
      * improve LogTraceHandler output
      
      * fix test
      
      * improve tracing log output
      
      * Apply suggestions from code review
      
      * Apply suggestions from code review
      
      Co-authored-by: default avatarBastian Köcher <[email protected]>
      
      * swap wasm indication from trace name to a separate value
      
      * Update client/tracing/src/lib.rs
      
      * add docs
      
      * remove runtime features
      
      remove wasm_tracing option from CLI
      
      remove wasm_tracing flag from ProfilingSubscriber
      
      Co-authored-by: default avatarMatt Rutherford <[email protected]>
      Co-authored-by: default avatarKian Paimani <[email protected]>
      Co-authored-by: default avatarBastian Köcher <[email protected]>
      Co-authored-by: default avatarCecile Tonglet <[email protected]>
      81ba3e28
    • Pierre Krieger's avatar
      a2653e87
  9. Jun 16, 2020
    • Svyatoslav Nikolsky's avatar
      fix BlockAttributes encoding (#6281) · db8916a4
      Svyatoslav Nikolsky authored
      db8916a4
    • Xiliang Chen's avatar
      add system_dryRun (#6300) · 02e77d20
      Xiliang Chen authored
      * add system_dryRun
      
      * fix build error
      
      * delete unneeded code
      
      * return ApplyExtrinsicResult directly
      
      * line width
      
      * mark dry run unsafe
      
      * line width
      
      * fix test
      
      * add test
      
      * update comment
      02e77d20
    • Pierre Krieger's avatar
      Use /dns/ instead of /dns4/ (#6369) · 18237825
      Pierre Krieger authored
      18237825
    • Max Inden's avatar
      client/authority-discovery: Don't add own address to priority group (#6370) · 288ead00
      Max Inden authored
      * client/authority-discovery: Don't add own address to priority group
      
      In the scenario of a validator publishing the address of its sentry node
      to the DHT, said sentry node should not add its own Multiaddr to the
      peerset "authority" priority group.
      
      Related to 70cfeffe.
      
      * client/authority-discovery: Remove unused import PeerId
      
      * client/authority-discovery/tests: Add tcp protocol to multiaddresses
      288ead00
    • Ashley's avatar
      Split the service initialisation up into seperate functions (#6332) · 6199d86c
      Ashley authored
      * Seperate out the complexity in ServiceBuilder::build_common into seperate functions
      
      * Fix line widths
      
      * Move some functions to their respective crates
      6199d86c
    • Bernhard Schuster's avatar
      historical slashing w ocw w adhoc tree creation (#6220) · 10959200
      Bernhard Schuster authored
      
      
      * draft
      
      * steps
      
      * chore: fmt
      
      * step by step
      
      * more details
      
      * make test public
      
      * refactor: split into on and offchain
      
      * test stab
      
      * tabs my friend
      
      * offchain overlay: split key into prefix and true key
      
      Simplifies inspection and makes key actually unique.
      
      * test: share state
      
      * fix & test
      
      * docs improv
      
      * address review comments
      
      * cleanup test chore
      
      * refactor, abbrev link text
      
      * chore: linewidth
      
      * fix prefix key split fallout
      
      * minor fallout
      
      * minor changes
      
      * addresses review comments
      
      * rename historical.rs -> historical/mod.rs
      
      * avoid shared::* wildcard import
      
      * fix: add missing call to store_session_validator_set_to_offchain
      
      * fix/compile: missing shared:: prefix
      
      * fix/test: flow
      
      * fix/review: Apply suggestions from code review
      
      Co-authored-by: default avatarTomasz Drwięga <[email protected]>
      
      * fix/review: more review comment fixes
      
      * fix/review: make ValidatorSet private
      
      * fix/include: core -> sp_core
      
      * fix/review: fallout
      
      * fix/visbility: make them public API
      
      Ref #6358
      
      * fix/review: review changes fallout - again
      
      Co-authored-by: default avatarBernhard Schuster <[email protected]>
      Co-authored-by: default avatarTomasz Drwięga <[email protected]>
      10959200
    • Demi Obenour's avatar
      Add IPC support (#6348) · 69070184
      Demi Obenour authored
      This is useful for both security and performance reasons. IPC is faster
      than TCP, and it is subject to OS access controls.
      69070184
  10. Jun 12, 2020
    • Bastian Köcher's avatar
      Fix transaction pool event sending (#6341) · 384be7e2
      Bastian Köcher authored
      This pr fixes a bug with the transaction pool not sending certain events
      like finalized and also fixes the order of events. The problem with the
      finalized event was that we did not extracted pruned extrinsics if there
      were not ready transactions in the pool. However this is wrong, if we
      have a re-org, a tx is clearly not ready anymore and we still need to
      send a pruned event for it because it is in a new block included. This
      also lead to sending "ready" events and tx being re-validated. The
      listener also only send the "finalized" event if it has seen a block as
      being included, which did not happen before with the old code.
      
      The second fix of the pr is the order of events. If we prune and retract the
      same transaction in the same block, we first need to send the "retract"
      event and after that the "pruned" event, because finalization takes
      longer and this would lead to the UI showing "retract" while it actually
      is included.
      384be7e2
    • André Silva's avatar
      client: use appropriate ExecutionContext for initial sync / regular import (#6180) · 0dc66347
      André Silva authored
      * client: use appropriate ExecutionContext for sync/import
      
      * client: remove dead code
      
      * client: ExecutionContext: distinguish between own and foreign imports
      
      * client: fix cli parameter doc
      
      * Revert "client: ExecutionContext: distinguish between own and foreign imports"
      
      This reverts commit 0fac1152.
      
      * primitives: add docs for ExecutionContext
      
      * cli: execution strategy docs
      
      * cli: use different execution context for importing block on validator
      
      * cli: remove defaults from execution context flags
      0dc66347
  11. Jun 11, 2020