Skip to content
  1. Aug 31, 2020
  3. Aug 29, 2020
  5. Aug 28, 2020
    • Max Inden's avatar
      client/*: Treat protocol name as str and not [u8] (#6967) · beb74f49
      Max Inden authored 
      * client/*: Treat protocol name as str and not [u8]

Notification protocol names are in practice always valid utf8 strings.
Instead of treating them as such in the type system, thus far they were
casted to a [u8] at creation time.

With this commit protocol names are instead treated as valid utf8
strings throughout the codebase and passed as `Cow<'static, str>`
instead of `Cow<'static, [u8]>`. Among other things this eliminates the
need for string casting when logging.

* client/network: Don't allocate when protocol name is borrowed
      beb74f49
  7. Aug 27, 2020
  9. Aug 26, 2020
  11. Aug 24, 2020
  13. Aug 23, 2020
  15. Aug 22, 2020
  17. Aug 21, 2020
  19. Aug 20, 2020
    • Pierre Krieger's avatar
      Remove the legacy requests-answering protocols (#6709) · 8b0a5ba7
      Pierre Krieger authored 
      Co-authored-by: parity-processbot <>
      8b0a5ba7
    • Pierre Krieger's avatar
      Try un-ignore flaky test (#6923) · 83aa4182
      Pierre Krieger authored
      83aa4182
    • Benjamin Kampmann's avatar
      prepping for releasing rc6 (#6922) · be8bb186
      Benjamin Kampmann authored 
      * Bump version

* update test-utils crates to be ready for publishing

* adding changelog

* Adding automaticly generated READMEs

* fixing versions

* another version mishap
      2 tags
      be8bb186
    • Cecile Tonglet's avatar
      Clean shutdown for subcommands (#6909) · 9c679b37
      Cecile Tonglet authored
      9c679b37
    • Web3 Philosopher's avatar
      Merge Subkey into sc-cli (#4954) · 6e098a10
      Web3 Philosopher authored 
      * draft

* revert

* WIP

* all that remains is tests

* update Cargo.lock

* tests WIP

* WIP refactor node-template-runtime and node-runtime

* implments sc_cli::RuntimeAdapter for node_template_runtime::Runtime

* final draft

* fix update_config for subcommands

* proper AccountId decoding

* test-runtime tests

* revert

* move RuntimeAdapter to cli-utils

* use &'static str for TryFrom::<&'a str>::Error for Ss58AddressFormat

* tests

* add frame-system to sc-cli dev-dependencies

* add frame-system to sc-cli dev-dependencies

* fix ui test

* wip

* fixed inspect test

* bump impl version

* bump impl version, fixx spaces remove todos

* pallet-balances-cli, rustc for some reason cannot resolve pallet_balances_cli in node-cli 😩

* wip

* Subcommand::run takes &self

* can't believe i missed that 🤦🏾‍♂️

* bump wasm-bindgen for some reason

* adds key subcommand, rename generate-node-key to generate-node-id

* cargo update and crossed fingers 🤞🏽



* update ui test

* update more ui tests

* should be all good now

* revert subkey change

* revert subkey change

* adds frame-utilities-cli

* Apply suggestions from code review

Co-authored-by: default avatarBenjamin Kampmann <[email protected]>

* removes frame from sc-cli, fix license

* my editor and ci disagrees on line width

* bump spec version

* turn off default features for parity-scale-codec

* enable full_crypto feature for sp-core in cli-utils

* merge frame-utilities-cli with pallet-balances-cli

* remove full_crypto feature from sp_core in cli-utils

* bump Cargo.lock

* cli-utils -> frame-utils

* rename BlockNumber to GenericNumber, fix spaces

* fix spaces

* construct additional_signed manually

* sign test

* remove unused vars

* implement subkey with frame-utilities-cli and sc_cli

* fix moduleid test

* CI and clion disagree on line widths

* adds associated Params type to SignedExtensionProvider

* Apply suggestions from code review

Co-authored-by: default avatarBenjamin Kampmann <[email protected]>

* move some code around

* removes unneccesary generic params

* moves module_id back to frame_utilities_cli

* Apply suggestions from code review

Co-authored-by: default avatarBenjamin Kampmann <[email protected]>
Co-authored-by: default avatarBastian Köcher <[email protected]>

* remove print_ext

* remove MaybeDisplay from pallet_balances::Trait::Balance

* a lot of stuff tbh

* adds ExtrasParamsBuilder

* remove tests for ModuleIdCmd

* address comments from PR

* bump Cargo.lock

* manually insert key into keystore

* remove unnecessary SharedParams

* add validation to vanity pattern, remove unused arg

* remove SharedParams from Sign, Vanity, Verify

* remove SharedParams from ModuleIdCmd, remove expect from Verify, new line to Cargo.toml

* remove SharedParams from InsertCmd

* 🤦🏾

‍♂️

* deleted prometheus.yml

* move a few things around

* fix vanity test

Co-authored-by: default avatarBenjamin Kampmann <[email protected]>
Co-authored-by: default avatarBastian Köcher <[email protected]>
Co-authored-by: default avatarBenjamin Kampmann <[email protected]>
      6e098a10
  21. Aug 19, 2020
  23. Aug 18, 2020
    • Roman Borschel's avatar
      Add support for sourced metrics. (#6895) · f8c83bd5
      Roman Borschel authored 
      

* Add support for sourced metrics.

A sourced metric is a metric that obtains its values
from an existing source, rather than the values being
independently recorded. It thus allows collecting
metrics from existing counters or gauges without
having to duplicate them in a dedicated prometheus
counter or gauge (and hence another atomic value).

The first use-case is to feed the bandwidth counters
from libp2p directly into prometheus.

* Tabs, not spaces.

* Tweak bandwidth counter registration.

* Add debug assertion for variable labels and values.

* Document monotonicity requirement for sourced counters.

* CI

* Update client/network/src/service.rs

Co-authored-by: default avatarMax Inden <[email protected]>

Co-authored-by: default avatarMax Inden <[email protected]>
      f8c83bd5
  25. Aug 17, 2020
  27. Aug 15, 2020
  29. Aug 14, 2020
    • Max Inden's avatar
      client/authority-discovery: Revert query interval change (#6897) · eec7d713
      Max Inden authored 
      Revert the accidental query interval change from every one minute back
to every 10 minutes.
      eec7d713
    • Roman Borschel's avatar
      Update to libp2p-0.23. (#6870) · 13b0650c
      Roman Borschel authored 
      * Update to libp2p-0.23.

Thereby incorporate bandwidth measurement along the
lines previously done by libp2p itself.

* Tweak dependencies for wasm32 compilation.

For wasm32 we need to enable unstable features to
make `task::Builder::local` available.

* Simplify dependencies.

* Simplify.

Leave the calculation of bytes sent/received per second
to the outer layers of the code, subject to their own
individual update intervals.

* Cleanup

* Re-add lost dev dependency.

* Avoid division by zero.

* Remove redundant metric.

* Enable sending of noise legacy handshakes.

* Add comment about monotonic gauge.

* CI
      13b0650c
  31. Aug 13, 2020
  33. Aug 12, 2020
    • Max Inden's avatar
      client/authority-discovery: Introduce AuthorityDiscoveryService (#6760) · 473a23f4
      Max Inden authored 
      * client/authority-discovery: Rename AuthorityDiscovery to XXXWorker

* client/authority-discovery: Introduce AuthorityDiscoveryService

Add a basic `AuthorityDiscoveryService` implementation which enables
callers to get the addresses for a given `AuthorityId` from the local
cache.

* client/authority-discovery: Split into worker and service mod

Move `Service` and `Worker` to their own Rust modules resulting in the
following file structure.

├── build.rs
├── Cargo.toml
└── src
    ├── error.rs
    ├── lib.rs
    ├── service.rs
    ├── tests.rs
    ├── worker
    │   ├── addr_cache.rs
    │   ├── schema
    │   │   └── dht.proto
    │   └── tests.rs
    └── worker.rs

* client/authority-discovery: Cache PeerId -> AuthorityId mapping

* client/authority-discovery: Update priority group on interval

Instead of updating the authority discovery peerset priority group each
time a new DHT value is found, update it regularly on an interval.

This removes the need for deterministic random selection. Instead of
trying to return a random stable set of `Multiaddr`s, the `AddrCache`
now returns a random set on each call.

* client/authority-discovery: Implement Service::get_authority_id

* client/authority-discovery: Use HashMap instead of BTreeMap

* client/authority-discovery: Rework priority group interval

* client/authority-discovery: Fix comment

* bin/node/cli: Update authority discovery constructor

* client/authority-discovery: Fuse from_service receiver

* client/authority-discovery: Remove Rng import

* client/authority-discovery: Ignore Multiaddr without PeerId

* client/authority-discovery/service: Add note on returned None

* client/authority-discovery/addr_cache: Replace double clone with deref
      473a23f4
    • mattrutherford's avatar
      Implement tracing::Event handling & parent_id for spans and events (#6672) · 0c3cdf16
      mattrutherford authored 
      

* implement events handling, implement parent_id for spans & events

* add events to sp_io::storage

* update test

* add tests

* adjust limit

* let tracing crate handle parent_ids

* re-enable current-id tracking

* add test for threads with CurrentSpan

* fix log level

* remove redundant check for non wasm traces

* remove duplicate definition in test

* Adding conditional events API

* prefer explicit parent_id over current,

enhance test

* limit changes to client::tracing event implementation

* remove From impl due to fallback required on parent_id

* implement SPAN_LIMIT

change event log output

* change version of tracing-core

* update dependancies

* revert limit

* remove duplicate dependency

* Apply suggestions from code review

Co-authored-by: default avatarBastian Köcher <[email protected]>

Co-authored-by: default avatarMatt Rutherford <[email protected]>
Co-authored-by: default avatarBenjamin Kampmann <[email protected]>
Co-authored-by: default avatarBastian Köcher <[email protected]>
      0c3cdf16
    • Pierre Krieger's avatar
      Add a warning if users pass --sentry or --sentry-nodes (#6779) · f6d66db4
      Pierre Krieger authored 
      

* Add a warning if users pass --sentry or --sentry-nodes

* Apply suggestions from code review

Co-authored-by: default avatarMax Inden <[email protected]>

* Fix text

Co-authored-by: parity-processbot <>
Co-authored-by: default avatarMax Inden <[email protected]>
      f6d66db4
  35. Aug 11, 2020