This commit splits the `DoSlash` trait in two traits: `DoReward` and `DoSlash`

The reasons for it, is that we want reward based on the `total slashed amount`
but the entire amount doesn't necessarily be rewarded. Some part of the total
slashed amount might need to transmitted to some other part such as
`treasory`.

Thus, instead we return the total slash and `ReportSlashing` has to determine
what to do with the total slashed amount.

In other words, the concrete misconduct type determines what to do.

* Don't set `HEAP_PAGES` in `BasicExternalities`

* Fix test

This reverts commit fb28e115.

* Update schnorrkel to `0.7.0`

* Apply suggestions from code review

Co-Authored-By: DemiMarie-parity <[email protected]>

* Increase `spec_version`

* node: update BABE authority ids in staging testnet config

* node: update flaming fir chain spec

* babe: don't execute median algorithm

* babe: checked sub in median calculation

* node: bump impl_version to make ci happy

* babe: remove forbid dead_code

* Reorg test

* Fixed informant misreporting reorgs

* Update cache when reorg is caused by applying finality

* Test for finality reorg

* Simplified test

* Typo

Co-Authored-By: André Silva <[email protected]>

Partly due to interaction with #3191.

* Stop block import after error

* Better diagnostic on error

* srml-contracts: Forbid remaining uses of float types.

* Bump node runtime impl version.

* srml: babe: add expected block time constant

* srml: babe: expose epoch duration constant

* node: bump spec_version

* core: don't use moment type in test-runtime

* babe: add docs regarding c parameter

* Allow creating a ChainSpec from a Vec<u8>

* Line widths

* Embedded -> Binary

* Remove from_embedded

* CLI execution flag for import-blocks and factory.

* Fix minimum_balance bug with CLI factory.

Max Inden authored Jul 29, 2019 and Pierre Krieger committed Jul 29, 2019

* core/network: Fix bad import %s/runtime_primitives/sr_primitives/

* Cargo.lock: Update consensus-common-primitives parity-codec version

* core/consensus/common: Remove obsolete package path

* refactor sr_primitives.

* Fix try build error.

* Line-width

* Ui test.

* Final fixes.

* Fix build again.

* bring back ui test.

* Fix unsigned import.

* Another ui fix.

* Also refactor substrate-primitives

* Fix benchmarks.

* Fix doc test.

* fix doc tests

The goal of the commit is to be able to retrieve the current set of
authorities without needing to know the concrete consensus mechanism in
place.

In order to achieve the above this commit introduces the
`core/consensus/common/primitives` crate, declaring the `ConsensusApi`
runtime API. In addition it implements the above mentioned trait
definition in `node/runtime` by returning the current authorities of the
BABE consensus mechanism.

Jim Posen authored Jul 29, 2019 and Sergey Pepyakin committed Jul 29, 2019

* srml-contracts: Change Ext interface to pass-by-value.

* srml-contracts: Refactor ExecutionContext to reduce duplication.

* srml-contracts: Refactor contracts Module to reduce duplication.

* Bump node runtime impl version.

* Switch consensus-common to new futures

* Fix tests

* More tests fixing

* Make Proposer, OnSlot and SyncOracle mut

* Make the Environment mut as well

* Fix test

* Fix Babe tests

* Babe fixes

* Fix CLI service tests

* Fix Babe tests

* Remove unnecessary trait bound

* Inline the code of BlockBuilder and AuthoringApi

* Remove warning lint

* Bounds simplification

* Imports simplification

* Don't panic on bad generated block

* Code style

* Add doc example

* Remove dependency on aura

* Order dependencies alphabetically

* Minor style

* Minor cleanup in native_executor.rs

* Fix tests

* fixed debug flags

* test everything works

* test everything works 2

* sections are rewritten

* everything works

* node: update babe parameters to target 6 second block time

* node: add comment on MILLISECS_PER_BLOCK constant

* Switch consensus-common to new futures

* Fix tests

* More tests fixing

* Pass the block_import by value when importing

* Rewrite the multi-blocks import as a future

* Add some comments

* Add a delay between each block

* Fix Babe tests

* Reverse white space change

* WIP to release subkey im docker

* debug run with publishing

* debug build

* debug build 2

* easier sync

* fix the template

* fix typo

* node: tabify constants file

* node: define minimum period and slot duration in milliseconds

* core: srml: use milliseconds for timestamp resolution

* core: update slot_duration to millis in tests

* node: bump spec_version

* node: fix integration test

* node: fix executor test

* Update node/runtime/src/lib.rs

Co-Authored-By: Kian Peymani <[email protected]>

* node: fix docs on timestamp resolution

* node: add docs on u64 for millis

* Make local_storage_compare_and_set take Option for old_value

* Adapt srml/im-online to API changes

* Bump version

* Bump version again

* Replace match

* Add test from original bug report

Original is from @pepyakin

 in 3d7b27f3421818e8d6de568e02fbc2947a06246b.
I adapted it to work with the latest master.

* No longer cleanup module instance

* Replace runtime cache with synchronous clone

* Fix test

* Preserve initial runtime memory and restore it on fetch

* Remove leftover comment

* Fix style

* Improve variable naming

* Replace get_into() with get()

* Handle missing memory export better

* Return earlier when creating runtime first time

* Improve comments

* fmt

* Fix #2967.

* Eradicate `code` from `Error::InvalidCode`

* tidy

* A state snapshot doc.

* Store multiple runtimes by hash.

* Get rid of deref.

* Docs

* Use Self for instantiate_module

* REVERT ME

* Should be ok

* Commit

* Remove dbg

* Use fast-memory's erase

* Clean and undo hacks.

* Introduce a dedicated error for heap_base

* Ban the start function.

* Clean, docs and refactor

* Add rustflags.

* Update Cargo.lock

* Apply Basti's suggestions

Co-Authored-By: Bastian Köcher <[email protected]>

* Rename allocates_huge_stack_array

* Extend TestClientBuilder with set_heap_pages

* Update the test.

* Update core/executor/src/wasm_executor.rs

Co-Authored-By: Bastian Köcher <[email protected]>

* Update core/executor/src/wasm_runtimes_cache.rs

Co-Authored-By: Bastian Köcher <[email protected]>

* Update core/executor/src/error.rs

Co-Authored-By: Bastian Köcher <[email protected]>

* Update core/executor/src/error.rs

Co-Authored-By: Bastian Köcher <[email protected]>

* Fix tests.

* Update cargo-lock

* Use wasmi master

* Use master wasmi

* Move tests.

* Use wasmi crates.io

* Update Cargo.lock

* Fix build.rs

* Bump runtime version

* Revert initial_heap_pages renaming

* Bump wasmi up to 0.5.0

* Bump runtime version

* Don't restore an instance every now and then

* Update core/executor/src/wasm_runtimes_cache.rs

Co-Authored-By: DemiMarie-parity <[email protected]>

* Propagate error in CacheError

* Clarify the get_heap_base call in instantiation

* Supply --export=__heap_base

See https://reviews.llvm.org/D62744



Co-authored-by: Jim Posen <[email protected]>

* Bump version.

* Use combinators for segments.

* Fix build.rs

* Fix build.rs for runtime-test

* srml: staking: track session index of current era start

* node: bump spec_version