1. Mar 11, 2020
  2. Mar 05, 2020
  3. Mar 02, 2020
  4. Feb 25, 2020
    • Cecile Tonglet's avatar
      Fix: CI failing for some CLI tests (#5043) · a64dd527
      Cecile Tonglet authored
      * Initial commit
      
      Forked at: 41bb2193
      Parent branch: origin/master
      
      * Increase killing grace period of CLI tests and display more info
      
      * Use --dev everywhere possible
      
      * Put pruning mode to its own params struct
      
      * Add pruning params to export-blocks command
      
      * Added missing file
      
      * Removed not-dev mode in tests
      
      * Add pruning mode to the revert command
      
      * Decrease killing grace period again
      
      * Move back unsafe_pruning to import_params
      
      * Applied proposed changes
      a64dd527
  5. Feb 21, 2020
    • Cecile Tonglet's avatar
      Add tests & Service's Configuration has optional fields that shouldn't be optional (#4842) · 97ad8026
      Cecile Tonglet authored
      Related to #4776 
      Related to https://github.com/paritytech/polkadot/pull/832
      
      To summarize the changes:
      1. I did not manage to validate with types the service's Configuration. But I did reduce the possibility of errors by moving all the "fill" functions to their respective structopts
      2. I split params.rs to multiple modules: one module params for just CLI parameters and one module commands for CLI subcommands (and RunCmd). Every command and params are in their own file so things are grouped better together and easier to remove
      3. I removed the run and run_subcommand helpers as they are not helping much anymore. Running a command is always a set of 3 commands: 1. init 2. update config 3. run. This still allow the user to change the config before arguments get parsed or right after.
      4. I added tests for all subcommands.
      5. [deleted]
      
      Overall the aim is to improve the situation with the Configuration and the optional parameters, add tests, make the API more consistent and simpler.
      97ad8026