• Cecile Tonglet's avatar
    CLI: refactoring: remove Options from sc_service::Configuration's fields (#5271) · b0efaa2c
    Cecile Tonglet authored
    * WIP
    
    Forked at: 2afecf81
    Parent branch: origin/master
    
    * Rename IntoConfiguration to CliConfiguration
    
    * Renamed into_configuration to create_configuration
    
    * WIP
    
    Forked at: 2afecf81
    Parent branch: origin/master
    
    * WIP
    
    Forked at: 2afecf81
    Parent branch: origin/master
    
    * Move keystore params to its own module
    
    * Use in-memory keystore even for build-spec
    
    * Enforce proper value for node name
    
    * dev_key_seed
    
    * Telemetry endpoints
    
    * rustfmt
    
    * Converted all RunCmd
    
    * rustfmt
    
    * Added export-blocks
    
    * Missed something
    
    * Removed config_path in NetworkConfiguration (not used)
    
    * Fixed warnings
    
    * public_addresses is used but never set, keeping it
    
    * Merge Configuration.node and NetworkConfiguration.node_name
    
    ...because they are the same thing
    
    * Added: import-blocks
    
    * Adding a proc_macro to help impl SubstrateCli
    
    * WIP
    
    Forked at: 2afecf81
    Parent branch: origin/master
    
    * WIP
    
    Forked at: 2afecf81
    Parent branch: origin/master
    
    * WIP
    
    Forked at: 2afecf81
    Parent branch: origin/master
    
    * Re-export spec_factory from sc_cli
    
    * Re-added all the commands
    
    * Refactored node_key_params
    
    * Fixed previous refucktoring
    
    * Clean-up and removed full_version()
    
    * Renamed get_is_dev to not confuse with Configuration field
    
    * Fixed sc-cli-derive example
    
    * Fixing tests
    
    * Fixing tests and removing some (will re-add later)
    
    * Fixing more tests
    
    * Removes the need of type parameter
    
    * Converting bin/node and simplifying API
    
    * Converting more
    
    * Converting last command
    
    * WIP
    
    Forked at: 2afecf81
    Parent branch: origin/master
    
    * Fixing tests and added default for WasmExecutionMethod
    
    * Fixing stuff
    
    * Fixed something I broke oops
    
    * Update Cargo.lock
    
    * Moving things around
    
    * Convert everything to Result
    
    * Added new macros to simplify the impl of CliConfiguration
    
    * Added a macro to generate CliConfiguration automatically for subcommands
    
    * Revert... too many macros (this one is not really useful)
    
    This reverts commit 9c516dd3
    
    .
    
    * Renamed is_dev to get_is_dev
    
    Good enough for now
    
    * Fixed name roles (this is plural, not singular)
    
    * Clean-up
    
    * Re-export NodeKeyConfig and TelemetryEndpoints from sc_service
    
    * Improve styling/formatting
    
    * Added copyrights
    
    * Added doc and fixed warnings
    
    * Added myself to code owners
    
    * Yes it is needed according to the history
    
    * Revert formatting
    
    * Fixing conflict
    
    * Updated build.rs
    
    * Cargo.lock
    
    * Clean-up
    
    * Update client/cli-derive/Cargo.toml
    
    Co-Authored-By: default avatarSeun Lanlege <[email protected]>
    
    * Fail if using proc_macro and build.rs is not set properly
    
    * Dropped all get_ in front of methods
    
    * Clean-up
    
    * Fixing proc macro missing env var
    
    * Get the configuration inside the Runtime (needed for polkadot)
    
    * Clean-up
    
    * Get is_dev from argument like the others
    
    * Get chain ID instead of chain spec from shared params
    
    * &self is passed to spec_factory/load_spec
    
    * Wrong text
    
    * Fix example
    
    * Officialize macro and made a cool doc
    
    * Renamed spec_factory to load_spec (substrate_cli_configuration)
    
    * Removed not so useful ChainSpec
    
    * Renamed SubstrateCLI to SubstrateCli
    
    * Added changelog for impl_version being full now
    
    * Renamed Runtime to Runner
    
    * Update changelog to show example
    
    * Removed option on database cache size
    
    * WIP
    
    Forked at: 2afecf81
    Parent branch: origin/master
    
    * Fix on removal of option
    
    * typo
    
    * Clean-up imports
    
    * Added info in Cargo.toml
    
    * typo
    
    * remarks
    
    * Moved function for build.rs to substrate-build-script-utils
    
    * Fixed example & test of cli-derive
    
    * Moved function for build.rs to substrate-build-script-utils
    
    * Renamed substrate_cli_configuration to substrate_cli oops
    
    It implements SubstrateCli not CliConfiguration!
    
    * Added documentation and wrapper macro
    
    * Removed option on database cache size
    
    * Removed option on database cache size
    
    * Clean-up
    
    * Reduce risk of errors due to typos
    
    * Removed option on database cache size
    
    * Added NOTE as suggested
    
    * Added doc as suggested
    
    * Fixed test
    
    * typo
    
    * renamed runtime to runner
    
    * Fixed weird argument
    
    * More commas
    
    * Moved client/cli-derive to client/cli/derive
    
    * Added 7 tests for the macros
    
    * Improve error message
    
    * Upgrade assert_cmd
    
    * Fixing missing stuff
    
    * Fixed unused import
    
    * Improve SubstrateCli doc
    
    * Applied suggestions
    
    * Fix and clean-up imports
    
    * Started replacing macros WIP
    
    * WIP
    
    Forked at: 2afecf81
    Parent branch: origin/master
    
    * WIP
    
    Forked at: 2afecf81
    Parent branch: origin/master
    
    * WIP
    
    Forked at: 2afecf81
    Parent branch: origin/master
    
    * Started removing substrate_cli
    
    * WIP
    
    Forked at: 2afecf81
    Parent branch: origin/master
    
    * WIP
    
    Forked at: 2afecf81
    Parent branch: origin/master
    
    * WIP
    
    Forked at: 2afecf81
    
    
    Parent branch: origin/master
    
    * fixed bug introduced while refactoring
    
    * Renamed NetworkConfigurationParams to NetworkParams for consistency sake
    
    * Fixed test
    
    * Update client/cli/src/commands/runcmd.rs
    
    Co-Authored-By: default avatarBastian Köcher <[email protected]>
    
    * Update client/cli/src/commands/runcmd.rs
    
    Co-Authored-By: default avatarBastian Köcher <[email protected]>
    
    * Update client/cli/src/commands/export_blocks_cmd.rs
    
    Co-Authored-By: default avatarBastian Köcher <[email protected]>
    
    * Update client/cli/src/commands/check_block_cmd.rs
    
    Co-Authored-By: default avatarBastian Köcher <[email protected]>
    
    * Update bin/node/cli/src/command.rs
    
    Co-Authored-By: default avatarBastian Köcher <[email protected]>
    
    * Update bin/node/cli/src/command.rs
    
    Co-Authored-By: default avatarBastian Köcher <[email protected]>
    
    * Update client/cli/src/commands/export_blocks_cmd.rs
    
    Co-Authored-By: default avatarBastian Köcher <[email protected]>
    
    * Revert "Update client/cli/src/commands/export_blocks_cmd.rs"
    
    This reverts commit 59067769.
    
    * Revert "Update client/cli/src/commands/check_block_cmd.rs"
    
    This reverts commit f705f42b.
    
    * Revert "Update client/cli/src/commands/export_blocks_cmd.rs"
    
    This reverts commit 8d57c055.
    
    * Revert "Update client/cli/src/commands/runcmd.rs"
    
    This reverts commit 93e74cf5.
    
    * Revert "Update client/cli/src/commands/runcmd.rs"
    
    This reverts commit 11d527ba
    
    .
    
    * Update client/cli/src/commands/export_blocks_cmd.rs
    
    Co-Authored-By: default avatarBastian Köcher <[email protected]>
    
    * Update client/cli/src/commands/import_blocks_cmd.rs
    
    Co-Authored-By: default avatarBastian Köcher <[email protected]>
    
    * Update client/cli/src/commands/purge_chain_cmd.rs
    
    Co-Authored-By: default avatarBastian Köcher <[email protected]>
    
    * Changed ::sc_cli to $crate in the macro
    
    * fixed tests
    
    * fixed conflicts
    
    * Fixing test
    
    * Update client/cli/src/commands/purge_chain_cmd.rs
    
    Co-Authored-By: default avatarBastian Köcher <[email protected]>
    
    * Update client/cli/src/params/pruning_params.rs
    
    Co-Authored-By: default avatarBastian Köcher <[email protected]>
    
    * Remove comment as suggested
    
    * Apply suggestion
    
    * Update client/cli/src/commands/purge_chain_cmd.rs
    
    Co-Authored-By: default avatarBastian Köcher <[email protected]>
    
    * Update client/cli/src/commands/purge_chain_cmd.rs
    
    Co-Authored-By: default avatarBastian Köcher <[email protected]>
    
    * Update client/cli/src/commands/purge_chain_cmd.rs
    
    Co-Authored-By: default avatarBastian Köcher <[email protected]>
    
    * Update utils/frame/benchmarking-cli/src/command.rs
    
    Co-Authored-By: default avatarBastian Köcher <[email protected]>
    
    * Update client/cli/src/runner.rs
    
    Co-Authored-By: default avatarBastian Köcher <[email protected]>
    
    * Update client/cli/src/runner.rs
    
    Co-Authored-By: default avatarBastian Köcher <[email protected]>
    
    * Update client/cli/src/runner.rs
    
    Co-Authored-By: default avatarBastian Köcher <[email protected]>
    
    * Update client/cli/src/params/pruning_params.rs
    
    Co-Authored-By: default avatarBastian Köcher <[email protected]>
    
    * Update client/cli/src/params/node_key_params.rs
    
    Co-Authored-By: default avatarBastian Köcher <[email protected]>
    
    * Update client/cli/src/params/network_params.rs
    
    Co-Authored-By: default avatarBastian Köcher <[email protected]>
    
    * Update client/cli/src/lib.rs
    
    Co-Authored-By: default avatarBastian Köcher <[email protected]>
    
    * Update client/cli/src/config.rs
    
    Co-Authored-By: default avatarBastian Köcher <[email protected]>
    
    * Added doc
    
    * Fixed error introduced after applying suggestion
    
    * Revert "Update client/cli/src/params/pruning_params.rs"
    
    This reverts commit 0574d06a
    
    .
    
    * Print error
    
    * Apply suggestions from code review
    
    * Remove useless Results
    
    * Fixed CI failing on polkadot approval
    
    Co-authored-by: default avatarSeun Lanlege <[email protected]>
    Co-authored-by: default avatarBastian Köcher <[email protected]>
    b0efaa2c