Some issues spotted (#145)
This PR lists some issues and suggested fixes for them (feel free to
pick them up separately and close this PR):
In addition to issues outlined in
https://github.com/paritytech/zombienet-sdk/issues/117#issuecomment-1867941395,
here are some issues spotted when writing
https://github.com/paritytech/disabling-e2e-tests:
- runtime genesis patch is applied incorrectly (extra `/genesis` pointer
shouldn't be added)
- malus accepts
[subcommands](https://github.com/paritytech/polkadot-sdk/blob/4c0e0e071355c1048d75fba538c96c35ac743547/polkadot/zombienet_tests/functional/0008-dispute-old-finalized.toml#L25),
having a command with spaces not supported, so I added a subcommand
support
- some types need to be exported in order to be able to reuse
setup/helper functions across multiple tests
- test cleanup doesn't always work (zombie polkadot processes - not
fixed here)
---------
Co-authored-by:
Javier Viola <363911+pepoviola@users.noreply.github.com>
Showing
- crates/configuration/src/relaychain.rs 5 additions, 5 deletionscrates/configuration/src/relaychain.rs
- crates/configuration/src/shared/node.rs 36 additions, 0 deletionscrates/configuration/src/shared/node.rs
- crates/examples/examples/0001-simple.toml 7 additions, 2 deletionscrates/examples/examples/0001-simple.toml
- crates/examples/examples/simple_network_example.rs 1 addition, 1 deletioncrates/examples/examples/simple_network_example.rs
- crates/orchestrator/src/generators/chain_spec.rs 8 additions, 9 deletionscrates/orchestrator/src/generators/chain_spec.rs
- crates/orchestrator/src/generators/command.rs 4 additions, 0 deletionscrates/orchestrator/src/generators/command.rs
- crates/orchestrator/src/network_spec/node.rs 10 additions, 0 deletionscrates/orchestrator/src/network_spec/node.rs
- crates/orchestrator/src/network_spec/relaychain.rs 2 additions, 2 deletionscrates/orchestrator/src/network_spec/relaychain.rs
- crates/orchestrator/src/shared/macros.rs 2 additions, 0 deletionscrates/orchestrator/src/shared/macros.rs
- crates/sdk/src/lib.rs 5 additions, 3 deletionscrates/sdk/src/lib.rs
Please register or sign in to comment