Skip to content
Snippets Groups Projects
Select Git revision
  • gh-readonly-queue/master/pr-7952-10d15dd1219b6124a265b8f9069916023e58b7ed protected
  • 8071
  • 8068
  • 8062
  • 8075
  • 6137
  • master default protected
  • 7995
  • 8058
  • 8074
  • 8063
  • gh-readonly-queue/master/pr-8059-7b74d9ecd5da768c762ecf4d6a362ae137e005af protected
  • gh-readonly-queue/master/pr-8059-c31ab2a246af0318a989ce6486f0bf8d7d385243 protected
  • 8072
  • gh-readonly-queue/master/pr-7952-5203160f5e7c944b80807c28e7e22897716a8fbe protected
  • gh-readonly-queue/master/pr-7952-c31ab2a246af0318a989ce6486f0bf8d7d385243 protected
  • 7867
  • 7955
  • gh-readonly-queue/master/pr-8059-761cfafd931b5f7ae76d97aaab8c8a343656b5dd protected
  • gh-readonly-queue/master/pr-8059-8d9862159ae2f40ff9e4b7b60e2071ca7d89d47a protected
20 results
Compare History
Muharem's avatar
Make `on_unbalanceds` work with `fungibles` `imbalances` (#4564)
Muharem Ismailov authored 
Make `on_unbalanceds` work with `fungibles` `imbalances`.

The `fungibles` `imbalances` cannot be handled by the default
implementation of `on_unbalanceds` from the `OnUnbalanced` trait. This
is because the `fungibles` `imbalances` types do not implement the
`Imbalance` trait (and cannot with its current semantics). The
`on_unbalanceds` function requires only the `merge` function for the
imbalance type. In this PR, we provide the `TryMerge` trait, which can
be implemented by all imbalance types and make `OnUnbalanced` require it
instead `Imbalance`.

### Migration for `OnUnbalanced` trait implementations:
In case if you have a custom implementation of `on_unbalanceds` trait
function, remove it's `<B>` type argument.

### Migration for custom imbalance types:
If you have your own imbalance types implementations, implement the
`TryMerge` trait for it introduced with this update.
        
The applicability of the `on_unbalanceds` function to fungibles
imbalances is useful in cases like -
[link](https://github.com/paritytech/polkadot-sdk/blob/3a8e675e

/substrate/frame/transaction-payment/asset-conversion-tx-payment/src/payment.rs#L267)
from https://github.com/paritytech/polkadot-sdk/pull/4488.

---------

Co-authored-by: default avatarOliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
6d0926e2
Name Last commit Last update
..
.config
.maintain
bin
client
deprecated/hashing
docker
docs
frame
primitives
scripts
test-utils
utils
zombienet
.dockerignore
.editorconfig
.git-blame-ignore-revs
.gitattributes
HEADER-APACHE2
HEADER-GPL3
LICENSE-APACHE2
LICENSE-GPL3
README.md
README.md

Substrate

GitHub license GitLab Status PRs Welcome Stack Exchange

Substrate is a next-generation framework for blockchain innovation 🚀.

Getting Started

Head to docs.substrate.io and follow the installation instructions. Then try out one of the tutorials. Refer to the Docker instructions to quickly run Substrate, Substrate Node Template, Subkey, or to build a chain spec.

Community & Support

Join the highly active and supportive community on the Substrate Stack Exchange to ask questions about use and problems you run into using this software. Please do report bugs and issues here for anything you suspect requires action in the source.

Contributions & Code of Conduct

Please follow the contributions guidelines as outlined in docs/contributor/CONTRIBUTING.md. In all communications and contributions, this project follows the Contributor Covenant Code of Conduct.

Security

The security policy and procedures can be found in docs/contributor/SECURITY.md.

License

The reason for the split-licensing is to ensure that for the vast majority of teams using Substrate to create feature-chains, then all changes can be made entirely in Apache2-licensed code, allowing teams full freedom over what and how they release and giving licensing clarity to commercial teams.

In the interests of the community, we require any deeper improvements made to Substrate's core logic (e.g. Substrate's internal consensus, crypto or database code) to be contributed back so everyone can benefit.