Skip to content
  1. Aug 10, 2020
    • Kian Paimani's avatar
      f9f82623
    • Hernando Castano's avatar
      Add Subscription RPC for Grandpa Finality (#5732) · 433b7214
      Hernando Castano authored
      
      
      * Rough skeleton for what I think the RPC should look like
      
      * Create channel for sending justifications
      
      Sends finalized header and justification from Grandpa to the
      client. This lays the groundwork for hooking into the RPC module.
      
      * WIP: Add subscribers for justifications to Grandpa
      
      Adds the Sender end of a channel into Grandpa, through which notifications
      about block finality events can be sent.
      
      * WIP: Add a struct for managing subscriptions
      
      Slightly different approach from the last commit, but same
      basic idea. Still a rough sketch, very much doesn't compile yet.
      
      * Make naming more clear and lock data in Arc
      
      * Rough idea of what RPC would look like
      
      * Remove code from previous approach
      
      * Missed some things
      
      * Update client/rpc-api/src/chain/mod.rs
      
      Co-Authored-By: default avatarTomasz Drwięga <[email protected]>
      
      * Update client/rpc-api/src/chain/mod.rs
      
      Co-Authored-By: default avatarTomasz Drwięga <[email protected]>
      
      * Split justification subscription into sender and receiver halves
      
      * Replace RwLock with a Mutex
      
      * Add sample usage from the Service's point of view
      
      * Remove code that referred to "chain_" RPC
      
      * Use the Justification sender/receivers from Grandpa LinkHalf
      
      * Add some PubSub boilerplate
      
      * Add guiding comments
      
      * TMP: comment out to fix compilation
      
      * Return MetaIoHandler from PubSubHandler in create_full
      
      * Uncomment pubsub methods in rpc handler (fails to build)
      
      * node/rpc: make Metadata concrete in create_full to fix compilation
      
      * node: pass in SubscriptionManger to grandpa rpc handler
      
      * grandpa-rpc: use SubscriptionManger to add subscriber
      
      * grandpa-rpc: attempt at setting up the justification stream (fails to build)
      
      * grandpa-rpc: fix compilation of connecting stream to sink
      
      * grandpa-rpc: implement unsubscribe
      
      * grandpa-rpc: update older tests
      
      * grandpa-rpc: add full prefix to avoid confusing rust-analyzer
      
      * grandpa-rpc: add test for pubsub not available
      
      * grandpa-rpc: tidy up leftover code
      
      * grandpa-rpc: add test for sub and unsub of justifications
      
      * grandpa-rpc: minor stylistic changes
      
      * grandpa-rpc: split unit test
      
      * grandpa-rpc: minor stylistic changes in test
      
      * grandpa-rpc: skip returning future when cancelling
      
      * grandpa-rpc: reuse testing executor from sc-rpc
      
      * grandpa-rpc: don't need to use PubSubHandler in tests
      
      * node-rpc: use MetaIoHandler rather than PubSubHandler
      
      * grandpa: log if getting header failed
      
      * grandpa: move justification channel creation into factory function
      
      * grandpa: make the justification sender optional
      
      * grandpa: fix compilation warnings
      
      * grandpa: move justification notification types to new file
      
      * grandpa-rpc: move JustificationNotification to grandpa-rpc
      
      * grandpa-rpc: move JustificationNotification to its own file
      
      * grandpa: rename justification channel pairs
      
      * grandpa: rename notifier types
      
      * grandpa: pass justification as GrandpaJustification to the rpc module
      
      * Move Metadata to sc-rpc-api
      
      * grandpa-rpc: remove unsed error code
      
      * grandpa: fix bug for checking if channel is closed before sendind
      
      * grandpa-rpc: unit test for sending justifications
      
      * grandpa-rpc: update comments for the pubsub test
      
      * grandpa-rpc: update pubsub tests with more steps
      
      * grandpa-rpc: fix pubsub test
      
      * grandpa-rpc: minor indendation
      
      * grandpa-rpc: decode instead of encode in test
      
      * grandpa: fix review comments
      
      * grandpa: remove unused serde dependency
      
      Co-authored-by: default avatarTomasz Drwięga <[email protected]>
      Co-authored-by: default avatarJon Häggblad <[email protected]>
      Co-authored-by: default avatarTomasz Drwięga <[email protected]>
      433b7214
    • Joshy Orndorff's avatar
      Update pinned wasm-bindgen dependency (#6861) · a936771c
      Joshy Orndorff authored
      * Update dependency.
      
      * Update readme docs
      
      * update python webserver command
      a936771c
  2. Aug 08, 2020
  3. Aug 07, 2020
  4. Aug 06, 2020
  5. Aug 05, 2020
  6. Aug 04, 2020
  7. Aug 03, 2020
  8. Jul 31, 2020
    • Pierre Krieger's avatar
      Don't close inbound notifications substreams immediately (#6781) · a1786a92
      Pierre Krieger authored
      * Don't close inbound notifications substreams immediately
      
      * Fix not closing in return to node A closing
      a1786a92
    • Bastian Köcher's avatar
      Order delta before calculating the storage root (#6780) · 9ca2300b
      Bastian Köcher authored
      We need to order the delta before calculating the storage root, because
      the order is important if the storage root is calculated using a storage
      proof. The problem is arises when the delta is different than at the
      time the storage root was recorded, because we may require a different
      node that is not part of the proof and so, the storage root can not be
      calculated. The problem is solved by always order the delta to use the
      same order when calculating the storage root while recording the
      stroage proof and when calculating the storage root using
      the storage proof.
      
      To prevent this bug in future again, a regression test is added.
      
      Fixes: https://github.com/paritytech/cumulus/issues/146
      9ca2300b
    • Wei Tang's avatar
      Allow blacklisting blocks from being finalized again after block revert (#6301) · 3c5cbb00
      Wei Tang authored
      * Allow blacklisting blocks from being finalized again after block revert
      
      * Use BlockRules for storing unfinalized and add have_state_at in revert
      
      * Move finalization_check in finalize_block upward
      
      * Directly mark finalization blacklist as badblocks
      
      * Remove obselete comment
      3c5cbb00
    • thiolliere's avatar
      Fix link (#6775) · 7db19db9
      thiolliere authored
      7db19db9
  9. Jul 30, 2020