Skip to content
  1. Aug 07, 2020
  2. Aug 06, 2020
    • Peter Goodspeed-Niklaus's avatar
      implement provisioner (#1473) · 21cec309
      Peter Goodspeed-Niklaus authored
      * sketch out provisioner basics
      
      * handle provisionable data
      
      * stub out select_inherent_data
      
      * split runtime APIs into sub-chapters to improve linkability
      
      * explain SignedAvailabilityBitfield semantics
      
      * add internal link to further documentation
      
      * some more work figuring out how the provisioner can do its thing
      
      * fix broken link
      
      * don't import enum variants where it's one layer deep
      
      * make request_availability_cores a free fn in util
      
      * document more precisely what should happen on block production
      
      * finish first-draft implementation of provisioner
      
      * start working on the full and proper backed candidate selection rule
      
      * Pass number of block under construction via RequestInherentData
      
      * Revert "Pass number of block under construction via RequestInherentData"
      
      This reverts commit 850fe62cc0dfb04252580c21a985962000e693c8.
      
      That initially looked like the better approach--it spent the time
      budget for fetching the block number in the proposer, instead of
      the provisioner, and that felt more appropriate--but it turns out
      not to be obvious how to get the block number of the block under
      construction from within the proposer. The Chain API may be less
      ideal, but it should be easier to implement.
      
      * wip: get the block under production from the Chain API
      
      * add ChainApiMessage to AllMessages
      
      * don't break the run loop if a provisionable data channel closes
      
      * clone only those backed candidates which are coherent
      
      * propagate chain_api subsystem through various locations
      
      * add delegated_subsystem! macro to ease delegating subsystems
      
      Unfortunately, it doesn't work right:
      
      ```
      error[E0446]: private type `CandidateBackingJob` in public interface
         --> node/core/backing/src/lib.rs:775:1
          |
      86  | struct CandidateBackingJob {
          | - `CandidateBackingJob` declared as private
      ...
      775 | delegated_subsystem!(CandidateBackingJob as CandidateBackingSubsystem);
          | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ can't leak private type
      ```
      
      I'm not sure precisely what's going wrong, here; I suspect the problem is
      the use of `$job as JobTrait>::RunArgs` and `::ToJob`; the failure would be
      that it's not reifying the types to verify that the actual types are public,
      but instead referring to them via `CandidateBackingJob`, which is in fact private;
      that privacy is the point.
      
      Going to see if I can generic my way out of this, but we may be headed for a
      quick revert here.
      
      * fix delegated_subsystem
      
      The invocation is a bit more verbose than I'd prefer, but it's also
      more explicit about what types need to be public. I'll take it as a win.
      
      * add provisioning subsystem; reduce public interface of provisioner
      
      * deny missing docs in provisioner
      
      * refactor core selection per code review suggestion
      
      This is twice as much code when measured by line, but IMO it is
      in fact somewhat clearer to read, so overall a win.
      
      Also adds an improved rule for selecting availability bitfields,
      which (unlike the previous implementation) guarantees that the
      appropriate postconditions hold there.
      
      * fix bad merge double-declaration
      
      * update guide with (hopefully) complete provisioner candidate selection procedure
      
      * clarify candidate selection algorithm
      
      * Revert "clarify candidate selection algorithm"
      
      This reverts commit c68a02ac9cf42b3a4a28eb197d38633a40d0e3e6.
      
      * clarify candidate selection algorithm
      
      * update provisioner to implement candidate selection per the guide
      
      * add test that no more than one bitfield is selected per validator
      
      * add test that each selected bitfield corresponds to an occupied core
      
      * add test that more set bits win conflicts
      
      * add macro for specializing runtime requests; specailize all runtime requests
      
      * add tests harness for select_candidates tests
      
      * add first real select_candidates test, fix test_harness
      
      * add mock overseer and test that success is possible
      
      * add test that the candidate selection algorithm picks the right ones
      
      * make candidate selection test somewhat more stringent
      21cec309
    • Sergey Pepyakin's avatar
      Implementer's guide: downward messages and HRMP, take 2 (#1503) · 877a5059
      Sergey Pepyakin authored
      
      
      * First stab at downward messages.
      
      That also includes a notion of horizontal messages.
      
      * Add some structure to the router.
      
      * Update `ValidationOutputs`
      
      * Add `processed_downward_messages` to `ValidationOutputs`.
      
      Forgot to check that in.
      
      * s/AccountId/ParaId
      
      * DownwardMessage::ParachainSpecfic
      
      * s/ensure_horizontal_messages_fits/ensure_horizontal_messages_fit
      
      * Clarify that Router called for each candidate
      
      * Update the preamble for Router.
      
      * Rewrite the relay-chain extrinsic routines
      
      * Update gloassary
      
      * Add DMP to the glossary
      
      * If the queue is empty, `processed_downward_messages` can be 0
      
      * WIP
      
      * Add condemned list
      
      * Pivot to message-storing channel based HRMP
      
      * Finished draft
      
      * Tidy up
      
      * Remove a duplicate glossary entry
      
      * Fix typo
      
      * Fix wording to emphasize that the channel is unidirectional
      
      * Proper decrement `HrmpOpenChannelRequestCount`
      
      * Add a comment for `HrmpOpenChannelRequestCount`.
      
      * Remove old configuration values.
      
      * Be more specific about the para{chain,thread} hrmp chan limits.
      
      * Fix indentation so the lists are rendendered properly
      
      * "to answer **the**" question instead of "a"
      
      * Add a missing call to `check_processed_downward_messages`
      
      * Clean more stuff during offboarding
      
      * Fix typo
      
      * Fix typo for the config
      
      * Add a call to `prune_dmq`
      
      * Add explicit invariants for ingress/egress indexes
      
      * Add comments for the sender/reciever deposit config fields
      
      * Document various fields and structs in Router module
      
      * More docs
      
      * Missing docs in Candidate.md
      
      * Tabs to spaces in router.md
      
      * Apply Rob's suggestion
      
      * Add the hrmp_ prefix to the router messages
      
      * Those are entry points
      
      * Use SessionIndex type for the `age` field
      
      * Use a struct to represent `HrmpChannelId`
      
      * Put only MQCs into the LocalValidationData
      
      * Close request can be initiated by the runtime directly
      
      * Close request can be initiated by the runtime directly
      
      * tabs/spaces
      
      * Maintain the list of the outgoing paras in Router
      
      * Update roadmap/implementers-guide/src/runtime/inclusion.md
      
      Co-authored-by: default avatarRobert Habermeier <[email protected]>
      
      * fix typo
      
      * Remove an unnecessary pair of code quotes
      
      Co-authored-by: default avatarRobert Habermeier <[email protected]>
      877a5059
    • Bastian Köcher's avatar
    • Gavin Wood's avatar
      Bump Substrate (#1548) · b1cf8a57
      Gavin Wood authored
      
      
      * Bump Substrate
      
      * Bumb substrate again
      
      Co-authored-by: default avatarAshley Ruglys <[email protected]>
      b1cf8a57
    • Pierre Krieger's avatar
    • Cecile Tonglet's avatar
      Add SyncOracle to network's Service (#1543) · e818944c
      Cecile Tonglet authored
      * WIP
      
      * WIP
      
      Forked at: e91642361133dba084a9c9b3efa45fcb6cd3c5ca
      Parent branch: origin/rococo-branch
      
      * WIP
      
      Forked at: e91642361133dba084a9c9b3efa45fcb6cd3c5ca
      Parent branch: origin/rococo-branch
      
      * Apply suggestions from code review
      
      * Update collator/src/lib.rs
      
      * Update collator/src/lib.rs
      
      * Update network/src/protocol/mod.rs
      e818944c
    • Cecile Tonglet's avatar
      Ignore checks for companion PRs (#1455) · 497772da
      Cecile Tonglet authored
      497772da
  3. Aug 05, 2020
  4. Aug 04, 2020
  5. Aug 03, 2020
  6. Aug 02, 2020
  7. Jul 31, 2020
    • Fedor Sakharov's avatar
      Parachains-runtime (#1505) · 047e2fdb
      Fedor Sakharov authored
      * Initial commit
      
      * v0 to v1 primitives and remove attestations
      
      * Review fixes
      
      * implement candidate_events
      
      * remove dead code
      047e2fdb
    • ordian's avatar
      Chain API subsystem (#1498) · 596ce826
      ordian authored
      * chain-api subsystem skeleton
      
      * chain-api subsystem: draft impl
      
      * chain-api subsystem: mock testclient
      
      * chain-api subsystem: impl HeaderBacked for TestClient
      
      * chain-api subsystem: impl basic tests
      
      * chain-api subsystem: tiny guide
      
      * chain-api subsystem: rename ChainApiRequestMessage to ChainApiMessage
      
      * chain-api subsystem: add the page to the ToC
      
      * chain-api subsystem: proper error type
      
      * chain-api subsystem: impl ancestors request
      
      * chain-api subsystem: tests for ancestors request
      
      * guide: fix ancestor return type
      
      * runtime-api subsystem: remove unused dep
      
      * fix fmt
      
      * fix outdated comment
      
      * chain-api subsystem: s/format/to_string
      
      * lower-case subsystem names
      
      * chain-api subsystem: resolve Finalized todo
      
      * chain-api subsystem: remove TODO
      
      * extract request errors into a module
      
      * remove caching TODO
      
      * fix imports
      596ce826
    • Bastian Köcher's avatar
      710a48ba
    • asynchronous rob's avatar
      guide: collator networking & subsystems (#1452) · 490f80d8
      asynchronous rob authored
      * Do a small write-up on collation-generation
      
      * preamble to collator protocol
      
      * notes on protocol
      
      * collation-generation: point to collator protocol
      
      * fix missing bracket
      
      * expand on collator protocol wire protocol
      
      * add a couple more sentences
      
      * expand on requests some more
      
      * go higher level
      
      * network bridge: note peerset
      
      * note peer-set = validation for protocols
      
      * add `ConnectToValidators` message
      
      * use ConnectToValidators in collator protocol
      
      * typo
      
      * remove references to sentry nodes
      490f80d8
    • ordian's avatar
      Guide: add a diagram for Inclusion Pipeline & Approval Subsystem (#1457) · ea834b12
      ordian authored
      * guide: optimize diagrams for readability
      
      * guide: inclusion subsystem diagram
      
      * guide: rename Approval Subsystem for clarity
      
      * guide: correct the approval subsystem
      
      * guide: clarify that validator are selected from the same set
      
      * guide: simplify secondary checkers labels
      ea834b12
    • s3krit's avatar
      [CI] Build wasm blob with srtool and include prop hashes and blobs in release notes (#1506) · c82f15ec
      s3krit authored
      * initial build-wasms commit
      
      * fix wasm builds
      
      * add caching and artifact upload
      
      * test for git dir
      
      * Revert "test for git dir"
      
      This reverts commit 295e4655484691aed9162f479a87f09c1b1c9317.
      
      * fix git version incompability
      
      * attempt to fix caching
      
      * Revert "fix git version incompability"
      
      This reverts commit 1d22ffd26b7eff635c5abcc9bd04cb3c88629a1d.
      
      * add kusama job
      
      * use a build matrix for building runtimes
      
      * combine build-wasms and publish draft release
      
      * attempt to name runtimes according to version
      
      * Revert "attempt to name runtimes according to version"
      
      This reverts commit 82f7b4dc0aea995f2599293bba9f11b879f459e5.
      Failed experiment
      
      * name runtimes according to version #2
      
      * fix asset path and name
      
      * build wasms first, include prop hash
      c82f15ec
  8. Jul 30, 2020
    • asynchronous rob's avatar
      Candidate Validation Subsystem (#1432) · 5253a055
      asynchronous rob authored
      * skeleton for candidate-validation
      
      * add to workspace
      
      * implement candidate validation logic
      
      * guide: note occupied-core assumption for candidate validation
      
      * adjust message doc
      
      * wire together `run` asynchronously
      
      * add a Subsystem implementation
      
      * clean up a couple warnings
      
      * fix compilation errors due to merge
      
      * improve candidate-validation.md
      
      * remove old reference to subsystem-test helpers crate
      
      * update Cargo.lock
      
      * add a couple new Runtime API methods
      
      * add a candidate validation message
      
      * fetch validation data from the chain state
      
      * some tests for assumption checking
      
      * make spawn_validate_exhaustive mockable
      
      * more tests on the error handling side
      
      * fix all other grumbles except for wasm validation API change
      
      * wrap a SpawnNamed in candidate-validation
      
      * warn
      
      * amend guide
      
      * squanch warning
      
      * remove duplicate after merge
      5253a055
    • asynchronous rob's avatar
      reduce slash defer durations (#1504) · 64bf3a1e
      asynchronous rob authored
      * reduce slash defer durations
      
      * update comments
      
      * tests
      64bf3a1e
    • asynchronous rob's avatar
      Implement the Runtime API subsystem (#1494) · 652ae86a
      asynchronous rob authored
      * type defaults for ParachainHost
      
      * add ValidationCode message
      
      * implement core loop of runtime API subsystem
      
      * subsystem trait implementation for runtime API subsystem
      
      * implement a mock runtime API
      
      * some tests that ensure requests are forwarded to runtime API correctly
      
      * fix dependency grumbles
      
      * improve RuntimeApiError API
      652ae86a
    • Shawn Tabrizi's avatar
      Companion for #6610 (Balances Weight Trait) (#1425) · 80303e99
      Shawn Tabrizi authored
      * Update for balances weights
      
      * remove unneeded tests
      
      * Add file headers
      
      * cargo update -p sp-io
      80303e99