Skip to content
  1. Jun 08, 2021
    • Bastian Köcher's avatar
      polkadot-service: Make native runtime configurable (#3189) · f6cbe8e8
      Bastian Köcher authored
      * polkadot-service: Make native runtime configurable
      
      This pull requests adds support for configuring the native runtimes used
      by polkadot-service. While this whole pr doesn't change that much for
      polkadot, besides not having the light-node enabled for the default
      polkadot binary. However, downstream projects (parachains) will have a
      much better compile time. In cumulus for example the `cargo test --all
      --release` is about 4m faster to compile.
      
      * Fixes
      
      * Fix
      
      * Enable rococo-native
      
      * Fix light client
      
      * 🤦
      
      * Fixes
      f6cbe8e8
  2. May 29, 2021
  3. May 10, 2021
  4. Apr 27, 2021
  5. Apr 22, 2021
    • André Silva's avatar
      Introduce Wococo testnet (#2918) · ae558997
      André Silva authored
      
      
      * runtime: remove mmr and beefy from westend runtime
      
      * runtime: westend: remove pallet_beefy config
      
      * node: only start beefy gadget on rococo
      
      * node: remove beefy keys from westend chain spec
      
      * node: add wococo testnet chain spec
      
      * node: add comments about beefy gadget task
      
      * runtime: update wococo chainspec
      
      * Remove stale comment
      
      Co-authored-by: default avatarTomasz Drwięga <[email protected]>
      Co-authored-by: default avataradoerr <[email protected]>
      ae558997
  6. Apr 21, 2021
    • Kian Paimani's avatar
      Fix bench bot (#2900) · 47889d84
      Kian Paimani authored
      
      
      * Fix bench bot
      
      * cargo run --release --features=runtime-benchmarks -- benchmark --chain=polkadot-dev --steps=50 --repeat=20 --pallet=pallet_membership --extrinsic=* --execution=wasm --wasm-execution=compiled --heap-pages=4096 --header=./file_header.txt --output=./runtime/polkadot/src/weights/
      
      * Fix weights files
      
      * Fix'
      
      * cargo run --release --features=runtime-benchmarks -- benchmark --chain=kusama-dev --steps=50 --repeat=20 --pallet=pallet_membership --extrinsic=* --execution=wasm --wasm-execution=compiled --heap-pages=4096 --header=./file_header.txt --output=./runtime/kusama/src/weights/
      
      Co-authored-by: default avatarParity Benchmarking Bot <[email protected]>
      47889d84
  7. Apr 08, 2021
    • Sergey Pepyakin's avatar
      New PVF validation host (#2710) · 59b4d651
      Sergey Pepyakin authored
      
      
      * Implement PVF validation host
      
      * WIP: Diener
      
      * Increase the alloted compilation time
      
      * Add more comments
      
      * Minor clean up
      
      * Apply suggestions from code review
      
      Co-authored-by: default avatarBastian Köcher <[email protected]>
      
      * Fix pruning artifact removal
      
      * Fix formatting and newlines
      
      * Fix the thread pool
      
      * Update node/core/pvf/src/executor_intf.rs
      
      Co-authored-by: default avatarBastian Köcher <[email protected]>
      
      * Remove redundant test declaration
      
      * Don't convert the path into an intermediate string
      
      * Try to workaround the test failure
      
      * Use the puppet_worker trick again
      
      * Fix a blip
      
      * Move `ensure_wasmtime_version` under the tests mod
      
      * Add a macro for puppet_workers
      
      * fix build for not real-overseer
      
      * Rename the puppet worker for adder collator
      
      * play it safe with the name of adder puppet worker
      
      * Typo: triggered
      
      * Add more comments
      
      * Do not kill exec worker on every error
      
      * Plumb Duration for timeouts
      
      * typo: critical
      
      * Add proofs
      
      * Clean unused imports
      
      * Revert "WIP: Diener"
      
      This reverts commit b9f54e513366c7a6dfdd117ac19fbdc46b900b4d.
      
      * Sync version of wasmtime
      
      * Update cargo.lock
      
      * Update Substrate
      
      * Merge fixes still
      
      * Update wasmtime version in test
      
      * bastifmt
      
      Co-authored-by: default avatarBastian Köcher <[email protected]>
      
      * Squash spaces
      
      * Trailing new line for testing.rs
      
      * Remove controversial code
      
      * comment about biasing
      
      * Fix suggestion
      
      * Add comments
      
      * make it more clear why unwrap_err
      
      * tmpfile retry
      
      * proper proofs for claim_idle
      
      * Remove mutex from ValidationHost
      
      * Add some more logging
      
      * Extract exec timeout into a constant
      
      * Add some clarifying logging
      
      * Use blake2_256
      
      * Clean up the merge
      
      Specifically the leftovers after removing real-overseer
      
      * Update parachain/test-parachains/adder/collator/Cargo.toml
      
      Co-authored-by: default avatarAndronik Ordian <[email protected]>
      
      Co-authored-by: default avatarBastian Köcher <[email protected]>
      Co-authored-by: default avatarAndronik Ordian <[email protected]>
      59b4d651
  8. Mar 31, 2021
  9. Mar 11, 2021
  10. Feb 24, 2021
  11. Feb 23, 2021
    • asynchronous rob's avatar
      Approval Checking Improvements Omnibus (#2480) · 3300b533
      asynchronous rob authored
      * add tracing to approval voting
      
      * notify if session info is not working
      
      * add dispute period to chain specs
      
      * propagate genesis session to parachains runtime
      
      * use `on_genesis_session`
      
      * protect against zero cores in computation
      
      * tweak voting rule to be based off of best and add logs
      
      * genesis configuration should use VRF slots only
      
      * swallow more keystore errors
      
      * add some docs
      
      * make validation-worker args non-optional and update clap
      
      * better tracing for bitfield signing and provisioner
      
      * pass amount of bits in bitfields to inclusion instead of recomputing
      
      * debug -> warn for some logs
      
      * better tracing for availability recovery
      
      * a little av-store tracing
      
      * bridge: forward availability recovery messages
      
      * add missing try_from impl
      
      * some more tracing
      
      * improve approval distribution tracing
      
      * guide: hold onto pending approval messages until NewBlocks
      
      * Hold onto pending approval messages until NewBlocks
      
      * guide: adjust comment
      
      * process all actions for one wakeup at a time
      
      * vec
      
      * fix network bridge test
      
      * replace randomness-collective-flip with Babe
      
      * remove PairNotFound
      3300b533
  12. Feb 09, 2021
  13. Jan 29, 2021
  14. Jan 20, 2021
  15. Jan 13, 2021
    • Bernhard Schuster's avatar
      display errors with their sources (#2264) · 1d28f59e
      Bernhard Schuster authored
      * update futures to 0.3.9
      
      * companion changes for generic error types
      
      * improve errors, keep error sources
      
      * command compile fix
      
      * use the correct Error type, add annotation
      
      * avoid async { fut.await.map_err(E::Variant) } with TryFuture
      
      * fix cargo lock, bump futures to 0.3.10
      
      futures 0.3.9 got yanked
      
      * chore cargo update -p sp-io
      
      * minor quirk
      
      * make rustc 1.48 happy by bouning the error more tightly
      
      * be more explicit
      
      * cargo lock futures
      1d28f59e
  16. Dec 29, 2020
  17. Dec 28, 2020
  18. Dec 11, 2020
  19. Dec 10, 2020
    • Bernhard Schuster's avatar
      addition error definitions (#2107) · 35c71bf3
      Bernhard Schuster authored
      * remove low information density error doc comments
      
      * another round of error dancing
      
      * fix compilation
      
      * remove stale `None` argument
      
      * adjust test, minor slip in command
      
      * only add AvailabilityError for full node features
      
      * another None where none shuld be
      35c71bf3
  20. Dec 03, 2020
  21. Nov 23, 2020
    • Max Inden's avatar
      *: Update authority discovery and remove WorkerConfig (#1953) · 63bf63e4
      Max Inden authored
      * *: Update authority discovery and remove WorkerConfig
      
      With https://github.com/paritytech/substrate/pull/7545 the authority
      discovery module queries and publishes addresses on an exponentially
      increasing interval. Doing so should make custom configurations
      obsolete, as operations are retried in a timely fashion in the first
      minutes.
      
      * */Cargo.{lock,toml}: Point to mxinden substrate auth-disc-timing
      
      * Revert "*/Cargo.{lock,toml}: Point to mxinden substrate auth-disc-timing"
      
      This reverts commit 0785943a1e377454f088814ef20f4432de09da7a.
      
      * "Update Substrate"
      
      * Revert ""Update Substrate""
      
      This reverts commit 377b221e1853b2c383f0c416d686535b545796cb.
      
      * Cargo.lock: Manual Substrate update
      
      * node/test/service/src/lib: Remove unused import
      
      * parachain/test-parachains/adder: Remove unused import
      
      Co-authored-by: parity-processbot <>
      63bf63e4
  22. Nov 09, 2020
  23. Nov 02, 2020
    • Bastian Köcher's avatar
      Adder collator improvements (#1896) · cfa078ae
      Bastian Köcher authored
      * Fixes bug that collator wasn't sending `Declare` message
      
      * Set authority discovery config
      
      * Fixes bug that collator wasn't sending `Declare` message
      
      * Adds real overseer feature and makes the wasm_validation fail with a
      proper error
      
      * Adds README
      
      * Remove debug stuff
      
      * Add feature
      
      * Make adder collator use the correct parent when building a new block
      cfa078ae
  24. Oct 28, 2020
    • Bastian Köcher's avatar
      Add key subcommand (#1874) · bbf7fc8d
      Bastian Köcher authored
      bbf7fc8d
    • Peter Goodspeed-Niklaus's avatar
    • Peter Goodspeed-Niklaus's avatar
      start working on building the real overseer (#1795) · 1a25c412
      Peter Goodspeed-Niklaus authored
      
      
      * start working on building the real overseer
      
      Unfortunately, this fails to compile right now due to an upstream
      failure to compile which is probably brought on by a recent upgrade
      to rustc v1.47.
      
      * fill in AllSubsystems internal constructors
      
      * replace fn make_metrics with Metrics::attempt_to_register
      
      * update to account for #1740
      
      * remove Metrics::register, rename Metrics::attempt_to_register
      
      * add 'static bounds to real_overseer type params
      
      * pass authority_discovery and network_service to real_overseer
      
      It's not straightforwardly obvious that this is the best way to handle
      the case when there is no authority discovery service, but it seems
      to be the best option available at the moment.
      
      * select a proper database configuration for the availability store db
      
      * use subdirectory for av-store database path
      
      * apply Basti's patch which avoids needing to parameterize everything on Block
      
      * simplify path extraction
      
      * get all tests to compile
      
      * Fix Prometheus double-registry error
      
      for debugging purposes, added this to node/subsystem-util/src/lib.rs:472-476:
      
      ```rust
      Some(registry) => Self::try_register(registry).map_err(|err| {
      	eprintln!("PrometheusError calling {}::register: {:?}", std::any::type_name::<Self>(), err);
      	err
      }),
      ```
      
      That pointed out where the registration was failing, which led to
      this fix. The test still doesn't pass, but it now fails in a new
      and different way!
      
      * authorities must have authority discovery, but not necessarily overseer handlers
      
      * fix broken SpawnedSubsystem impls
      
      detailed logging determined that using the `Box::new` style of
      future generation, the `self.run` method was never being called,
      leading to dropped receivers / closed senders for those subsystems,
      causing the overseer to shut down immediately.
      
      This is not the final fix needed to get things working properly,
      but it's a good start.
      
      * use prometheus properly
      
      Prometheus lets us register simple counters, which aren't very
      interesting. It also allows us to register CounterVecs, which are.
      With a CounterVec, you can provide a set of labels, which can
      later be used to filter the counts.
      
      We were using them wrong, though. This pattern was repeated in a
      variety of places in the code:
      
      ```rust
      // panics with an cardinality mismatch
      let my_counter = register(CounterVec::new(opts, &["succeeded", "failed"])?, registry)?;
      my_counter.with_label_values(&["succeeded"]).inc()
      ```
      
      The problem is that the labels provided in the constructor are not
      the set of legal values which can be annotated, but a set of individual
      label names which can have individual, arbitrary values.
      
      This commit fixes that.
      
      * get av-store subsystem to actually run properly and not die on first signal
      
      * typo fix: incomming -> incoming
      
      * don't disable authority discovery in test nodes
      
      * Fix rococo-v1 missing session keys
      
      * Update node/core/av-store/Cargo.toml
      
      * try dummying out av-store on non-full-nodes
      
      * overseer and subsystems are required only for full nodes
      
      * Reduce the amount of warnings on browser target
      
      * Fix two more warnings
      
      * InclusionInherent should actually have an Inherent module on rococo
      
      * Ancestry: don't return genesis' parent hash
      
      * Update Cargo.lock
      
      * fix broken test
      
      * update test script: specify chainspec as script argument
      
      * Apply suggestions from code review
      
      Co-authored-by: default avatarBastian Köcher <[email protected]>
      
      * Update node/service/src/lib.rs
      
      Co-authored-by: default avatarBastian Köcher <[email protected]>
      
      * node/service/src/lib: Return error via ? operator
      
      * post-merge blues
      
      * add is_collator flag
      
      * prevent occasional av-store test panic
      
      * simplify fix; expand application
      
      * run authority_discovery in Role::Discover when collating
      
      * distinguish between proposer closed channel errors
      
      * add IsCollator enum, remove is_collator CLI flag
      
      * improve formatting
      
      * remove nop loop
      
      * Fix some stuff
      
      Co-authored-by: default avatarAndronik Ordian <[email protected]>
      Co-authored-by: default avatarBastian Köcher <[email protected]>
      Co-authored-by: default avatarFedor Sakharov <[email protected]>
      Co-authored-by: default avatarRobert Habermeier <[email protected]>
      Co-authored-by: default avatarBastian Köcher <[email protected]>
      Co-authored-by: default avatarMax Inden <[email protected]>
      1a25c412
  25. Oct 15, 2020
  26. Oct 14, 2020
  27. Oct 13, 2020
  28. Oct 09, 2020
  29. Oct 08, 2020
    • Peter Goodspeed-Niklaus's avatar
      Remove old service, 3rd try (#1776) · c2941a27
      Peter Goodspeed-Niklaus authored
      * Remove old service, 3rd try
      
      i.e.
      Revert "Revert "Remove Old Service, 2nd try (#1732)" (#1758)"
      
      This reverts commit 9a0f08bf
      
      .
      
      Closes #1757.
      
      We now have some evidence that the polkadot validator was producing
      blocks after all; the reason the blocks_constructed metric was 0 was
      that as a new metric it hadn't yet been incorporated into that
      branch's codebase. See
      https://github.com/paritytech/polkadot/issues/1757#issuecomment-700977602
      
      As this PR is based on a newer `master` branch than the previous one,
      that should hopefully no longer be an issue.
      
      * paras trait now has an Origin type
      
      * initial work running a two node local net
      
      * use the right incantations so the nodes produce blocks together
      
      * improve internal documentation
      
      Co-authored-by: default avatarBastian Köcher <[email protected]>
      c2941a27
  30. Sep 28, 2020
  31. Sep 18, 2020
    • Peter Goodspeed-Niklaus's avatar
      b4457f55
    • Peter Goodspeed-Niklaus's avatar
      Remove service, migrate all to service-new (#1630) · d531ba56
      Peter Goodspeed-Niklaus authored
      
      
      * import rococo into chain-spec
      
      * make a few stabs at moving forward
      
      * wip: rococo readme
      
      * remove /service crate
      
      - Move the chain-spec files to node-service
      - update sufficient cargo files that polkadot-service-new builds
      - not everything else builds yet
      
      * wip: chase down some build errors in polkadot-cli
      
      There's a lot more to go, but some progress has happened.
      
      * make more progress getting polkadot-cli to build
      
      * don't ignore polkadot.json within the res directory
      
      * don't recreate pathbufs
      
      * Prepare Polkadot to be used by Cumulus
      
      This begins to make Polkadot usable from Cumulus.
      
      * Remove old test
      
      * migrate new_chain_ops fix from /service
      
      * partially remove node/test-service
      
      * Reset some changes
      
      * Revert "partially remove node/test-service"
      
      This reverts commit 7b8f9ba5bfc286a309df89853ae11facf3277ffb.
      
      * WIP: replace v0 ParachainHost impl with v1 for test runtime
      
      This is necessary because one of the current errors when building
      the test service boils down to:
      
      the trait bound `polkadot_test_runtime::RuntimeApiImpl<...>`:
        `polkadot_primitives::v1::ParachainHost<...>` is not satisfied
      
      This is WIP because it appears to be causing some std leakage into
      the wasm environment, or something; the compiler is currently
      complaining about duplicate definitions of `panic_handler` and `oom`.
      Presumably I have to identify all std types (Vec etc) and replace
      them with sp_std equivalents.
      
      * fix test runtime build
      
      it wasn't std leakage, after all
      
      * bump westend spec version
      
      * use service-new as service within cli
      
      * to revert: demo that forwarding the test runtime to the real impl blows up
      
      * Revert "to revert: demo that forwarding the test runtime to the real impl blows up"
      
      This reverts commit 68d2f385f378721c7433e3e39133434610cd2a51.
      
      * Revert "Revert "to revert: demo that forwarding the test runtime to the real impl blows up""
      
      This reverts commit 04cb1cbf8873b4429cb9c9fdccb7f4bb137dc720.
      
      Might have just forgotten to disable default features
      
      * More reverts
      
      * MOARE
      
      * plug in the runtime as the generic instantiation
      
      This feels closer to a solution, but it still has problems: in particular,
      it's assumed that Runtime implements all appropriate Trait traits,
      which this one apparently does not.
      
      * implement necessary traits to get the test runtime compiling
      
      This is almost certainly not correct in some way; it really
      looks like I need to mess with the construct_runtime! macro
      somehow, to inject the inclusion trait's event type as a Event
      variant. Still, better lock down this changeset while it all
      compiles.
      
      * add inclusion::Event as variant into Event enum
      
      * implement unimplemented bits in kusama
      
      * implement unimplemented bits in polkadot runtime
      
      * implement unimplemented bits in westend runtime
      
      * migrate client upgrades from master
      
      * update test service with new node changes
      
      * package metadata--that wasn't intended to be removed
      
      * add parachains v1 modules to each runtime
      
      It's not clear what precisely this does, but it's probably the right
      thing to do.
      
      * enable cli to opt out of full node features
      
      * adjust rococo chainspec per example
      
      https://github.com/paritytech/polkadot/blob/26f1fa47f7836ab4bee5d4aad127ebce748320dd/service/src/chain_spec.rs#L362
      
      * try to fix Cargo.lock
      
      Co-authored-by: default avatarBastian Köcher <[email protected]>
      Co-authored-by: default avatarAndronik Ordian <[email protected]>
      d531ba56
  32. Sep 17, 2020
  33. Sep 11, 2020
  34. Sep 01, 2020
  35. Aug 24, 2020