- Apr 25, 2020
-
-
Shawn Tabrizi authored
* Introduce `BlockExectionWeight` and `ExtrinsicBaseWeight` * Add new traits everywhere * Missed one update * fix tests * Update `check_weight` logic * introduce `max_extrinsic_weight` function * fix + add tests * format nits * remove println * make test a bit more clear * Remove minimum weight * newlines left over from find/replace * Fix test, improve clarity * Fix executor tests * Extrinsic base weight same as old `MINIMUM_WEIGHT` * fix example test * Expose constants * Add test for full block with operational and normal * Initiate test environment with `BlockExecutionWeight` weight * format nit * Update frame/system/src/lib.rs Co-Authored-By:
Kian Paimani <[email protected]> * Replace `TransactionBaseFee` with `ExtrinsicBaseWeight` (#5761) * Replace `TransactionBaseFee` with `ExtrinsicBaseFee` * Fix stuff * Fix and make tests better * Forgot to update this test * Fix priority number in test * Remove minimum weight from merge * Fix weight in contracts * remove `TransactionBaseFee` from contract tests * Let `register_extra_weight_unchecked` go past `MaximumBlockWeight` * address feedback Co-authored-by:
Kian Paimani <[email protected]>
-
- Apr 24, 2020
-
-
Wei Tang authored
* babe: secondary blocks with VRF * Fix node runtime compile * Fix test-utils runtime interface * Fix babe tests * typo: v == 2 * babe: support online configuration upgrades * Fix rpc tests * Fix runtime version tests * Switch to use NextConfigDescriptor instead of changing runtime interface * Fix tests * epoch-changes: map function that allows converting with different epoch types * Add migration script for the epoch config change * Fix docs for PrimaryAndSecondaryVRFSlots * Add docs of `SecondaryVRF` in babe crate * babe-primitives: Secondary -> SecondaryPlain * babe-client: Secondary -> SecondaryPlain * Fix migration tests * test-utils-runtime: Secondary -> SecondaryPlain * Fix missing name change in test-utils-runtime * Fix migration: Epoch should be EpochV0 * Update client/consensus/babe/src/lib.rs Co-Authored-By:
André Silva <[email protected]> * Fix new epochChanges version * Fix babe-primitives naming changes * Fix merge issues in babe-client Co-authored-by:
André Silva <[email protected]> Co-authored-by:
André Silva <[email protected]>
-
Alexander Popiak authored
* add old_registrar_count as param to estimate weight * cast count to Weight Co-Authored-By:
Shawn Tabrizi <[email protected]> * add weight calculation for set_identity * remove superfluous weight comment * add detailed weight estimation for set_subs * adjust benchmarking code to the new API * add second parameter to set_subs benchmark * rename o to p * calculate weight based on benchmarks * use try_mutate for registrars * fix weight number typo * update weights for set_subs + add weights for clear_identity and request_judgement * improve naming and docs * add weight calculation for cancel_request * fix benchmark * fix tests * fix arithmetic overflow in balances triggered by tests * add weight calcluations for more dispatchables * add weight calculation for provide_judgement * mark param as unused * add MaxRegistrars associated type used for weight estimation * check that MaxRegistrars is not exceeded * add remaining weight calculations * use weight refunds to use more constants in weight estimation * adjust usage of clear_identity * refund request_judgement weights and remove param * refund weights for cancel_request and remove param * add remaining refunds and remove params * refund weight for set_subs and remove param * make comment more specific * add range note to benchmarking docs * fix inconsistencies before review * fix actual weight calculation for add_registrar * remove duplicate balance ops weights + refund on all dispatchables Co-authored-by:
Shawn Tabrizi <[email protected]>
-
Bernhard Schuster authored
Co-Authored-By:
Kian Paimani <[email protected]> Co-Authored-By:
Tomasz Drwięga <[email protected]>
-
Wei Tang authored
* babe: support online configuration upgrades * Switch to use NextConfigDescriptor instead of changing runtime interface * Fix tests * epoch-changes: map function that allows converting with different epoch types * Add migration script for the epoch config change * Fix migration tests * Fix migration: Epoch should be EpochV0 * Update client/consensus/babe/src/lib.rs Co-Authored-By:
André Silva <[email protected]> * Fix new epochChanges version * Fix unused imports Co-authored-by:
André Silva <[email protected]>
-
emostov authored
* transition treasury to configurable moduleids * make election module id configurable * convert runtime and pallet to accept module id config elections-phragmen * add ModuleId to evm pallet * change society pallet to configurable module id * delete commented out module_id * delete commented out code and merge in upstream master * try and convert 4 whitespace to tab * fix remaining space to tab conversions * trivial cleaning * delete comment from elections-phragrems tests * trivial * Update frame/elections-phragmen/src/lib.rs * add docs for elections and elections phragmen * make has_lock test get moduleid dynamically * Apply suggestions from code review Co-Authored-By:
Amar Singh <[email protected]> * make sure get is imported to evm Co-authored-by:
Shawn Tabrizi <[email protected]> Co-authored-by:
Bastian Köcher <[email protected]> Co-authored-by:
Amar Singh <[email protected]> Co-authored-by:
Benjamin Kampmann <[email protected]>
-
Shawn Tabrizi authored
-
Alexander Theißen authored
Co-Authored-By:
Tomasz Drwięga <[email protected]> Co-Authored-By:
Sergei Pepyakin <[email protected]>
-
- Apr 23, 2020
-
-
Nikolay Volf authored
-
Ashley authored
-
Nikolay Volf authored
-
Nikolay Volf authored
-
- Apr 22, 2020
-
-
Ashley authored
* Fix the browser tests * Mistyping * Fix warnings Co-authored-by:
Pierre Krieger <[email protected]>
-
Bastian Köcher authored
-
Kian Paimani authored
* enum Pays for PaysFee * Fix doc test * Update bin/node/executor/tests/basic.rs * Update bin/node/executor/tests/basic.rs
-
- Apr 21, 2020
-
-
Rakan Alhneiti authored
* New approach to offchain signing. * Use in im-online * Rewrite to use Account<T> * DRY signing. * Implement send_raw_unsigned_transaction * WiP * Expunge LocalCall * Expunge LocalCall * Fix compilation. * Solve call. * Make it compile again. * Finalize implementation. * Change CreateTransaction * Clear CreateTransaction. * Add price payload * Send raw transaction * Submit signed payload / unsigned transaction (WIP) * Supertrait requirements on T::Signature * Validate signature of payload on an unsigned transaction * Fix encoding - part 1 * Make it compile. * Fix compilation of unsigned validator. * Pass price payload to the transaction * Make block number part of the signed payload * Send signed transaction * Implement all_accounts, any_account * Fix formatting * Implement submit_transaction * Submit signed transaction (ForAll, ForAny) * Fix formatting * Implement CreateSignedTransaction * Move sign and verify to AppCrypto * Sign transaction * Call `use_encoded` * Remove SubmitAndSignTransaction * Implement runtime using new SigningTypes * Adapt offchain example to changes * Fix im-online pallet * Quick fix: rename AuthorityId2 * Fix offchain example tests * Add a comment on why keystore is required in unsigned transaction test * Use UintAuthorityId instead of u64 * WIP * Remove IdentifyAccount from UintAuthorityId * Implement PublicWrapper type * Fix im-online tests * Fix runtime test * Bump spec version * Fix executor tests * Rename ImOnlineAuthId -> ImOnlineAuthorityId and formatting * Fix merge * Documentation * Revert u64 -> UintAuthorityId conversion * Fix string errors * Document public members in offchain module * Introduce SubmitTransaction * Update pallets to use SubmitTransaction * WIP * Use SubmitTransaction in offchain * Use `submit_unsigned_transaction` * Fix tests * Update docs * Remove SigningTypes requirement from `SendTransactionTypes` * Fix tests * Update frame/system/src/offchain.rs Co-Authored-By:
Kian Paimani <[email protected]> * Update frame/system/src/offchain.rs Co-Authored-By:
Kian Paimani <[email protected]> * Update frame/example-offchain-worker/src/tests.rs Co-Authored-By:
Kian Paimani <[email protected]> * Update frame/system/src/offchain.rs Co-Authored-By:
Kian Paimani <[email protected]> * Update frame/system/src/offchain.rs Co-Authored-By:
Kian Paimani <[email protected]> * Remove leftover from previous iterations * Change enum to struct * Remove public * Move mock to node/executor/tests * Cleanup test-helpers * Make `application-crypto` `std` feature internal The macros should not generate code that requires that the calling crate has a feature with the name `std` defined. * Revert cargo lock update * Use TestAuthorityId from common * Restore members of account to public * Tidy up imports * Fix benchmarking pallet * Add tests demonstrating ForAll, ForAny on signer * Move definition of AppCrypto in example-offchain-worker from tests to mod::crypto * Cleanup stray comment * Fix ValidTransaction * Re-fix CreateSignedTransaction * Address PR feedback * Add can_sign method to signer * Propagate error * Improve documentation * Fix vec! macro not available * Document SendTransactiontypes * Add some docs. * Split signing examples * Add tests for signing examples * WIP can_sign - PR feedback * WIP * Split for_any / for_all into different calls * Verify payload and signature in test * Fix can_sign implementation * Fix impl_version * Import Box from sp_std * Create issues for TODOs * Ignore doctest. * Add test directly to system. Adjust UintTypes. * Add some tests to account filtering. * Remove code samples and point to example offchain worker * Fix doc links * Fix im-online tests using signatures. Co-authored-by:
Tomasz Drwięga <[email protected]> Co-authored-by:
Kian Paimani <[email protected]> Co-authored-by:
Bastian Köcher <[email protected]>
-
- Apr 20, 2020
-
-
cheme authored
Co-Authored-By:
thiolliere <[email protected]>
-
Ashley authored
Co-Authored-By:
Pierre Krieger <[email protected]>
-
- Apr 17, 2020
-
-
Gavin Wood authored
* Add transaction_version * Semantic versioning for runtimes * Move new field to bottom * Versioning * Runtime versioning stuff. * Fix test * Adds tests and fixes bugs * Bump runtime Co-authored-by:
Bastian Köcher <[email protected]>
-
Nikolay Volf authored
* make new contructor * add metrics to txpool * fix review * fix doc comment * change to counters * Update client/transaction-pool/src/metrics.rs Co-Authored-By:
Max Inden <[email protected]> * Update client/transaction-pool/src/metrics.rs Co-Authored-By:
Max Inden <[email protected]> * Update client/transaction-pool/src/metrics.rs Co-Authored-By:
Max Inden <[email protected]> * Update client/transaction-pool/src/lib.rs Co-Authored-By:
Max Inden <[email protected]> * Update client/transaction-pool/src/lib.rs Co-Authored-By:
Max Inden <[email protected]> * use dedicated wrapper Co-authored-by:
Max Inden <[email protected]>
-
Xiliang Chen authored
* emit TipClosed event on success tip payout * test for events * bump version
-
- Apr 16, 2020
-
-
Nikolay Volf authored
* create parallel tasks extension * make type system happy * basic externalities * test for dynamic extensions * batching test * remove premature verify_batch * shnschnorrkel batch * alter test * shnschnorrkel test * executive batching * some docs * also multi/any signatgures * error propagation * styling * make verification extension optional * experimental ed25519 parallelization * some merge fallout * utilize task executor * merge fallout * utilize task executor more * another merge fallout * feature-gate sp-io * arrange toml * fix no-std * sr25519 batching and refactoring * add docs * fix name * add newline * fix block import test * long sr25519 test * blocking instead of parking * move everything in crypto * return batch_verify to check :) * use condvars * use multi-threaded executor for benches * don't call via host interface * try no spawning * add true * cleanup * straighten batching * remove signature check from this test (?) * remove now pointless test * remove another now useless test * fix warnings * Revert "remove another now useless test" This reverts commit bbdec24bb67ed4373072daef7c863e1a8825bd8b. * rethink the sp-io-part * Revert "remove now pointless test" This reverts commit 4d553066322e65782264caa6053d4cd5538df977. * fix wording * add wording * add todo and fix * return check and fix * add logging in sp-io * Update primitives/io/src/batch_verifier.rs Co-Authored-By:
cheme <[email protected]> * address review and use std condvar * account for early exit * address reivew * address review * more suggestions * add docs for batch verification * remove unused * more review suggestions * move to sp-runtime * add expects * remove blocks * use entry * Update primitives/io/src/batch_verifier.rs Co-Authored-By:
Bastian Köcher <[email protected]> * Update primitives/externalities/src/extensions.rs Co-Authored-By:
Bastian Köcher <[email protected]> * update overlooked note * remove stupid return * Update primitives/io/src/lib.rs Co-Authored-By:
Bastian Köcher <[email protected]> * Update primitives/io/src/lib.rs Co-Authored-By:
Bastian Köcher <[email protected]> * fix wording * bump spec_version Co-authored-by:
cheme <[email protected]> Co-authored-by:
Bastian Köcher <[email protected]>
-
Max Inden authored
* client/authority-discovery: Allow to be run by sentry node When run as a sentry node, the authority discovery module does not publish any addresses to the dht, but still discovers validators and sentry nodes of validators. * client/authority-discovery/src/lib: Wrap lines at 100 characters * client/authority-discovery: Remove TODO and unused import * client/authority-discovery: Pass role to new unit tests * client/authority-discovery: Apply suggestions Co-Authored-By:
André Silva <[email protected]> * bin/node/cli/src/service: Use expressions instead of statements Co-authored-by:
André Silva <[email protected]>
-
Nikolay Volf authored
-
Shawn Tabrizi authored
Co-Authored-By:
Kian Paimani <[email protected]>
-
- Apr 15, 2020
-
-
Gavin Wood authored
* Introduce trait * The trait * Generic * Basic impls. * Remove unneeded bounds * Minor changes * Switch over to the new DB trait * Integrated parity-db and added CLI for db selection * Default impl. * Fix logs. * Started integrating subdb * Apply suggestions from code review Co-Authored-By:
Cecile Tonglet <[email protected]> * Apply suggestions from code review Co-Authored-By:
Nikolay Volf <[email protected]> * Enable subdb * Bump parity-db * Fixed CLI macro * Fixed browser build * Fixed features * Sort out features * Use parity-db from crates.io * Typo Co-authored-by:
arkpar <[email protected]> Co-authored-by:
Cecile Tonglet <[email protected]> Co-authored-by:
Nikolay Volf <[email protected]>
-
Benjamin Kampmann authored
-
- Apr 14, 2020
-
-
Benjamin Kampmann authored
* bumping version * cargo update * adding changelog
-
Pierre Krieger authored
* Give names to channels * Fix * A couple more changes * More minor tweaks * Fix test
-
- Apr 13, 2020
-
-
Nikolay Volf authored
-
Gavin Wood authored
* Native version text was borked. * Unfix benchmarking.
-
- Apr 12, 2020
-
-
Ashley authored
* Fix browser node * Fix readme
-
- Apr 11, 2020
-
-
Alexander Theißen authored
This refunds weight and the weight bases fee back to the sender of an extrinsic after the dispatch.
-
- Apr 09, 2020
-
-
Stanislav Tkach authored
* Hide benchmarking CLI behind the feature flag * Add a message
-
Kian Paimani authored
* Collection of enhancement for staking phragmen. * Ditch signed extension * Fix build * Update frame/staking/src/lib.rs Co-Authored-By:
thiolliere <[email protected]> * Update frame/staking/src/tests.rs Co-Authored-By:
thiolliere <[email protected]> * Fix reward limits * Disallow payout_stakers * Remove unused import Co-authored-by:
thiolliere <[email protected]>
-
Nikolay Volf authored
* 128 -> 1024 * add trace and set = 512 * fix doc comment
-
- Apr 08, 2020
-
-
Bastian Köcher authored
* Add new RPC method to get the chain type This adds a new RPC method to get the chain type of the running chain. The chain type needs to be specified in the chain spec. This should make it easier for tools/UI to display extra information without needing to rely on parsing the chain name. * Update client/rpc-api/src/system/mod.rs Co-Authored-By:
Tomasz Drwięga <[email protected]> * Primitive crate * Feedback Co-authored-by:
Tomasz Drwięga <[email protected]>
-
Tomasz Drwięga authored
* Configurable Unsigned Priority. * Use the new builder. * Fix tests. * Fix benches. * Remove unused import. * Rename for_pallet
-
- Apr 07, 2020
-
-
Cecile Tonglet authored
* WIP Forked at: d6aa8e95 Parent branch: origin/master * Rename IntoConfiguration to CliConfiguration * Renamed into_configuration to create_configuration * WIP Forked at: d6aa8e95 Parent branch: origin/master * WIP Forked at: d6aa8e95 Parent branch: origin/master * Move keystore params to its own module * Use in-memory keystore even for build-spec * Enforce proper value for node name * dev_key_seed * Telemetry endpoints * rustfmt * Converted all RunCmd * rustfmt * Added export-blocks * Missed something * Removed config_path in NetworkConfiguration (not used) * Fixed warnings * public_addresses is used but never set, keeping it * Merge Configuration.node and NetworkConfiguration.node_name ...because they are the same thing * Added: import-blocks * Adding a proc_macro to help impl SubstrateCli * WIP Forked at: d6aa8e95 Parent branch: origin/master * WIP Forked at: d6aa8e95 Parent branch: origin/master * WIP Forked at: d6aa8e95 Parent branch: origin/master * Re-export spec_factory from sc_cli * Re-added all the commands * Refactored node_key_params * Fixed previous refucktoring * Clean-up and removed full_version() * Renamed get_is_dev to not confuse with Configuration field * Fixed sc-cli-derive example * Fixing tests * Fixing tests and removing some (will re-add later) * Fixing more tests * Removes the need of type parameter * Converting bin/node and simplifying API * Converting more * Converting last command * WIP Forked at: d6aa8e95 Parent branch: origin/master * Fixing tests and added default for WasmExecutionMethod * Fixing stuff * Fixed something I broke oops * Update Cargo.lock * Moving things around * Convert everything to Result * Added new macros to simplify the impl of CliConfiguration * Added a macro to generate CliConfiguration automatically for subcommands * Revert... too many macros (this one is not really useful) This reverts commit 9c516dd38b40fbc420b02c1f8e61d5b2b1a4e434. * Renamed is_dev to get_is_dev Good enough for now * Fixed name roles (this is plural, not singular) * Clean-up * Re-export NodeKeyConfig and TelemetryEndpoints from sc_service * Improve styling/formatting * Added copyrights * Added doc and fixed warnings * Added myself to code owners * Yes it is needed according to the history * Revert formatting * Fixing conflict * Updated build.rs * Cargo.lock * Clean-up * Update client/cli-derive/Cargo.toml Co-Authored-By:
Seun Lanlege <[email protected]> * Fail if using proc_macro and build.rs is not set properly * Dropped all get_ in front of methods * Clean-up * Fixing proc macro missing env var * Get the configuration inside the Runtime (needed for polkadot) * Clean-up * Get is_dev from argument like the others * Get chain ID instead of chain spec from shared params * &self is passed to spec_factory/load_spec * Wrong text * Fix example * Officialize macro and made a cool doc * Renamed spec_factory to load_spec (substrate_cli_configuration) * Removed not so useful ChainSpec * Renamed SubstrateCLI to SubstrateCli * Added changelog for impl_version being full now * Renamed Runtime to Runner * Update changelog to show example * Removed option on database cache size * WIP Forked at: d6aa8e95 Parent branch: origin/master * Fix on removal of option * typo * Clean-up imports * Added info in Cargo.toml * typo * remarks * Moved function for build.rs to substrate-build-script-utils * Fixed example & test of cli-derive * Moved function for build.rs to substrate-build-script-utils * Renamed substrate_cli_configuration to substrate_cli oops It implements SubstrateCli not CliConfiguration! * Added documentation and wrapper macro * Removed option on database cache size * Removed option on database cache size * Clean-up * Reduce risk of errors due to typos * Removed option on database cache size * Added NOTE as suggested * Added doc as suggested * Fixed test * typo * renamed runtime to runner * Fixed weird argument * More commas * Moved client/cli-derive to client/cli/derive * Added 7 tests for the macros * Improve error message * Upgrade assert_cmd * Fixing missing stuff * Fixed unused import * Improve SubstrateCli doc * Applied suggestions * Fix and clean-up imports * Started replacing macros WIP * WIP Forked at: d6aa8e95 Parent branch: origin/master * WIP Forked at: d6aa8e95 Parent branch: origin/master * WIP Forked at: d6aa8e95 Parent branch: origin/master * Started removing substrate_cli * WIP Forked at: d6aa8e95 Parent branch: origin/master * WIP Forked at: d6aa8e95 Parent branch: origin/master * WIP Forked at: d6aa8e95 Parent branch: origin/master * fixed bug introduced while refactoring * Renamed NetworkConfigurationParams to NetworkParams for consistency sake * Fixed test * Update client/cli/src/commands/runcmd.rs Co-Authored-By:
Bastian Köcher <[email protected]> * Update client/cli/src/commands/runcmd.rs Co-Authored-By:
Bastian Köcher <[email protected]> * Update client/cli/src/commands/export_blocks_cmd.rs Co-Authored-By:
Bastian Köcher <[email protected]> * Update client/cli/src/commands/check_block_cmd.rs Co-Authored-By:
Bastian Köcher <[email protected]> * Update bin/node/cli/src/command.rs Co-Authored-By:
Bastian Köcher <[email protected]> * Update bin/node/cli/src/command.rs Co-Authored-By:
Bastian Köcher <[email protected]> * Update client/cli/src/commands/export_blocks_cmd.rs Co-Authored-By:
Bastian Köcher <[email protected]> * Revert "Update client/cli/src/commands/export_blocks_cmd.rs" This reverts commit 5906776953392c02beac6bc0bf50f8cbe1a12a01. * Revert "Update client/cli/src/commands/check_block_cmd.rs" This reverts commit f705f42b7f3d732be001141afee210fe46a1ef47. * Revert "Update client/cli/src/commands/export_blocks_cmd.rs" This reverts commit 8d57c0550164449e6eb2d3bacb04c750c714fcea. * Revert "Update client/cli/src/commands/runcmd.rs" This reverts commit 93e74cf5d2e1c0dc49cdff8608d59fc40fc59338. * Revert "Update client/cli/src/commands/runcmd.rs" This reverts commit 11d527ba345c0d79f0d3b5b071933d95474d0614. * Update client/cli/src/commands/export_blocks_cmd.rs Co-Authored-By:
Bastian Köcher <[email protected]> * Update client/cli/src/commands/import_blocks_cmd.rs Co-Authored-By:
Bastian Köcher <[email protected]> * Update client/cli/src/commands/purge_chain_cmd.rs Co-Authored-By:
Bastian Köcher <[email protected]> * Changed ::sc_cli to $crate in the macro * fixed tests * fixed conflicts * Fixing test * Update client/cli/src/commands/purge_chain_cmd.rs Co-Authored-By:
Bastian Köcher <[email protected]> * Update client/cli/src/params/pruning_params.rs Co-Authored-By:
Bastian Köcher <[email protected]> * Remove comment as suggested * Apply suggestion * Update client/cli/src/commands/purge_chain_cmd.rs Co-Authored-By:
Bastian Köcher <[email protected]> * Update client/cli/src/commands/purge_chain_cmd.rs Co-Authored-By:
Bastian Köcher <[email protected]> * Update client/cli/src/commands/purge_chain_cmd.rs Co-Authored-By:
Bastian Köcher <[email protected]> * Update utils/frame/benchmarking-cli/src/command.rs Co-Authored-By:
Bastian Köcher <[email protected]> * Update client/cli/src/runner.rs Co-Authored-By:
Bastian Köcher <[email protected]> * Update client/cli/src/runner.rs Co-Authored-By:
Bastian Köcher <[email protected]> * Update client/cli/src/runner.rs Co-Authored-By:
Bastian Köcher <[email protected]> * Update client/cli/src/params/pruning_params.rs Co-Authored-By:
Bastian Köcher <[email protected]> * Update client/cli/src/params/node_key_params.rs Co-Authored-By:
Bastian Köcher <[email protected]> * Update client/cli/src/params/network_params.rs Co-Authored-By:
Bastian Köcher <[email protected]> * Update client/cli/src/lib.rs Co-Authored-By:
Bastian Köcher <[email protected]> * Update client/cli/src/config.rs Co-Authored-By:
Bastian Köcher <[email protected]> * Added doc * Fixed error introduced after applying suggestion * Revert "Update client/cli/src/params/pruning_params.rs" This reverts commit 0574d06a4f1efd86e94c1214420a12e7a4be0099. * Print error * Apply suggestions from code review * Remove useless Results * Fixed CI failing on polkadot approval Co-authored-by:
Seun Lanlege <[email protected]> Co-authored-by:
Bastian Köcher <[email protected]>
-
Marcio Diaz authored
* Add initial report_ofence bench. * Remove unused imports * Style nit * Add nominators * Remove logs. * Nits. * Add nominators param. * Reorg, comment. * Remove whitespaces. * Apply review suggestion: move benchmark to own crate. * Remove import. * Remove line. * Add feature flag. * Pass can_report. * Cleaning up. * More cleaning
-