- Feb 16, 2021
-
-
Gavin Wood authored
* Move dust collection hook to outside of account mutate * Fix dust cleanup in nested mutates. * Fixes * Fixes * Apply suggestions from code review Co-authored-by:
Guillaume Thiolliere <[email protected]> * dust removal reentrancy test case integration (#8133) * dust removal reentrancy test case integration * Update frame/balances/src/tests_reentrancy.rs Co-authored-by:
Kian Paimani <[email protected]> * Update frame/balances/src/tests_reentrancy.rs Co-authored-by:
Kian Paimani <[email protected]> * Update frame/balances/src/tests_reentrancy.rs Co-authored-by:
Kian Paimani <[email protected]> * Update frame/balances/src/tests_reentrancy.rs Co-authored-by:
Kian Paimani <[email protected]> * Update frame/balances/src/tests_reentrancy.rs Co-authored-by:
Kian Paimani <[email protected]> * dust removal reentrancy test case integration | removed dependency on tests.rs * dust removal reentrancy test case integration | formatt correction * dust removal reentrancy test case integration | formatt correction Co-authored-by:
Kian Paimani <[email protected]> Co-authored-by:
Guillaume Thiolliere <[email protected]> Co-authored-by:
RK <[email protected]> Co-authored-by:
Kian Paimani <[email protected]>
-
Peter Goodspeed-Niklaus authored
* Create a macro which automates creation of benchmark test suites. * bump impl_version * allow unused on test_bench_by_name * use proper doctest ignore attribute * Explicitly hand the Module to the test suite Much better practice than depending on it showing up implicitly in the namespace. * explicitly import what we need into `mod tests` * bench_module is `ident` not `tt` Co-authored-by:
Guillaume Thiolliere <[email protected]> * allow end users to specify arguments for new_test_ext This turned out to be surprisingly easy. On reflection, it turns out that of course the compiler can't eagerly evaluate the function call, but needs to paste it in everywhere desired. * enable explicitly specifying the path to the benchmarks invocation also enable optional trailing commas * Revert "bump impl_version" This reverts commit 0209e4de33fd43873f8cfc6875815d0fd6151e63. * list failing benchmark tests and the errors which caused the failure * harden benchmark tests against internal panics * suppress warning about ignored profiles unfortunately, setting the profile here doesn't do anything; we'd need to set it in every leaf package anyway. However, as this was just making the default explicit anyway, I think it's safe enough to remove entirely. * impl_benchmark_test_suite for assets * impl_benchmark_test_suite for balances * impl_benchmark_test_suite for bounties * impl_benchmark_test_suite for Collective * impl_benchmark_test_suite for Contracts * impl_benchmark_test_suite for Democracy * don't impl_benchmark_test_suite for Elections-Phragmen * impl_benchmark_test_suite for Identity Note that Identity tests currently fail. They failed in an identical way before this change, so as far as I'm concerned, the status quo is good enough for now. * impl_benchmark_test_suite for ImOnline * impl_benchmark_test_suite for indices For this crate also, the test suite fails identically with and without this change, so we can say that this change is not the cause of the tests' failure to compile. * impl_benchmark_test_suite for lottery * impl_benchmark_test_suite for merkle-mountain-range * impl_benchmark_test_suite for Multisig These tests fail identically with and without the change, so the change seems unlikely to be the origin of the failures. * impl_benchmark_test_suite for offences * impl_benchmark_test_suite for Proxy Fails identically with and without this change. * impl_benchmark_test_suite for scheduler * impl_benchmark_test_suite for session It turns out to be important to be able to exclude items marked `#[extra]` sometimes. Who knew? * impl_benchmark_test_suite for staking * impl_benchmark_test_suite for system * impl_benchmark_test_suite for timestamp * impl_benchmark_test_suite for tips * impl_benchmark_test_suite for treasury * impl_benchmark_test_suite for utility Note that benchmark tests fail identically before and after this change. * impl_benchmark_test_suite for vesting * fix wrong module name in impl_benchmark_test_suite in Offences * address line length nits * enable optional keyword argument: exec_name Took a _lot_ of macro-wrangling to get the functionality that I want, but now you have the option to pass in ```rust impl_benchmark_test_suite!( Elections, crate::tests::ExtBuilder::default().desired_members(13).desired_runners_up(7), crate::tests::Test, exec_name = build_and_execute, ); ``` and have it expand out properly. A selected fragment of the expansion: ```rust fn test_benchmarks() { crate::tests::ExtBuilder::default() .desired_members(13) .desired_runners_up(7) .build_and_execute(|| { ``` * get rid of dead code Co-authored-by:
Guillaume Thiolliere <[email protected]>
-
- Feb 15, 2021
-
-
André Silva authored
* grandpa: make the VotingRule api async * grandpa: add docs to VotingRuleResult * grandpa: formatting * grandpa: use async blocks Co-authored-by:
Bastian Köcher <[email protected]> * grandpa: expose VotingRuleResult * grandpa: revert some broken changes to async syntax * grandpa: use finality-grandpa v0.14.0 * grandpa: bump impl_version Co-authored-by:
Bastian Köcher <[email protected]>
-
Shawn Tabrizi authored
-
- Feb 10, 2021
-
-
Benjamin Kampmann authored
* bumping version for next release * add changelog * add guide
-
Shaun Wang authored
* Migrate pallet-timestamp to pallet attribute macro. * Migrate inherent. * Unify private visbility. * Update benchmarking. * Update storage usages.
-
André Silva authored
* babe: set longevity for equivocation report transactions * grandpa: set longevity for equivocation report transaction * babe, grandpa: fix tests * node: add ReportLongevity to babe and grandpa modules * node: bump spec_version
-
Andrew Jones authored
* Initial migration of balances pallet * Fix some errors * Remove unused imports * Formatting and removing some todos * Delete Subtrait * Add genesis builder impls for tests * Fix GenesisConfig impl * Make set_balance visible to tests, rename RawEvent to Event * Fix tests with Event rename etc. * More test RawEvent renames * Even more RawEvent renames * Rename module to pallet in comments * Add PalletInfo impl to avid storage collision, fixes tests * Apply review suggestion: remove trailing a Co-authored-by:
David <[email protected]> * BalancesEvent alias * Remove BalancesEvent alias * Review suggestion: remove redundant comment * Apply review suggestion: make vis super * Fis doc links * Add RawEvent alias * Add missing Instance parameter to deprecated RawEvent alias * Fix RawEvent deprecation warnings Co-authored-by:
David <[email protected]>
-
Shaun Wang authored
* Fix pallet attribute macro guidelines. * Typo fixes.
-
thiolliere authored
-
- Feb 09, 2021
-
-
Andrew Jones authored
-
thiolliere authored
* replace last occurences * Update frame/support/src/traits.rs Co-authored-by:
Kian Paimani <[email protected]> * Update frame/support/test/src/lib.rs Co-authored-by:
Kian Paimani <[email protected]> * fix dispatch test * move PanicPalletInfo to tests module Co-authored-by:
Kian Paimani <[email protected]>
-
Bastian Köcher authored
Switches to the latest version everywhere now, as I fixed the problems in the crate ;)
-
- Feb 06, 2021
-
-
thiolliere authored
* impl some more * add serde * remove unused * fix staking fuzz * fix system bench Co-authored-by:
Shawn Tabrizi <[email protected]>
-
- Feb 05, 2021
-
-
Alexander Theißen authored
* contracts: Remove ConfigCache * cargo run --release --features=runtime-benchmarks --manifest-path=bin/node/cli/Cargo.toml -- benchmark --chain=dev --steps=50 --repeat=20 --pallet=pallet_contracts --extrinsic=* --execution=wasm --wasm-execution=compiled --heap-pages=4096 --output=./frame/contracts/src/weights.rs --template=./.maintain/frame-weight-template.hbs * Fixup test Co-authored-by:
Parity Benchmarking Bot <[email protected]>
-
Alejandro Martinez Andres authored
* CheckSpecVersion reference fix * Update frame/example/src/lib.rs Co-authored-by:
Kian Paimani <[email protected]> Co-authored-by:
Guillaume Thiolliere <[email protected]> Co-authored-by:
Kian Paimani <[email protected]>
-
- Feb 04, 2021
-
-
Benjamin Kampmann authored
Updates dependencies: parity-db 0.2.2 paste prometheus 0.11 cfg-if 1.0 strum 0.20 env_logger 0.8 pin-project prost nix platforms quickcheck 1.0
-
Andrew Jones authored
* Migrate bounties tests to use construct_runtime * Migrate contracts tests to use construct_runtime * Migrate democracy tests to use construct_runtime * review: rename TreasuryEvent -> TreasuryError
-
thiolliere authored
* migrate some more pallets * revert example-offcahin-worker as not straightforward * fix mmr
-
André Silva authored
* grandpa: check equivocation report staleness on `validate_unsigned` * babe: check equivocation report staleness on `validate_unsigned` * node: bump spec_version * babe, grandpa: remove duplicate call destructuring
-
David authored
* Prep: move things around to suggested order * Compiles, tests pass * cleanup * cleanup 2 * Fix dead doc-links * Add back documentation for storage items * Switch benchmarks to use `Event` rather than `RawEvent`. * Update frame/assets/src/lib.rs Co-authored-by:
Guillaume Thiolliere <[email protected]> * reviwe feedback * Obey line length checks Co-authored-by:
Guillaume Thiolliere <[email protected]>
-
Alexander Theißen authored
* contracts: Implement refcounting for wasm code * contracts: Charge rent for code storage * contracts: Fix dispatchables erroneously refunding base costs * Fixed typos in comments. Co-authored-by:
Andrew Jones <[email protected]> * Remove awkward empty line * Fix more typos in docs * Fix typos in docs Co-authored-by:
Andrew Jones <[email protected]> * Split up complicated expression Co-authored-by:
Andrew Jones <[email protected]> * review: Remove unused return value * Fix typos Co-authored-by:
Andrew Jones <[email protected]> * review: Fix refcount being reset to one on re-instrumentation * Document evictable_code parameter * Make Executable::execute consume and store itself * Added comments about stale values * Disregard struct size in occupied_storage() Co-authored-by:
Andrew Jones <[email protected]>
-
- Feb 03, 2021
-
-
Bastian Köcher authored
* Convert AURA to new pallet macro * AURA: Switch to `CurrentSlot` instead of `LastTimestamp` This switches AURA to use `CurrentSlot` instead of `LastTimestamp`. * Add missing file * Update frame/aura/src/migrations.rs Co-authored-by:
André Silva <[email protected]> * Remove the runtime side provide inherent code * Use correct weight * Add TODO * Remove the Inherent from AURA *
🤦 * Remove unused stuff Co-authored-by:André Silva <[email protected]>
-
Alexander Theißen authored
-
Shaopeng Wang authored
-
- Feb 02, 2021
-
-
Liu-Cheng Xu authored
* Decouple the session validators from im-online * . * Add SessionInterface trait in im-online Add ValidatorId in im-online Trait Make im-online compile Make substrate binary compile * Fix merging issue * Make all compile * Fix tests * Avoid using frame dep in primitives via pallet-session-common * Merge ValidatorSet into SessionInterface trait Wrap a few too long lines Add some docs * Move pallet-sesion-common into pallet-session * Move SessionInterface to sp-session and impl it in session pallet Ref https://github.com/paritytech/substrate/pull/7127#discussion_r494892472 * Split put historical::FullValidatorIdentification trait * Fix line width * Fix staking mock * Fix session doc test * Simplify <T as ValidatorIdentification<AccountId>>::ValidatorId as ValidatorId<T> * Nits * Clean up. * Make it compile by commenting out report_offence_im_online bench * Tests * Nits * Move OneSessionHandler to sp-session * Fix tests * Add some docs * . * Fix typo * Rename to ValidatorSet::session_index() * Add some more docs * . * Remove extra empty line * Fix line width check . * Apply suggestions from code review * Cleaup Cargo.toml * Aura has migrated to Pallet now Co-authored-by:
Tomasz Drwięga <[email protected]>
-
Bastian Köcher authored
-
Alexander Theißen authored
* contracts: Document seal_input * contracts: Improve `ReturnCode` docs. * contracts: Improve seal_restore_to docs * review: Improved wording
-
Alexander Theißen authored
* contracts: Remove redundant bool argument from the eviction event * contracts: Improve event documentation * contracts: Emit event on contract termination
-
- Feb 01, 2021
-
-
Alexander Popiak authored
-
Alexander Popiak authored
* make AllModules public * add doc comments for AllModules
-
yjh authored
-
- Jan 29, 2021
-
-
Amar Singh authored
* () * master.into() * Update frame/support/src/inherent.rs Co-authored-by:
Bastian Köcher <[email protected]> * address comment Co-authored-by:
Bastian Köcher <[email protected]>
-
thiolliere authored
* update cargo.toml * use 2.0 in mmmr
-
- Jan 28, 2021
-
-
Bastian Köcher authored
* Introduce a `Slot` type Instead of having some type definition that only was used in half of the code or directly using `u64`, this adds a new unit type wrapper `Slot`. This makes it especially easy for the outside api to know what type is expected/returned. * Change epoch duratioC * rename all instances of slot number to slot * Make the constructor private Co-authored-by:
André Silva <[email protected]>
-
Tomasz Drwięga authored
* Add stateless verification helper function. * Split MMR primitives. * Add RuntimeAPI * RuntimeAPI with OpaqueLeaves * Bump spec_version,. * Move primitives back to frame. * Fix OpaqueLeaf encoding. * Add block number to frame_system implementation of LeafDataProvider. * Relax leaf codec requirements and fix OpaqueLeaf * Add root to debug line. * Apply suggestions from code review Co-authored-by:
Hernando Castano <[email protected]> * Typo. Co-authored-by:
Hernando Castano <[email protected]>
-
- Jan 26, 2021
-
-
thiolliere authored
-
thiolliere authored
-
- Jan 25, 2021
-
-
Andrew Jones authored
* Fix weight syntax in comments * Mention to add `IsType` bound * Link to subsee * Fix link * Update frame/support/procedural/src/pallet/parse/call.rs Co-authored-by:
David <[email protected]> * Apply review suggestion from @dvdplm , make StorageInstance doc link * fix ui test Co-authored-by:
David <[email protected]> Co-authored-by:
thiolliere <[email protected]>
-
Andrew Jones authored
* WIP converting balances tests to construct_runtime * Converting balances tests_local to construct_runtime * Fix up system and balances Events * Use static Call instance in tests * Migrate indices to construct_runtime * Migrate babe test to construct_runtime * Update frame/indices/src/mock.rs Co-authored-by:
Guillaume Thiolliere <[email protected]> * Update frame/babe/src/mock.rs Co-authored-by:
Guillaume Thiolliere <[email protected]> * Update frame/babe/src/mock.rs Co-authored-by:
Bastian Köcher <[email protected]> * Remove redundant import Co-authored-by:
Guillaume Thiolliere <[email protected]> Co-authored-by:
Bastian Köcher <[email protected]>
-