Skip to content
  1. Jul 05, 2021
  2. Jul 01, 2021
  3. Jun 28, 2021
    • Kian Paimani's avatar
      Decouple Staking and Election - Part 3: Signed Phase (#7910) · e6c83710
      Kian Paimani authored
      
      
      * Base features and traits.
      
      * pallet and unsigned phase
      
      * add signed phase.
      
      * remove comments
      
      * Undo bad formattings.
      
      * some formatting cleanup.
      
      * Small self-cleanup.
      
      * Add todo
      
      * Make it all build
      
      * self-review
      
      * Some doc tests.
      
      * Some changes from other PR
      
      * Fix session test
      
      * Update bin/node/runtime/src/lib.rs
      
      Co-authored-by: default avatarPeter Goodspeed-Niklaus <[email protected]>
      
      * Fix name.
      
      * cargo run --release --features=runtime-benchmarks --manifest-path=bin/node/cli/Cargo.toml -- benchmark --chain=dev --steps=50 --repeat=20 --pallet=pallet_election_provider_multi_phase --extrinsic=* --execution=wasm --wasm-execution=compiled --heap-pages=4096 --output=./frame/election-provider-multi-phase/src/weights.rs --template=./.maintain/frame-weight-template.hbs
      
      * typos and verbiage
      
      * no glob imports in signed.rs
      
      * meaningful generic type parameters for SignedSubmission
      
      * dedup feasibility check weight calculation
      
      * simplify/optimize fn insert_submission
      
      * tests: remove glob, cause to build without error
      
      * use sp_std::vec::Vec
      
      * maintain invariant within fn insert_submission
      
      * fix accidentally ordering the list backward
      
      * intentionally order the list in reverse
      
      * get rid of unused import
      
      * ensure signed submissions are cleared in early elect
      
      * finalize the signed phase when appropriate
      
      - ensure we don't leave storage lying around, even if elect called prematurely
      - test that proposition
      - disable the unsigned phase if a viable solution from the signed phase exists
      - ensure signed phase finalization weight is accounted for
      
      * resolve dispatch error todo
      
      * update assumptions in submit benchmark
      
      * cargo run --release --features=runtime-benchmarks --manifest-path=bin/node/cli/Cargo.toml -- benchmark --chain=dev --steps=50 --repeat=20 --pallet=pallet_election_provider_multi_phase --extrinsic=* --execution=wasm --wasm-execution=compiled --heap-pages=4096 --output=./frame/election-provider-multi-phase/src/weights.rs --template=./.maintain/frame-weight-template.hbs
      
      * line length
      
      * make a few more things pub
      
      * restore missing import
      
      * update ui test output
      
      * update tests from master branch
      
      * cargo run --release --features=runtime-benchmarks --manifest-path=bin/node/cli/Cargo.toml -- benchmark --chain=dev --steps=50 --repeat=20 --pallet=pallet_election_provider_multi_phase --extrinsic=* --execution=wasm --wasm-execution=compiled --heap-pages=4096 --output=./frame/election-provider-multi-phase/src/weights.rs --template=./.maintain/frame-weight-template.hbs
      
      * remove duplicate definitions
      
      * remove signed reward factor due to its attack potential
      
      * Update frame/election-provider-multi-phase/src/signed.rs
      
      Co-authored-by: default avatarKian Paimani <[email protected]>
      
      * remove SignedRewardMax; no longer necessary
      
      * compute the encoded size without actually encoding
      
      * remove unused PostInfo
      
      * pub use some stuff
      
      Co-authored-by: default avatarKian Paimani <[email protected]>
      
      * ensure `pub use` things are in fact `pub`
      
      * add event information: was another solution ejected to make room
      
      * unconditionally run the unsigned phase even if signed was successful
      
      * remove dead test code
      
      * meaningful witness data name
      
      * use errors instead of defensive `unwrap_or_default`
      
      * get rid of a log message redundant with an event
      
      * saturating math
      
      Co-authored-by: default avatarShawn Tabrizi <[email protected]>
      
      * import Saturating
      
      * mv `fn submit` to end of call
      
      * add log line
      
      * Use a better data structure for SignedSubmissions instead of Vec (#8933)
      
      * Remove: (#8748)
      
      * `NetworkStatusSinks`
      * `sc_service::SpawnTasksParams::network_status_sinks`
      
      Also:
      * `sc_service::build_network()` does not return `network_status_sinks`
      
      * CI: fix simnet trigger (#8927)
      
      * CI: chore
      
      * CI: pin simnet version
      
      * More sc-service config reexports (#8887)
      
      * Reexport ExecutionStrategies and ExecutionStrategy
      
      * Reexport more of the network
      
      * Reexport the ExecutionStrategy as it's used within ExecutionStrategies
      
      * Fix check runtime CI (#8930)
      
      * Fix check_runtime.sh script
      
      * contracts: Remove confusing "Related Modules" doc
      
      * Bump parity-wasm and pwasm-utils to the newest versions everywhere (#8928)
      
      * BROKEN: convert SignedSubmissions to BoundedBTreeSet
      
      Eventually, once it works, this change should improve overall performance.
      However, in the meantime, the trait bounds aren't playing nicely, and
      this is turning into too much of a pain to handle right now as part of
      /#7910. We can take care of it later.
      
      * Simple `MaxBoundedLen` Implementations (#8793)
      
      * implement max_values + storages info
      
      * some formatting + doc
      
      * sudo sanity check
      
      * timestamp
      
      * assets (not working)
      
      * fix assets
      
      * impl for proxy
      
      * update balances
      
      * rename StoragesInfo -> PalletStorageInfo
      
      * merge both StorageInfoTrait and PalletStorageInfo
      
      I think it is more future proof. In the future some storage could make
      use of multiple prefix. Like one to store how much value has been
      inserted, etc...
      
      * Update frame/support/procedural/src/storage/parse.rs
      
      Co-authored-by: default avatarPeter Goodspeed-Niklaus <[email protected]>
      
      * Update frame/support/procedural/src/storage/storage_struct.rs
      
      Co-authored-by: default avatarPeter Goodspeed-Niklaus <[email protected]>
      
      * Fix max_size using hasher information
      
      hasher now expose `max_len` which allows to computes their maximum len.
      For hasher without concatenation, it is the size of the hash part,
      for hasher with concatenation, it is the size of the hash part + max
      encoded len of the key.
      
      * fix tests
      
      * fix ui tests
      
      * Move `MaxBoundedLen` into its own crate (#8814)
      
      * move MaxEncodedLen into its own crate
      
      * remove MaxEncodedLen impl from frame-support
      
      * add to assets and balances
      
      * try more fixes
      
      * fix compile
      
      Co-authored-by: default avatarShawn Tabrizi <[email protected]>
      
      * nits
      
      * fix compile
      
      * line width
      
      * fix max-values-macro merge
      
      * Add some derive, needed for test and other purpose
      
      * use weak bounded vec in some cases
      
      * Update lib.rs
      
      * move max-encoded-len crate
      
      * fix
      
      * remove app crypto for now
      
      * width
      
      * Revert "remove app crypto for now"
      
      This reverts commit 73623e9933d50648e0e7fe90b6171a8e45d7f5a2.
      
      * unused variable
      
      * more unused variables
      
      * more fixes
      
      * Add #[max_encoded_len_crate(...)] helper attribute
      
      The purpose of this attribute is to reduce the surface area of
      max_encoded_len changes. Crates deriving `MaxEncodedLen` do not
      need to add it to `Cargo.toml`; they can instead just do
      
      ```rust
      \#[derive(Encode, MaxEncodedLen)]
      \#[max_encoded_len_crate(frame_support::max_encoded_len)]
      struct Example;
      ```
      
      * fix a ui test
      
      * use #[max_encoded_len_crate(...)] helper in app_crypto
      
      * remove max_encoded_len import where not necessary
      
      * update lockfile
      
      * fix ui test
      
      * ui
      
      * newline
      
      * fix merge
      
      * try fix ui again
      
      * Update max-encoded-len/derive/src/lib.rs
      
      Co-authored-by: default avatarPeter Goodspeed-Niklaus <[email protected]>
      
      * extract generate_crate_access_2018
      
      * Update lib.rs
      
      * compiler isnt smart enough
      
      Co-authored-by: default avatarthiolliere <[email protected]>
      Co-authored-by: default avatarPeter Goodspeed-Niklaus <[email protected]>
      Co-authored-by: default avatarPeter Goodspeed-Niklaus <[email protected]>
      
      * remove duplicate Issued/Burned events (#8935)
      
      * weather -> whether (#8938)
      
      * make remote ext use batch ws-client (#8916)
      
      * make remote ext use batch ws-client
      
      * Add debug log for key length
      
      * better assertions
      
      * new sanity_checl
      
      * try and make it work with batch
      
      * update test
      
      * remove exctra uri
      
      * add missing at
      
      * remove unused rpc stuff
      
      * improve
      
      Co-authored-by: default avataremostov <[email protected]>
      
      * Make `Schedule` fields public to allow for customization (#8924)
      
      * Make `Schedule` fields public for customization
      
      * Fix doc typo
      
      Co-authored-by: default avatarAndrew Jones <[email protected]>
      
      Co-authored-by: default avatarAndrew Jones <[email protected]>
      
      * Session key should be settable at genesis even for non-endowed accounts (#8942)
      
      * Session key should be settable at genesis even for non-endowed accounts
      
      * Docs
      
      * Migrate pallet-scored-pool to pallet attribute macro (#8825)
      
      * Migrate pallet-scored-pool to pallet attribute macro.
      
      * Remove dummy event.
      
      * Apply review suggestions.
      
      * Bump retain_mut from 0.1.2 to 0.1.3 (#8951)
      
      Bumps [retain_mut](https://github.com/upsuper/retain_mut) from 0.1.2 to 0.1.3.
      - [Release notes](https://github.com/upsuper/retain_mut/releases)
      - [Commits](https://github.com/upsuper/retain_mut/compare/v0.1.2...v0.1.3)
      
      Signed-off-by: default avatardependabot[bot] <[email protected]>
      
      Co-authored-by: default avatardependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
      
      * Use correct CreateInherentDataProviders impl for manual seal (#8852)
      
      * use correct CreateInherentDataProviders impl for manual seal
      
      * add babe inherent provider
      
      * move client into factory fn
      
      * Refactor code a little bit (#8932)
      
      * Optimize `next_storage_key` (#8956)
      
      * Optimize `next_storage_key`
      
      - Do not rely on recursion
      - Use an iterator over the overlay to not always call the same method
      
      * Fix bug
      
      * Add deserialize for TransactionValidityError in std. (#8961)
      
      * Add deserialize for TransactionValidityError in std.
      
      * Fix derives
      
      * Bump getrandom from 0.2.2 to 0.2.3 (#8952)
      
      Bumps [getrandom](https://github.com/rust-random/getrandom) from 0.2.2 to 0.2.3.
      - [Release notes](https://github.com/rust-random/getrandom/releases)
      - [Changelog](https://github.com/rust-random/getrandom/blob/master/CHANGELOG.md)
      - [Commits](https://github.com/rust-random/getrandom/compare/v0.2.2...v0.2.3)
      
      Signed-off-by: default avatardependabot[bot] <[email protected]>
      
      Co-authored-by: default avatardependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
      
      * Allow usage of path in construct_runtime! (#8801)
      
      * Allow usage of path in construct_runtime!
      
      * Fix whitespace
      
      * Fix whitespace
      
      * Make expand_runtime_metadata accept slice instead of Iterator
      
      * Include Call and Event in construct_runtime for testing
      
      * Migrate impl_outer_event to proc macro
      
      * Fix integrity_test_works
      
      * Update UI test expectations
      
      * Factor in module path while generating enum variant or fn names
      
      * Use ParseStream::lookahead for more helpful error messages
      
      * Remove generating outer_event_metadata
      
      * Ensure pallets with different paths but same last path segment can coexist
      
      * Remove unnecessary generated function
      
      * Migrate decl_outer_config to proc macro
      
      * Add default_filter test for expand_outer_origin
      
      * Allow crate, self and super keywords to appear in pallet path
      
      * Add UI test for specifying empty pallet paths in construct_runtime
      
      * Reduce cargo doc warnings (#8947)
      
      Co-authored-by: default avatarBastian Köcher <[email protected]>
      
      * Update wasmtime to 0.27 (#8913)
      
      * Update wasmtime to 0.27
      
      A couple of notes:
      
      - Now we are fair about unsafeness of runtime creation via an compiled artifact.
        This change was prompted by the change in wasmtime which made
        `deserialize` rightfully unsafe. Now `CodeSupplyMode` was hidden and
        the `create_runtime` now takes the blob again and there is now a new
        fn for creating a runtime with a compiled artifact.
      - This is a big change for wasmtime. They switched to the modern backend
        for code generation. While this can bring performance improvements, it
        can also introduce some problems. In fact, 0.27 fixed a serious issue
        that could lead to sandbox escape. Hence we need a proper burn in.
      
      This would require a change to PVF validation host as well.
      
      * Filter regalloc logging
      
      * Spellling corrections (no code changes) (#8971)
      
      * Spelling corrections
      
      * As this might break let's do as a separate PR
      
      * Dependabot use correct label (#8973)
      
      * Inject hashed prefix for remote-ext (#8960)
      
      * Inject for remote-ext
      
      * Update utils/frame/remote-externalities/src/lib.rs
      
      Co-authored-by: default avatarZeke Mostov <[email protected]>
      
      * Update utils/frame/remote-externalities/src/lib.rs
      
      Co-authored-by: default avatarZeke Mostov <[email protected]>
      
      * Apply suggestions from code review
      
      * Apply suggestions from code review
      
      Co-authored-by: default avatarZeke Mostov <[email protected]>
      
      * Use `SpawnTaskHandle`s for spawning tasks in the tx pool  (#8958)
      
      * Remove futures-diagnose
      
      * Use `SpawnTaskHandle`s for spawning tasks in the tx pool
      
      * Box the spawner
      
      * Fix tests
      
      * Use the testing task executor
      
      * Do not spend time on verifying the signatures before calling Runtime (#8980)
      
      * Revert "Use `SpawnTaskHandle`s for spawning tasks in the tx pool  (#8958)" (#8983)
      
      This reverts commit 84e40238
      
      .
      
      * Uniques: An economically-secure basic-featured NFT pallet (#8813)
      
      * Uniques: An economically-secure basic-featured NFT pallet
      
      * force_transfer
      
      * freeze/thaw
      
      * team management
      
      * approvals
      
      * Fixes
      
      * force_asset_status
      
      * class_metadata
      
      * instance metadata
      
      * Fixes
      
      * use nmap
      
      * Fixes
      
      * class metadata has information field
      
      * Intiial mock/tests and a fix
      
      * Remove impl_non_fungibles
      
      * Docs
      
      * Update frame/uniques/src/lib.rs
      
      Co-authored-by: default avatarShawn Tabrizi <[email protected]>
      
      * Update frame/uniques/src/lib.rs
      
      Co-authored-by: default avatarShawn Tabrizi <[email protected]>
      
      * Update frame/uniques/src/lib.rs
      
      Co-authored-by: default avatarShawn Tabrizi <[email protected]>
      
      * Update frame/uniques/src/lib.rs
      
      Co-authored-by: default avatarShawn Tabrizi <[email protected]>
      
      * Reserve, don't transfer.
      
      * Fixes
      
      * Tests
      
      * Tests
      
      * refresh_deposit
      
      * Tests and proper handling of metdata destruction
      
      * test burn
      
      * Tests
      
      * Update impl_fungibles.rs
      
      * Initial benchmarking
      
      * benchmark
      
      * Fixes
      
      * cargo run --release --features=runtime-benchmarks --manifest-path=bin/node/cli/Cargo.toml -- benchmark --chain=dev --steps=50 --repeat=20 --pallet=pallet_uniques --extrinsic=* --execution=wasm --wasm-execution=compiled --heap-pages=4096 --output=./frame/uniques/src/weights.rs --template=./.maintain/frame-weight-template.hbs
      
      * Attributes
      
      * Attribute metadata
      
      * Fixes
      
      * Update frame/uniques/README.md
      
      * Docs
      
      * Docs
      
      * Docs
      
      * Simple metadata
      
      * Use BoundedVec
      
      * cargo run --release --features=runtime-benchmarks --manifest-path=bin/node/cli/Cargo.toml -- benchmark --chain=dev --steps=50 --repeat=20 --pallet=pallet_uniques --extrinsic=* --execution=wasm --wasm-execution=compiled --heap-pages=4096 --output=./frame/uniques/src/weights.rs --template=./.maintain/frame-weight-template.hbs
      
      * Update frame/uniques/src/lib.rs
      
      Co-authored-by: default avatarLohann Paterno Coutinho Ferreira <[email protected]>
      
      * Update frame/uniques/src/lib.rs
      
      Co-authored-by: default avatarLohann Paterno Coutinho Ferreira <[email protected]>
      
      * Update frame/uniques/src/lib.rs
      
      Co-authored-by: default avatarLohann Paterno Coutinho Ferreira <[email protected]>
      
      * Update frame/uniques/src/lib.rs
      
      Co-authored-by: default avatarLohann Paterno Coutinho Ferreira <[email protected]>
      
      * Update frame/uniques/src/lib.rs
      
      Co-authored-by: default avatarLohann Paterno Coutinho Ferreira <[email protected]>
      
      * Fixes
      
      * Update frame/uniques/README.md
      
      Co-authored-by: default avatarAlexander Popiak <[email protected]>
      
      * Update frame/uniques/README.md
      
      Co-authored-by: default avatarAlexander Popiak <[email protected]>
      
      * Update frame/uniques/README.md
      
      Co-authored-by: default avatarAlexander Popiak <[email protected]>
      
      * Docs
      
      * Bump
      
      Co-authored-by: default avatarShawn Tabrizi <[email protected]>
      Co-authored-by: default avatarParity Bot <[email protected]>
      Co-authored-by: default avatarLohann Paterno Coutinho Ferreira <[email protected]>
      Co-authored-by: default avatarAlexander Popiak <[email protected]>
      
      * Update WeakBoundedVec's remove and swap_remove (#8985)
      
      Co-authored-by: default avatarBoiethios <[email protected]>
      
      * Convert another instance of Into impl to From in the macros (#8986)
      
      * Convert another instance of Into impl to From in the macros
      
      * Convert another location
      
      * also fix bounded vec (#8987)
      
      * fix most compiler errors
      
      Mostly the work so far has been in tracking down where precisely
      to insert appropriate trait bounds, and updating `fn insert_submission`.
      However, there's still a compiler error remaining:
      
      ```
      error[E0275]: overflow evaluating the requirement `Compact<_>: Decode`
        |
        = help: consider adding a `#![recursion_limit="256"]` attribute to your crate (`pallet_election_provider_multi_phase`)
        = note: required because of the requirements on the impl of `Decode` for `Compact<_>`
        = note: 126 redundant requirements hidden
        = note: required because of the requirements on the impl of `Decode` for `Compact<_>`
      ```
      
      Next up: figure out how we ended up with that recursive bound, and fix it.
      
      * extract type SignedSubmissionsOf<T>
      
      Weirdly, we still encounter the recursive trait definition error here,
      despite removing the trait bounds. Something weird is happening.
      
      * impl Decode bounds on BoundedBTreeMap/Set on T, not predecessor
      
      Otherwise, Rust gets confused and decides that the trait bound is
      infinitely recursive.
      
      For that matter, it _still_ gets confused somehow and decides
      that the trait bound is infinitely recursive, but at least
      this should somewhat simplify the matter.
      
      * fix recursive trait bound problem
      
      * minor fixes
      
      * more little fixes
      
      * correct semantics for try_insert
      
      * more fixes
      
      * derive Ord for SolutionType
      
      * tests compile
      
      * fix most tests, rm unnecessary one
      
      * Transactionpool: Make `ready_at` return earlier (#8995)
      
      `ready_at` returns when we have processed the requested block. However,
      on startup we already have processed the best block and there
      are no transactions in the pool on startup anyway. So, we can set `updated_at`
      to the best block on startup.
      
      Besides that `ready_at` now returns early when there are no ready nor
      any future transactions in the pool.
      
      * Discard notifications if we have failed to parse handshake (#8806)
      
      * Migrate pallet-democracy to pallet attribute macro (#8824)
      
      * Migrate pallet-democracy to pallet attribute macro.
      
      * Metadata fix.
      
      * Trigger CI.
      
      * Add ecdsa::Pair::verify_prehashed() (#8996)
      
      * Add ecdsa::Pair::verify_prehashed()
      
      * turn verify_prehashed() into an associated function
      
      * add Signature::recover_prehashed()
      
      * Non-fungible token traits (#8993)
      
      * Non-fungible token traits
      
      * Docs
      
      * Fixes
      
      * Implement non-fungible trait for Uniques
      
      * Update frame/uniques/src/impl_nonfungibles.rs
      
      Co-authored-by: default avatarShawn Tabrizi <[email protected]>
      
      * Update frame/uniques/src/impl_nonfungibles.rs
      
      Co-authored-by: default avatarShawn Tabrizi <[email protected]>
      
      Co-authored-by: default avatarShawn Tabrizi <[email protected]>
      
      * Removes unused import (#9007)
      
      * Add Call Filter That Prevents Nested `batch_all` (#9009)
      
      * add filter preventing nested `batch_all`
      
      * more tests
      
      * fix test
      
      * cargo run --release --features=runtime-benchmarks --manifest-path=bin/node/cli/Cargo.toml -- benchmark --chain=dev --steps=50 --repeat=20 --pallet=pallet_utility --extrinsic=* --execution=wasm --wasm-execution=compiled --heap-pages=4096 --output=./frame/utility/src/weights.rs --template=./.maintain/frame-weight-template.hbs
      
      Co-authored-by: default avatarParity Bot <[email protected]>
      
      * Transaction pool: Ensure that we prune transactions properly (#8963)
      
      * Transaction pool: Ensure that we prune transactions properly
      
      There was a bug in the transaction pool that we didn't pruned
      transactions properly because we called `prune_known`, instead of `prune`.
      
      This bug was introduced by:
      https://github.com/paritytech/substrate/pull/4629
      
      This is required to have stale extrinsics being removed properly, so
      that they don't fill up the tx pool.
      
      * Fix compilation
      
      * Fix benches
      
      * ...
      
      * Storage chain: Runtime module (#8624)
      
      * Transaction storage runtime module
      
      * WIP: Tests
      
      * Tests, benchmarks  and docs
      
      * Made check_proof mandatory
      
      * Typo
      
      * Renamed a crate
      
      * Apply suggestions from code review
      
      Co-authored-by: default avatarKian Paimani <[email protected]>
      
      * Added weight for on_finalize
      
      * Fixed counter mutations
      
      * Reorganized tests
      
      * Fixed build
      
      * Update for the new inherent API
      
      * Reworked for the new inherents API
      
      * Apply suggestions from code review
      
      Co-authored-by: default avatarcheme <[email protected]>
      Co-authored-by: default avatarAlexander Popiak <[email protected]>
      Co-authored-by: default avatarShawn Tabrizi <[email protected]>
      
      * Store transactions in a Vec
      
      * Added FeeDestination
      
      * Get rid of constants
      
      * Fixed node runtime build
      
      * Fixed benches
      
      * Update frame/transaction-storage/src/lib.rs
      
      Co-authored-by: default avatarcheme <[email protected]>
      
      Co-authored-by: default avatarKian Paimani <[email protected]>
      Co-authored-by: default avatarcheme <[email protected]>
      Co-authored-by: default avatarAlexander Popiak <[email protected]>
      Co-authored-by: default avatarShawn Tabrizi <[email protected]>
      
      * more useful error message (#9014)
      
      * Named reserve (#7778)
      
      * add NamedReservableCurrency
      
      * move currency related trait and types into a new file
      
      * implement NamedReservableCurrency
      
      * remove empty reserves
      
      * Update frame/support/src/traits.rs
      
      Co-authored-by: default avatarShawn Tabrizi <[email protected]>
      
      * fix build
      
      * bump year
      
      * add MaxReserves
      
      * repatriate_reserved_named should put reserved fund into named reserved
      
      * add tests
      
      * add some docs
      
      * fix warning
      
      * Update lib.rs
      
      * fix test
      
      * fix test
      
      * fix
      
      * fix
      
      * triggier CI
      
      * Move NamedReservableCurrency.
      
      * Use strongly bounded vec for reserves.
      
      * Fix test.
      
      * remove duplicated file
      
      * trigger CI
      
      * Make `ReserveIdentifier` assosicated type
      
      * add helpers
      
      * make ReserveIdentifier assosicated type
      
      * fix
      
      * update
      
      * trigger CI
      
      * Apply suggestions from code review
      
      Co-authored-by: default avatarShawn Tabrizi <[email protected]>
      
      * trigger CI
      
      * Apply suggestions from code review
      
      Co-authored-by: default avatarShawn Tabrizi <[email protected]>
      Co-authored-by: default avatarGavin Wood <[email protected]>
      Co-authored-by: default avatarShaun Wang <[email protected]>
      
      * update ss58 type to u16 (#8955)
      
      * Fixed build (#9021)
      
      * Bump parity-db (#9024)
      
      * consensus: handle justification sync for blocks authored locally (#8698)
      
      * consensus: add trait to control justification sync process
      
      * network: implement JustificationSyncLink for NetworkService
      
      * slots: handle justification sync in slot worker
      
      * babe: fix slot worker instantiation
      
      * aura: fix slot worker instantiation
      
      * pow: handle justification sync in miner
      
      * babe: fix tests
      
      * aura: fix tests
      
      * node: fix compilation
      
      * node-template: fix compilation
      
      * consensus: rename justification sync link parameter
      
      * aura: fix test compilation
      
      * consensus: slots: move JustificationSyncLink out of on_slot
      
      * arithmetic: fix PerThing pow (#9030)
      
      * arithmetic: add failing test for pow
      
      * arithmetic: fix PerThing::pow
      
      * Revert back to previous optimisations
      
      Co-authored-by: default avatarGav Wood <[email protected]>
      
      * Compact proof utilities in sp_trie. (#8574)
      
      * validation extension in sp_io
      
      * need paths
      
      * arc impl
      
      * missing host function in executor
      
      * io to pkdot
      
      * decode function.
      
      * encode primitive.
      
      * trailing tab
      
      * multiple patch
      
      * fix child trie logic
      
      * restore master versionning
      
      * bench compact proof size
      
      * trie-db 22.3 is needed
      
      * line width
      
      * split line
      
      * fixes for bench (additional root may not be needed as original issue was
      with empty proof).
      
      * revert compact from block size calculation.
      
      * New error type for compression.
      
      * Adding test (incomplete (failing)).
      Also lacking real proof checking (no good primitives in sp-trie crate).
      
      * There is currently no proof recording utility in sp_trie, removing
      test.
      
      * small test of child root in proof without a child proof.
      
      * remove empty test.
      
      * remove non compact proof size
      
      * Missing revert.
      
      * proof method to encode decode.
      
      * Don't inlucde nominaotrs that back no one in the snapshot. (#9017)
      
      * fix all_in_one test which had a logic error
      
      * use sp_std, not std
      
      * Periodically call `Peerset::alloc_slots` on all sets (#9025)
      
      * Periodically call alloc_slots on all slots
      
      * Add test
      
      * contracts: Add new `seal_call` that offers new features (#8909)
      
      * Add new `seal_call` that offers new features
      
      * Fix doc typo
      
      Co-authored-by: default avatarMichael Müller <[email protected]>
      
      * Fix doc typos
      
      Co-authored-by: default avatarMichael Müller <[email protected]>
      
      * Fix comment on assert
      
      * Update CHANGELOG.md
      
      Co-authored-by: default avatarMichael Müller <[email protected]>
      
      * fix unreserve_all_named (#9042)
      
      * Delete legacy runtime metadata macros (#9043)
      
      * `rpc-http-threads` cli arg (#8890)
      
      * Add optional `rpc-http-threads` cli arg
      
      * Update `http::ServerBuilder`threads
      
      * allow inserting equal items into bounded map/set
      
      * refactor: only load one solution at a time
      
      This increases the database read load, because we read one solution
      at a time. On the other hand, it substantially decreases the overall
      memory load, because we _only_ read one solution at a time instead
      of reading all of them.
      
      * Emit `Bonded` event when rebonding (#9040)
      
      * Emit `Bonded` event when rebonding
      
      * fix borrow checker
      
      * cargo run --release --features=runtime-benchmarks --manifest-path=bin/node/cli/Cargo.toml -- benchmark --chain=dev --steps=50 --repeat=20 --pallet=pallet_staking --extrinsic=* --execution=wasm --wasm-execution=compiled --heap-pages=4096 --output=./frame/staking/src/weights.rs --template=./.maintain/frame-weight-template.hbs
      
      Co-authored-by: default avatarParity Bot <[email protected]>
      
      * fix tests
      
      * Revert "Merge remote-tracking branch 'origin/master' into prgn-election-provider-multi-phase-bounded-btree-set-signed-submissions"
      
      This reverts commit de92b1e8e0e44a74c24e270d02b6e8e6a2c37032, reversing
      changes made to dae31f2018593b60dbf1d96ec96cdc35c374bb9e.
      
      * only derive debug when std
      
      * write after check
      
      * SignedSubmissions doesn't ever modify storage until .put()
      
      This makes a true check-before-write pattern possible.
      
      * REVERT ME: demo that Drop impl doesn't work
      
      * Revert "REVERT ME: demo that Drop impl doesn't work"
      
      This reverts commit 3317a4bb4de2e77d5a7fff2154552a81ec081763.
      
      * doc note about decode_len
      
      * rename get_submission, take_submission for clarity
      
      * add test which fails for current incorrect behavior
      
      * inline fn insert_submission
      
      This fixes a tricky check-before-write error, ensuring that we
      really only ever modify anything if we have in fact succeeded.
      
      Co-authored-by: default avatarRoman Proskuryakov <[email protected]>
      Co-authored-by: default avatarDenis Pisarev <[email protected]>
      Co-authored-by: default avatarMOZGIII <[email protected]>
      Co-authored-by: default avatarAlexander Theißen <[email protected]>
      Co-authored-by: default avatarShawn Tabrizi <[email protected]>
      Co-authored-by: default avatarthiolliere <[email protected]>
      Co-authored-by: default avatarjoe petrowski <[email protected]>
      Co-authored-by: default avatarSebastian Müller <[email protected]>
      Co-authored-by: default avatarKian Paimani <[email protected]>
      Co-authored-by: default avataremostov <[email protected]>
      Co-authored-by: default avatarAndrew Jones <[email protected]>
      Co-authored-by: default avatarGavin Wood <[email protected]>
      Co-authored-by: default avatarShaun Wang <[email protected]>
      Co-authored-by: default avatardependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
      Co-authored-by: default avatarSeun Lanlege <[email protected]>
      Co-authored-by: default avatarBastian Köcher <[email protected]>
      Co-authored-by: default avatarKeith Yeung <[email protected]>
      Co-authored-by: default avatarSquirrel <[email protected]>
      Co-authored-by: default avatarSergei Shulepov <[email protected]>
      Co-authored-by: default avatarAshley <[email protected]>
      Co-authored-by: default avatarParity Bot <[email protected]>
      Co-authored-by: default avatarLohann Paterno Coutinho Ferreira <[email protected]>
      Co-authored-by: default avatarAlexander Popiak <[email protected]>
      Co-authored-by: default avatarBoiethios <[email protected]>
      Co-authored-by: default avatarBoiethios <[email protected]>
      Co-authored-by: default avatarPierre Krieger <[email protected]>
      Co-authored-by: default avatarAndreas Doerr <[email protected]>
      Co-authored-by: default avatarDmitry Kashitsyn <[email protected]>
      Co-authored-by: default avatarArkadiy Paronyan <[email protected]>
      Co-authored-by: default avatarcheme <[email protected]>
      Co-authored-by: default avatarAndronik Ordian <[email protected]>
      Co-authored-by: default avatarXiliang Chen <[email protected]>
      Co-authored-by: default avatarGavin Wood <[email protected]>
      Co-authored-by: default avatarJakub Pánik <[email protected]>
      Co-authored-by: default avatarAndré Silva <[email protected]>
      Co-authored-by: default avatarMichael Müller <[email protected]>
      Co-authored-by: default avatartgmichel <[email protected]>
      
      * cargo run --release --features=runtime-benchmarks --manifest-path=bin/node/cli/Cargo.toml -- benchmark --chain=dev --steps=50 --repeat=20 --pallet=pallet_election_provider_multi_phase --extrinsic=* --execution=wasm --wasm-execution=compiled --heap-pages=4096 --output=./frame/election-provider-multi-phase/src/weights.rs --template=./.maintain/frame-weight-template.hbs
      
      * remove duplicate weight definitions injected by benchmark bot
      
      * check deletion overlay before getting
      
      * clarify non-conflict between delete, insert overlays
      
      * drain can be used wrong so is private
      
      * update take_submission docs
      
      * more drain improvements
      
      * more take_submission docs
      
      * debug assertion helps prove expectation is valid
      
      * doc on changing SignedMaxSubmissions
      
      * take_submission inner doc on system properties
      
      * Apply suggestions from code review
      
      Co-authored-by: default avatarZeke Mostov <[email protected]>
      Co-authored-by: default avatarKian Paimani <[email protected]>
      
      * get SolutionOrSnapshotSize out of the loop
      
      Co-authored-by: default avatarZeke Mostov <[email protected]>
      
      * doc which items comprise `SignedSubmissions`
      
      * add doc about index as unique identifier
      
      * Add debug assertions to prove drain worked properly
      
      Co-authored-by: default avatarKian Paimani <[email protected]>
      
      * replace take_submission with swap_out_submission
      
      * use a match to demonstrate all cases from signed_submissions.insert
      
      * refactor signed_submissions.insert return type
      
      * prettify test assertion
      
      Co-authored-by: default avatarKian Paimani <[email protected]>
      
      * improve docs
      
      Co-authored-by: default avatarGuillaume Thiolliere <[email protected]>
      
      * add tests that finalize_signed_phase is idempotent
      
      * add some debug assertions to guard against misuse of storage
      
      * log internal logic errors instead of panicing
      
      * don't store the reward with each signed submission
      
      The signed reward base can be treated as a constant. It can in principle
      change, but even if it's updated in the middle of an election, it's
      appropriate to use the current value for the winner.
      
      * emit Rewarded, Slashed events as appropriate
      
      Makes it easier to see who won/lost with signed submissions.
      
      * update docs
      
      * use a custom enum to be explicit about the outcome of insertion
      
      * remove outdated docs
      
      Co-authored-by: default avatarPeter Goodspeed-Niklaus <[email protected]>
      Co-authored-by: default avatarParity Benchmarking Bot <[email protected]>
      Co-authored-by: default avatarPeter Goodspeed-Niklaus <[email protected]>
      Co-authored-by: default avatarShawn Tabrizi <[email protected]>
      Co-authored-by: default avatarRoman Proskuryakov <[email protected]>
      Co-authored-by: default avatarDenis Pisarev <[email protected]>
      Co-authored-by: default avatarMOZGIII <[email protected]>
      Co-authored-by: default avatarAlexander Theißen <[email protected]>
      Co-authored-by: default avatarthiolliere <[email protected]>
      Co-authored-by: default avatarjoe petrowski <[email protected]>
      Co-authored-by: default avatarSebastian Müller <[email protected]>
      Co-authored-by: default avataremostov <[email protected]>
      Co-authored-by: default avatarAndrew Jones <[email protected]>
      Co-authored-by: default avatarGavin Wood <[email protected]>
      Co-authored-by: default avatarShaun Wang <[email protected]>
      Co-authored-by: default avatardependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
      Co-authored-by: default avatarSeun Lanlege <[email protected]>
      Co-authored-by: default avatarBastian Köcher <[email protected]>
      Co-authored-by: default avatarKeith Yeung <[email protected]>
      Co-authored-by: default avatarSquirrel <[email protected]>
      Co-authored-by: default avatarSergei Shulepov <[email protected]>
      Co-authored-by: default avatarAshley <[email protected]>
      Co-authored-by: default avatarLohann Paterno Coutinho Ferreira <[email protected]>
      Co-authored-by: default avatarAlexander Popiak <[email protected]>
      Co-authored-by: default avatarBoiethios <[email protected]>
      Co-authored-by: default avatarBoiethios <[email protected]>
      Co-authored-by: default avatarPierre Krieger <[email protected]>
      Co-authored-by: default avatarAndreas Doerr <[email protected]>
      Co-authored-by: default avatarDmitry Kashitsyn <[email protected]>
      Co-authored-by: default avatarArkadiy Paronyan <[email protected]>
      Co-authored-by: default avatarcheme <[email protected]>
      Co-authored-by: default avatarAndronik Ordian <[email protected]>
      Co-authored-by: default avatarXiliang Chen <[email protected]>
      Co-authored-by: default avatarGavin Wood <[email protected]>
      Co-authored-by: default avatarJakub Pánik <[email protected]>
      Co-authored-by: default avatarAndré Silva <[email protected]>
      Co-authored-by: default avatarMichael Müller <[email protected]>
      Co-authored-by: default avatartgmichel <[email protected]>
      e6c83710
    • Keith Yeung's avatar
      Support NMap in generate_storage_alias (#9147) · fb1bd573
      Keith Yeung authored
      * Support NMap in generate_storage_alias
      
      * Verify that 2-key NMap is identical to DoubleMap
      
      * Also compare key hashes and make sure they're identical
      
      * Fix and add tests for 1-tuple NMap generated by generate_storage_alias
      fb1bd573
  4. Jun 24, 2021
  5. Jun 23, 2021
  6. Jun 21, 2021
  7. Jun 16, 2021
    • thiolliere's avatar
      Avoid running some test 2 times when unneeded (#9124) · 205ab6de
      thiolliere authored
      * avoid running some test 2 times when unneeded
      
      * Update frame/support/test/Cargo.toml
      205ab6de
    • thiolliere's avatar
      Do not run pallet_ui test with conditional-storage feature (#9122) · 5fa96f2e
      thiolliere authored
      * do not run pallet_ui test with conditional-compilation feature
      
      * fix
      5fa96f2e
    • Keith Yeung's avatar
      Emit error when construct_runtime imports a non-existent pallet part (#8949) · 58e837fc
      Keith Yeung authored
      
      
      * Emit error when construct_runtime imports a non-existent Call part
      
      * Reword and display pallet name when emitting part not found error
      
      * Migrate decl_outer_dispatch to a proc macro
      
      * Rename calls.rs to call.rs
      
      * Create new construct_runtime_v2 macro
      
      * Add UI test for importing non-existent call part in construct_runtime
      
      * Emit error when construct_runtime imports a non-existent Config part
      
      * Emit error when construct_runtime imports a non-existent Event part
      
      * Migrate decl_outer_inherent to a proc macro
      
      * Emit error when construct_runtime imports a non-existent Inherent part
      
      * Migrate decl_outer_validate_unsigned to a proc macro
      
      * Emit error when construct_runtime imports a non-existent ValidateUnsigned part
      
      * impl for old macro
      
      * fix line width
      
      * add doc
      
      * hide macroes and use unique counter everywhere
      
      * Remove construct_runtime_v2
      
      * Encapsulate pallet part check macros in a module
      
      * Fix macro definitions in dummy part checker
      
      * Tag ProvideInherent impl with #[pallet::inherent] properly for authorship pallet
      
      * Remove Call part from pallets that do not define it
      
      * Add Call part unit tests
      
      * Remove undefined Call part import from offences pallet
      
      * Add tests for expand_outer_inherent
      
      * Remove Call part from pallets that do not define them
      
      * Remove Call part imports from pallets that do not have it defined
      
      * Remove Call part import of the offences pallet from grandpa pallet mocks
      
      * Update frame/support/test/tests/pallet.rs
      
      Co-authored-by: default avatarGuillaume Thiolliere <[email protected]>
      
      * Remove Call part imports for pallets that do not define them
      
      * Move inherent tests to inherent_expand
      
      * Add unit tests for expand_outer_validate_unsigned
      
      * Add newline at the end of file
      
      * fix ui test
      
      * Small prayer to RNGsus for fixing CI
      
      * Remove Call part from construct_runtime for randomness collective flip pallet
      
      * Remove Call part import for randomness collective flip pallet
      
      * Summon Laplace's demon instead of praying to RNGsus
      
      * Update test expectations
      
      * fix ui test and make sure it's flaky
      
      * Revert "fix ui test and make sure it's flaky"
      
      This reverts commit 362b6881389c911ef8d9ef85d71c9463f5694b20.
      
      * Comment out test instead of putting it in conditional compilation
      
      * Update UI test expectations
      
      * Update UI test expectations
      
      * Emit error when construct_runtime imports a non-existent Origin part
      
      Co-authored-by: default avatarthiolliere <[email protected]>
      Co-authored-by: default avatarDenis P <[email protected]>
      58e837fc
  8. Jun 15, 2021
  9. Jun 14, 2021
    • thiolliere's avatar
      execute system integrity_test also (#9104) · 65d3d5d4
      thiolliere authored
      65d3d5d4
    • h4x3rotab's avatar
      Improve construct_runtime doc (#9096) · cd52b3f2
      h4x3rotab authored
      - Mention when the pallet definition parts are needed
      - Rename "module" to "pallet"
      cd52b3f2
    • Keith Yeung's avatar
      Allow renaming storage item prefixes (#9016) · c2f13a03
      Keith Yeung authored
      * Implement parsing for #[pallet::storage_name] on storage items
      
      * Rename storage prefix when a #[pallet::storage_name] is supplied
      
      * Fix test_storage_info
      
      * Rename storage_name to storage_prefix
      
      * Check for duplicates when renaming storage prefixes
      
      * Allow only string literals for storage_prefix renames
      
      * Use proper spans for attribute errors
      
      * Check for valid identifiers when parsing storage prefix renames
      c2f13a03
  10. Jun 13, 2021
  11. Jun 12, 2021
  12. Jun 11, 2021
  13. Jun 09, 2021
    • Joshy Orndorff's avatar
      remove explicit unit return type (#9053) · 5e0f922d
      Joshy Orndorff authored
      5e0f922d
    • Keith Yeung's avatar
      Use pallet names to name enum variants (#8990) · 828d1d74
      Keith Yeung authored
      * Remove unused event_metadata variable
      
      * Eliminate mod_name and use pallet names to name enum variants
      
      * Rename field name `pallet` to `path`
      
      * Use only the pallet name to generate variant names
      
      * Use new naming scheme for Event enum in sudo pallet tests
      
      * Use new naming scheme for Event enum in offences pallet tests
      
      * Use new naming scheme for Event enum in contracts pallet tests
      
      * Use new naming scheme for Event enum in collective pallet tests
      
      * Use new naming scheme for Event enum in bounties pallet tests
      
      * Use new naming scheme for Event enum in balances pallet tests
      
      * Use new naming scheme for Event enum in assets pallet tests
      
      * Use new naming scheme for Event enum in frame support tests
      
      * Use new naming scheme for Event enum in tips pallet tests
      
      * Use new naming scheme for Event enum in transaction payment pallet tests
      
      * Use new naming scheme for GenesisConfig fields in example pallet tests
      
      * Use new naming scheme for GenesisConfig fields in elections pallet tests
      
      * Use new naming scheme for Event enum in election provider multi-phase pallet tests
      
      * Use new naming scheme for Event enum in elections phragmen pallet tests
      
      * Use new naming scheme for GenesisConfig fields in chain spec
      
      * Use new naming scheme for Event enum in staking pallet mock
      
      * Use new naming scheme for GenesisConfig fields in node-template chain spec
      
      * Use new naming scheme for GenesisConfig fields in node-testing chain spec
      
      * Use new naming scheme for Event enum in node executor tests
      
      * Use new naming scheme for GenesisConfig fields in transaction storage pallet mock
      
      * Refactor match conditions
      828d1d74
  14. Jun 08, 2021
  15. Jun 04, 2021
    • Xiliang Chen's avatar
      Named reserve (#7778) · 223529e4
      Xiliang Chen authored
      
      
      * add NamedReservableCurrency
      
      * move currency related trait and types into a new file
      
      * implement NamedReservableCurrency
      
      * remove empty reserves
      
      * Update frame/support/src/traits.rs
      
      Co-authored-by: default avatarShawn Tabrizi <[email protected]>
      
      * fix build
      
      * bump year
      
      * add MaxReserves
      
      * repatriate_reserved_named should put reserved fund into named reserved
      
      * add tests
      
      * add some docs
      
      * fix warning
      
      * Update lib.rs
      
      * fix test
      
      * fix test
      
      * fix
      
      * fix
      
      * triggier CI
      
      * Move NamedReservableCurrency.
      
      * Use strongly bounded vec for reserves.
      
      * Fix test.
      
      * remove duplicated file
      
      * trigger CI
      
      * Make `ReserveIdentifier` assosicated type
      
      * add helpers
      
      * make ReserveIdentifier assosicated type
      
      * fix
      
      * update
      
      * trigger CI
      
      * Apply suggestions from code review
      
      Co-authored-by: default avatarShawn Tabrizi <[email protected]>
      
      * trigger CI
      
      * Apply suggestions from code review
      
      Co-authored-by: default avatarShawn Tabrizi <[email protected]>
      Co-authored-by: default avatarGavin Wood <[email protected]>
      Co-authored-by: default avatarShaun Wang <[email protected]>
      223529e4
  16. Jun 03, 2021
  17. Jun 02, 2021
  18. Jun 01, 2021
  19. May 28, 2021
    • Sebastian Müller's avatar
      weather -> whether (#8938) · 1888e56a
      Sebastian Müller authored
      1888e56a
    • Shawn Tabrizi's avatar
      Simple `MaxBoundedLen` Implementations (#8793) · 444d4e20
      Shawn Tabrizi authored
      
      
      * implement max_values + storages info
      
      * some formatting + doc
      
      * sudo sanity check
      
      * timestamp
      
      * assets (not working)
      
      * fix assets
      
      * impl for proxy
      
      * update balances
      
      * rename StoragesInfo -> PalletStorageInfo
      
      * merge both StorageInfoTrait and PalletStorageInfo
      
      I think it is more future proof. In the future some storage could make
      use of multiple prefix. Like one to store how much value has been
      inserted, etc...
      
      * Update frame/support/procedural/src/storage/parse.rs
      
      Co-authored-by: default avatarPeter Goodspeed-Niklaus <[email protected]>
      
      * Update frame/support/procedural/src/storage/storage_struct.rs
      
      Co-authored-by: default avatarPeter Goodspeed-Niklaus <[email protected]>
      
      * Fix max_size using hasher information
      
      hasher now expose `max_len` which allows to computes their maximum len.
      For hasher without concatenation, it is the size of the hash part,
      for hasher with concatenation, it is the size of the hash part + max
      encoded len of the key.
      
      * fix tests
      
      * fix ui tests
      
      * Move `MaxBoundedLen` into its own crate (#8814)
      
      * move MaxEncodedLen into its own crate
      
      * remove MaxEncodedLen impl from frame-support
      
      * add to assets and balances
      
      * try more fixes
      
      * fix compile
      
      Co-authored-by: default avatarShawn Tabrizi <[email protected]>
      
      * nits
      
      * fix compile
      
      * line width
      
      * fix max-values-macro merge
      
      * Add some derive, needed for test and other purpose
      
      * use weak bounded vec in some cases
      
      * Update lib.rs
      
      * move max-encoded-len crate
      
      * fix
      
      * remove app crypto for now
      
      * width
      
      * Revert "remove app crypto for now"
      
      This reverts commit 73623e9933d50648e0e7fe90b6171a8e45d7f5a2.
      
      * unused variable
      
      * more unused variables
      
      * more fixes
      
      * Add #[max_encoded_len_crate(...)] helper attribute
      
      The purpose of this attribute is to reduce the surface area of
      max_encoded_len changes. Crates deriving `MaxEncodedLen` do not
      need to add it to `Cargo.toml`; they can instead just do
      
      ```rust
      \#[derive(Encode, MaxEncodedLen)]
      \#[max_encoded_len_crate(frame_support::max_encoded_len)]
      struct Example;
      ```
      
      * fix a ui test
      
      * use #[max_encoded_len_crate(...)] helper in app_crypto
      
      * remove max_encoded_len import where not necessary
      
      * update lockfile
      
      * fix ui test
      
      * ui
      
      * newline
      
      * fix merge
      
      * try fix ui again
      
      * Update max-encoded-len/derive/src/lib.rs
      
      Co-authored-by: default avatarPeter Goodspeed-Niklaus <[email protected]>
      
      * extract generate_crate_access_2018
      
      * Update lib.rs
      
      * compiler isnt smart enough
      
      Co-authored-by: default avatarthiolliere <[email protected]>
      Co-authored-by: default avatarPeter Goodspeed-Niklaus <[email protected]>
      Co-authored-by: default avatarPeter Goodspeed-Niklaus <[email protected]>
      444d4e20
  20. May 27, 2021
  21. May 26, 2021