Skip to content
  1. Jan 06, 2021
    • Peter Goodspeed-Niklaus's avatar
      Add metrics timing message passing from OverseerSubsystemContext to Overseer::route_message (#2201) · cd58c02c
      Peter Goodspeed-Niklaus authored 
      * add timing setup to OverseerSubsystemContext

* figure out how to initialize the rng

* attach a timer to a portion of the messages traveling to the Overseer

This timer only exists / logs a fraction of the time (configurable
by `MESSAGE_TIMER_METRIC_CAPTURE_RATE`). When it exists, it tracks
the span between the `OverSubsystemContext` receiving the message
and its receipt in `Overseer::run`.

* propagate message timing to the start of route_message

This should be more accurate; it ensures that the timer runs
at least as long as that function. As `route_message` is async,
it may not actually run for some time after it is called (or ever).

* fix failing test

* rand_chacha apparently implicitly has getrandom feature

* change rng initialization

The previous impl using `from_entropy` depends on the `getrandom`
crate, which uses the system entropy source, and which does not
work on `wasm32-unknown-unknown` because it wants to fall back to
a JS implementation which we can't assume exists.

This impl depends only on `rand::thread_rng`, which has no documentation
stating that it's similarly limited.

* remove randomness in favor of a simpler 1 of N procedure

This deserves a bit of explanation, as the motivating issue explicitly
requested randomness. In short, it's hard to get randomness to compile
for `wasm32-unknown-unknown` because that is explicitly intended to be
as deterministic as practical. Additionally, even though it would never
be used for consensus purposes, it still felt offputting to intentionally
introduce randomness into a node's operations. Except, it wasn't really
random, either: it was a deterministic PRNG varying only in its state,
and getting the state to work right for that target would have required
initializing from a constant.

Given that it was a deterministic sequence anyway, it seemed much simpler
and more explicit to simply select one of each N messages instead of
attempting any kind of realistic randomness.

* reinstate randomness for better statistical properties

This partially reverts commit 0ab8594c328b3f9ce1f696fe405556d4000630e9.

`oorandom` is much lighter than the previous `rand`-based implementation,
which makes this easier to work with.

This implementation gives each subsystem and each child RNG a distinct
increment, which should ensure they produce distinct streams of values.
      cd58c02c
    • dependabot[bot]'s avatar
      Bump pin-project from 1.0.2 to 1.0.3 (#2209) · 82ee539d
      dependabot[bot] authored 
      

Bumps [pin-project](https://github.com/taiki-e/pin-project) from 1.0.2 to 1.0.3.
- [Release notes](https://github.com/taiki-e/pin-project/releases)
- [Changelog](https://github.com/taiki-e/pin-project/blob/master/CHANGELOG.md)
- [Commits](https://github.com/taiki-e/pin-project/compare/v1.0.2...v1.0.3)

Signed-off-by: default avatardependabot[bot] <[email protected]>

Co-authored-by: default avatardependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
      82ee539d
  3. Jan 05, 2021
  5. Jan 04, 2021
    • Bastian Köcher's avatar
      Use correct ROC currency name (#2195) · 03b31c6b
      Bastian Köcher authored
      03b31c6b
    • asynchronous rob's avatar
      Improve Network Spans (#2169) · 41102a6f
      asynchronous rob authored 
      

* utility functions for erasure-coding threshold

* add candidate-hash tag to candidate jaeger spans

* debug implementation for jaeger span

* add a span to each live candidate in availability dist.

* availability span covers only our piece

* fix tests

* keep span alive slightly longer

* remove spammy bitfield-gossip-received log

* Revert "remove spammy bitfield-gossip-received log"

This reverts commit 831a2db506d66f64ea516af3caf891e8643f5c43.

* add claimed validator to bitfield-gossip span

* add peer-id to handle-incoming span

* add peer-id to availability distribution span

* Update node/network/availability-distribution/src/lib.rs

Co-authored-by: default avatarBernhard Schuster <[email protected]>

* Update erasure-coding/src/lib.rs

Co-authored-by: default avatarBernhard Schuster <[email protected]>

* Update node/subsystem/src/jaeger.rs

Co-authored-by: default avatarBernhard Schuster <[email protected]>

Co-authored-by: default avatarBernhard Schuster <[email protected]>
      41102a6f
    • Sergey Pepyakin's avatar
      Add relay storage root to persisted validation data (#2161) · a864eaa0
      Sergey Pepyakin authored 
      * Cont.: Implement the state root obtaining during inclusion

During inclusion now we obtain the storage root by passing it through
the inclusion_inherent.

* Fix tests

* Bump rococo spec version

* Reorder the parent header into the end

of the inclusion inherent.

When the parent header is in the beginning, it shifts the other two
fields, so that a previous version won't be able to decode that. If
we put the parent header in the end, the other two fields will stay
at their positions, thus make it possible to decode with the previous
version.

That allows us to perform upgrade of rococo runtime without needing of
simultanuous upgrade of nodes and runtime, or restart of the network.

* Squash a stray tab
      a864eaa0
    • Bastian Köcher's avatar
      Improve unbacked span (#2191) · 930978ce
      Bastian Köcher authored 
      We need to make sure to drop the import-statement child span before the
parent span is dropped.
      930978ce
    • Bastian Köcher's avatar
      Improve jaeger spans for bitfield signing (#2189) · 9e554721
      Bastian Köcher authored
      9e554721
  7. Jan 02, 2021
  9. Dec 29, 2020
  11. Dec 28, 2020
  13. Dec 24, 2020
    • Bastian Köcher's avatar
      Support variable session length for Rococo chains at genesis (#2167) · bb856698
      Bastian Köcher authored 
      This pr adds support to change the session length of a Rococo chain at
genesis. This is rather useful because Rococo has a session length of
1 hour, while on rococo-local you will now get 1 minute. This improves
the dev experience, because a parachain is only going live at the
start of a new session.
      bb856698
  15. Dec 20, 2020
  17. Dec 18, 2020
  19. Dec 17, 2020
    • asynchronous rob's avatar
      address review comments from 2104 (#2136) · eab86d6f
      asynchronous rob authored
      eab86d6f
    • asynchronous rob's avatar
      adjust span names (#2135) · fa7cced5
      asynchronous rob authored 
      * adjust span names

* fix compile
      fa7cced5
    • asynchronous rob's avatar
      add better spans for unbacked candidates (#2132) · 7cbf4f0b
      asynchronous rob authored 
      * add better spans for unbacked candidates

* improve span names
      7cbf4f0b
    • Bastian Köcher's avatar
      Fix bug and further optimizations in availability distribution (#2104) · d0c97539
      Bastian Köcher authored 
      

* Fix bug and further optimizations in availability distribution

- There was a bug that resulted in only getting one candidate per block
as the candidates were put into the hashmap with the relay block hash as
key. The solution for this is to use the candidate hash and the relay
block hash as key.
- We stored received/sent messages with the candidate hash and chunk
index as key. The candidate hash wasn't required in this case, as the
messages are already stored per candidate.

* Update node/core/bitfield-signing/src/lib.rs

Co-authored-by: default avatarRobert Habermeier <[email protected]>

* Remove the reverse map

* major refactor of receipts & query_live

* finish refactoring

remove ancestory mapping,

improve relay-parent cleanup & receipts-cache cleanup,
add descriptor to `PerCandidate`

* rename and rewrite query_pending_availability

* add a bunch of consistency tests

* Add some last changes

* xy

* fz

* Make it compile again

* Fix one test

* Fix logging

* Remove some buggy code

* Make tests work again

* Move stuff around

* Remove dbg

* Remove state from test_harness

* More refactor and new test

* New test and fixes

* Move metric

* Remove "duplicated code"

* Fix tests

* New test

* Change break to continue

* Update node/core/av-store/src/lib.rs

* Update node/core/av-store/src/lib.rs

* Update node/core/bitfield-signing/src/lib.rs

Co-authored-by: default avatarFedor Sakharov <[email protected]>

* update guide to match live_candidates changes

* add comment

* fix bitfield signing

Co-authored-by: default avatarRobert Habermeier <[email protected]>
Co-authored-by: default avatarBernhard Schuster <[email protected]>
Co-authored-by: default avatarFedor Sakharov <[email protected]>
      d0c97539
    • ordian's avatar
      refactor View to include finalized_number (#2128) · 3f5156e8
      ordian authored 
      * refactor View to include finalized_number

* guide: update the NetworkBridge on BlockFinalized

* av-store: fix the tests

* actually fix tests

* grumbles

* ignore macro doctest

* use Hash::repeat_bytes more consistently

* broadcast empty leaves updates as well

* fix issuing view updates on empty leaves updates
      3f5156e8
    • Pierre Krieger's avatar
      Improve Jaeger errors and debugging experience (#2127) · e6e3bda3
      Pierre Krieger authored 
      * Improve Jaeger errors and debugging experience

* Bind on 0.0.0.0:0 instead
      e6e3bda3
  21. Dec 16, 2020
    • Sergey Pepyakin's avatar
      Add logging to collation-generation (#2121) · 34e58121
      Sergey Pepyakin authored 
      Right now if the collation is not happening one will have to sprinkle
log statements and then recompile the code. It's doubly annoying if that
happens when working with Cumulus: that means one has to resort to
.cargo/config's `paths` or `diener`, which both are not ideal.

This just adds some verbose logging to save the investigators some time
when looking why the collations are not happening
      34e58121
    • RK's avatar
      Companion for #7536 (Pallet Treasury Refactor) (#2025) · 1ecc2e03
      RK authored 
      

* wk2048 | D6 | issue-7143-treasury-refactor | integration

* wk2048 | D6 | issue-7143-treasury-refactor | integration | p2

* trait -> config

* fix weight files and import

* missed some

* fix import

* fix imports

* alphabetize

* fix config traits

* fix trait

* update traits

* update weights

* "Update Substrate"

* fix features

* Update runtime/kusama/src/lib.rs

* Update runtime/polkadot/src/lib.rs

* add bounties and tips in proxy filters

* remove unused

* remove unused

* remove unused

Co-authored-by: default avatarShawn Tabrizi <[email protected]>
Co-authored-by: parity-processbot <>
Co-authored-by: default avatarthiolliere <[email protected]>
      1ecc2e03
  23. Dec 15, 2020
  25. Dec 11, 2020
  27. Dec 10, 2020
    • Bernhard Schuster's avatar
      addition error definitions (#2107) · 35c71bf3
      Bernhard Schuster authored 
      * remove low information density error doc comments

* another round of error dancing

* fix compilation

* remove stale `None` argument

* adjust test, minor slip in command

* only add AvailabilityError for full node features

* another None where none shuld be
      35c71bf3
  29. Dec 09, 2020
  31. Dec 08, 2020
  33. Dec 07, 2020