Skip to content
  1. Apr 07, 2022
  3. Apr 06, 2022
  5. Apr 05, 2022
  7. Apr 04, 2022
  9. Apr 03, 2022
  11. Apr 02, 2022
  13. Apr 01, 2022
  15. Mar 31, 2022
  17. Mar 30, 2022
    • Oliver Tale-Yazdi's avatar
      Fix Phragmen benchmark (#11137) · 7bf19fa9
      Oliver Tale-Yazdi authored 
      

* Fix phragmen benchmark

Signed-off-by: default avatarOliver Tale-Yazdi <[email protected]>

* cargo run --quiet --profile=production  --features=runtime-benchmarks --manifest-path=bin/node/cli/Cargo.toml -- benchmark --chain=dev --steps=50 --repeat=20 --pallet=pallet_elections_phragmen --extrinsic=* --execution=wasm --wasm-execution=compiled --heap-pages=4096 --output=./frame/elections-phragmen/src/weights.rs --template=./.maintain/frame-weight-template.hbs

Co-authored-by: default avatarParity Bot <[email protected]>
      7bf19fa9
  19. Mar 29, 2022
  21. Mar 28, 2022
  23. Mar 27, 2022
  25. Mar 26, 2022
  27. Mar 25, 2022
    • Georges's avatar
      Add a bounded fallback on failed elections (#10988) · e9bfdd9a
      Georges authored 
      

* Allow `pallet-election-provider` to accept smaller
solutions, issue #9478

* Fixing a typo

* Adding some more tests
Removing a seemingly outdated comment

* making it a URL

* Updating test name as per suggestion

Co-authored-by: default avatarKian Paimani <[email protected]>

* Updating documentation to be more explicit

And to follow the general guidelines

Co-authored-by: default avatarKian Paimani <[email protected]>

* Fixing formatting

* `Fallback` now of type `InstantElectionProvider`
Some cleanups

* Allow `pallet-election-provider` to accept smaller
solutions, issue #9478

* Fixing a typo

* Adding some more tests
Removing a seemingly outdated comment

* making it a URL

* Updating test name as per suggestion

Co-authored-by: default avatarKian Paimani <[email protected]>

* Updating documentation to be more explicit

And to follow the general guidelines

Co-authored-by: default avatarKian Paimani <[email protected]>

* Fixing formatting

* `Fallback` now of type `InstantElectionProvider`
Some cleanups

* Merging types into one type with generics

* Removing `ConstUSize` and use `ConstU32`

* cleaning up the code

* deprecating `OnChainSequentialPhragmen`
Renaming it to `UnboundedSequentialPhragmen` which should only be used
at genesis and for testing.
Use preferrably `BoundedOnChainSequentialPhragmen`

* Amending docs

* Adding some explicit imports

* Implementing generic `BoundedOnchainExecution`
Removing the deprecated `OnChainSequentialPhragmen`

* Use the right Balancing strategy

* Refactoring `onchain::Config`
Creating `onchain::ExecutionConfig`

* Merge master

* fmt

* Name cleanups after review suggestions

* cosmetics

* renaming `instant_elect` to `elect_with_bounds`
Other corresponding changes as per @Kianenigma

 feedback

* `BoundedOnchainExecution` -> `BoundedExecution`
And `UnboundedOnchainExecution` -> `UnboundedExecution`

* feedback from kian

* fmt + unneeded import

Co-authored-by: default avatarKian Paimani <[email protected]>
Co-authored-by: default avatarkianenigma <[email protected]>
      e9bfdd9a
    • Gavin Wood's avatar
      Remove unneeded code (#11117) · cbfb1f0e
      Gavin Wood authored 
      

* Remove unneeded code

* Remove unused imports

Signed-off-by: default avatarOliver Tale-Yazdi <[email protected]>

Co-authored-by: default avatarOliver Tale-Yazdi <[email protected]>
      cbfb1f0e
    • Adrian Catangiu's avatar
      Implement Lean BEEFY (#10882) · 498e8c18
      Adrian Catangiu authored 
      

Simplified BEEFY worker logic based on the invariant that GRANDPA
will always finalize 1st block of each new session, meaning BEEFY
worker is guaranteed to receive finality notification for the
BEEFY mandatory blocks.

Under these conditions the current design is as follows:
- session changes are detected based on BEEFY Digest present in
  BEEFY mandatory blocks,
- on each new session new `Rounds` of voting is created, with old
  rounds being dropped (for gossip rounds, last 3 are still alive
  so votes are still being gossiped),
- after processing finality for a block, the worker votes if
  a new voting target has become available as a result of said
  block finality processing,
- incoming votes as well as self-created votes are processed
  and signed commitments are created for completed BEEFY voting
  rounds,
- the worker votes if a new voting target becomes available
  once a round successfully completes.

On worker startup, the current validator set is retrieved from
the BEEFY pallet. If it is the genesis validator set, worker
starts voting right away considering Block #1 as session start.

Otherwise (not genesis), the worker will vote starting with
mandatory block of the next session.

Later on when we add the BEEFY initial-sync (catch-up) logic,
the worker will sync all past mandatory blocks Signed Commitments
and will be able to start voting right away.

BEEFY mandatory block is the block with header containing the BEEFY
`AuthoritiesChange` Digest, this block is guaranteed to be finalized
by GRANDPA.

This session-boundary block is signed by the ending-session's
validator set. Next blocks will be signed by the new session's
validator set. This behavior is consistent with what GRANDPA does
as well.

Also drop the limit N on active gossip rounds. In an adversarial
network, a bad actor could create and gossip N invalid votes with
round numbers larger than the current correct round number. This
would lead to votes for correct rounds to no longer be gossiped.

Add unit-tests for all components, including full voter consensus
tests.

Signed-off-by: default avatarAdrian Catangiu <[email protected]>
Co-authored-by: default avatarTomasz Drwięga <[email protected]>
Co-authored-by: David Salami <Wizdave97>
      498e8c18
    • Qinxuan Chen's avatar
      pallet-conviction-voting: make the pallet instantiable (#11088) · 52967f17
      Qinxuan Chen authored 
      

* pallet-conviction-voting: make the pallet instanceable

Signed-off-by: default avatarkoushiro <[email protected]>

* Add default type param for some type alias

Signed-off-by: default avatarkoushiro <[email protected]>
      52967f17
    • Shawn Tabrizi's avatar
      Improve Bounties and Child Bounties Deposit Logic (#11014) · a95dbede
      Shawn Tabrizi authored 
      

* basic idea

* make tests better

* update bounties pallet to also have similar logic

* new test verifies logic for bounty pallet

* add test for new child logic

* better name

* make `node` compile with bounties changes

* * formatting
* use uniform notion of parent and child, no "master" or "general" entity
* README updated to match comments

* Revert "* formatting"

This reverts commit 1ab729e7c23b5db24a8e229d487bbc2ed81d38c3.

* update bounties logic to use bounds

* fix child

* bounties test for max

* update tests

* check min bound

* update node

* remove stale comment

* Update frame/bounties/src/lib.rs

Co-authored-by: default avatarDan Shields <[email protected]>
      a95dbede
    • Oliver Tale-Yazdi's avatar
      Add `benchmark-block` command (#11091) · fa8fa8fa
      Oliver Tale-Yazdi authored 
      

* Add benchmark-block command

Signed-off-by: default avatarOliver Tale-Yazdi <[email protected]>

* Apply suggestions from code review

Co-authored-by: default avatarShawn Tabrizi <[email protected]>

* Beauty fixes

Signed-off-by: default avatarOliver Tale-Yazdi <[email protected]>

* Beauty fixes

Signed-off-by: default avatarOliver Tale-Yazdi <[email protected]>

Co-authored-by: default avatarShawn Tabrizi <[email protected]>
Co-authored-by: parity-processbot <>
      fa8fa8fa