Skip to content
  1. Aug 14, 2020
  2. Aug 13, 2020
    • Bastian Köcher's avatar
      Make parachain validation wasm executor functional (#1574) · 950bcece
      Bastian Köcher authored
      
      
      * Make parachain validation wasm executor functional
      
      - Increase the size of the validation result in the shared memory. The
      validation result holds the new runtime when a runtime upgrade is
      scheduled. So, we need to give it enough memory to send the data between
      the validator and the wasm execution host.
      - Add the `CallInWasmExt`. This is required when doing a runtime upgrade
      to check that we upgrade to something meaningful.
      
      * Update parachain/src/wasm_executor/mod.rs
      
      * Update parachain/src/wasm_executor/mod.rs
      
      Co-authored-by: default avatarNikolay Volf <[email protected]>
      
      Co-authored-by: default avatarNikolay Volf <[email protected]>
      950bcece
    • Cecile Tonglet's avatar
    • asynchronous rob's avatar
      guide: validation data refactoring (#1576) · 2a96c193
      asynchronous rob authored
      
      
      * guide: validation data refactoring
      
      * address grumbles from review
      
      * Update roadmap/implementers-guide/src/types/candidate.md
      
      Co-authored-by: default avatarBernhard Schuster <[email protected]>
      
      * last comments from review
      
      Co-authored-by: default avatarSergei Shulepov <[email protected]>
      Co-authored-by: default avatarBernhard Schuster <[email protected]>
      2a96c193
    • asynchronous rob's avatar
      Remove v0 parachains runtime (#1501) · 57aef8ee
      asynchronous rob authored
      * remove v0 parachains modules and switch to v1 primitives
      
      * get tests compiling for runtime-common
      
      * remove registrar module
      
      * Add a dummy module
      
      * remove runtime-parachains
      
      * mostly remove old parachains code from polkadot-runtime
      
      * remove slots::Trait implementation
      
      * remove sp_std prelude import
      
      * add a ZeroSizedTypeDifferentiator to dummy
      
      * finish porting over polkadot runtime
      
      * ZeroSizedTypeDifferentiator was actually unnecessary
      
      * westend
      
      * kusama
      
      * test-runtime (no dummy modules)
      
      * fix warning
      
      * fix chain-specs
      
      * fix test-service
      
      * test-client
      
      * remove dead import
      
      * remove unused needed_extrinsics parameter
      
      * runtimes compile
      
      * remove rococo-v0
      
      * remove remaining references to Rococo
      
      * bump versions
      57aef8ee
    • s3krit's avatar
      e6688620
    • Cecile Tonglet's avatar
      Allow using any polkadot client instead of enum Client (#1575) · 661c10a2
      Cecile Tonglet authored
      * WIP
      
      Forked at: e91642361133dba084a9c9b3efa45fcb6cd3c5ca
      Parent branch: origin/rococo-branch
      
      * WIP
      
      Forked at: e91642361133dba084a9c9b3efa45fcb6cd3c5ca
      Parent branch: origin/rococo-branch
      
      * WIP
      
      Forked at: e91642361133dba084a9c9b3efa45fcb6cd3c5ca
      Parent branch: origin/rococo-branch
      
      * WIP
      
      Forked at: e91642361133dba084a9c9b3efa45fcb6cd3c5ca
      Parent branch: origin/rococo-branch
      
      * WIP
      
      Forked at: e91642361133dba084a9c9b3efa45fcb6cd3c5ca
      Parent branch: origin/rococo-branch
      
      * WIP
      
      Forked at: e91642361133dba084a9c9b3efa45fcb6cd3c5ca
      Parent branch: origin/rococo-branch
      
      * WIP
      
      Forked at: e91642361133dba084a9c9b3efa45fcb6cd3c5ca
      Parent branch: origin/rococo-branch
      
      * WIP
      
      Forked at: e91642361133dba084a9c9b3efa45fcb6cd3c5ca
      Parent branch: origin/rococo-branch
      
      * Apply suggestions from code review
      
      * WIP
      
      Forked at: e91642361133dba084a9c9b3efa45fcb6cd3c5ca
      Parent branch: origin/rococo-branch
      
      * WIP
      
      Forked at: e91642361133dba084a9c9b3efa45fcb6cd3c5ca
      Parent branch: origin/rococo-branch
      
      * WIP
      
      Forked at: e91642361133dba084a9c9b3efa45fcb6cd3c5ca
      Parent branch: origin/rococo-branch
      
      * CLEANUP
      
      Forked at: e91642361133dba084a9c9b3efa45fcb6cd3c5ca
      Parent branch: origin/rococo-branch
      
      * link in doc
      
      * doc
      661c10a2
  3. Aug 12, 2020
    • Max Inden's avatar
      service/src/lib: Update authority discovery construction (#1563) · 79148479
      Max Inden authored
      * service/src/lib: Update authority discovery construction
      
      https://github.com/paritytech/substrate/pull/6760 introduces the concept
      of an authority discovery `Service` allowing one to communicate with an
      authority discovery `Worker`, e.g. to learn the `Multiaddr`s for a given
      `AuthorityId`.
      
      Along with the new `Service` structure it also alters the authority
      discovery constructor to return both a worker and a service. This
      commit adjusts the callside of the constructor, ignoring the `Service`
      for now.
      
      * "Update Substrate"
      
      * Revert ""Update Substrate""
      
      This reverts commit 04fb79c465f91b55422e22d4ea266f08f4072854.
      
      * Update Substrate
      
      Co-authored-by: parity-processbot <>
      79148479
    • Sergey Pepyakin's avatar
      Update .editorconfig to what we have in practice (#1545) · e3c83e42
      Sergey Pepyakin authored
      While editing the impl guide markdowns I tried to be inline with what seemingly more
      common way to indent them: spaces. However, despite that I changed it kept reseting.
      Turned out the culprit is the .editorconfig file.
      
      This commit addresses this issue. I didn't try to deduplicate the rules since
      I found that the formal specification is a bit ambigious and it is not a big
      deal anyway.
      e3c83e42
    • mattrutherford's avatar
      Companion PR for substrate #6672 (#1560) · c35c92aa
      mattrutherford authored
      
      
      * update Cargo.lock
      
      * "Update Substrate"
      
      Co-authored-by: default avatarMatt Rutherford <[email protected]>
      Co-authored-by: parity-processbot <>
      c35c92aa
    • Federico Gimenez's avatar
      abf00e31
    • asynchronous rob's avatar
      Network bridge refactoring impl (#1537) · a6b1d91d
      asynchronous rob authored
      * update networking types
      
      * port over overseer-protocol message types
      
      * Add the collation protocol to network bridge
      
      * message sending
      
      * stub for ConnectToValidators
      
      * add some helper traits and methods to protocol types
      
      * add collator protocol message
      
      * leaves-updating
      
      * peer connection and disconnection
      
      * add utilities for dispatching multiple events
      
      * implement message handling
      
      * add an observedrole enum with equality and no sentry nodes
      
      * derive partial-eq on network bridge event
      
      * add PartialEq impls for network message types
      
      * add Into implementation for observedrole
      
      * port over existing network bridge tests
      
      * add some more tests
      
      * port bitfield distribution
      
      * port over bitfield distribution tests
      
      * add codec indices
      
      * port PoV distribution
      
      * port over PoV distribution tests
      
      * port over statement distribution
      
      * port over statement distribution tests
      
      * update overseer and service-new
      
      * address review comments
      
      * port availability distribution
      
      * port over availability distribution tests
      a6b1d91d
    • Dan Forbes's avatar
      Augment Implementer's Guide XCMP docs (#1569) · 8e60a519
      Dan Forbes authored
      
      
      * Augment Implementer's Guide XCMP docs
      
      * Remove the note about the third category
      
      * Make Cross-Chain Message Passing a h3
      
      Co-authored-by: default avatarSergei Shulepov <[email protected]>
      8e60a519
  4. Aug 11, 2020
    • Bastian Köcher's avatar
      Support `build-spec` for other chains than Polkadot (#1567) · a12f634e
      Bastian Köcher authored
      
      
      * Support `build-spec` for other chains than Polkadot
      
      The problem when building a chain specification is that you require the
      native runtime to parse the json file (assuming the chain spec is not
      raw yet). Before this pr we could only overwrite the native runtime when
      running the node using `force_*`. This pr now adds support to load the
      native runtime when the filename starts with the name of the chain. So,
      when usng `build-spec --chain rococo-something-else.jon` it will use the
      rococo native runtime to load the chain spec.
      
      * Apply suggestions from code review
      
      Co-authored-by: default avatarAndronik Ordian <[email protected]>
      
      Co-authored-by: default avatarAndronik Ordian <[email protected]>
      a12f634e
  5. Aug 10, 2020
  6. Aug 07, 2020
  7. Aug 06, 2020
    • Peter Goodspeed-Niklaus's avatar
      implement provisioner (#1473) · 21cec309
      Peter Goodspeed-Niklaus authored
      * sketch out provisioner basics
      
      * handle provisionable data
      
      * stub out select_inherent_data
      
      * split runtime APIs into sub-chapters to improve linkability
      
      * explain SignedAvailabilityBitfield semantics
      
      * add internal link to further documentation
      
      * some more work figuring out how the provisioner can do its thing
      
      * fix broken link
      
      * don't import enum variants where it's one layer deep
      
      * make request_availability_cores a free fn in util
      
      * document more precisely what should happen on block production
      
      * finish first-draft implementation of provisioner
      
      * start working on the full and proper backed candidate selection rule
      
      * Pass number of block under construction via RequestInherentData
      
      * Revert "Pass number of block under construction via RequestInherentData"
      
      This reverts commit 850fe62cc0dfb04252580c21a985962000e693c8.
      
      That initially looked like the better approach--it spent the time
      budget for fetching the block number in the proposer, instead of
      the provisioner, and that felt more appropriate--but it turns out
      not to be obvious how to get the block number of the block under
      construction from within the proposer. The Chain API may be less
      ideal, but it should be easier to implement.
      
      * wip: get the block under production from the Chain API
      
      * add ChainApiMessage to AllMessages
      
      * don't break the run loop if a provisionable data channel closes
      
      * clone only those backed candidates which are coherent
      
      * propagate chain_api subsystem through various locations
      
      * add delegated_subsystem! macro to ease delegating subsystems
      
      Unfortunately, it doesn't work right:
      
      ```
      error[E0446]: private type `CandidateBackingJob` in public interface
         --> node/core/backing/src/lib.rs:775:1
          |
      86  | struct CandidateBackingJob {
          | - `CandidateBackingJob` declared as private
      ...
      775 | delegated_subsystem!(CandidateBackingJob as CandidateBackingSubsystem);
          | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ can't leak private type
      ```
      
      I'm not sure precisely what's going wrong, here; I suspect the problem is
      the use of `$job as JobTrait>::RunArgs` and `::ToJob`; the failure would be
      that it's not reifying the types to verify that the actual types are public,
      but instead referring to them via `CandidateBackingJob`, which is in fact private;
      that privacy is the point.
      
      Going to see if I can generic my way out of this, but we may be headed for a
      quick revert here.
      
      * fix delegated_subsystem
      
      The invocation is a bit more verbose than I'd prefer, but it's also
      more explicit about what types need to be public. I'll take it as a win.
      
      * add provisioning subsystem; reduce public interface of provisioner
      
      * deny missing docs in provisioner
      
      * refactor core selection per code review suggestion
      
      This is twice as much code when measured by line, but IMO it is
      in fact somewhat clearer to read, so overall a win.
      
      Also adds an improved rule for selecting availability bitfields,
      which (unlike the previous implementation) guarantees that the
      appropriate postconditions hold there.
      
      * fix bad merge double-declaration
      
      * update guide with (hopefully) complete provisioner candidate selection procedure
      
      * clarify candidate selection algorithm
      
      * Revert "clarify candidate selection algorithm"
      
      This reverts commit c68a02ac9cf42b3a4a28eb197d38633a40d0e3e6.
      
      * clarify candidate selection algorithm
      
      * update provisioner to implement candidate selection per the guide
      
      * add test that no more than one bitfield is selected per validator
      
      * add test that each selected bitfield corresponds to an occupied core
      
      * add test that more set bits win conflicts
      
      * add macro for specializing runtime requests; specailize all runtime requests
      
      * add tests harness for select_candidates tests
      
      * add first real select_candidates test, fix test_harness
      
      * add mock overseer and test that success is possible
      
      * add test that the candidate selection algorithm picks the right ones
      
      * make candidate selection test somewhat more stringent
      21cec309
    • Sergey Pepyakin's avatar
      Implementer's guide: downward messages and HRMP, take 2 (#1503) · 877a5059
      Sergey Pepyakin authored
      
      
      * First stab at downward messages.
      
      That also includes a notion of horizontal messages.
      
      * Add some structure to the router.
      
      * Update `ValidationOutputs`
      
      * Add `processed_downward_messages` to `ValidationOutputs`.
      
      Forgot to check that in.
      
      * s/AccountId/ParaId
      
      * DownwardMessage::ParachainSpecfic
      
      * s/ensure_horizontal_messages_fits/ensure_horizontal_messages_fit
      
      * Clarify that Router called for each candidate
      
      * Update the preamble for Router.
      
      * Rewrite the relay-chain extrinsic routines
      
      * Update gloassary
      
      * Add DMP to the glossary
      
      * If the queue is empty, `processed_downward_messages` can be 0
      
      * WIP
      
      * Add condemned list
      
      * Pivot to message-storing channel based HRMP
      
      * Finished draft
      
      * Tidy up
      
      * Remove a duplicate glossary entry
      
      * Fix typo
      
      * Fix wording to emphasize that the channel is unidirectional
      
      * Proper decrement `HrmpOpenChannelRequestCount`
      
      * Add a comment for `HrmpOpenChannelRequestCount`.
      
      * Remove old configuration values.
      
      * Be more specific about the para{chain,thread} hrmp chan limits.
      
      * Fix indentation so the lists are rendendered properly
      
      * "to answer **the**" question instead of "a"
      
      * Add a missing call to `check_processed_downward_messages`
      
      * Clean more stuff during offboarding
      
      * Fix typo
      
      * Fix typo for the config
      
      * Add a call to `prune_dmq`
      
      * Add explicit invariants for ingress/egress indexes
      
      * Add comments for the sender/reciever deposit config fields
      
      * Document various fields and structs in Router module
      
      * More docs
      
      * Missing docs in Candidate.md
      
      * Tabs to spaces in router.md
      
      * Apply Rob's suggestion
      
      * Add the hrmp_ prefix to the router messages
      
      * Those are entry points
      
      * Use SessionIndex type for the `age` field
      
      * Use a struct to represent `HrmpChannelId`
      
      * Put only MQCs into the LocalValidationData
      
      * Close request can be initiated by the runtime directly
      
      * Close request can be initiated by the runtime directly
      
      * tabs/spaces
      
      * Maintain the list of the outgoing paras in Router
      
      * Update roadmap/implementers-guide/src/runtime/inclusion.md
      
      Co-authored-by: default avatarRobert Habermeier <[email protected]>
      
      * fix typo
      
      * Remove an unnecessary pair of code quotes
      
      Co-authored-by: default avatarRobert Habermeier <[email protected]>
      877a5059
    • Bastian Köcher's avatar
    • Gavin Wood's avatar
      Bump Substrate (#1548) · b1cf8a57
      Gavin Wood authored
      
      
      * Bump Substrate
      
      * Bumb substrate again
      
      Co-authored-by: default avatarAshley Ruglys <[email protected]>
      b1cf8a57
    • Pierre Krieger's avatar
    • Cecile Tonglet's avatar
      Add SyncOracle to network's Service (#1543) · e818944c
      Cecile Tonglet authored
      * WIP
      
      * WIP
      
      Forked at: e91642361133dba084a9c9b3efa45fcb6cd3c5ca
      Parent branch: origin/rococo-branch
      
      * WIP
      
      Forked at: e91642361133dba084a9c9b3efa45fcb6cd3c5ca
      Parent branch: origin/rococo-branch
      
      * Apply suggestions from code review
      
      * Update collator/src/lib.rs
      
      * Update collator/src/lib.rs
      
      * Update network/src/protocol/mod.rs
      e818944c
    • Cecile Tonglet's avatar
      Ignore checks for companion PRs (#1455) · 497772da
      Cecile Tonglet authored
      497772da
  8. Aug 05, 2020
  9. Aug 04, 2020