1. Feb 22, 2021
  2. Feb 19, 2021
  3. Feb 18, 2021
  4. Feb 17, 2021
    • Cecile Tonglet's avatar
      Fix telemetry span not entering properly attempt 3 (#8043) · 27274c42
      Cecile Tonglet authored
      
      
      * Fix tracing tests (#8022)
      
      * Fix tracing tests
      
      The tests were not working properly.
      
      1. Some test was setting a global subscriber, this could lead to racy
      conditions with other tests.
      
      2. A logging test called `process::exit` which is completly wrong.
      
      * Update client/tracing/src/lib.rs
      
      Co-authored-by: default avatarDavid <[email protected]>
      
      * Review comments
      
      Co-authored-by: default avatarDavid <[email protected]>
      
      * Fix tracing spans are not being forwarded to spawned task (#8009)
      
      * Fix tracing spans are not being forwarded to spawned task
      
      There is a bug that tracing spans are not forwarded to spawned task. The
      problem was that only the telemetry span was forwarded. The solution to
      this is to use the tracing provided `in_current_span` to capture the
      current active span and pass the telemetry span explictely. We will now
      always enter the span when the future is polled. This is essentially the
      same strategy as tracing is doing with its `Instrumented`, but now
      extended for our use case with having multiple spans active.
      
      * More tests
      
      * Proper test for telemetry and prefix span
      
      * WIP
      
      * Fix test (need to create & enter the span at the same time)
      
      * WIP
      
      * Remove telemtry_span from sc_service config
      
      * CLEANUP
      
      * Update comment
      
      * Incorrect indent
      
      * More meaningful name
      
      * Dedent
      
      * Naming XD
      
      * Attempt to make a more complete test
      
      * lint
      
      * Missing licenses
      
      * Remove user data
      
      * CLEANUP
      
      * Apply suggestions from code review
      
      Co-authored-by: default avatarBastian Köcher <[email protected]>
      
      * CLEANUP
      
      * Apply suggestion
      
      * Update bin/node/cli/tests/telemetry.rs
      
      Co-authored-by: default avatarDavid <[email protected]>
      
      * Wrapping lines
      
      Co-authored-by: default avatarBastian Köcher <[email protected]>
      Co-authored-by: default avatarDavid <[email protected]>
      27274c42
  5. Feb 16, 2021
  6. Feb 15, 2021
  7. Feb 12, 2021
  8. Feb 10, 2021
  9. Feb 05, 2021
    • Alexander Theißen's avatar
      contracts: Remove ConfigCache (#8047) · 1b31f7c5
      Alexander Theißen authored
      
      
      * contracts: Remove ConfigCache
      
      * cargo run --release --features=runtime-benchmarks --manifest-path=bin/node/cli/Cargo.toml -- benchmark --chain=dev --steps=50 --repeat=20 --pallet=pallet_contracts --extrinsic=* --execution=wasm --wasm-execution=compiled --heap-pages=4096 --output=./frame/contracts/src/weights.rs --template=./.maintain/frame-weight-template.hbs
      
      * Fixup test
      
      Co-authored-by: default avatarParity Benchmarking Bot <[email protected]>
      1b31f7c5
  10. Feb 04, 2021
  11. Feb 03, 2021
  12. Feb 02, 2021
    • Liu-Cheng Xu's avatar
      Decouple the session validators from im-online (#7127) · 9904267e
      Liu-Cheng Xu authored
      * Decouple the session validators from im-online
      
      * .
      
      * Add SessionInterface trait in im-online
      
      Add ValidatorId in im-online Trait
      
      Make im-online compile
      
      Make substrate binary compile
      
      * Fix merging issue
      
      * Make all compile
      
      * Fix tests
      
      * Avoid using frame dep in primitives via pallet-session-common
      
      * Merge ValidatorSet into SessionInterface trait
      
      Wrap a few too long lines
      
      Add some docs
      
      * Move pallet-sesion-common into pallet-session
      
      * Move SessionInterface to sp-session and impl it in session pallet
      
      Ref https://github.com/paritytech/substrate/pull/7127#discussion_r494892472
      
      
      
      * Split put historical::FullValidatorIdentification trait
      
      * Fix line width
      
      * Fix staking mock
      
      * Fix session doc test
      
      * Simplify <T as ValidatorIdentification<AccountId>>::ValidatorId as ValidatorId<T>
      
      * Nits
      
      * Clean up.
      
      * Make it compile by commenting out report_offence_im_online bench
      
      * Tests
      
      * Nits
      
      * Move OneSessionHandler to sp-session
      
      * Fix tests
      
      * Add some docs
      
      * .
      
      * Fix typo
      
      * Rename to ValidatorSet::session_index()
      
      * Add some more docs
      
      * .
      
      * Remove extra empty line
      
      * Fix line width check
      
      .
      
      * Apply suggestions from code review
      
      * Cleaup Cargo.toml
      
      * Aura has migrated to Pallet now
      
      Co-authored-by: default avatarTomasz Drwięga <[email protected]>
      9904267e
    • Pierre Krieger's avatar
  13. Jan 29, 2021
  14. Jan 28, 2021
    • Bastian Köcher's avatar
      Introduce a `Slot` type (#7997) · b6294418
      Bastian Köcher authored
      
      
      * Introduce a `Slot` type
      
      Instead of having some type definition that only was used in half of the
      code or directly using `u64`, this adds a new unit type wrapper `Slot`.
      This makes it especially easy for the outside api to know what type is
      expected/returned.
      
      * Change epoch duratioC
      
      * rename all instances of slot number to slot
      
      * Make the constructor private
      
      Co-authored-by: default avatarAndré Silva <[email protected]>
      b6294418
    • Tomasz Drwięga's avatar
      Merkle Mountain Range pallet improvements (#7891) · 6c2dd28d
      Tomasz Drwięga authored
      
      
      * Add stateless verification helper function.
      
      * Split MMR primitives.
      
      * Add RuntimeAPI
      
      * RuntimeAPI with OpaqueLeaves
      
      * Bump spec_version,.
      
      * Move primitives back to frame.
      
      * Fix OpaqueLeaf encoding.
      
      * Add block number to frame_system implementation of LeafDataProvider.
      
      * Relax leaf codec requirements and fix OpaqueLeaf
      
      * Add root to debug line.
      
      * Apply suggestions from code review
      
      Co-authored-by: default avatarHernando Castano <[email protected]>
      
      * Typo.
      
      Co-authored-by: default avatarHernando Castano <[email protected]>
      6c2dd28d
  15. Jan 27, 2021
  16. Jan 26, 2021
  17. Jan 25, 2021
  18. Jan 21, 2021
    • Jon Häggblad's avatar
      Cleaner GRANDPA RPC API for proving finality (#7339) · 20f40fbd
      Jon Häggblad authored
      
      
      * grandpa: persist block number for last block of authority set
      
      * grandpa: fix authority_set_changes field in tests
      
      * grandpa: fix date on copyright notice
      
      * grandpa-rpc: implement cleaner api for prove finality rpc
      
      * grandpa-rpc: replace the old prove_finality with the new one
      
      * grandpa: undo accidental whitespace change
      
      * grandpa-rpc: start work on redo of the finality_proof RPC API
      
      * grandpa: manual impl of Decode for AuthoritySet
      
      * grandpa: add comment about appending changes for forced changes
      
      * grandpa: flip order in set changes, tidy up some comments
      
      * grandpa: update some of the doc comments
      
      * grandpa: store authority set changes when applying forced changes
      
      * grandpa: simplify finality_proof.rs
      
      * grandpa: move checks and extend tests in finality_proof
      
      * grandpa: address first set of review comments
      
      * grandpa: check that set changes have well-defined start
      
      * grandpa: rework prove_finality and assocated tests
      
      * grandpa: make AuthoritySetChanges tuple struct
      
      * grandpa: add assertions for tracking auth set changes
      
      * grandpa: remove StorageAndProofProvider trait
      
      * grandpa: return more informative results for unexpected input to RPC
      
      * grandpa: tiny tweak to error msg
      
      * grandpa: fix tests
      
      * grandpa: add error specific to finality_proof
      
      * grandpa: fix review comments
      
      * grandpa: proper migration to new AuthoritySet
      
      * grandpa: fix long lines
      
      * grandpa: fix unused warning after merge
      
      Co-authored-by: default avatarAndré Silva <[email protected]>
      20f40fbd
    • Ashley's avatar
      Grandpa warp sync request-response protocol (#7711) · 87cc2167
      Ashley authored
      
      
      * Made a start
      
      * So the proof between authority set is phragmen one, this is crazy big,
      or is there some signing of the result : that is the storage key, damn?
      
      * ok getting from header digest seems doable.
      
      * for testing
      
      * get set id from storage directly (should use runtime to handler change).
      
      * move test to init
      
      * correct auth key
      
      * fix iteration
      
      * Correct proof content
      
      * actually update block number.
      
      * actually check last justif against its header
      
      * justification relation to new authorities through header hash check is
      needed here. This assumes the hash from header is calculated.
      
      * Few changes
      
      * Connected up cheme's branch
      
      * Clean up
      
      * Move things around a bit so that adding the grandpa warp sync request response protocol happens in the node code
      
      * Nits
      
      * Changes to comments
      
      * Cheme changes
      
      * Remove todos and test compile.
      
      * Rename _authority_ related proof function to _warp_sync_ .
      
      * Update client/grandpa-warp-sync/src/lib.rs
      
      quick fix
      
      * Put the warp sync request response protocol behind a feature flag because we dont' need it on a light client.
      
      * Update client/grandpa-warp-sync/src/lib.rs
      
      Quick fix
      
      * Update Cargo.lock
      
      * Adding test, comment on limitation related to 'delay', this could
      be implemented but with a cost.
      
      * Set between a delay override last fragment.
      
      * Check for pending authority set change at start.
      
      * adjust index
      
      * custom cache is not a good idea.
      
      * Use a simple cache instead.
      
      * restore broken indentation
      
      * Address crate rename
      
      * Merge conflict badly resolved, sorry
      
      Co-authored-by: default avatarcheme <[email protected]>
      Co-authored-by: default avatarPierre Krieger <[email protected]>
      87cc2167
  19. Jan 20, 2021
    • Kian Paimani's avatar
      Fix elections-phragmen and proxy issue (#7040) · e8307b7b
      Kian Paimani authored
      * Fix elections-phragmen and proxy issue
      
      * remove TODO
      
      * Update bond to be per-vote
      
      * Update frame/elections-phragmen/src/lib.rs
      
      * Fix benchmakrs
      
      * Fix weight as well.
      
      * Add license
      
      * Make weight interpreted wasm! 🤦🏻
      
      ‍♂️
      
      * Remove a bunch of TODOs
      
      * Add migration
      
      * Better storage version.
      
      * Functionify.
      
      * Fix deposit scheme.
      
      * remove legacy bond.
      
      * Master.into()
      
      * better logging.
      
      * Fix benchmarking test
      
      * Fix confused deposit collection.
      
      * Add fine
      
      * Better name for storage item
      
      * Fix name again.
      
      * remove unused
      
      * Update frame/elections-phragmen/src/lib.rs
      
      Co-authored-by: default avatarGuillaume Thiolliere <[email protected]>
      
      * Update frame/elections-phragmen/src/lib.rs
      
      Co-authored-by: default avatarGuillaume Thiolliere <[email protected]>
      
      * cargo run --release --features runtime-benchmarks --manifest-path bin/node/cli/Cargo.toml -- benchmark --chain dev --steps 50 --repeat 20 --extrinsic * --execution=wasm --wasm-execution=compiled --output ./bin/node/runtime/src/weights --header ./HEADER --pallet pallet_elections_phragmen
      
      * new weight fns
      
      * Fix build
      
      * Fix line width
      
      * fix benchmakrs
      
      * fix warning
      
      * cargo run --release --features runtime-benchmarks --manifest-path bin/node/cli/Cargo.toml -- benchmark --chain dev --steps 50 --repeat 20 --extrinsic * --execution=wasm --wasm-execution=compiled --output ./bin/node/runtime/src/weights --header ./HEADER --pallet pallet_elections_phragmen
      
      * Tune the stake again
      
      * cargo run --release --features runtime-benchmarks --manifest-path bin/node/cli/Cargo.toml -- benchmark --chain dev --steps 50 --repeat 20 --extrinsic * --execution=wasm --wasm-execution=compiled --output ./bin/node/runtime/src/weights --header ./HEADER --pallet pallet_elections_phragmen
      
      * All tests work again.
      
      * A large number of fixes.
      
      * more fixes.
      
      * Fix node build
      
      * Some fixes to benchmarks
      
      * Fix some warnings.
      
      * cargo run --release --features=runtime-benchmarks --manifest-path=bin/node/cli/Cargo.toml -- benchmark --chain=dev --steps=50 --repeat=20 --pallet=pallet_elections_phragmen --extrinsic=* --execution=wasm --wasm-execution=compiled --heap-pages=4096 --output=./frame/elections-phragmen/src/weights.rs --template=./.maintain/frame-weight-template.hbs
      
      * cargo run --release --features=runtime-benchmarks --manifest-path=bin/node/cli/Cargo.toml -- benchmark --chain=dev --steps=50 --repeat=20 --pallet=pallet_elections_phragmen --extrinsic=* --execution=wasm --wasm-execution=compiled --heap-pages=4096 --output=./frame/elections-phragmen/src/weights.rs --template=./.maintain/frame-weight-template.hbs
      
      * Update frame/elections-phragmen/src/lib.rs
      
      Co-authored-by: default avatarGuillaume Thiolliere <[email protected]>
      
      * a batch of review comments.
      
      * Fix a test.
      
      * Fix some more tests.
      
      * do migration with pallet version???
      
      * Final touches.
      
      * Remove unused storage.
      
      * another rounds of changes and fixes.
      
      * Update frame/elections-phragmen/src/lib.rs
      
      Co-authored-by: default avatarShawn Tabrizi <[email protected]>
      
      * Update frame/elections-phragmen/src/lib.rs
      
      Co-authored-by: default avatarShawn Tabrizi <[email protected]>
      
      * Review grumbles.
      
      * Fix a bit more.
      
      * Fix build
      
      * Experimental: independent migration.
      
      * WIP: isolated migration logics
      
      * clean up.
      
      * make migration struct private and move migration to own file
      
      * add doc
      
      * fix StorageInstance new syntax
      
      * Update frame/elections-phragmen/src/migrations_3_0_0.rs
      
      Co-authored-by: default avatarShawn Tabrizi <[email protected]>
      
      * another round of self-review.
      
      * bit better formatting
      
      * cargo run --release --features=runtime-benchmarks --manifest-path=bin/node/cli/Cargo.toml -- benchmark --chain=dev --steps=50 --repeat=20 --pallet=pallet_elections_phragmen --extrinsic=* --execution=wasm --wasm-execution=compiled --heap-pages=4096 --output=./frame/elections-phragmen/src/weights.rs --template=./.maintain/frame-weight-template.hbs
      
      * Fix tests.
      
      * Round of self-review
      
      * Clean migrations
      
      * cargo run --release --features=runtime-benchmarks --manifest-path=bin/node/cli/Cargo.toml -- benchmark --chain=dev --steps=50 --repeat=20 --pallet=pallet_elections_phragmen --extrinsic=* --execution=wasm --wasm-execution=compiled --heap-pages=4096 --output=./frame/elections-phragmen/src/weights.rs --template=./.maintain/frame-weight-template.hbs
      
      * Revert unwanted change to construct-runtime
      
      Co-authored-by: default avatarGavin Wood <[email protected]>
      Co-authored-by: default avatarGuillaume Thiolliere <[email protected]>
      Co-authored-by: default avatarShawn Tabrizi <[email protected]>
      Co-authored-by: default avatarParity Benchmarking Bot <[email protected]>
      e8307b7b
    • Cecile Tonglet's avatar
      Telemetry per node (#7463) · 970cc25c
      Cecile Tonglet authored
      970cc25c
    • Andrew Jones's avatar
      Migrate frame-system to pallet attribute macro (#7898) · 71ef82af
      Andrew Jones authored
      
      
      * PRINT_PALLET_UPGRADE=1 cargo check -p frame-system
      
      * Copy attributes, imports, mods and type defs
      
      * Copy Config trait
      
      * Annotate constants
      
      * Tabify
      
      * Migrate hooks
      
      * Upgrade template rename interface to hooks
      
      * Migrate pallet call
      
      * Migrate Event
      
      * Migrate Error
      
      * Migrate Origin
      
      * Remove optional validate_unsigned
      
      * Remove remaining TODO_MAYBE_WHERE_CLAUSE
      
      * Overwrite original lib.rs with migrated lib2.rs.
      
      * Add required Event IsType constraint
      
      * Add disable supertrait check
      
      * Fix leftover Trait trait
      
      * Add missing pallet prefix for weight attributes
      
      * Add missing Error type parameter
      
      * Add missing Hooks type parameter
      
      * Private call visibility, restore original helper types and helpers etc
      
      * Fix hooks type parameter
      
      * Rename RawEvent to Event
      
      * Add missing storage type annotations
      
      * Remove unused imports
      
      * Add GenesisConfig helpers for compat
      
      * Fix unused import warnings
      
      * Update frame/support/procedural/src/storage/print_pallet_upgrade.rs
      
      Co-authored-by: default avatarGuillaume Thiolliere <[email protected]>
      
      * Fix test errors and warnings
      
      * Fix remaining errors and warnings
      
      * Apply review suggestion: fix formatting
      
      Co-authored-by: default avatarGuillaume Thiolliere <[email protected]>
      
      * Apply review suggestion: annotate BlockLength as constant
      
      Co-authored-by: default avatarGuillaume Thiolliere <[email protected]>
      
      * Apply review suggestion: add triling comma
      
      Co-authored-by: default avatarGuillaume Thiolliere <[email protected]>
      
      * Apply review suggestion: add triling comma
      
      Co-authored-by: default avatarGuillaume Thiolliere <[email protected]>
      
      * Apply review suggestion: add trailing comma
      
      Co-authored-by: default avatarGuillaume Thiolliere <[email protected]>
      
      * Apply review suggestion: fix storage type indentation
      
      * Apply review suggestion: remove redundant Origin type alias
      
      * Add missing codec derives for BlockLength
      
      * Restore module docs
      
      * Module -> Pallet renamel
      
      * Revert "Update frame/support/procedural/src/storage/print_pallet_upgrade.rs"
      
      This reverts commit d2a2d5b6
      
      * Apply review suggestion: merge crate imports
      
      Co-authored-by: default avatarAlexander Theißen <[email protected]>
      
      * Revert "Upgrade template rename interface to hooks"
      
      This reverts commit 306f0239
      
      * Single line import
      
      * Refactor generated genesis build
      
      * Import sp_io::storage
      
      * Revert previous, fully qualify sp_io::storage
      
      * Fix ui tests
      
      * Fix errors after merge, missing changes
      
      * Set UpgradedToDualRefCount to true in genesis build
      
      * Annotated Runtime version with constant, exposing it via metadata
      
      * Add metadata attribute
      
      Co-authored-by: default avatarGuillaume Thiolliere <[email protected]>
      Co-authored-by: default avatarAlexander Theißen <[email protected]>
      71ef82af
  20. Jan 19, 2021
    • Shawn Tabrizi's avatar
      Freeze Assets and Asset Metadata (#7346) · 748bdf65
      Shawn Tabrizi authored
      
      
      * Features needed for reserve-backed stablecoins
      
      * Builds & tests.
      
      * Double map for an efficient destroy.
      
      * Update frame/assets/src/lib.rs
      
      Co-authored-by: default avatarNikolay Volf <[email protected]>
      
      * ED/zombie-count/refs
      
      Feature: ED/minimum balance enforcement
      Feature: enforce zombie count
      Feature: allow system-alive accounts to exist, but add reference
      
      * Update frame/assets/src/lib.rs
      
      Co-authored-by: default avatarNikolay Volf <[email protected]>
      
      * Update frame/assets/Cargo.toml
      
      Co-authored-by: default avatarNiklas Adolfsson <[email protected]>
      
      * Docs
      
      * Some tests
      
      * More tests
      
      * Allow for max_zombies to be adjusted
      
      * Test for set_max_zombies
      
      * Tests and a couple of fixes
      
      * First few benchmarks
      
      * Benchmarks.
      
      * Fix error message in test
      
      * Fixes
      
      * Fixes
      
      * Fixes
      
      * cargo run --release --features runtime-benchmarks --manifest-path bin/node/cli/Cargo.toml -- benchmark --chain dev --steps 50 --repeat 20 --extrinsic * --execution=wasm --wasm-execution=compiled --output ./bin/node/runtime/src/weights --header ./HEADER --pallet pallet_assets
      
      * Update frame/assets/src/lib.rs
      
      Co-authored-by: default avatarGuillaume Thiolliere <[email protected]>
      
      * Fixes
      
      * Fixes
      
      * Fixes
      
      * cargo run --release --features runtime-benchmarks --manifest-path bin/node/cli/Cargo.toml -- benchmark --chain dev --steps 50 --repeat 20 --extrinsic * --execution=wasm --wasm-execution=compiled --output ./bin/node/runtime/src/weights --header ./HEADER --pallet pallet_assets
      
      * Fixes
      
      * Update default weight
      
      * Add proper verification to benchmarks
      
      * minor improvements to tests
      
      * Add `freeze_asset` and `thaw_asset`
      
      * Add metadata
      
      * fix build
      
      * Update benchmarks
      
      * fix line width
      
      * cargo run --release --features runtime-benchmarks --manifest-path bin/node/cli/Cargo.toml -- benchmark --chain dev --steps 50 --repeat 20 --extrinsic * --execution=wasm --wasm-execution=compiled --output ./bin/node/runtime/src/weights --header ./HEADER --pallet pallet_assets
      
      * update default weights
      
      * destroy cleans up metadata
      
      * more comprehensive lifecycle test
      
      * update docs
      
      * Update frame/assets/src/benchmarking.rs
      
      Co-authored-by: default avatarKian Paimani <[email protected]>
      
      * Fix
      
      * New weights system
      
      * fix compile
      
      * cargo run --release --features=runtime-benchmarks --manifest-path=bin/node/cli/Cargo.toml -- benchmark --chain=dev --steps=50 --repeat=20 --pallet=pallet_assets --extrinsic=* --execution=wasm --wasm-execution=compiled --heap-pages=4096 --output=./frame/assets/src/weights.rs --template=./.maintain/frame-weight-template.hbs
      
      * fix compile
      
      * fix up
      
      * cargo run --release --features=runtime-benchmarks --manifest-path=bin/node/cli/Cargo.toml -- benchmark --chain=dev --steps=50 --repeat=20 --pallet=pallet_assets --extrinsic=* --execution=wasm --wasm-execution=compiled --heap-pages=4096 --output=./frame/assets/src/weights.rs --template=./.maintain/frame-weight-template.hbs
      
      * fixes to pallet compile
      
      * fix node build
      
      * remote diff artifacts
      
      * less diff
      
      * cargo run --release --features=runtime-benchmarks --manifest-path=bin/node/cli/Cargo.toml -- benchmark --chain=dev --steps=50 --repeat=20 --pallet=pallet_assets --extrinsic=* --execution=wasm --wasm-execution=compiled --heap-pages=4096 --output=./frame/assets/src/weights.rs --template=./.maintain/frame-weight-template.hbs
      
      * Update frame/assets/src/lib.rs
      
      * Update frame/assets/src/lib.rs
      
      * usize to u32
      
      * missed some usize
      
      * cargo run --release --features=runtime-benchmarks --manifest-path=bin/node/cli/Cargo.toml -- benchmark --chain=dev --steps=50 --repeat=20 --pallet=pallet_assets --extrinsic=* --execution=wasm --wasm-execution=compiled --heap-pages=4096 --output=./frame/assets/src/weights.rs --template=./.maintain/frame-weight-template.hbs
      
      Co-authored-by: default avatarGav Wood <[email protected]>
      Co-authored-by: default avatarNikolay Volf <[email protected]>
      Co-authored-by: default avatarNiklas Adolfsson <[email protected]>
      Co-authored-by: default avatarParity Benchmarking Bot <[email protected]>
      Co-authored-by: default avatarGuillaume Thiolliere <[email protected]>
      Co-authored-by: default avatarKian Paimani <[email protected]>
      748bdf65
  21. Jan 16, 2021