Skip to content
  1. Oct 01, 2021
    • ucover's avatar
      Test each benchmark case in own #[test] (#9860) · f8ce1864
      ucover authored
      
      
      * Generate one #[test] fn per bench case.
      
      * Update benchmark macro syntax in frame pallets.
      
      * Explain new benchmark macro syntax in example pallet.
      
      * support with and without a semicolon
      
      * update pallets to use individual tests
      
      * migrate staking too
      
      * migrate more pallets
      
      * fix up democracy and use individual tests
      
      * Fix comment
      
      * Put println message in panic
      
      * Remove `another_set_dummy` from doc
      
      `another_set_dummy` is not present in the benchmarking.rs (anymore).
      
      * Update doc for benchmarks macro
      
      * Update doc for impl_benchmark_test_suite macro
      
      Co-authored-by: default avatarShawn Tabrizi <[email protected]>
      f8ce1864
  2. Sep 29, 2021
  3. Sep 22, 2021
  4. Sep 15, 2021
    • Andrew Jones's avatar
      Enrich metadata with type information (#8615) · 49b6dfd2
      Andrew Jones authored
      
      
      * Cargo.lock after merge
      
      * Restore scale-info feature
      
      * Fully qualify TypeInfo derive
      
      * Skip PendingSwap T
      
      * Add missing skip_type_params attr
      
      * metadata docs features
      
      * Reduce pallet event attribute to struct
      
      * Cargo.lock
      
      * Update frame/balances/src/tests_composite.rs
      
      Co-authored-by: default avatarGuillaume Thiolliere <[email protected]>
      
      * Line widths check
      
      * Cargo.lock
      
      * Add scale-info/std
      
      * Update frame/system/src/lib.rs
      
      Co-authored-by: default avatarGuillaume Thiolliere <[email protected]>
      
      * Use `skip_type_params` to remove `TypeInfo` requirements on checks
      
      * Revert "Remove unused Call metadata stuff"
      
      This reverts commit 41311f85
      
      * Skip BalanceSwapAction type parameter
      
      * Remove unused event metadata macro
      
      * Update frame-metadata
      
      * Update primitives/npos-elections/compact/src/codec.rs
      
      Co-authored-by: default avatarGuillaume Thiolliere <[email protected]>
      
      * Manual TypeInfo for Header
      
      * Remove TypeInfo requirement for consts in BoundedVec etc.
      
      * Another TypeInfo bound removed
      
      * review: fix indentation
      
      * TypeInfo impls for Identity types
      
      * Add some todos to add custom TypeInfo impls
      
      * Update frame/support/procedural/src/pallet/expand/pallet_struct.rs
      
      Co-authored-by: default avatarGuillaume Thiolliere <[email protected]>
      
      * Add some todos to add custom TypeInfo impls
      
      * Add a test for manual Data TypeInfo impl
      
      * Add custom TypeInfo impl for Vote
      
      * Era custom TypeInfo crimes
      
      * Revert finality-grandpa version to 0.14.z
      
      * review: renamed module to pallet_constants_metadata
      
      * New line at end of file
      
      * Add missing scale-info/std
      
      * Update frame/support/src/storage/types/mod.rs
      
      Co-authored-by: default avatarGuillaume Thiolliere <[email protected]>
      
      * Remove StorageEntryType::Map unused flag
      
      * Add missing scale-info dependency after merge
      
      * SignedExtension::AdditionalSigned metadata
      
      * Update frame-metadata, use abbreviated docs and args fields
      
      * Update frame/example/Cargo.toml
      
      Co-authored-by: default avatarKeith Yeung <[email protected]>
      
      * Add scale_info/std and remove unused scale-info dependency
      
      * Remove scale-info dependency
      
      * Remove treasury pallet::metadata
      
      * Remove redundant Event test
      
      * Add back scale-info as dev dependency
      
      * fix error metadata when no error defined in decl_module
      
      * Add Module3 to tests
      
      * Fix metadata test
      
      * Add docs feature to frame-support test
      
      * WIP fixing pallet metadata test
      
      * Remove redundant FunctionMetadata, FunctionArgumentMetadata as per https://github.com/paritytech/frame-metadata/pull/20
      
      * Use main branch of frame-metadata
      
      * Use patch of scale-info for latest changes
      
      * Use latest patched scale-info
      
      * Manual TypeInfo for DigestItem
      
      * Manual TypeInfo for DigestItem
      
      * Update scale-info
      
      * Skip __Ignore variants for Error, depends on https://github.com/paritytech/scale-info/pull/117
      
      * Named fields for FRAME v2 pallet Call variants
      
      * Named fields for FRAME v1 pallet Call variants
      
      * Add missing scale-info dependency
      
      * WIP expand benchmark call variant
      
      * fix benchmark with new function
      
      create a new function for each variant of a pallet call.
      This function is called by benchmarking macro in order not to break call
      creation with unnamed argument
      
      * fix tests
      
      * more fix
      
      * Fix staking tests
      
      * Fix offchain workers calls
      
      * Cherry pick rustfmt.toml from master
      
      * cargo +nightly-2021-06-22 fmt --all
      
      * Update to new call variant structs
      
      * More call variant struct updates
      
      * Remove unused import
      
      * More call variant structs
      
      * More call variant structs
      
      * Even more call variant structs
      
      * Mooar variant structs
      
      * Evermore variant structs
      
      * Call variant structs ad infinitum
      
      * Fmt
      
      * More call variants
      
      * Last call variant
      
      * Call variants all done?
      
      * Fix SS58Prefix type
      
      * Potential workaround for BitFlags<IdentityFields> TypeInfo
      
      * Enable docs capturing for Call, Event, and Error types
      
      * Fix IdentityFields TypeInfo
      
      * Remove metadata-docs feature
      
      * Add capture_docs = true for legacy Call, Event and Error types
      
      * Fmt
      
      * Fix metadata test type
      
      * Update benchmarks with call struct variants
      
      * Fmt
      
      * More test fixes
      
      * Fmt
      
      * Fix benches
      
      * Use latest capture_docs attr
      
      * Latest scale_info
      
      * Fmt
      
      * review: change &Vec to &[]
      
      * Remove pallet metadata attr
      
      * review: remove commented out test code
      
      * review: skip_type_params trailing comma suggestion
      
      * Update to scale-info 0.10.0
      
      * Update construct_runtime ui tests, different because of metadata TypeInfo impls
      
      * Add some TypeInfo derives for UI tests
      
      * Update storage ensure span ui stderrs
      
      * Update call argument bound ui tests
      
      Possibly changed because change from tuple to struct variants?
      
      * Add scale-info dev dependency
      
      * Update to latest finality-grandpa release
      
      * review: missing newline
      
      * review: missing scale-info/std
      
      * review: remove duplicate scale-info/std
      
      * review: remove fully qualified TypeInfo
      
      * review: add missing scale-info/std
      
      * review: remove unnecessary imports.
      
      * Fmt
      
      * Use crates.io RC version of frame-metadata
      
      * Remove scale-info/std because it is a dev dependency
      
      * Add missing scale_info dev-dependency for test
      
      * Delete empty metadata folder
      
      * Fix sp_std import
      
      * review: improve manual UncheckedExtrinsic TypeInfo impl
      
      * review: use full scale-info for dev-dependency
      
      * Remove DefaultByteGetter impl
      
      * review: derive TypeInfo for generic header
      
      * Fmt
      
      * Update primitives/runtime/src/generic/unchecked_extrinsic.rs
      
      Co-authored-by: default avatarKeith Yeung <[email protected]>
      
      * Update primitives/runtime/src/generic/unchecked_extrinsic.rs
      
      Co-authored-by: default avatarKeith Yeung <[email protected]>
      
      * Update bin/node/executor/Cargo.toml
      
      Co-authored-by: default avatarBastian Köcher <[email protected]>
      
      * Update frame/identity/src/types.rs
      
      Co-authored-by: default avatarBastian Köcher <[email protected]>
      
      * Update frame/support/src/dispatch.rs
      
      Co-authored-by: default avatarBastian Köcher <[email protected]>
      
      * Remove redundant derive
      
      * Simplify scale-info dependency
      
      * Strip underscore prefix from call variant struct names
      
      * Another underscore field
      
      * More underscore fields
      
      * Another underscore field
      
      * Update to frame-metadata 14.0.0-rc.2 with combined StorageEntryType::Map
      
      * Fmt
      
      * Revert weights formatting
      
      * Fix up some tests
      
      * Fix up some tests for StorageEntryTypeMetadata
      
      * scale-info dev dependency
      
      * Fix test error
      
      * Add missing TypeInfo derives
      
      * Add back missing scale-info dependency
      
      * Add back missing scale-info dependency
      
      * Fix npos compact impls
      
      * Cargo.lock
      
      * Fmt
      
      * Fix errors
      
      * Fmt
      
      * Fix renamed raw_solution field
      
      * Fix error
      
      * Fmt
      
      * Fix some benchmarks
      
      * Fmt
      
      * Stray R
      
      * Fix
      
      * Add missing TypeInfos
      
      * ui test fix
      
      * Fix line widths
      
      * Revert "ui test fix"
      
      This reverts commit 2d15ec058a216e3f92d713f1174603a2bb1eac65.
      
      * Upgrade to scale-info 0.11.0
      
      * Revert "Upgrade to scale-info 0.11.0"
      
      This reverts commit 047bb179085a0059c36cd20ab405f55cf0867e28.
      
      * Add Runtime type
      
      * Update to scale-info 0.12
      
      * Update to scale-info 1.0
      
      * Update frame-metadata to version 14.0.0
      
      * Patch finality-grandpa until release available
      
      * Fix metadata tests
      
      * Fix metadata tests
      
      * Fmt
      
      * Remove patched finality-grandpa
      
      * Fix tests, use scale_info imports
      
      * Fix pallet tests
      
      * Add BlockNumber TypeInfo bound
      
      * ui test fix
      
      * Cargo.lock
      
      * Remove pallet metadata
      
      * Cargo.lock
      
      * Add missing scale-info dependency
      
      * Remove pallet event metadata
      
      * Fix error
      
      * Fix collective errors
      
      * Semicolol
      
      * Fmt
      
      * Remove another metadata attribute
      
      * Add new variant to custom digest TypeInfo
      
      * Fmt
      
      * Cargo.lock from master
      
      * Remove comma lol
      
      * Fix example call error
      
      * Fix example call error properly
      
      Co-authored-by: default avatarGuillaume Thiolliere <[email protected]>
      Co-authored-by: default avatarKeith Yeung <[email protected]>
      Co-authored-by: default avatarShawn Tabrizi <[email protected]>
      Co-authored-by: default avatarBastian Köcher <[email protected]>
      49b6dfd2
  5. Sep 03, 2021
  6. Sep 02, 2021
  7. Aug 18, 2021
    • Ashley's avatar
      Make choosing an executor (native/wasm) an explicit part of service construction (#9525) · bad45445
      Ashley authored
      
      
      * Split native executor stuff from wasm executor stuff
      
      * Remove `native_runtime_version` in places
      
      * Fix warning
      
      * Fix test warning
      
      * Remove redundant NativeRuntimeInfo trait
      
      * Add a warning for use_native
      
      * Run cargo fmt
      
      * Revert "Add a warning for use_native"
      
      This reverts commit 9494f765a06037e991dd60524f2ed1b14649bfd6.
      
      * Make choosing an executor (native/wasm) an explicit part of service construction
      
      * Add Cargo.lock
      
      * Rename Executor to ExecutorDispatch
      
      * Update bin/node/executor/src/lib.rs
      
      Co-authored-by: default avatarSquirrel <[email protected]>
      
      * Fix tests
      
      * Fix minor node-executor error
      
      * Fix node cli command thing
      
      Co-authored-by: default avatarSquirrel <[email protected]>
      bad45445
  8. Aug 16, 2021
  9. Aug 13, 2021
    • Squirrel's avatar
      depend-o-pocalipse (#9450) · 7e9b8d27
      Squirrel authored
      Remove unneeded dependencies and dev-dependencies.
      Made self_destruct test not dependent on wasm bin size.  
      Updated code related to deprecated warning on tracing-subscriber `scope()` 
      ( See https://github.com/tokio-rs/tracing/issues/1429 )
      7e9b8d27
    • Bastian Köcher's avatar
      Upgrade jsonrpc to 0.18.0 (#9547) · c44aba89
      Bastian Köcher authored
      * Upgrade jsonrpc to 0.18.0
      
      I think this says all :P
      
      * 🤦
      
      * Fmt etc
      
      * Fix tests
      
      * Fix tests again...
      
      * Better impl
      
      * Revert "Tell dependabot to ignore jsonrpc-* updates (#9518)"
      
      This reverts commit 6e0cd558.
      c44aba89
  10. Aug 07, 2021
  11. Aug 04, 2021
    • Bastian Köcher's avatar
      Decouples light-sync state from chain spec (#9491) · 6e4d30e8
      Bastian Köcher authored
      * Decouples light-sync state from chain spec
      
      This decouples the light-sync state from chain spec. First, the
      light-sync state currently only works with BABE+Grandpa, so not
      all *Substrate* based chains can use this feature. The next problem was
      also that this pulled the `sc-consensus-babe` and `sc-finality-grandpa`
      crate into `sc-chain-spec`.
      
      If a chain now wants to support the light-sync state, it needs to add
      the `LightSyncStateExtension` to the chain spec as an extension. This is
      documented in the crate level docs of `sc-sync-state-rpc`. If this
      extension is not available, `SyncStateRpc` fails at initialization.
      
      * Fix compilation for browser
      
      * Fmt
      6e4d30e8
  12. Aug 03, 2021
  13. Aug 02, 2021
  14. Aug 01, 2021
    • Shawn Tabrizi's avatar
      Refactor Benchmarks for Less Wasm Memory Usage (#9373) · fa8c6274
      Shawn Tabrizi authored
      
      
      * extract repeat out of benchmark
      
      * remove r
      
      * unused
      
      * cargo run --quiet --release --features=runtime-benchmarks --manifest-path=bin/node/cli/Cargo.toml -- benchmark --chain=dev --steps=50 --repeat=20 --pallet=pallet_balances --extrinsic=* --execution=wasm --wasm-execution=compiled --heap-pages=4096 --output=./frame/balances/src/weights.rs --template=./.maintain/frame-weight-template.hbs
      
      * cargo run --quiet --release --features=runtime-benchmarks --manifest-path=bin/node/cli/Cargo.toml -- benchmark --chain=dev --steps=50 --repeat=20 --pallet=pallet_balances --extrinsic=* --execution=wasm --wasm-execution=compiled --heap-pages=4096 --output=./frame/balances/src/weights.rs --template=./.maintain/frame-weight-template.hbs
      
      * cargo run --quiet --release --features=runtime-benchmarks --manifest-path=bin/node/cli/Cargo.toml -- benchmark --chain=dev --steps=50 --repeat=20 --pallet=pallet_staking --extrinsic=* --execution=wasm --wasm-execution=compiled --heap-pages=4096 --output=./frame/staking/src/weights.rs --template=./.maintain/frame-weight-template.hbs
      
      * use linked map to keep order
      
      * cargo run --quiet --release --features=runtime-benchmarks --manifest-path=bin/node/cli/Cargo.toml -- benchmark --chain=dev --steps=50 --repeat=20 --pallet=pallet_balances --extrinsic=* --execution=wasm --wasm-execution=compiled --heap-pages=4096 --output=./frame/balances/src/weights.rs --template=./.maintain/frame-weight-template.hbs
      
      * Delete pallet_balances.rs
      
      * Delete out
      
      * cargo run --quiet --release --features=runtime-benchmarks --manifest-path=bin/node/cli/Cargo.toml -- benchmark --chain=dev --steps=50 --repeat=20 --pallet=pallet_staking --extrinsic=* --execution=wasm --wasm-execution=compiled --heap-pages=4096 --output=./frame/staking/src/weights.rs --template=./.maintain/frame-weight-template.hbs
      
      * steps and repeat to tuple (current_*, total_*)
      
      * idea for list command
      
      * fmt
      
      * use benchmark list in cli
      
      * handle steps in cli
      
      * move log update to cli
      
      * fmt
      
      * remove old todo
      
      * line width
      
      * cargo run --quiet --release --features=runtime-benchmarks --manifest-path=bin/node/cli/Cargo.toml -- benchmark --chain=dev --steps=50 --repeat=20 --pallet=pallet_balances --extrinsic=* --execution=wasm --wasm-execution=compiled --heap-pages=4096 --output=./frame/balances/src/weights.rs --template=./.maintain/frame-weight-template.hbs
      
      * benchmark metadata function
      
      * don't need this warm up
      
      * cargo run --quiet --release --features=runtime-benchmarks --manifest-path=bin/node/cli/Cargo.toml -- benchmark --chain=dev --steps=50 --repeat=20 --pallet=pallet_balances --extrinsic=* --execution=wasm --wasm-execution=compiled --heap-pages=4096 --output=./frame/balances/src/weights.rs --template=./.maintain/frame-weight-template.hbs
      
      * fix warnings
      
      * fix node-template
      
      * fix
      
      * fmt
      
      * line width
      
      * cargo run --quiet --release --features=runtime-benchmarks --manifest-path=bin/node/cli/Cargo.toml -- benchmark --chain=dev --steps=50 --repeat=20 --pallet=pallet_staking --extrinsic=* --execution=wasm --wasm-execution=compiled --heap-pages=4096 --output=./frame/staking/src/weights.rs --template=./.maintain/frame-weight-template.hbs
      
      * improve docs
      
      * improve cli
      
      * fix format
      
      * fix bug?
      
      * Revert "fix bug?"
      
      This reverts commit 8051bf1bf9bae862ff28dfff386e7045cd3f045e.
      
      * skip frame-metadata
      
      * extract repeat out of benchmark
      
      * remove r
      
      * cargo run --quiet --release --features=runtime-benchmarks --manifest-path=bin/node/cli/Cargo.toml -- benchmark --chain=dev --steps=50 --repeat=20 --pallet=pallet_balances --extrinsic=* --execution=wasm --wasm-execution=compiled --heap-pages=4096 --output=./frame/balances/src/weights.rs --template=./.maintain/frame-weight-template.hbs
      
      * cargo run --quiet --release --features=runtime-benchmarks --manifest-path=bin/node/cli/Cargo.toml -- benchmark --chain=dev --steps=50 --repeat=20 --pallet=pallet_balances --extrinsic=* --execution=wasm --wasm-execution=compiled --heap-pages=4096 --output=./frame/balances/src/weights.rs --template=./.maintain/frame-weight-template.hbs
      
      * cargo run --quiet --release --features=runtime-benchmarks --manifest-path=bin/node/cli/Cargo.toml -- benchmark --chain=dev --steps=50 --repeat=20 --pallet=pallet_staking --extrinsic=* --execution=wasm --wasm-execution=compiled --heap-pages=4096 --output=./frame/staking/src/weights.rs --template=./.maintain/frame-weight-template.hbs
      
      * use linked map to keep order
      
      * cargo run --quiet --release --features=runtime-benchmarks --manifest-path=bin/node/cli/Cargo.toml -- benchmark --chain=dev --steps=50 --repeat=20 --pallet=pallet_balances --extrinsic=* --execution=wasm --wasm-execution=compiled --heap-pages=4096 --output=./frame/balances/src/weights.rs --template=./.maintain/frame-weight-template.hbs
      
      * Delete pallet_balances.rs
      
      * Delete out
      
      * cargo run --quiet --release --features=runtime-benchmarks --manifest-path=bin/node/cli/Cargo.toml -- benchmark --chain=dev --steps=50 --repeat=20 --pallet=pallet_staking --extrinsic=* --execution=wasm --wasm-execution=compiled --heap-pages=4096 --output=./frame/staking/src/weights.rs --template=./.maintain/frame-weight-template.hbs
      
      * steps and repeat to tuple (current_*, total_*)
      
      * idea for list command
      
      * fmt
      
      * use benchmark list in cli
      
      * handle steps in cli
      
      * move log update to cli
      
      * remove old todo
      
      * line width
      
      * cargo run --quiet --release --features=runtime-benchmarks --manifest-path=bin/node/cli/Cargo.toml -- benchmark --chain=dev --steps=50 --repeat=20 --pallet=pallet_balances --extrinsic=* --execution=wasm --wasm-execution=compiled --heap-pages=4096 --output=./frame/balances/src/weights.rs --template=./.maintain/frame-weight-template.hbs
      
      * benchmark metadata function
      
      * don't need this warm up
      
      * cargo run --quiet --release --features=runtime-benchmarks --manifest-path=bin/node/cli/Cargo.toml -- benchmark --chain=dev --steps=50 --repeat=20 --pallet=pallet_balances --extrinsic=* --execution=wasm --wasm-execution=compiled --heap-pages=4096 --output=./frame/balances/src/weights.rs --template=./.maintain/frame-weight-template.hbs
      
      * fix warnings
      
      * fix node-template
      
      * fix
      
      * fmt
      
      * line width
      
      * cargo run --quiet --release --features=runtime-benchmarks --manifest-path=bin/node/cli/Cargo.toml -- benchmark --chain=dev --steps=50 --repeat=20 --pallet=pallet_staking --extrinsic=* --execution=wasm --wasm-execution=compiled --heap-pages=4096 --output=./frame/staking/src/weights.rs --template=./.maintain/frame-weight-template.hbs
      
      * improve docs
      
      * improve cli
      
      * fix format
      
      * fix bug?
      
      * Revert "fix bug?"
      
      This reverts commit 8051bf1bf9bae862ff28dfff386e7045cd3f045e.
      
      * skip frame-metadata
      
      * Update .gitlab-ci.yml
      
      * fix import
      
      * Update .gitlab-ci.yml
      
      Co-authored-by: default avatarParity Benchmarking Bot <[email protected]>
      fa8c6274
  15. Jul 30, 2021
  16. Jul 26, 2021
  17. Jul 21, 2021
    • Bastian Köcher's avatar
      Run cargo fmt on the whole code base (#9394) · 7b56ab15
      Bastian Köcher authored
      * Run cargo fmt on the whole code base
      
      * Second run
      
      * Add CI check
      
      * Fix compilation
      
      * More unnecessary braces
      
      * Handle weights
      
      * Use --all
      
      * Use correct attributes...
      
      * Fix UI tests
      
      * AHHHHHHHHH
      
      * 🤦
      
      * Docs
      
      * Fix compilation
      
      * 🤷
      
      * Please stop
      
      * 🤦
      
       x 2
      
      * More
      
      * make rustfmt.toml consistent with polkadot
      
      Co-authored-by: default avatarAndré Silva <[email protected]>
      7b56ab15
  18. Jul 13, 2021
  19. Jul 12, 2021
  20. Jul 11, 2021
    • Benjamin Kampmann's avatar
      Attempting to fix publishing (#9140) · c78c2892
      Benjamin Kampmann authored
      
      
      * mark template and utils as non-publish
      
      * switch to development version for testing
      
      * activate unleash check
      
      * maybe if I disable all rules...
      
      * Fix isolated compilation of `max-encoded-len-derive` with `syn`
      
      error[E0369]: binary operation `==` cannot be applied to type `syn::Path`
        --> src/lib.rs:88:29
         |
      88 |             .filter(|attr| attr.path == parse_quote!(max_encoded_len_crate))
         |                            --------- ^^ ----------------------------------- _
         |                            |
         |                            syn::Path
      
      error: aborting due to previous error
      
      For more information about this error, try `rustc --explain E0369`.
      Error: could not compile `max-encoded-len-derive`
      
      * WIP: bump changes crates since v3 tag to next breaking
      
      cargo unleash version bump-breaking --changed-since v3.0.0
      cargo unleash version set-pre dev --changed-since v3.0.0
      
      FIXME: Don't modify crates that are not yet released, e.g.
      `max-encoded-len-derive`
      
      * Update lockfile
      
      * WIP: Bump sp-transaction-pool as well
      
      * WIP: Bump sp-offchain as well
      
      * WIP: Bump frame-system-rpc-runtime-api as well
      
      * WIP: Bump sp-authority-discovery as well
      
      * Manually deactivate dev-deps before `cargo unleash check`
      
      Otherwise we run into `Cycle detected` error.
      
      * Bump sp-consensus-slots
      
      * Add missing Cargo.lock change
      
      * Bump sp-consensus-vrf as well
      
      * Bump sp-keyring as well
      
      * Bump sp-consensus-pow as well
      
      * Try to speed up the `unleash-check` job
      
      Previously, the job took 106 minutes - let's see if explicitly
      specifying a `CARGO_TARGET_DIR` will help
      
      * fixup: Ensure the temp target dir exists for unleash check
      
      * Bump pallet-transaction-payment-rpc-runtime-api as well
      
      Needed for Polkadot
      
      * Bump pallet-transaction-payment-rpc as well
      
      Needed for Polkadot
      
      * Try updating crates after patching in the Polkadot CI job
      
      * Use another approach to update patched Substrate crates
      
      * Try to update all sp-core versions in Polkadot CI job
      
      * Simplify sp-core version checking
      
      * Apply another shellcheck lint
      
      * Just do the simplest thing I guess
      
      * Welp don't do --offline then
      
      * Clean up `unleash-check` job triggers
      
      Co-authored-by: default avatarDenis Pisarev <[email protected]>
      
      * Fix a note in unleash-check cache step
      
      * Add a note about temporary optimization in cargo-unleash
      
      * Pin a newer version of cargo-unleash
      
      Co-authored-by: default avatarIgor Matuszewski <[email protected]>
      Co-authored-by: default avatarDenis Pisarev <[email protected]>
      c78c2892
  21. Jul 08, 2021
    • Seun Lanlege's avatar
      sc-transcation-pool refactor (#9228) · 2ae9d367
      Seun Lanlege authored
      * Use TransactionPool trait
      
      * sc-transaction-pool-primitives
      
      * sc-transaction-pool-api
      
      * TP
      
      * bye sc_transaction_graph
      
      * fix line widths
      
      * fix import errors
      
      * fix import errors
      
      * fix import errors 🤦🏾‍♂️
      
      * fix import errors 🤦🏾‍♂️🤦🏾‍♂️🤦🏾‍♂️
      
      * remove sp-keyring
      2ae9d367
  22. Jul 07, 2021
    • Shawn Tabrizi's avatar
      Include `StorageInfo` in Benchmarking Pipeline (#9090) · b42b8fc5
      Shawn Tabrizi authored
      
      
      * extend storageinfo
      
      * extend_storage_info
      
      * use vec
      
      * add storage info to pipeline
      
      * get read and written keys
      
      * undo storageinfo move
      
      * refactor keytracker
      
      * return read / write count
      
      * playing with key matching
      
      * add basic `StorageInfo` constructor
      
      * add whitelisted to returned info
      
      * fix some test stuff
      
      * pipe comments into benchmark data
      
      * add_storage_comments
      
      * add comments to template
      
      * track only storage prefix
      
      * Update frame/benchmarking/src/lib.rs
      
      * cargo run --release --features=runtime-benchmarks --manifest-path=bin/node/cli/Cargo.toml -- benchmark --chain=dev --steps=50 --repeat=20 --pallet=pallet_balances --extrinsic=* --execution=wasm --wasm-execution=compiled --heap-pages=4096 --output=./frame/balances/src/weights.rs --template=./.maintain/frame-weight-template.hbs
      
      * fix test
      
      * cargo run --release --features=runtime-benchmarks --manifest-path=bin/node/cli/Cargo.toml -- benchmark --chain=dev --steps=50 --repeat=20 --pallet=pallet_balances --extrinsic=* --execution=wasm --wasm-execution=compiled --heap-pages=4096 --output=./frame/balances/src/weights.rs --template=./.maintain/frame-weight-template.hbs
      
      * remove test logs
      
      * add temp benchmark script
      
      * Apply suggestions from code review
      
      Co-authored-by: default avatarGuillaume Thiolliere <[email protected]>
      
      * remove keytracker and use trackedstoragekey
      
      * add comment for unknown keys
      
      * cargo run --release --features=runtime-benchmarks --manifest-path=bin/node/cli/Cargo.toml -- benchmark --chain=dev --steps=50 --repeat=20 --pallet=pallet_timestamp --extrinsic=* --execution=wasm --wasm-execution=compiled --heap-pages=4096 --output=./frame/timestamp/src/weights.rs --template=./.maintain/frame-weight-template.hbs
      
      * remove duplicate comments with unknown keys
      
      * cargo run --release --features=runtime-benchmarks --manifest-path=bin/node/cli/Cargo.toml -- benchmark --chain=dev --steps=50 --repeat=20 --pallet=pallet_timestamp --extrinsic=* --execution=wasm --wasm-execution=compiled --heap-pages=4096 --output=./frame/timestamp/src/weights.rs --template=./.maintain/frame-weight-template.hbs
      
      * cargo run --release --features=runtime-benchmarks --manifest-path=bin/node/cli/Cargo.toml -- benchmark --chain=dev --steps=50 --repeat=20 --pallet=pallet_balances --extrinsic=* --execution=wasm --wasm-execution=compiled --heap-pages=4096 --output=./frame/balances/src/weights.rs --template=./.maintain/frame-weight-template.hbs
      
      * refactor bench tracker, and fix results
      
      * cargo run --release --features=runtime-benchmarks --manifest-path=bin/node/cli/Cargo.toml -- benchmark --chain=dev --steps=50 --repeat=20 --pallet=pallet_balances --extrinsic=* --execution=wasm --wasm-execution=compiled --heap-pages=4096 --output=./frame/balances/src/weights.rs --template=./.maintain/frame-weight-template.hbs
      
      * fix child tries in new tracker
      
      * extra newline
      
      * fix unused warning
      
      * cargo run --release --features=runtime-benchmarks --manifest-path=bin/node/cli/Cargo.toml -- benchmark --chain=dev --steps=50 --repeat=20 --pallet=pallet_timestamp --extrinsic=* --execution=wasm --wasm-execution=compiled --heap-pages=4096 --output=./frame/timestamp/src/weights.rs --template=./.maintain/frame-weight-template.hbs
      
      * fix master merge
      
      * storage info usage refactor
      
      * remove now unused
      
      * fix refactor
      
      * use a vec for prefix
      
      * fix tests
      
      * also update writer to use vec
      
      * disable read and written keys for now
      
      * cargo run --release --features=runtime-benchmarks --manifest-path=bin/node/cli/Cargo.toml -- benchmark --chain=dev --steps=50 --repeat=20 --pallet=frame_system --extrinsic=* --execution=wasm --wasm-execution=compiled --heap-pages=4096 --output=./frame/system/src/weights.rs --template=./.maintain/frame-weight-template.hbs
      
      * Update frame/system/src/weights.rs
      
      * fix test
      
      * Delete weights.rs
      
      * reset weights
      
      Co-authored-by: default avatarParity Bot <[email protected]>
      Co-authored-by: default avatarGuillaume Thiolliere <[email protected]>
      b42b8fc5
  23. Jul 01, 2021
    • Bastian Köcher's avatar
      Do not call `initialize_block` before any runtime api (#8953) · d489bd70
      Bastian Köcher authored
      * Do not call `initialize_block` before any runtime api
      
      Before this change we always called `initialize_block` before calling
      into the runtime. There was already support with `skip_initialize` to skip
      the initialization. Almost no runtime_api requires that
      `initialize_block` is called before. Actually this only leads to higher
      execution times most of the time, because all runtime modules are
      initialized and this is especially expensive when the block contained a
      runtime upgrade.
      
      TLDR: Do not call `initialize_block` before calling a runtime api.
      
      * Change `validate_transaction` interface
      
      * Fix rpc test
      
      * Fixes and comments
      
      * Some docs
      d489bd70
  24. Jun 23, 2021
  25. Jun 19, 2021
  26. Jun 16, 2021
    • Keith Yeung's avatar
      Emit error when construct_runtime imports a non-existent pallet part (#8949) · 58e837fc
      Keith Yeung authored
      
      
      * Emit error when construct_runtime imports a non-existent Call part
      
      * Reword and display pallet name when emitting part not found error
      
      * Migrate decl_outer_dispatch to a proc macro
      
      * Rename calls.rs to call.rs
      
      * Create new construct_runtime_v2 macro
      
      * Add UI test for importing non-existent call part in construct_runtime
      
      * Emit error when construct_runtime imports a non-existent Config part
      
      * Emit error when construct_runtime imports a non-existent Event part
      
      * Migrate decl_outer_inherent to a proc macro
      
      * Emit error when construct_runtime imports a non-existent Inherent part
      
      * Migrate decl_outer_validate_unsigned to a proc macro
      
      * Emit error when construct_runtime imports a non-existent ValidateUnsigned part
      
      * impl for old macro
      
      * fix line width
      
      * add doc
      
      * hide macroes and use unique counter everywhere
      
      * Remove construct_runtime_v2
      
      * Encapsulate pallet part check macros in a module
      
      * Fix macro definitions in dummy part checker
      
      * Tag ProvideInherent impl with #[pallet::inherent] properly for authorship pallet
      
      * Remove Call part from pallets that do not define it
      
      * Add Call part unit tests
      
      * Remove undefined Call part import from offences pallet
      
      * Add tests for expand_outer_inherent
      
      * Remove Call part from pallets that do not define them
      
      * Remove Call part imports from pallets that do not have it defined
      
      * Remove Call part import of the offences pallet from grandpa pallet mocks
      
      * Update frame/support/test/tests/pallet.rs
      
      Co-authored-by: default avatarGuillaume Thiolliere <[email protected]>
      
      * Remove Call part imports for pallets that do not define them
      
      * Move inherent tests to inherent_expand
      
      * Add unit tests for expand_outer_validate_unsigned
      
      * Add newline at the end of file
      
      * fix ui test
      
      * Small prayer to RNGsus for fixing CI
      
      * Remove Call part from construct_runtime for randomness collective flip pallet
      
      * Remove Call part import for randomness collective flip pallet
      
      * Summon Laplace's demon instead of praying to RNGsus
      
      * Update test expectations
      
      * fix ui test and make sure it's flaky
      
      * Revert "fix ui test and make sure it's flaky"
      
      This reverts commit 362b6881389c911ef8d9ef85d71c9463f5694b20.
      
      * Comment out test instead of putting it in conditional compilation
      
      * Update UI test expectations
      
      * Update UI test expectations
      
      * Emit error when construct_runtime imports a non-existent Origin part
      
      Co-authored-by: default avatarthiolliere <[email protected]>
      Co-authored-by: default avatarDenis P <[email protected]>
      58e837fc
  27. Jun 14, 2021
  28. Jun 11, 2021
    • Bastian Köcher's avatar
      Transaction pool: Remove futures-diagnose and thread pool (#9074) · 68833498
      Bastian Köcher authored
      * Transaction pool: Remove futures-diagnose and thread pool
      
      This pr removes `futures-diagnose` as this isn't used anymore. Besides
      that the pr also removes the thread pool that was used to validate the
      transactions in the background. Instead of this thread pool we now spawn
      two separate long running tasks that we use to validate the
      transactions. All tasks of the transaction pool are now also spawned as
      essential tasks. This means, if any of these tasks is stopping, the node
      will stop as well.
      
      * Update client/transaction-pool/src/api.rs
      68833498
  29. Jun 09, 2021
    • Keith Yeung's avatar
      Use pallet names to name enum variants (#8990) · 828d1d74
      Keith Yeung authored
      * Remove unused event_metadata variable
      
      * Eliminate mod_name and use pallet names to name enum variants
      
      * Rename field name `pallet` to `path`
      
      * Use only the pallet name to generate variant names
      
      * Use new naming scheme for Event enum in sudo pallet tests
      
      * Use new naming scheme for Event enum in offences pallet tests
      
      * Use new naming scheme for Event enum in contracts pallet tests
      
      * Use new naming scheme for Event enum in collective pallet tests
      
      * Use new naming scheme for Event enum in bounties pallet tests
      
      * Use new naming scheme for Event enum in balances pallet tests
      
      * Use new naming scheme for Event enum in assets pallet tests
      
      * Use new naming scheme for Event enum in frame support tests
      
      * Use new naming scheme for Event enum in tips pallet tests
      
      * Use new naming scheme for Event enum in transaction payment pallet tests
      
      * Use new naming scheme for GenesisConfig fields in example pallet tests
      
      * Use new naming scheme for GenesisConfig fields in elections pallet tests
      
      * Use new naming scheme for Event enum in election provider multi-phase pallet tests
      
      * Use new naming scheme for Event enum in elections phragmen pallet tests
      
      * Use new naming scheme for GenesisConfig fields in chain spec
      
      * Use new naming scheme for Event enum in staking pallet mock
      
      * Use new naming scheme for GenesisConfig fields in node-template chain spec
      
      * Use new naming scheme for GenesisConfig fields in node-testing chain spec
      
      * Use new naming scheme for Event enum in node executor tests
      
      * Use new naming scheme for GenesisConfig fields in transaction storage pallet mock
      
      * Refactor match conditions
      828d1d74
  30. Jun 04, 2021
    • André Silva's avatar
      consensus: handle justification sync for blocks authored locally (#8698) · c44b552d
      André Silva authored
      * consensus: add trait to control justification sync process
      
      * network: implement JustificationSyncLink for NetworkService
      
      * slots: handle justification sync in slot worker
      
      * babe: fix slot worker instantiation
      
      * aura: fix slot worker instantiation
      
      * pow: handle justification sync in miner
      
      * babe: fix tests
      
      * aura: fix tests
      
      * node: fix compilation
      
      * node-template: fix compilation
      
      * consensus: rename justification sync link parameter
      
      * aura: fix test compilation
      
      * consensus: slots: move JustificationSyncLink out of on_slot
      c44b552d
    • Xiliang Chen's avatar
      Named reserve (#7778) · 223529e4
      Xiliang Chen authored
      
      
      * add NamedReservableCurrency
      
      * move currency related trait and types into a new file
      
      * implement NamedReservableCurrency
      
      * remove empty reserves
      
      * Update frame/support/src/traits.rs
      
      Co-authored-by: default avatarShawn Tabrizi <[email protected]>
      
      * fix build
      
      * bump year
      
      * add MaxReserves
      
      * repatriate_reserved_named should put reserved fund into named reserved
      
      * add tests
      
      * add some docs
      
      * fix warning
      
      * Update lib.rs
      
      * fix test
      
      * fix test
      
      * fix
      
      * fix
      
      * triggier CI
      
      * Move NamedReservableCurrency.
      
      * Use strongly bounded vec for reserves.
      
      * Fix test.
      
      * remove duplicated file
      
      * trigger CI
      
      * Make `ReserveIdentifier` assosicated type
      
      * add helpers
      
      * make ReserveIdentifier assosicated type
      
      * fix
      
      * update
      
      * trigger CI
      
      * Apply suggestions from code review
      
      Co-authored-by: default avatarShawn Tabrizi <[email protected]>
      
      * trigger CI
      
      * Apply suggestions from code review
      
      Co-authored-by: default avatarShawn Tabrizi <[email protected]>
      Co-authored-by: default avatarGavin Wood <[email protected]>
      Co-authored-by: default avatarShaun Wang <[email protected]>
      223529e4
  31. May 27, 2021
    • Roman Proskuryakov's avatar
      Remove: (#8748) · 8dfb8cd9
      Roman Proskuryakov authored
      * `NetworkStatusSinks`
      * `sc_service::SpawnTasksParams::network_status_sinks`
      
      Also:
      * `sc_service::build_network()` does not return `network_status_sinks`
      8dfb8cd9
  32. May 26, 2021
    • Jon Häggblad's avatar
      Migrate pallet-grandpa to attribute macros (#8724) · acef22bb
      Jon Häggblad authored
      * frame/grandpa: migrate Config
      
      * frame/grandpa: migrate decl_module
      
      * frame/grandpa: migrate decl_event
      
      * frame/grandpa: migrate decl_error
      
      * frame/grandpa: migrate decl_storage
      
      * frame/grandpa: make report_equivocation_unsigned pub(super)
      
      * frame/grandpa: remove unused imports
      
      * frame/grandpa: replace deprecated Module with Pallet
      
      * frame/grandpa: add RawEvent for compatibility
      
      * frame/grandpa: create migration to new storage prefix
      
      * frame/grandpa: bump version to 4.0.0
      
      * frame/grandpa: address review comments
      
      * Try using version 3.1 instead
      
      * frame/grandpa: tweak log text to say cancelled
      acef22bb
    • André Silva's avatar
      grandpa: enable light clients to participate in gossip (#8796) · 61507e1b
      André Silva authored
      
      
      * network: allow gossiping to light clients
      
      * grandpa: gossip global messages to light clients
      
      * grandpa: don't send neighbor packets to light clients
      
      * grandpa: fix tests
      
      * grandpa: export run_grandpa_observer
      
      * node: run grandpa observer on light client
      
      * node: start network at end
      
      * Use wasm_timer in finality-grandpa
      
      Co-authored-by: default avatarPierre Krieger <[email protected]>
      61507e1b
  33. May 23, 2021
  34. May 22, 2021
    • Bastian Köcher's avatar
      Aura improvements (#8881) · 4dc8f3a7
      Bastian Köcher authored
      * Aura: Expose function to build the verifier
      
      * Use best block to initialize the authorities cache
      
      * Use best block when determining the slot duration
      
      * Remove `AuraBlockImport`
      
      * Some cleanups
      
      * Fix build error
      4dc8f3a7
  35. May 12, 2021
    • Sergey Pepyakin's avatar
      Embed runtime version as a custom section (#8688) · 0849bcce
      Sergey Pepyakin authored
      
      
      * emit a custom section from impl_runtime_apis!
      
      This change emits a custom section from the impl_runtime_apis! proc macro.
      
      Each implemented API will result to emitting a link section `runtime_apis`.
      During linking all sections with this name will be concatenated and
      placed into the final wasm binary under the same name.
      
      * Introduce `runtime_version` proc macro
      
      This macro takes an existing `RuntimeVersion` const declaration, parses
      it and emits the version information in form of a linking section.
      Ultimately such a linking section will result into a custom wasm
      section.
      
      * Parse custom wasm section for runtime version
      
      * Apply suggestions from code review
      
      Co-authored-by: default avatarDavid <[email protected]>
      
      * Fix sc-executor integration tests
      
      * Nits
      
      Co-authored-by: default avatarBastian Köcher <[email protected]>
      
      * Refactor apis section deserialization
      
      * Fix version decoding
      
      * Reuse uncompressed value for CallInWasm
      
      * Log on decompression error
      
      * Simplify if
      
      * Reexport proc-macro from sp_version
      
      * Merge ReadRuntimeVersionExt
      
      * Export `read_embedded_version`
      
      * Fix test
      
      * Simplify searching for custom section
      
      Co-authored-by: default avatarDavid <[email protected]>
      Co-authored-by: default avatarBastian Köcher <[email protected]>
      0849bcce
  36. May 04, 2021