Skip to content
Snippets Groups Projects
  1. Apr 01, 2020
    • Gavin Wood's avatar
      A few missing emojies (#5490) · b86c7e87
      Gavin Wood authored
      * A few missing emojies
      
      * P2p message emojis
      
      * Add a bit of colour
      
      * format
      
      * Introduce a couple of spaces
      
      * Some spaces
      b86c7e87
  2. Mar 27, 2020
  3. Mar 26, 2020
    • pscott's avatar
      TelemetryEndpoints must be valid MutliAddr URL (#5069) · 73c99eec
      pscott authored
      
      * Check for url validity when creating TelemetryEndpoints
      
      * Update code that used TelemetryEndpoints::new()
      
      * Update commennts that referred to TelemetryEndpoints::new()
      
      * Add tests for telemetry
      
      * Fix typo and fix code in docs
      
      * Return error on failing to override telemetry
      
      * Use expect instead of suppressing errors on must-be-valid telemetry endpoints
      
      * Update telemetry unit tests to use expect instead of unwrap
      
      * Implement custom deserializer for TelemetryEndpoints
      
      * Fix typo
      
      * Apply suggestions from code review
      
      Co-authored-by: default avatarBastian Köcher <bkchr@users.noreply.github.com>
      73c99eec
  4. Mar 21, 2020
  5. Mar 11, 2020
  6. Mar 05, 2020
    • Gavin Wood's avatar
      Remove substrate-ui.parity.io from CORS whitelist (#5142) · 26fc97f6
      Gavin Wood authored
      The only up-to-date deployment of PolkadotJS apps is currently on https://polkadot.js.org/apps/.
      https://substrate-ui.parity.io is only useful as deliberately kept outdated version of Apps, to be used for projects still on Substrate 1.0
      It cannot be used with the up-to-date chains running the Substrate 2.0 codebase, and probably won't be maintained much longer.
      26fc97f6
    • Gavin Wood's avatar
      Pass Prometheus `Registry` into `Client` (#5120) · 906e08ee
      Gavin Wood authored
      * Add a few metrics to Client
      
      * Improve PrometheusConfig
      
      * Fix client docs
      906e08ee
  7. Feb 21, 2020
    • Cecile Tonglet's avatar
      Add tests & Service's Configuration has optional fields that shouldn't be optional (#4842) · e8000e74
      Cecile Tonglet authored
      Related to #4776 
      Related to https://github.com/paritytech/polkadot/pull/832
      
      To summarize the changes:
      1. I did not manage to validate with types the service's Configuration. But I did reduce the possibility of errors by moving all the "fill" functions to their respective structopts
      2. I split params.rs to multiple modules: one module params for just CLI parameters and one module commands for CLI subcommands (and RunCmd). Every command and params are in their own file so things are grouped better together and easier to remove
      3. I removed the run and run_subcommand helpers as they are not helping much anymore. Running a command is always a set of 3 commands: 1. init 2. update config 3. run. This still allow the user to change the config before arguments get parsed or right after.
      4. I added tests for all subcommands.
      5. [deleted]
      
      Overall the aim is to improve the situation with the Configuration and the optional parameters, add tests, make the API more consistent and simpler.
      e8000e74