Skip to content
  1. Apr 04, 2023
  2. Apr 03, 2023
  3. Mar 31, 2023
    • Mattia L.V. Bradascio's avatar
      Consolidate subsystem spans so they are all children of the leaf-activated root span (#6458) · 713f6625
      Mattia L.V. Bradascio authored
      * Pass the PerLeafSpan as mutable reference to handle_new_head function
      
      * cargo +nightly fmt --all
      
      * Add mock span for test
      
      * cargo +nightly fmt --all
      
      * add new-blocks-hashes to span
      
      * ref span in match statement, set span to disabled if not passed
      
      * remove second match clause, make handle_new_head_span mutable
      
      * cargo +nightly fmt --all
      
      * improve tag on error and warning
      
      * add imported blocks and info span
      
      * cargo +nightly fmt --all
      
      * Improve error for imported_blocks_and_info trace
      
      * format tags on get_header_span
      
      * add lost-to-finality tag
      
      * add missing bracket
      
      * - Add bitfield child span
      - Add block db insertion span
      
      * - fix update-bitfield span tag
      
      * - Fix type conversion to u64
      - Add missing argument
      
      * - Cargo fmt
      
      * - Test add_follows_from
      
      * - Revert as  relationship between spans not working correctly
      
      * - use drop to test if parent-child relationship can be re-established
      
      * - remove bitfield span, check if parent-child relationship can be reestablished
      
      * - Remove dangling bitfield span which is not used, to see if parent-child relationship can be re-established
      
      * Another dangling bitfield span
      
      * cargo fmt
      
      * - add imported blocks and info span
      - add candidate span per candidate
      
      * add tags before moving block_header to push scope
      
      * - Add db-insertion span
      
      * cargo fmt
      
      * fix types
      
      * * Pass mutable reference to span in handle_new_head
      * Change get-header-span tags in handle_new_head
      * Create cache-session-info span in handle_new_head
      * Create optional argument in determine_new_blocks
      * Pass mutable reference to handle_new_head_span in determine_new_blocks in handle_new_head function
      * Add candidate-hash, candidate-number, lost-to-finality tags to candidate_span in handle_new_head function
      * Manually drop db_insertion_span and remove superfluous tags  to it, only keeping approved-bitfields tag
      * Add ApprovalVoting stage in jaeger
      
      * * Pass mutable reference to jaeger::Span in stead of PerLeafSpan
      * Add block-import span
      
      * *Pass optional_span (optional argument) to determine_new_blocks util function
      
      * * Add num-candidates int tag to block_import_span
      
      * * Add head tag to cache_session_span
      
      * * Create PerLeafSpan in handle_from_overseer (this is required to establish parent-child relationship between approval-voting span, and leaf-activated root span)
      
      * * Add candidate-import-span as child of block-import-span
      * Add candidate-hash and num-approval tags to candidate-import-span
      
      * * Fix num-candidate tag to bitvec-len tag in candidate-import-span
      
      * *Fix imported_blocKs_and_info span to create new-block-span as not dealing with candidates
      
      * Consider the future::select! block
      
      * Use HashMap<Hash, jaeger::PerLeafSpan>
      
      * Remove Stage 9
      
      * Add missing spans
      
      * cargo +nightly fmt --all
      
      * Remove optional span argument for determine_new_blocks
      
      * * Remove no-longer needed default PerLeafSpan implementation
      * Remove no-longer necessary mock span given re-factoring of handle_new_head() no longer neeing mutable span
      * Split validation-result and request-data (availability and validation code) spans into two by dropping request_validation_data_spans
      * Remove drop statements for cache_session_info_span
      *
      
      * Remove unnecessary span
      
      * Remove another excessively spammy span
      
      * Add missing spans from State in import tests
      
      * Use functional approach to get spans
      
      * - Add functional approach for the approval-voting span
      - Add doc on block_numbers given labelling ambiguity
      - Add span pruning logic
      - Use .add_para_id on validation_result_span
      
      * Replace for hash_set in hash_set_iter with map closure
      
      * cargo +nightly fmt --all
      
      * Change from unconsumed `map` to `.for_each`
      
      * cargo +nightly fmt --all
      
      * Refactor add_para_id to validation_result_span
      
      * cargo +nightly fmt --all
      
      * Remove duplicate tag
      
      * Add missing tag to handle-approved-ancestor span
      
      * Refactor span pruning to only invoke retain once
      
      * Typo in span name
      
      * - Replace unwrap_or with unwrap_or_else due to lazy evaluation of trace-identifier in polkadot_node_jaeger
      - Remove some redundant spans
      
      * Add approval-distribution spans
      
      * - Add unwrap_or_else on note-approved-in-chain-selection
      - Use child_with_trace_id to add traceID string tag on span (note this does not change the traceID, but just adds a tag)
      
      * cargo +nightly fmt --all
      
      * - Add traceID tags were necessary in approval-voting and availability-distribution
      - Always use block-hash tag in stead of relay-parent tag in approval-distribution
      
      * Remove schedule-wakeup span as it will duplicate spans on existing wakeups (which should be a no-op)
      
      * Remove a couple of warnings related to mutability
      
      * Fix failing tests in availability distribution
      
      * Add traceID tag to launch-approval and validation-result
      
      * Reshuffle the validation and validation result spans to where more appropriate and add block-hash tag
      
      * - Add tranche and should-trigger tag to process-wakeup span
      - Add candidate-hash and traceID to check-and-import-approval span
      
      * cargo fmt
      
      * - Adjustments after PR comments
      
      * Move span pruning after other pruning logic
      
      * Remove DerefMut - no longer needed
      
      * Relabel request-chunk spans
      
      * - Fix typo in span label
      - Add docs for drops
      
      * Add new approval-voting span pruning logic
      
      * Undo removal of !
      
      * cargo fmt
      713f6625
    • eskimor's avatar
      Avoid redundant clone. (#6989) · 9fe528d5
      eskimor authored
      
      
      Co-authored-by: default avatareskimor <[email protected]>
      9fe528d5
    • Javier Viola's avatar
      bump zombienet version (#6985) · d62d0b48
      Javier Viola authored
      d62d0b48
    • arminteimouri's avatar
      avoid triggering unwanted room_id for the release notifs (#6984) · b5a0bca1
      arminteimouri authored
      * avoid triggering unwanted room_id for the release notifs
      
      * fixing typo
      b5a0bca1
    • NingBo Wang's avatar
      Add crowdloan to SafeCallFilter (#6903) · 906094a2
      NingBo Wang authored
      * Add crowdloan to SafeCallFilter
      
      * Add crowdloan to SafeCallFilter
      906094a2
  4. Mar 30, 2023
  5. Mar 29, 2023
    • s0me0ne-unkn0wn's avatar
      Check spawned worker version vs node version before PVF preparation (#6861) · 55b4aceb
      s0me0ne-unkn0wn authored
      
      
      * Check spawned worker version vs node version before PVF preparation
      
      * Address discussions
      
      * Propagate errors and shutdown preparation and execution pipelines properly
      
      * Add logs; Fix execution worker checks
      
      * Revert "Propagate errors and shutdown preparation and execution pipelines properly"
      
      This reverts commit b96cc3160ff58db5ff001d8ca0bfea9bd4bdd0f2.
      
      * Don't try to shut down; report the condition and exit worker
      
      * Get rid of `VersionMismatch` preparation error
      
      * Merge master
      
      * Add docs; Fix tests
      
      * Update Cargo.lock
      
      * Kill again, but only the main node process
      
      * Move unsafe code to a common safe function
      
      * Fix libc dependency error on MacOS
      
      * pvf spawning: Add some logging, add a small integration test
      
      * Minor fixes
      
      * Restart CI
      
      ---------
      
      Co-authored-by: default avatarMarcin S <[email protected]>
      55b4aceb
    • Bastian Köcher's avatar
      Companion: wasm-builder support stable Rust (#6967) · 8b1645fa
      Bastian Köcher authored
      * Companion: wasm-builder support stable Rust
      
      * update lockfile for {"substrate"}
      
      ---------
      
      Co-authored-by: parity-processbot <>
      8b1645fa
    • Oliver Tale-Yazdi's avatar
      Fix feature (#6966) · faa2d5b0
      Oliver Tale-Yazdi authored
      
      
      Signed-off-by: default avatarOliver Tale-Yazdi <[email protected]>
      faa2d5b0
  6. Mar 28, 2023
    • Chris Sosnin's avatar
      configuration: backport async backing parameters from the feature branch (#6961) · 16e46614
      Chris Sosnin authored
      * Backport async backing params primitive
      
      * migration follow-up
      
      * link pr
      
      * parameters -> params
      
      * rustfmt::skip block ident
      16e46614
    • Tsvetomir Dimitrov's avatar
      Histogram support in runtime metrics (#6935) · 22f404f0
      Tsvetomir Dimitrov authored
      
      
      * Histogram support in runtime metrics
      
      Add support for histograms to the runtime metrics. Additionally add
      `polkadot_parachain_verify_dispute_signature` histogram which tracks the
      time needed from the runtime to verify a single validator signature of a
      dispute statement.
      
      * Add noops
      
      * u64 instead of f64
      
      * Update buckets
      
      * Wrap `get_current_time()` in runtime metrics
      
      * Change the dimension of the Histogram from usec to sec
      
      * Fix a compilation error
      
      * Update buckets
      
      * Fix `on_signature_check_complete` calculation
      
      * Update buckets
      
      * Update buckets
      
      * formatting
      
      * Another weights update
      
      * Adjust buckets again
      
      * Final buckets adjustment
      
      * Revert "Fix a compilation error"
      
      This reverts commit 06290b40a39eeb78de2602d8916a39edf7a8b714.
      
      * Update primitives/src/v4/metrics.rs
      
      Co-authored-by: default avatarAndrei Sandu <[email protected]>
      
      * Use `saturating_sub` for time difference calculation
      
      * Pass nanoseconds to client instead of seconds (using f64 in runtime is dangerous)
      
      ---------
      
      Co-authored-by: default avatarAndrei Sandu <[email protected]>
      22f404f0
  7. Mar 27, 2023
  8. Mar 24, 2023
  9. Mar 23, 2023
  10. Mar 22, 2023
  11. Mar 21, 2023
    • ordian's avatar
      4ed39979
    • Davide Galassi's avatar
      Companion for #13624 (#6924) · 6414284f
      Davide Galassi authored
      * Update lock
      
      * Trigger pipeline
      
      * update lockfile for {"substrate"}
      
      * Update ed25519 in the lockfile T_T
      
      ---------
      
      Co-authored-by: parity-processbot <>
      6414284f
    • ordian's avatar
      kusama: enable dispute slashes (#5974) · 3b493f02
      ordian authored
      
      
      * disputes: runtime part of slashing
      
      * disputes: reward winners
      
      * disputes/slashing: validate_unsigned impl
      
      * fmt
      
      * disputes/slashing: report_dispute_lost_unsigned
      
      * disputes/slashing: separate winners from losers and report winners
      
      * disputes/slashing: refactoring
      
      * impl HandleReports
      
      * enable on Wenstend
      
      * fmt
      
      * add slashing pallet to the mock and test runtimes
      
      * fix a bug in report_dispute_lost_unsigned
      
      * fmt
      
      * disputes: remove new_participants from summary
      
      * disputes: remove punish_inconclusive
      
      * impl SlashingHandler for Pallet for type-safety
      
      * do not impl slashing::Config on mainnets yet
      
      * teach spellcheck deduplication
      
      * simplify interfaces and resolve some TODOs
      
      * resolve some more TODOs
      
      * minor typos
      
      * move slashing into a folder
      
      * remove unnecessary clone
      
      * fix validator_set_count calculation
      
      * introduce ValidatorSetCount
      
      * store ValidatorSetCount
      
      * fmt
      
      * add the benchmark
      
      * fmt
      
      * unflatten slashing
      
      * post-rebase fixes
      
      * remove winners eagerly
      
      * use real slashing weights for westend
      
      * remove bench test suite
      
      * zombinet: modify disputes test to check for an offence report
      
      * zombinet: add a timeout
      
      * add slashing pallet to Rococo
      
      * zombienet: revert back to rococo-local
      
      * fmt
      
      * remove TODOs
      
      * revert some accidental changes
      
      * slashing is submodule of disputes
      
      * Change the log target
      
      Co-authored-by: default avatarKian Paimani <[email protected]>
      
      * wrap comments with rustfmt, more docs, constants
      
      * use Defensive trait
      
      * cargo update -p sp-io
      
      * merge offence types, remove rewards for now
      
      * cargo update -p sp-io
      
      * benchmark fixes
      
      * fmt
      
      * unused var
      
      * fix block_author impl
      
      * ressurect RewardValidators trait
      
      * remove outdated comment
      
      * more module docs
      
      * introduce BenchmarkingConfig
      
      * typo fix
      
      * teach spellcheck unapplied
      
      * use Weight::new()
      
      * fix mocking rewards
      
      * use RefTimeWeight
      
      * ".git/.scripts/bench-bot.sh" runtime westend-dev runtime_parachains::disputes::slashing
      
      * refactor maybe_identify_validators
      
      * no more ticket in disguise
      
      * remove outdated comments
      
      * lower against valid to 0.1%
      
      * bump zombienet version for debug
      
      * use from_perthousand
      
      * post-merge fixes
      
      * another day, another Weight changes
      
      * Revert "bump zombienet version for debug"
      
      This reverts commit 371ab2dfdfd6b4ca46320a6106339bcd4a3a0b12.
      
      * do not reward block authors
      
      * fix outdated comment
      
      * use Pays from frame_support::dispatch::Pays
      
      * kusama: enable dispute slashing
      
      * ".git/.scripts/bench-bot.sh" runtime kusama-dev runtime_parachains::disputes::slashing
      
      * post merge fixes
      
      * ".git/.scripts/commands/bench/bench.sh" runtime kusama-dev runtime_parachains::disputes::slashing
      
      * ".git/.scripts/commands/bench/bench.sh" runtime kusama runtime_parachains::disputes::slashing
      
      ---------
      
      Co-authored-by: default avatarKian Paimani <[email protected]>
      Co-authored-by: command-bot <>
      Co-authored-by: default avatarJavier Viola <[email protected]>
      Co-authored-by: default avatarJavier Viola <[email protected]>
      3b493f02
    • Gavin Wood's avatar
      Introduce OpenGov into Polkadot (#6701) · 7beeba5f
      Gavin Wood authored
      
      
      * OpenGov for Polkadot
      
      * Integrate OpenGov into XCM
      
      * Formatting
      
      * Missing files
      
      * Remove Gov1 from Kusama
      
      * Fixes
      
      * Update runtime/polkadot/src/governance/origins.rs
      
      Co-authored-by: default avatarAnkan <[email protected]>
      
      * Revert scheduler origin changes
      
      * Fixes
      
      * Docs
      
      * Remove todo
      
      * Docs
      
      * Move Fellowship to Collectives  (#6718)
      
      * FellowshipAdmin origin over xcm
      
      * accept Fellows origin from Collectives
      
      * remove Fellowship
      
      * remove unreachable arm
      
      * define benchmarks
      
      * correct comment for DOLLARS constant
      
      * Add OpenGov Calls to Proxy Definitions (#6729)
      
      * add opengov calls to proxy definitions
      
      * fix build
      
      * Update runtime/polkadot/src/governance/mod.rs
      
      Co-authored-by: default avatarjoe petrowski <[email protected]>
      
      * Update runtime/polkadot/src/governance/tracks.rs
      
      Co-authored-by: default avatarjoe petrowski <[email protected]>
      
      * Update runtime/polkadot/src/lib.rs
      
      Co-authored-by: default avatarjoe petrowski <[email protected]>
      
      * Update runtime/polkadot/src/governance/origins.rs
      
      Co-authored-by: default avatarjoe petrowski <[email protected]>
      
      * Update runtime/polkadot/src/governance/mod.rs
      
      Co-authored-by: default avatarjoe petrowski <[email protected]>
      
      * Update old.rs
      
      * Update old.rs
      
      * weights with new api
      
      * XCM tweaks for OpenGov (#6855)
      
      * pass xcm origin, allow unpaid form Collectives and Fellows, whitelist call
      
      * unpaid execution only for Fellows
      
      * Apply suggestions from code review
      
      Co-authored-by: default avatarjoe petrowski <[email protected]>
      
      * rename const namespace to system_parachains
      
      * remove prod_or_fast
      
      ---------
      
      Co-authored-by: default avatarjoe petrowski <[email protected]>
      
      * remove unused import
      
      ---------
      
      Co-authored-by: default avatarAnkan <[email protected]>
      Co-authored-by: parity-processbot <>
      Co-authored-by: default avatarMuharem Ismailov <[email protected]>
      Co-authored-by: default avatarjoe petrowski <[email protected]>
      7beeba5f
    • Chris Sosnin's avatar
      introduce new well known key (#6915) · 2e5da3cb
      Chris Sosnin authored
      2e5da3cb
    • Martin Pugh's avatar
      [CI] Add bootnode checking CI jobs (#6889) · 270540cf
      Martin Pugh authored
      * Add check_bootnode script and github action
      
      * fix mktemp for linux machines
      
      * Update check_bootnodes.sh
      
      show logs to see what's going wrong
      
      * fix ephemeral ports and fetch polkadot
      
      * fix check-bootnodes.yml
      
      * increase node spawn holdoff
      
      * disable fail-fast
      
      * refactor, separate out check_bootnodes and make it posix-compliant
      
      * add new job for detecting new bootnodes
      
      * fix check-bootnodes.yml
      
      * only check all bootnodes on release
      
      * Add test bad bootnode
      
      REVERT ME before merging PR. Should cause the test to fail, then
      when we remove it, we should succeed. Sadly doesn't account for a
      new successful bootnode, should ask if we have one we can use for
      testing.
      
      * fix paths
      
      * fix paths and git... hopefully
      
      * this better work...
      
      * fix
      
      * test
      
      * last test
      
      * Revert "Add test bad bootnode"
      
      This reverts commit 540dd9754a1f8e2d3fef33f7f5a033b8c2aa4dcb.
      
      * Update check_bootnodes.sh
      
      * optimisations
      
      Begin polling the RPC node right after spawning, allowing us to break
      early on detecting peers
      
      * increase holdoff to 5 seconds
      
      * dont delete chainspec til we kill the node
      
      * Update check-bootnodes.yml
      
      * Remove checking bootnodes on pushing of this branch
      
      ---------
      
      Co-authored-by: parity-processbot <>
      270540cf
    • Arkadiy Paronyan's avatar
      Bump parity-db (#6921) · 3264cb7b
      Arkadiy Paronyan authored
      3264cb7b
    • Bradley Olson's avatar
      Handling timers for repeat dispute participation requests (#6901) · b26cf3b7
      Bradley Olson authored
      * Added participation and queue sizes metrics
      
      * First draft of all metric code
      
      * Tests pass
      
      * Changed Metrics to field on participation + queues
      
      * fmt
      
      * Improving naming
      
      * Refactor, placing timer in ParticipationRequest
      
      * fmt
      
      * Final cleanup
      
      * Revert "Final cleanup"
      
      This reverts commit 02e5608df64b2e0f7810905e4508673b2037d351.
      
      * Changing metric names
      
      * Implementing Eq only for unit tests
      
      * fmt
      
      * Removing Clone trait from ParticipationRequest
      
      * fmt
      
      * Moved clone functionality to tests helper
      
      * fmt
      
      * Fixing dropped timers on repeat requests
      
      * Keep older best effort timers
      
      * Removing comment redundency and explaining better
      
      * Updating queue() to use single mem read
      
      * fmt
      b26cf3b7