Skip to content
  1. Jun 15, 2019
  2. Jun 14, 2019
    • Gavin Wood's avatar
      New sessions, kill consensus module (#2802) · bda86418
      Gavin Wood authored
      
      
      * Draft of new sessions
      
      * Reintroduce tuple impls
      
      * Move staking module to new session API
      
      * More work on staking and grandpa.
      
      * Use iterator to avoid cloning and tuple macro
      
      * Make runtime build again
      
      * Polish the OpaqueKeys devex
      
      * Move consensus logic into system & aura.
      
      * Fix up system module
      
      * Get build mostly going. Stuck at service.rs
      
      * Building again
      
      * Update srml/staking/src/lib.rs
      
      Co-Authored-By: default avatarDemiMarie-parity <[email protected]>
      
      * Refactoring out Consensus module, AuthorityIdOf, &c.
      
      * Refactored out DigestItem::AuthoritiesChanged. Building.
      
      * Remove tentative code
      
      * Remove invalid comment
      
      * Make Seal opaque and introduce nice methods for handling opaque items.
      
      * Start to use proper digest for Aura authorities tracking.
      
      * Fix up grandpa, remove system::Raw/Log
      
      * Refactor Grandpa to use new logging infrastructure.
      
      Also make authorityid/sessionkey static. Switch over to storing
      authorities in a straight Vec.
      
      * Building again
      
      * Tidy up some AuthorityIds
      
      * Expunge most of the rest of the AuthorityKey confusion.
      
      Also, de-generify Babe and re-generify Aura.
      
      * Remove cruft
      
      * Untangle last of the `AuthorityId`s.
      
      * Sort out finality_tracker
      
      * Refactor median getting
      
      * Apply suggestions from code review
      
      Co-Authored-By: default avatarRobert Habermeier <[email protected]>
      
      * Session tests works
      
      * Update core/sr-primitives/src/generic/digest.rs
      
      Co-Authored-By: default avatarDemiMarie-parity <[email protected]>
      
      * Session tests works
      
      * Fix for staking from @dvc94ch
      
      * log an error
      
      * fix test runtime build
      
      * Some test fixes
      
      * Staking mock update to new session api.
      
      * Fix build.
      
      * Move OpaqueKeys to primitives.
      
      * Use on_initialize instead of check_rotate_session.
      
      * Update tests to new staking api.
      
      * fixup mock
      
      * Fix bond_extra_and_withdraw_unbonded_works.
      
      * Fix bond_with_little_staked_value_bounded_by_slot_stake.
      
      * Fix bond_with_no_staked_value.
      
      * Fix change_controller_works.
      
      * Fix less_than_needed_candidates_works.
      
      * Fix multi_era_reward_should_work.
      
      * Fix nominating_and_rewards_should_work.
      
      * Fix nominators_also_get_slashed.
      
      * Fix phragmen_large_scale_test.
      
      * Fix phragmen_poc_works.
      
      * Fix phragmen_score_should_be_accurate_on_large_stakes.
      
      * Fix phragmen_should_not_overflow.
      
      * Fix reward_destination_works.
      
      * Fix rewards_should_work.
      
      * Fix sessions_and_eras_should_work.
      
      * Fix slot_stake_is_least_staked_validator.
      
      * Fix too_many_unbond_calls_should_not_work.
      
      * Fix wrong_vote_is_null.
      
      * Fix runtime.
      
      * Fix wasm runtime build.
      
      * Update Cargo.lock
      
      * Fix warnings.
      
      * Fix grandpa tests.
      
      * Fix test-runtime build.
      
      * Fix template node build.
      
      * Fix stuff.
      
      * Update Cargo.lock to fix CI
      
      * Re-add missing AuRa logs
      
      Runtimes are required to know about every digest they receive ― they
      panic otherwise.  This re-adds support for AuRa pre-runtime digests.
      
      * Update core/consensus/babe/src/digest.rs
      
      Co-Authored-By: default avatarDemiMarie-parity <[email protected]>
      
      * Kill log trait and all that jazz.
      
      * Refactor staking tests.
      
      * Fix ci runtime wasm check.
      
      * Line length 120.
      
      * Make tests build again
      
      * Remove trailing commas in function declarations
      
      The `extern_functions!` macro doesn’t like them, perhaps due to a bug in
      rustc.
      
      * Fix type error
      
      * Fix compilation errors
      
      * Fix a test
      
      * Another couple of fixes
      
      * Fix another test
      
      * More test fixes
      
      * Another test fix
      
      * Bump runtime.
      
      * Wrap long line
      
      * Fix build, remove redundant code.
      
      * Issue to track TODO
      
      * Leave the benchmark code alone.
      
      * Fix missing `std::time::{Instant, Duration}`
      
      * Indentation
      
      * Aura ConsensusLog as enum
      bda86418
  3. Jun 13, 2019
    • Gavin Wood's avatar
      Subkey supports 24-word phrases (#2827) · f4afdd2f
      Gavin Wood authored
      * Revamp crypto API and make seeds work better in subkey
      
      * Final tweaks
      
      * Update tests
      
      * line spacing
      
      * Avoid escapes in hex constants
      
      * Fix build
      
      * Another fix
      
      * More fixes
      
      * Minor nits
      f4afdd2f
  4. Jun 12, 2019
  5. Jun 11, 2019
  6. Jun 07, 2019
    • Kian Peymani's avatar
      Enhanced Council. (#2407) · d7ba5c00
      Kian Peymani authored
      * first --unclean-- working version of locks and weight decay
      
      * Refactor voter activity history.
      
      * Tuning offset calculation and tests
      
      * Remove print.
      
      * Configurable decay ratio.
      
      * Remove spaces.
      
      * Name for activity.
      
      * Fix some style
      
      * Re-write voters as chunked map-vec.
      
      * Adds panic todo.
      
      * Fix some of the grumbles.
      
      * Fix some of the grumbles.
      
      * Chunked approvals vector.
      
      * Introduce voter_index for set_approvas in favor of complexity.
      
      * Add a bit more docs
      
      * Add boolean approvals as scalar.
      
      * Some cleanups TODO removes.
      
      * enhance some error checking.
      
      * No more double_map
      
      * Combined voter info and fee.
      
      * Fix global tests
      
      * Bump.
      
      * Fix line length
      
      * Fix error message.
      
      * Kill As<T>.
      
      * Final fix.
      
      * _Further_ kill As.
      
      * Proper imbalance for fee.
      
      * Bump.
      
      * Fix spacing.
      
      * Update
      
      * Address grumbles.
      
      * Line width.
      d7ba5c00
  7. Jun 06, 2019
  8. Jun 05, 2019
    • Pierre Krieger's avatar
      Small slots refactor (#2780) · 67bdfc7d
      Pierre Krieger authored
      * Deprecate SlotWorker::on_start
      
      * start_slot_worker no longer needs an Arc
      
      * start_slot_worker now always succeeds
      
      * Removed on_exit parameter from start_*_worker
      
      * Minor doc
      
      * Fix node-template
      67bdfc7d
    • Benjamin Kampmann's avatar
      Move import lock onto backend (#2797) · eaa0ab01
      Benjamin Kampmann authored
      * Drop import_lock from client, move it into backend, impl default version via static mutex
      
      * still need to allow depcretion because of client.backend
      
      * additional docs
      
      * Remove default impl of get_import_lock, impl on instances
      
      * Bump parking_lot to 0.8.0 accross the board
      eaa0ab01
    • Gavin Wood's avatar
      Sensible scheduling for referenda (#2753) · 22a00a33
      Gavin Wood authored
      
      
      * Nonlinear locking and cleanups
      
      * Bump runtime version
      
      * Minor cleanup
      
      * Fix tests
      
      * Fix council tests
      
      * Fix flaw in turnout counting
      
      * Initial work on referendum schedules
      
      * Refactor council-democracy interface.
      
      * Fix build
      
      * Update srml/democracy/src/lib.rs
      
      Co-Authored-By: default avatarLuke Schoen <[email protected]>
      
      * Update srml/democracy/src/lib.rs
      
      Co-Authored-By: default avatarLuke Schoen <[email protected]>
      
      * Tests compile again
      
      * Tests!
      
      * Update todo
      
      * Fix build
      
      * Ensure votes arer not double-counted on member-transitions
      
      * Extra logic for normal council changes
      
      * Typo
      
      * A few grumbles addressed.
      22a00a33
    • Pierre Krieger's avatar
      Revert #2745 (#2791) · 89b312fe
      Pierre Krieger authored
      * Revert #2745
      
      * Fix error in merge resolve
      
      * Fix compilation
      89b312fe
    • Svyatoslav Nikolsky's avatar
      Restore integration tests (#2620) · 012ce587
      Svyatoslav Nikolsky authored
      * restored test_consensus
      
      * restored test_sync
      
      * run integration tests only on CI
      
      * use single test-thread for integration tests
      
      * post-merge fix
      
      * panic when integration test runs for too long
      
      * add some traces to integration logs
      
      * manual wait -> timeout
      
      * post-merge fix
      
      * post-merge fix
      012ce587
  9. Jun 04, 2019
    • Bastian Köcher's avatar
      Remove deprecated authorities function (#2785) · 4d9efbc1
      Bastian Köcher authored
      * Remove deprecated authorities function
      
      * Bump spec
      
      * Fixes compilation
      
      * Remove last piece
      4d9efbc1
    • Tomasz Drwięga's avatar
      JSON-RPC client generation (#2778) · 6112f815
      Tomasz Drwięga authored
      * Bump jsonrpc & generate clients.
      
      * Initial version of JSON-RPC client.
      
      * Re-wort
      
      * Remove spurious `#[derive(Encode, Decode)]`
      
      They did not compile, since `Encode` and `Decode` are deliberately not
      implemented for `usize`.
      
      Fixes #2742.
      
      * Re-write rpc-client example.
      
      * Update to jsonrpc=12.0.0
      
      * Remove unnecessary import
      
      * Bump version.
      
      * Revert version bump.
      
      * Bump again.
      6112f815
    • Pierre Krieger's avatar
      5df89a8a
    • DemiMarie-parity's avatar
      Add runtime support for `PreRuntime` and `Consensus` digests (#2757) · 53e8ad87
      DemiMarie-parity authored
      * Try to fix runtime panic
      
      Does not work
      
      * Fix trivial typo
      
      * Add runtime support for `PreRuntime` and `Consensus` digests
      
      Fixes c7d1204c
      
      
      
      * Fix silly compile error.
      
      * Fix overly-long lines
      
      Also remove some in-progress code that would not wind up being useful
      anyway.
      
      * Respond to review comments
      
      * delete `unset RUSTC_WRAPPER` from scripts/common.sh
      * delete unnecessary `use aura::AURA_ENGINE_ID` from
        `node/runtime/src/lib.rs`
      * add comments explaining why `PreRuntime` and `Consensus` must be
        special-cased in `core/sr-primitives/lib.rs`
      * switch to using `$crate::rstd::marker::PhantomData` in
        `impl_outer_log!`
      * improve documentation of `DigestItem::Seal`
      
      * Fix compilation and add proof that we do not panic
      
      Also fix some warnings.
      
      * Apply suggestions from code review
      
      Mostly for readability
      
      Co-Authored-By: default avatarSergei Pepyakin <[email protected]>
      
      * Apply suggestions from code review
      
      Co-Authored-By: default avatarBastian Köcher <[email protected]>
      
      * $crate::rstd::marker::PhantomData → Default::default()
      
      The import is still needed, as `Default::default()` can’t be used in
      patterns.
      
      * Bump `spec_version`
      
      Also do some reformatting.
      53e8ad87
    • Shawn Tabrizi's avatar
      Add support for tuples in `OnNewAccount` hook (#2765) · 6ce7c1c8
      Shawn Tabrizi authored
      
      
      * Add support for tuples in `OnNewAccount` hook
      
      * Bump impl version
      
      * Use `for_each_tuple` with `OnNewAccount` hook
      
      * Update `OnFreeBalanceZero` to also use `for_each_tuple`
      
      * Fix spelling/typo
      
      * Bump spec again
      
      * Update srml/support/src/traits.rs
      
      Co-Authored-By: default avatarBastian Köcher <[email protected]>
      
      * Update srml/system/src/lib.rs
      
      Co-Authored-By: default avatarBastian Köcher <[email protected]>
      6ce7c1c8
  10. Jun 03, 2019
  11. May 31, 2019
    • Tomasz Drwięga's avatar
      Offchain-worker APIs stubs (#2615) · 308ab4f2
      Tomasz Drwięga authored
      * WiP: HTTP Apis.
      
      * Working on the API.
      
      * Add docs, clean up the API.
      
      * Expose ext_ stuff as well.
      
      * Implement HTTP helpers for offchain sr-io.
      
      * Remove HTTP stuff.
      
      * Revert "Remove HTTP stuff."
      
      This reverts commit 7cca029d6ae93c5849b50edfcc6d2c313ba3e5bf.
      
      * HTTP apis.
      
      * Additional offchain methods.
      
      * Make it compile.
      
      * Implement wasm-ext boundary of offchain methods.
      
      * Add stubs for offchain stuff to prevent panics.
      
      * Fix tests.
      
      * Addres some more issues.
      
      * Introduce typedef, use unsafe from_utf8
      
      * Bump runtime version.
      
      * Introduce error to distinguish deadline and io errors.
      
      * Add local_storage_cas
      
      * Some tests for offchain stuff.
      
      * Address more grumbles.
      
      * Fix tests compilation.
      
      * Fix borked merge.
      
      * Improve docs for expected return values from ext functions.
      
      * Adding new sign/enrypt/decrypt APIs.
      308ab4f2
  12. May 29, 2019
    • DemiMarie-parity's avatar
      Update runtime dependencies (#2721) · 683fd5d3
      DemiMarie-parity authored
      683fd5d3
    • Tomasz Drwięga's avatar
      Remove InherentsPool and introduce non-propagateable transactions. (#2695) · 25b9c12c
      Tomasz Drwięga authored
      * Remove InherentsPool.
      
      * Introduce transactions that are not propagated over the network.
      
      * Bump spec version.
      
      * Use separate flag for propagation.
      
      * Fix tests.
      25b9c12c
    • Gavin Wood's avatar
      Maps are appendable too (#2716) · fccc5516
      Gavin Wood authored
      
      
      * Maps are appendable too
      
      * Update srml/support/src/storage/hashed/generator.rs
      
      Co-Authored-By: default avatarTomasz Drwięga <[email protected]>
      
      * Update srml/support/src/storage/mod.rs
      
      Co-Authored-By: default avatarTomasz Drwięga <[email protected]>
      
      * Fix docs
      
      * Make Appendable public
      
      * Bump runtime version
      fccc5516
    • Kian Peymani's avatar
      Limited Unbonding Chunks. (#2700) · 810d2712
      Kian Peymani authored
      * Limit number of unlocking chunks.
      
      * Bump.
      810d2712
    • thiolliere's avatar
      derive codec for inherent data (#2714) · 91a241ad
      thiolliere authored
      * derive codec for inherent data
      
      * increase spec version
      91a241ad
    • DemiMarie-parity's avatar
      Introduce inherent digests (#2466) · c7d1204c
      DemiMarie-parity authored
      
      
      * Introduce inherent digests
      
      * Implement inherent digests
      
      * fix silly error
      
      * Implementation of inherent digests in BABE
      
      All tests pass. There are still limitations:
      
      1. The runtime strips out inherent digests, so BABE must re-add them.
      2. The test runtime checks that it can re-compute all digests.  It
         can’t, so I had to comment out that test.
      
      * Fix compilation and seal import
      
      Seals were not imported correctly: the pre-digest was imported twice,
      instead of both it and the seal being imported.  Also, other parts of
      the code did not compile due to incomplete refactoring.
      
      * Remove bogus assertion
      
      * Fix testsuite compilation
      
      * Remove unused import
      
      * Fix compiler diagnostics
      
      * Add inherent digest parameters to block constructors
      
      This enforces that inherent digests are added first.
      
      * Fixup Cargo.lock
      
      * Fix build errors
      
      * Re-add an incorrectly removed import
      
      * Bump primitive-types version
      
      * Update Cargo.lock
      
      * Refactoring
      
      * Use inherent digests for AuRa
      
      They do reach the runtime, but get stripped.  I have not figured out
      where.
      
      * Fix compilation errors
      
      * Fix compilation errors due to incorrect types
      
      * Fix whitespace
      
      Suggested-by: default avatarTomasz Drwiega <[email protected]>
      
      * Add preamble
      
      Suggested-by: default avatarTomasz Drwiega <[email protected]>
      
      * Fix silly compile error
      
      * Refactor pre-digest finding code into a separate function
      
      * Remove unwanted assertion
      
      It is too likely to bring down the entire blockchain.
      
      Suggested-by: default avatarTomasz Drwiega <[email protected]>
      
      * Use `find_pre_digest` after runtime, too
      
      Also, use `Member` trait rather than rolling our own requirements.
      
      Suggested-by: default avatarTomasz Drwiega <[email protected]>
      
      * Fix various warnings
      
      mostly due to upgrading the dependency on `error_chain`.
      
      * Pre-digests nearly complete
      
      This nearly completes the implementation of pre-runtime digests.
      
      * `Seal2` → `Seal` and fix test suite
      
      * Try to fix the storage error
      
      * Try to fix storage (again)
      
      * Fix tests
      
      * Hopefully finish pre-runtime digests
      
      The key is to pass *only* the pre-runtime digests to the runtime.  The
      others must be stripped out by `initialize_block`.
      
      * Fix silly typo
      
      * Fix another silly mistake
      
      * Remove unnecessary filtering of BABE pre-digests
      
      We no longer get duplicate BABE pre-digests, so if they appear, the
      header should be rejected outright.
      
      * Update Cargo.lock files
      
      * Reformatting
      
      * Fix silly typo in inherent digest code
      
      Also, revert `error.rs` files that contained calls to the `error_chain!`
      macro.
      
      * Try to keep the runtime from stripping pre-digests
      
      Currently runs into the “Storage root must match that calculated”
      assertion.
      
      * Don’t compute storage root until storage changes are done.
      
      Also, fix a compilation error.
      
      * Fix compile-time error
      
      * Fix compilation errors
      
      * Fix more compile errors
      
      * Hopefully it compiles this time…
      
      * Fix compilation and add docs
      
      * Prevent BABE from adding duplicate pre-runtime digests
      
      Found by comparing with the AuRa code.  I also did some refactoring.
      
      * Respond to review and fix some warnings
      
      * Delete some dead code introduced earlier
      
      * More dead code goes away
      
      * `ref mut` → `&mut`
      
      * Respond to review and fix some warnings
      
      * Fix compilation error
      
      * Remove unneeded `HashT` type parameter
      
      Suggested-by: default avatarRobert Habermeier <[email protected]>
      
      * Remove spurious #[allow(deprecated)]
      
      * Document inherent digest parameter to `build_block`
      
      * Delete `Simple` trait
      
      It wasn’t needed
      
      * delete wrongly added files
      
      * Fix trait bounds
      
      * Digest serialization tests
      
      I also did some reformatting and cleanup.
      
      * Apply suggestions from code review
      
      Reformatting
      
      Co-Authored-By: default avatarAndré Silva <[email protected]>
      
      * Swap two arguments to `propose` and `propose_with`
      
      Also, remove some needless unsafe code.
      
      * Remove bogus `#![allow(deprecated)]` annotations
      
      With the removal of the deprecated `Seal` variant, these are not needed.
      
      * Add a missing `#[allow(deprecated)]` in the AuRa tests
      
      * Fix silly compile error
      
      * Fix silly compiler error
      
      RLS did not tell me that I hadn’t fixed `babe/lib.rs`, so I missed it.
      
      * Fixes made automatically by Cargo
      c7d1204c
  13. May 28, 2019
    • Michael Müller's avatar
      Transaction factory (#2481) · a706d994
      Michael Müller authored
      
      
      * Fix typos
      
      * Add transaction factory
      
      `cargo run -- purge-chain -y --chain dev && cargo run -- --dev --transaction-factory 10`
      
      * Fix comment and remove build deps
      
      * Move crate to test-utils
      
      * Switch from flag to subcommand
      
      `cargo run -- factory --dev --num 5`
      
      * Decouple factory from node specifics
      
      * Introduce different manufacturing modes
      
      * Remove unrelated changes
      
      * Update Cargo.lock
      
      * Use SelectChain to fetch best block
      
      * Improve expect proof
      
      * Panic if factory executed with unsupported chain spec
      
      * Link ToDo comments to follow-up ticket
      
      * Address comments and improve style
      
      * Remove unused dependencies
      
      * Fix indent level
      
      * Replace naked unwrap
      
      * Update node/cli/src/factory_impl.rs
      
      * Fix typo
      
      * Use inherent_extrinsics instead of timestamp
      
      * Generalize factory and remove saturated conversions
      
      * Format imports
      
      * Make it clearer that database needs to be empty
      
      * Ensure factory settings
      
      * Apply suggestions from code review
      
      Co-Authored-By: default avatarBastian Köcher <[email protected]>
      
      * Update test-utils/transaction-factory/src/lib.rs
      
      Co-Authored-By: default avatarBastian Köcher <[email protected]>
      
      * Fix match guard syntax
      
      * Simplify import, remove empty line
      
      * Update node/cli/Cargo.toml
      
      * Update lockfile
      a706d994
    • Svyatoslav Nikolsky's avatar
      Remove BlockNumber <-> u64 conversions from light-client related code (#2666) · 549d9e1d
      Svyatoslav Nikolsky authored
      
      
      * Remove As usage from CHT
      
      * Remove As usage from CHT (continue)
      
      * Restrict BN <-> int conversions in CT
      
      * more BN <-> u64 conversions removed
      
      * upd spec_version
      
      * Apply suggestions from code review
      
      Co-Authored-By: default avatarGavin Wood <[email protected]>
      
      * Apply suggestions from code review
      
      Co-Authored-By: default avatarGavin Wood <[email protected]>
      
      * more grumbles
      
      * fix last grumbles + compilation
      
      * too long lines
      
      * too long lines
      549d9e1d
    • Benjamin Kampmann's avatar
      Silence known deprecation warnings (#2651) · 22d30439
      Benjamin Kampmann authored
      * Silence known deprecation warnings
      
      1. Prefixes known instances of usages of client.backend and client.import_lock with `#[allow(deprecated)]` to silence the warnings. 2. Remove file-global `#![allow(deprecated)]` used in these cases. Both to prevent us overlooking externally caused deprecation messages.
      
      * fixing missing ;
      
      * fix missing test cases
      
      * move deprecated markers to make CI happy
      
      * move deprecated markers to make CI happy
      
      * attempt to fix the test
      
      * bumping impl_version of node runtime
      
      * Minor cleanup
      22d30439
  14. May 24, 2019
    • Tomasz Drwięga's avatar
      Expunge error-chain (feat. tomaka) (#2662) · c162fc5f
      Tomasz Drwięga authored
      * Remove error_chain
      
      * Expunge error-chain from rpc and service.
      
      * Expunge from transaction pool.
      
      * Expunge from node/cli
      
      * Expunge from keystore.
      
      * Remove some boilerplate.
      
      * Fix remaining stuff.
      
      * Improve on deprecation message.
      
      * Fix issues.
      
      * Fix trnsaction pool tests.
      
      * Fix the rest.
      
      * Fix borked merge.
      
      * Update lock
      c162fc5f
  15. May 23, 2019
  16. May 22, 2019
    • Gavin Wood's avatar
      Remove `As` (#2602) · 3860d7c8
      Gavin Wood authored
      
      
      * Start to remove the `As` bound on `SimpleArtithmetic`
      
      This just introduces standard numeric bounds, assuming a minimum of
      `u32`. Also included is a saturating from/into trait allowing ergonomic
      infallible conversion when you don't care if it saturates.
      
      * Remove As from Balances trait
      
      * Remove As from Aura module
      
      * Remove As from Babe module
      
      * Expunge `As` from contract
      
      * Council module
      
      * Democracy
      
      * Finality tracker
      
      * Grandpa
      
      * First bit of indices
      
      * indices
      
      * Line lengths
      
      * session
      
      * system
      
      * Staking
      
      * Square up all other uses of As.
      
      * RHD update
      
      * Fix build/test
      
      * Remove As trait
      
      * line widths
      
      * Remove final As ref
      
      * Update srml/staking/src/lib.rs
      
      Co-Authored-By: default avatarBastian Köcher <[email protected]>
      
      * Update core/client/src/cht.rs
      
      Co-Authored-By: default avatarBastian Köcher <[email protected]>
      
      * Update core/client/db/src/light.rs
      
      Co-Authored-By: default avatarBastian Köcher <[email protected]>
      
      * Apply suggestions from code review
      
      Co-Authored-By: default avatarBastian Köcher <[email protected]>
      
      * whitespace
      
      * Apply suggestions from code review
      
      Co-Authored-By: default avatarBastian Köcher <[email protected]>
      Co-Authored-By: default avatarAndré Silva <[email protected]>
      
      * Bring back u32 check for number on CLI
      3860d7c8