Skip to content
Snippets Groups Projects
  1. Oct 18, 2024
    • Giuseppe Re's avatar
      Adding migration instruction from benchmarking v1 to v2 (#6093) · a83f0fe8
      Giuseppe Re authored
      
      # Adding instruction to migrate benchmarking from v1 to v2
      
      Even if the documentation for benchmarking v1 and v2 is clear and
      detailed, I feel that adding a migration guide from v1 to v2 would help
      doing it quicker.
      
      ## Integration
      This change only affects documentation, so it does not cause integration
      issues.
      
      ## Review Notes
      I followed the migration procedure I applied in PR
      https://github.com/paritytech/polkadot-sdk/pull/6018 . I added
      everything from there, but I may be missing some extra steps that are
      needed in specific case, so in case you notice something please let me
      know.
      
      ---------
      
      Co-authored-by: default avatarDónal Murray <donal.murray@parity.io>
    • Egor_P's avatar
      [CI] Fix branch-off pipeline (#6120) · b48a6fa5
      Egor_P authored
      A tiny fix for the `Release - Branch off stable branch` pipeline, that
      adds an environment to be able to access secrets
    • Pavlo Khrystenko's avatar
      rpc v2: backpressure `chainhead_v1_follow` (#6058) · a0aefc6b
      Pavlo Khrystenko authored
      # Description
      
      closes #5871
      
      > The chainHead_v1_follow is using unbounded channels to send out
      messages on the JSON-RPC connection which may use lots of memory if the
      client is slow and can't really keep up with server i.e, substrate may
      keep lots of message in memory
      
      This PR changes the outgoing stream to abort and send a `Stop` event
      downstream in the case that client doesn't keep up with the producer.
      
      ## Integration
      
      *In depth notes about how this PR should be integrated by downstream
      projects. This part is mandatory, and should be
      reviewed by reviewers, if the PR does NOT have the `R0-Silent` label. In
      case of a `R0-Silent`, it can be ignored.*
      
      ## Review Notes
      
      - `rpc::Subscription::pipe_from_stream` - now takes `Self` param by
      reference, change was made to allow sending events to the `Subscription`
      after calls to `pipe_from_stream`.
      - `chainhead_follow::submit_events` - now uses `Abortable` stream to end
      it early in case
           - connection was clos...
    • Ermal Kaleci's avatar
      pallet-revive: EXTCODEHASH to match EIP-1052 (#6088) · 09155dbc
      Ermal Kaleci authored
      # Description
      Update `ext_code_hash` to match
      [EIP-1052](https://eips.ethereum.org/EIPS/eip-1052) specs. Since all
      possible results are written into output pointer then there's no need
      for a return value.
      
      https://github.com/paritytech/revive/pull/77
  2. Oct 17, 2024
    • Andrii's avatar
      Added Trusted Query API calls (#6039) · 7240b474
      Andrii authored
      
      Implemented is_trusted_reserve and is_trusted_teleporter API methods. 
      Tested them with regular and chopstick tests.
      Fixes #97
      
      ---------
      
      Co-authored-by: default avatarFrancisco Aguirre <franciscoaguirreperez@gmail.com>
    • Dónal Murray's avatar
      Fix generate-prdoc for single audiences (#6103) · d23a1bbd
      Dónal Murray authored
      
      `prdoc check -n NNNN` (used in CI) enforces that yaml lists only be used
      for lists with length more than one.
      
      Previously this script generated a list no matter how many audiences
      were provided, which generated a broken PRDoc when that number was 1.
      
      Reproducing the issue locally:
      ```
      python .github/scripts/generate-prdoc.py --pr 6022 --bump patch --audience runtime_user --force
      prdoc check -n 6022
      ```
      Fails on master but passes with this change
      
      Co-authored-by: default avatarBastian Köcher <git@kchr.de>
    • Egor_P's avatar
      [Release/CI] Adjust release pipelines to support new tags and delete rococo from release (#6108) · 1cc760b2
      Egor_P authored
      This PR introduces adjustments to the release pipelines so that it could
      be used with the new tags in the form of `poilakdot-stableYYMM(-rcX)` in
      addition to the old form of tags like `vX.XX.X`.
      
      Also, the rococo runtime and its parachains are deleted now from the
      build and release draft as it is decommissioned and not used any more
    • Joseph Zhao's avatar
    • Adrian Catangiu's avatar
      [AHs] Support registering assets on Asset Hubs over bridge (#5435) · 9714796b
      Adrian Catangiu authored
      ## Changes
      
      Allows one Asset Hub on one side, to register assets on the other Asset
      Hub over the bridge.
      
      Rococo <> Ethereum test bridge will be dropped in favor of Westend <>
      Ethereum test bridge. This PR also changes emulated tests to simulate
      double bridging from Ethereum<>Westend<>Rococo.
      
      ## Tests
      
      - [x] e2e test: Westend Asset Hub can register Westend and Ethereum
      assets on Asset Hub Rococo
      - [x] e2e test: Rococo Asset Hub can register Rococo assets on Asset Hub
      Westend
      - [x] e2e test (existing): Users on Ethereum can register Ethereum
      assets on Asset Hub Westend
      - [x] e2e test: transfer Rococo assets from Rococo to Westend and back
      - [x] e2e test: transfer Westend assets from Westend to Rococo and back
      - [x] e2e test: transfer Ethereum assets (bridged in through Snowbridge)
      from Westend to Rococo and back
    • drewstone's avatar
      Import vec to bridges/primitives/header-chain (#6031) · 31dfc9f6
      drewstone authored
      # Description
      
      I'm unable to build a bridge library due to the errors below, so I am
      adding the explicit import to `sp_std::vec`.
      
      ## Integration
      
      Projects using it can update their dependency. We are using the branch
      `stable2407` (mixed them up in my branch).
      
      ## Errors
      ```
      error: cannot find macro `vec` in this scope
        --> /Users/drew/.cargo/git/checkouts/polkadot-sdk-cff69157b985ed76/88c32501/bridges/primitives/header-chain/src/justification/verification/mod.rs:99:19
         |
      99 |         let mut route = vec![];
         |                         ^^^
         |
      help: consider importing one of these items
         |
      23 + use scale_info::prelude::vec;
         |
      23 + use sp_std::vec;
         |
      
      error: cannot find macro `vec` in this scope
         --> /Users/drew/.cargo/git/checkouts/polkadot-sdk-cff69157b985ed76/88c32501/bridges/primitives/header-chain/src/justification/verification/optimizer.rs:135:36
          |
      135 |         duplicate_votes_ancestries_idxs: vec![],
          |                       ...
  3. Oct 16, 2024
    • Javier Viola's avatar
      bump `zombienet` version and inc. memory request in k8s (#6091) · d5b96e9e
      Javier Viola authored
      
      Bump zombienet version, include updated baseline resources request.
      
      Thx!
      
      Co-authored-by: default avatarBastian Köcher <git@kchr.de>
    • Miles Patterson's avatar
      Fix for Issue 4762 (#4803) · 504edb1b
      Miles Patterson authored
      
      [Issue #4762 ](https://github.com/paritytech/polkadot-sdk/issues/4762)
      
      - Creates an enum for passing context of `service_queues` being called
      from within `on_initialize` and `on_idle` hooks. Uses a match statement
      inside of `service_queues` to continue using the same code, but NOT
      throw a `defensive` if being called within `on_idle` hook.
      - The issue requested to not throw the `defensive` if being called from
      within `on_idle` hook.
      - Created the `ServiceQueuesContext` enum to pass as an argument of
      `service_queues` when called within the `on_initialize` and `on_idle`
      hooks. A match statement was added inside of `service_queues` to
      continue to throw the defensive if called from `on_initialize` but NOT
      throw the defensive if called from `on_idle`.
      
      ---------
      
      Co-authored-by: default avatargotnoshoeson <milesbrentpatterson@proton.me>
      Co-authored-by: default avatarBastian Köcher <git@kchr.de>
      Co-authored-by: default avatarBastian Köcher <info@kchr.de>
    • Alexander Samusev's avatar
      [ci] Small updates (#6085) · 4cd7e865
      Alexander Samusev authored
      PR adds timeouts to some jobs, fixes `node-bench-regression-guard` so it
      works on master.
      
      cc https://github.com/paritytech/ci_cd/issues/1063
    • Cyrill Leutwiler's avatar
      [pallet-revive] ensure the return data is reset if no frame was instantiated (#6045) · 90c0a0ca
      Cyrill Leutwiler authored
      
      Failed call frames do not produce new return data but still reset it.
      
      ---------
      
      Signed-off-by: default avatarxermicus <cyrill@parity.io>
      Co-authored-by: default avatarGitHub Action <action@github.com>
    • dependabot[bot]'s avatar
      Bump platforms from 3.0.2 to 3.4.1 (#5865) · e6100597
      dependabot[bot] authored
      Bumps [platforms](https://github.com/rustsec/rustsec) from 3.0.2 to
      3.4.1.
      <details>
      <summary>Commits</summary>
      <ul>
      <li>See full diff in <a
      href="https://github.com/rustsec/rustsec/commits">compare view</a></li>
      </ul>
      </details>
      <br />
      
      
      [![Dependabot compatibility
      score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=platforms&package-manager=cargo&previous-version=3.0.2&new-version=3.4.1)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores)
      
      Dependabot will resolve any conflicts with this PR as long as you don't
      alter it yourself. You can also trigger a rebase manually by commenting
      `@dependabot rebase`.
      
      [//]: # (dependabot-automerge-start)
      [//]: # (dependabot-automerge-end)
      
      ---
      
      <details>
      <summary>Dependabot commands and options</summary>
      <br />
      
      You can trigger Dependabot actions by commenting on this PR:
      - `@dependabot rebase` will rebase this...
    • Alexandre R. Baldé's avatar
      Refactor staking pallet benchmarks to `v2` (#6025) · 9d78c51c
      Alexandre R. Baldé authored
      
      # Description
      This PR migrates the staking pallet's benchmarks to the `v2` of pallet
      benchmarking tooling provided by
      [`frame_benchmarking`](https://github.com/paritytech/polkadot-sdk/tree/master/substrate/frame/benchmarking).
      
      ## Integration
      
      N/A
      
      ## Review Notes
      
      The PR is straightforward, as were #1676 , #1838 and #1868.
      
      ---------
      
      Co-authored-by: default avatarDónal Murray <donal.murray@parity.io>
      Co-authored-by: default avatarShawn Tabrizi <shawntabrizi@gmail.com>
    • Alexandru Vasile's avatar
      Metadata V16 (unstable): Enrich metadata with associated types of config traits (#5274) · b649f4a4
      Alexandru Vasile authored
      
      This feature is part of the upcoming metadata V16. The associated types
      of the `Config` trait that require the `TypeInfo` or `Parameter` bounds
      are included in the metadata of the pallet. The metadata is not yet
      exposed to the end-user, however the metadata intermediate
      representation (IR) contains these types.
      
      Developers can opt out of metadata collection of the associated types by
      specifying `without_metadata` optional attribute to the
      `#[pallet::config]`.
      
      Furthermore, the `without_metadata` argument can be used in combination
      with the newly added `#[pallet::include_metadata]` attribute to
      selectively include only certain associated types in the metadata
      collection.
      
      ### API Design
      
      - There is nothing to collect from the associated types:
      
      ```rust
      #[pallet::config]
      pub trait Config: frame_system::Config {
      		// Runtime events already propagated to the metadata.
      		type RuntimeEvent: From<Event<Self>> + IsType<<Self as frame_system::Config>::RuntimeEvent>;
      
      		// Constants are already propagated.
      		#[pallet::constant]
      		type MyGetParam2: Get<u32>;
      	}
      ```
      
      - Default automatic collection of associated types that require TypeInfo
      or Parameter bounds:
      
      ```rust
      	#[pallet::config]
      	pub trait Config: frame_system::Config {
      		// Runtime events already propagated to the metadata.
      		type RuntimeEvent: From<Event<Self>> + IsType<<Self as frame_system::Config>::RuntimeEvent>;
      
      		// Constants are already propagated.
      		#[pallet::constant]
      		type MyGetParam2: Get<u32>;
      
      		// Associated type included by default, because it requires TypeInfo bound.
      		/// Nonce doc.
      		type Nonce: TypeInfo;
      
      		// Associated type included by default, because it requires
      		// Parameter bound (indirect TypeInfo).
      		type AccountData: Parameter;
      
      		// Associated type without metadata bounds, not included.
      		type NotIncluded: From<u8>;
      	}
      ```
      
      - Disable automatic collection
      
      ```rust
      // Associated types are not collected by default.
      	#[pallet::config(without_metadata)]
      	pub trait Config: frame_system::Config {
      		// Runtime events already propagated to the metadata.
      		type RuntimeEvent: From<Event<Self>> + IsType<<Self as frame_system::Config>::RuntimeEvent>;
      
      		// Constants are already propagated.
      		#[pallet::constant]
      		type MyGetParam2: Get<u32>;
      
      		// Explicitly include associated types.
      		#[pallet::include_metadata]
      		type Nonce: TypeInfo;
      
      		type AccountData: Parameter;
      
      		type NotIncluded: From<u8>;
      	}
      ```
      
      Builds on top of the PoC:
      https://github.com/paritytech/polkadot-sdk/pull/4358
      Closes: https://github.com/paritytech/polkadot-sdk/issues/4519
      
      cc @paritytech/subxt-team
      
      ---------
      
      Signed-off-by: default avatarAlexandru Vasile <alexandru.vasile@parity.io>
      Co-authored-by: default avatarBastian Köcher <git@kchr.de>
      Co-authored-by: default avatarGuillaume Thiolliere <gui.thiolliere@gmail.com>
      Co-authored-by: default avatarShawn Tabrizi <shawntabrizi@gmail.com>
    • Sebastian Kunert's avatar
      Stabilize elastic-pov-recovery zombienet test (#6076) · 2c41656c
      Sebastian Kunert authored
      We should start the `recovery-target` node first, then the
      `collator-elastic` node. Also increases the resources available to these
      pods.
    • Alexandru Vasile's avatar
      litep2p/discovery: Fix memory leak in `litep2p.public_addresses()` (#5998) · 38aa4b75
      Alexandru Vasile authored
      This PR ensures that the `litep2p.public_addresses()` never grows
      indefinitely.
      - effectively fixes subtle memory leaks
      - fixes authority DHT records being dropped due to size limits being
      exceeded
      - provides a healthier subset of public addresses to the `/identify`
      protocol
      
      This PR adds a new `ExternalAddressExpired` event to the
      litep2p/discovery process.
      
      Substrate uses an LRU `address_confirmations` bounded to 32 address
      entries.
      The oldest entry is propagated via the `ExternalAddressExpired` event
      when a new address is added to the list (if capacity is exceeded).
      
      The expired address is then removed from the
      `litep2p.public_addresses()`, effectively limiting its size to 32
      entries (the size of `address_confirmations` LRU).
      
      cc @paritytech/networking @alexggh
      
      
      
      ---------
      
      Signed-off-by: default avatarAlexandru Vasile <alexandru.vasile@parity.io>
      Co-authored-by: default avatarBastian Köcher <git@kchr.de>
      Co-authored-by: default avatarDmitry Markin <dmitry@markin.tech>
    • Michał Gil's avatar
      remove pallet::getter from pallet-offences (#6027) · fbd69a3b
      Michał Gil authored
      
      # Description
      Part of https://github.com/paritytech/polkadot-sdk/issues/3326
      Removes pallet::getter from pallet-offences from type `Reports`.
      Adds a test to verify that retrieval of `Reports` still works with
      storage::getter.
      
      polkadot address: 155YyFVoMnv9BY6qxy2i5wxtveUw7WE1n5H81fL8PZKTA1Sd
      
      ---------
      
      Co-authored-by: default avatarShawn Tabrizi <shawntabrizi@gmail.com>
      Co-authored-by: default avatarDónal Murray <donal.murray@parity.io>
  4. Oct 15, 2024
    • Radek Bochenek's avatar
      Fix `solochain-template-runtime` freezes config (#5846) · 5a8e082b
      Radek Bochenek authored
      
      # Description
      
      Sets the correct `RuntimeFreezeReason` type for
      `solochain-template-runtime` configuration of pallet_balances.
      
      ## Review Notes
      
      For whatever reason `RuntimeFreezeReason` is currently set to
      `RuntimeHoldReason`. This in turn causes problems with variant counting
      in `MaxFreezes` and results in pallet_balances integrity tests failing
      whenever hold/freeze reasons are added to the runtime.
      This fixes it by simply setting `RuntimeFreezeReason` to
      `RuntimeFreezeReason` in pallet_balances Config.
      
      Co-authored-by: default avatarBastian Köcher <git@kchr.de>
    • dependabot[bot]'s avatar
      Bump tokio-test from 0.4.3 to 0.4.4 (#5944) · f754863a
      dependabot[bot] authored
      
      Bumps [tokio-test](https://github.com/tokio-rs/tokio) from 0.4.3 to
      0.4.4.
      <details>
      <summary>Commits</summary>
      <ul>
      <li><a
      href="https://github.com/tokio-rs/tokio/commit/3d0d0fd2af9192ca5cf2836451e96dffab68216a"><code>3d0d0fd</code></a>
      chore: prepare tokio-test v0.4.4 (<a
      href="https://redirect.github.com/tokio-rs/tokio/issues/6400">#6400</a>)</li>
      <li><a
      href="https://github.com/tokio-rs/tokio/commit/7cfb1007969e3fcb28b03854f3126caeca93932e"><code>7cfb100</code></a>
      chore: prepare tokio-stream v0.1.15 (<a
      href="https://redirect.github.com/tokio-rs/tokio/issues/6401">#6401</a>)</li>
      <li><a
      href="https://github.com/tokio-rs/tokio/commit/e37bd6385430620f850a644d58945ace541afb6e"><code>e37bd63</code></a>
      io: implement <code>try_new</code> and <code>try_with_interest</code>
      for <code>AsyncFd</code> (<a
      href="https://redirect.github.com/tokio-rs/tokio/issues/6345">#6345</a>)</li>
      <li><a
      href="https://github.com/tokio-rs/tokio/commit/c9e75785c84a441199992ed38e49aeba2f061a24"><code>c9e7578</code></a>
      sync: remove <code>'static</code> bound on <code>impl Sink for
      PollSender</code> (<a
      href="https://redirect.github.com/tokio-rs/tokio/issues/6397">#6397</a>)</li>
      <li><a
      href="https://github.com/tokio-rs/tokio/commit/3141ed62287043b5400e24ac930b002dc7d11d92"><code>3141ed6</code></a>
      sync: update watch channel docs (<a
      href="https://redirect.github.com/tokio-rs/tokio/issues/6395">#6395</a>)</li>
      <li><a
      href="https://github.com/tokio-rs/tokio/commit/ea1cfbdb97f524a1ae465c0f5454dd6690dd5e6e"><code>ea1cfbd</code></a>
      sync: reorder const_new before new_with (<a
      href="https://redirect.github.com/tokio-rs/tokio/issues/6392">#6392</a>)</li>
      <li><a
      href="https://github.com/tokio-rs/tokio/commit/fb2dc97468fead3c1d318f209a65648e11ade55d"><code>fb2dc97</code></a>
      readme: update commit message guidelines (<a
      href="https://redirect.github.com/tokio-rs/tokio/issues/6393">#6393</a>)</li>
      <li><a
      href="https://github.com/tokio-rs/tokio/commit/a3d2548789d22d4bf193a4614f229944270e912c"><code>a3d2548</code></a>
      sync: implement <code>Clone</code> for <code>watch::Sender</code> (<a
      href="https://redirect.github.com/tokio-rs/tokio/issues/6388">#6388</a>)</li>
      <li><a
      href="https://github.com/tokio-rs/tokio/commit/b4ab6472de9a0708873c5f14f3b8de03b149a1c5"><code>b4ab647</code></a>
      signal: fix typo in argument name (<a
      href="https://redirect.github.com/tokio-rs/tokio/issues/6389">#6389</a>)</li>
      <li><a
      href="https://github.com/tokio-rs/tokio/commit/3133af42e123b9469dad292ae3a090da915d23c5"><code>3133af4</code></a>
      runtime: make the <code>enter</code> example deterministic (<a
      href="https://redirect.github.com/tokio-rs/tokio/issues/6351">#6351</a>)</li>
      <li>Additional commits viewable in <a
      href="https://github.com/tokio-rs/tokio/compare/tokio-test-0.4.3...tokio-test-0.4.4">compare
      view</a></li>
      </ul>
      </details>
      <br />
      
      
      [![Dependabot compatibility
      score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=tokio-test&package-manager=cargo&previous-version=0.4.3&new-version=0.4.4)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores)
      
      Dependabot will resolve any conflicts with this PR as long as you don't
      alter it yourself. You can also trigger a rebase manually by commenting
      `@dependabot rebase`.
      
      [//]: # (dependabot-automerge-start)
      [//]: # (dependabot-automerge-end)
      
      ---
      
      <details>
      <summary>Dependabot commands and options</summary>
      <br />
      
      You can trigger Dependabot actions by commenting on this PR:
      - `@dependabot rebase` will rebase this PR
      - `@dependabot recreate` will recreate this PR, overwriting any edits
      that have been made to it
      - `@dependabot merge` will merge this PR after your CI passes on it
      - `@dependabot squash and merge` will squash and merge this PR after
      your CI passes on it
      - `@dependabot cancel merge` will cancel a previously requested merge
      and block automerging
      - `@dependabot reopen` will reopen this PR if it is closed
      - `@dependabot close` will close this PR and stop Dependabot recreating
      it. You can achieve the same result by closing it manually
      - `@dependabot show <dependency name> ignore conditions` will show all
      of the ignore conditions of the specified dependency
      - `@dependabot ignore this major version` will close this PR and stop
      Dependabot creating any more for this major version (unless you reopen
      the PR or upgrade to it yourself)
      - `@dependabot ignore this minor version` will close this PR and stop
      Dependabot creating any more for this minor version (unless you reopen
      the PR or upgrade to it yourself)
      - `@dependabot ignore this dependency` will close this PR and stop
      Dependabot creating any more for this dependency (unless you reopen the
      PR or upgrade to it yourself)
      
      
      </details>
      
      Signed-off-by: default avatardependabot[bot] <support@github.com>
      Co-authored-by: default avatardependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
      Co-authored-by: default avatarBastian Köcher <git@kchr.de>
      Co-authored-by: default avatarSebastian Kunert <skunert49@gmail.com>
    • Alexander Samusev's avatar
      [ci] Move build and publish rustdocs to GHA (#6047) · 4edb2198
      Alexander Samusev authored
      PR moves jobs `build-rustdoc`, `test-doc` and `publish-rustdoc` to GHA.
      `publish-rustdoc` was changed so it can publish changes using token from
      GH APP.
      PR removes `test-rustdoc` because the same command in executed in
      `build-rustdoc` and I see no reason to run it twice.
      
      cc https://github.com/paritytech/ci_cd/issues/1006
    • Michal Kucharczyk's avatar
      fork-aware transaction pool added (#4639) · 26c11fc5
      Michal Kucharczyk authored
      ### Fork-Aware Transaction Pool Implementation
      
      This PR introduces a fork-aware transaction pool (fatxpool) enhancing
      transaction management by maintaining the valid state of txpool for
      different forks.
      
      ### High-level overview
      The high level overview was added to
      [`sc_transaction_pool::fork_aware_txpool`](https://github.com/paritytech/polkadot-sdk/blob/3ad0a1b7/substrate/client/transaction-pool/src/fork_aware_txpool/mod.rs#L21)
      module. Use:
      ```
      cargo  doc --document-private-items -p sc-transaction-pool --open
      ```
      to build the doc. It should give a good overview and nice entry point
      into the new pool's mechanics.
      
      <details>
        <summary>Quick overview (documentation excerpt)</summary>
      
      #### View
      For every fork, a view is created. The view is a persisted state of the
      transaction pool computed and updated at the tip of the fork. The view
      is built around the existing `ValidatedPool` structure.
      
      A view is created on every new best block n...
    • Javier Viola's avatar
      Bump zombienet version `v1.3.115` (#6065) · 183b55aa
      Javier Viola authored
      
      Includes:
      - Fixes for `ci`
      - Support to pass a json as arg for `js-script`
      
      Co-authored-by: default avatarBastian Köcher <git@kchr.de>
    • Francisco Aguirre's avatar
      Add assets in pool with native to query_acceptable_payment_assets's return (#5599) · d2ba5677
      Francisco Aguirre authored
      
      `XcmPaymentApi::query_acceptable_payment_assets` is an API that returns
      the assets that can be used to pay fees on the runtime where it's
      called.
      For relays and most system chains this was configured only as the native
      asset: ROC and WND.
      However, the asset hubs have the asset conversion pallet, which allows
      fees to be paid in any asset in a pool with the native one.
      This PR adds the list of assets in a pool with the native one to the
      return value of this API for the asset hubs.
      
      ---------
      
      Co-authored-by: default avatarBranislav Kontur <bkontur@gmail.com>
    • Ayevbeosa Iyamu's avatar
      pallet-xcm: added useful error logs (#2408) (#4982) · b20be7c1
      Ayevbeosa Iyamu authored
      
      Added error logs in pallet-xcm to help in debugging, fixes #2408 
      
      ## TODO
      
      - [x] change `log::error` to `tracing::error` format for `xcm-executor`
      - [x] check existing logs, e.g. this one can be extended with more info
      `tracing::error!(target: "xcm::reanchor", ?error, "Failed reanchoring
      with error");`
      - [x] use `tracing` instead of `log` for `pallet-xcm/src/lib.rs`
      
      ---------
      
      Co-authored-by: default avatarAyevbeosa Iyamu <aiyamu@vatebra.com>
      Co-authored-by: default avatarAdrian Catangiu <adrian@parity.io>
      Co-authored-by: default avatarFrancisco Aguirre <franciscoaguirreperez@gmail.com>
      Co-authored-by: default avatarBranislav Kontur <bkontur@gmail.com>
      Co-authored-by: default avatarBastian Köcher <git@kchr.de>
    • Bastian Köcher's avatar
      Remove "Check Features" test · 36eadec1
      Bastian Köcher authored
      This is done by zepter any way
    • Branislav Kontur's avatar
      Remove `check-migrations` for rococo chain (#6061) · f7119e40
      Branislav Kontur authored
      This PR removes the `check-migrations` pipelines for all Rococo chains
      because they are going down:
      https://github.com/paritytech/devops/issues/3589, and these checks are
      starting to fail, e.g.:
      
      https://github.com/paritytech/polkadot-sdk/actions/runs/11339904745/job/31535485254?pr=4982
      
      https://github.com/paritytech/polkadot-sdk/actions/runs/11339904745/job/31535486189?pr=4982
      
      https://github.com/paritytech/polkadot-sdk/actions/runs/11339904745/job/31535486471?pr=4982
      
      Additionally, `coretime-westend` was added to the `check-migrations`
      matrix.
  5. Oct 14, 2024
    • Julian Eager's avatar
      Fix `feeless_if` in pallet section (#6032) · 6f03f7a1
      Julian Eager authored
      fixes #5981 
      
      Could confirm the issue with the added tests:
      
      ```
      test tests/split_ui/pass/split_call.rs [should pass] ... error
      ┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈
      error[E0423]: expected value, found attribute macro `origin`
        --> tests/split_ui/pass/split_call.rs:23:1
         |
      23 | #[frame_support::pallet(dev_mode)]
         | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ not a value
         |
         = note: this error originates in the attribute macro `frame_support::pallet` (in Nightly builds, run with -Z macro-backtrace for more info)
      ```
      
      # Description
      
      `origin` unexpectedly resolved to a macro, which is available at the
      span of invocation. The solution here is to use the expansion as a
      function instead of a call and pass in the desired values to avoid
      ambiguities.
    • Oliver Tale-Yazdi's avatar
      Westend: Constant yearly emission (#5999) · aca11dcc
      Oliver Tale-Yazdi authored
      
      Testing the approach of this before it goes live on Polkadot
      https://github.com/polkadot-fellows/runtimes/pull/471
      
      ---------
      
      Signed-off-by: default avatarOliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
      Co-authored-by: default avatarDónal Murray <donal.murray@parity.io>
    • Serban Iorga's avatar
      Use the umbrella crate for the parachain template (#5991) · d7f01a17
      Serban Iorga authored
      Use the umbrella crate for the parachain template
      
      This covers almost all the dependencies. There are just a few exceptions
      for which I created a separate issue:
      https://github.com/paritytech/polkadot-sdk/issues/5993
      
      Also related to: https://github.com/paritytech/polkadot-sdk/issues/4782
    • Maksym H's avatar
      update cmd timeout (#6038) · ff87db8c
      Maksym H authored
      30 hrs -> 72 hours
      as it has stopped by timeout here
      https://github.com/paritytech/polkadot-sdk/actions/runs/11299872333/job/31431758932
  6. Oct 12, 2024
    • Julian Eager's avatar
      Fix storage expansion in pallet section (#6023) · d1c115b6
      Julian Eager authored
      fixes #5320 @sam0x17 @gupnik 
      
      # Description
      
      The issue could be confirmed with the added example. The cause is for
      macro hygiene, `entries` in the `#( #entries_builder )*` expansion won't
      be able to reference the `entries` defined outside. The solution here is
      to allow the reference to be passed into the expansion with closure.
      
      Or we could just switch to the unhygienic span with `quote::quote!`
      instead such that `entries` will resolve to the "outer" definition.
  7. Oct 11, 2024
    • Maksym H's avatar
      /cmd: Improved devx of benching many pallets simultaneously (#6007) · c0b73433
      Maksym H authored
      
      ### Improved devx of running many pallets simultaneously
      
      Changes to /cmd:
      - Replace (flip) `--continue-on-fail` with `--fail-fast`, but only for
      `bench`. This makes all pallets/runtimes run non-stop by default, as it
      was primary use-case during tests
      - The list of successful/failed pallets was hard to find within tons of
      logs, so decided to write only needed logs in a file, and output as a
      summary in the workflow and in the comment
      - Side fix: updated `tasks_example` to `pallet_example_tasks` to make
      compliant with standard naming
      
      <img width="1006" alt="image"
      src="https://github.com/user-attachments/assets/14896041-7018-4a0d-92b7-4508e81913c2">
      
      + added command results to workflow summary:
      <img width="1275" alt="image"
      src="https://github.com/user-attachments/assets/b4a8afdb-dc9f-4ff9-9720-28a88956035f">
      
      ---------
      
      Co-authored-by: default avatarGitHub Action <action@github.com>
    • Michal Kucharczyk's avatar
      `substrate-node`: removed excessive polkadot-sdk features (#5925) · b45f89c5
      Michal Kucharczyk authored
      Some of the features enabled for `polkadot-sdk` umbrella crate were not
      necessary for substrate node (e.g. all `cumulus-*` or `polkadot-*`
      features) resulting in much longer compilation time. This PR fixes that.
    • Andrei Eres's avatar
      Rename QueueEvent::StartWork (#6015) · e5ccc008
      Andrei Eres authored
      # Description
      
      When we send `QueueEvent::StartWork`, we have already completed the
      execution. This may be a leftover of a previous logic change. Currently,
      the name is misleading, so it would be better to rename it to
      `FinishWork`.
      
      
      https://github.com/paritytech/polkadot-sdk/blob/c52675ef/polkadot/node/core/pvf/src/execute/queue.rs#L632-L646
      
      
      https://github.com/paritytech/polkadot-sdk/blob/c52675ef
      
      /polkadot/node/core/pvf/src/execute/queue.rs#L361-L363
      
      Fixes https://github.com/paritytech/polkadot-sdk/issues/5910
      
      ## Integration
      
      Shouldn't affect downstream projects.
      
      ---------
      
      Co-authored-by: default avatarGitHub Action <action@github.com>
    • Alexander Samusev's avatar
      [ci] Remove quick-benchmarks-omni from GitLab (#6014) · c16ac925
      Alexander Samusev authored
      The `quick-benchmarks-omni` job was moved to GHA (can be found
      [here](https://github.com/paritytech/polkadot-sdk/blob/439b31ef/.github/workflows/check-frame-omni-bencher.yml#L22))
      but hasn't been removed from GitLab . PR fixes it and makes the check
      required.
  8. Oct 10, 2024