Skip to content
Snippets Groups Projects
  1. May 06, 2020
    • Igor Matuszewski's avatar
      client: Replace `unsafe_rpc_expose` with an `RpcMethods` enum (#5729) · 9acf88f5
      Igor Matuszewski authored
      
      * client: Replace `unsafe_rpc_expose` with an `RpcMethods` enum
      
      which can be either Default, Safe or Unsafe. The idea is to have the
      following:
      |                       | --rpc-external=false  | --rpc-external=true   |
      |---------------------  |-------------------    |-----------------      |
      | --rpc-methods=Default |                       | unsafe calls denied   |
      | --rpc-methods=Safe    | unsafe calls denied   | unsafe calls denied   |
      | --rpc-methods=Unsafe  |                       |                       |
      Since the previous `unsafe-rpc-expose` option was confusing.
      
      * client: Only warn against exposing externally unsafe RPC method set
      
      * Apply suggestions from code review
      
      Co-Authored-By: default avatarCecile Tonglet <cecile.tonglet@cecton.com>
      
      * cli: Rephrase doc comment for rpc_methods config
      
      * Improve debuggability of build_spec_works
      
      ...by printing to stderr the stderr of the command. This is normally
      suppressed for succesful tests but not for failing ones - if that's the
      case then it's useful to see the test failure reason inline rather than
      having to execute the command separately ourselves.
      
      * Rename RpcMethods::{Default => Auto} variant
      
      * Update bin/node/cli/tests/build_spec_works.rs
      
      Co-authored-by: default avatarBenjamin Kampmann <ben.kampmann@googlemail.com>
      Co-authored-by: default avatarCecile Tonglet <cecile.tonglet@cecton.com>
      Co-authored-by: default avatarBastian Köcher <bkchr@users.noreply.github.com>
      9acf88f5
    • Max Inden's avatar
      client/authority-discovery: Do not double encode signature (#5901) · d40bf3cf
      Max Inden authored
      Previously, when publishing ones address onto the DHT, the signature
      signing those addresses would be SCALE encoded twice.
      
      This commit removes the second encoding and adjusts the tests
      to catch future regressions.
      d40bf3cf
  2. May 05, 2020
  3. May 04, 2020
  4. May 03, 2020
  5. May 01, 2020
  6. Apr 30, 2020