Skip to content
  1. Jul 24, 2023
    • Gonçalo Pestana's avatar
      Removes incorrect try-state check in staking (#14186) · 9ac344e6
      Gonçalo Pestana authored 
      Co-authored-by: parity-processbot <>
      9ac344e6
    • Michal Kucharczyk's avatar
      `test-runtime`: `GenesisBuilder` runtime API impl + tests (#14310) · 53cbda1d
      Michal Kucharczyk authored 
      

* test-runtime: GenesisBuilder runtime API impl + tests

This PR provides implementation of `GenesisBuilder` API for `substrate-test-runtime`, can be considered as reference imiplementation for other runtimes.
The `GenesisBuilder` implementation is gated by `gensis-config` feature.

Tested scenarios:
- default `GenesisConfig` to JSON blob,
- deserialization of `GenesisConfig` from custom JSON, and storing its keys into the Storage (genesis storage creation).
- creation of genesis storage using partial JSON definition,
- checking if invalid/renamed JSON files causes the runtime to panic,

* missing file added

* client: GenesisBuilder helper added

* feature renamed: genesis-config -> genesis-builder

* Update Cargo.toml

* Update Cargo.toml

* Update Cargo.toml

* Update Cargo.toml

* redundant function removed

* genesis builder helper: introduced RuntimeGenesisBuild

* test-runtime: get rid of unused T

* redundant bound removed

* helper: use GenesisBuild again

* tests adjusted for on_genesis

* test-runtime: support for BuildGenesisConfig

* helper: BuildGenesisConfig support

* Update client/genesis-builder/src/lib.rs

Co-authored-by: default avatarDavide Galassi <[email protected]>

* Update test-utils/runtime/src/test_json/readme.md

Co-authored-by: default avatarDavide Galassi <[email protected]>

* Update test-utils/runtime/src/test_json/readme.md

Co-authored-by: default avatarDavide Galassi <[email protected]>

* Update test-utils/runtime/src/genesismap.rs

Co-authored-by: default avatarDavide Galassi <[email protected]>

* jsons are now human-friendly

* fix

* improvements

* jsons fixed

* helper: no_defaults added

* test-runtime: no_defaults added

* test-runtime: patching fn removed

* helper: patching fn removed

* helper: moved to frame_support

* test-runtime: fixes

* Cargo.lock updated

* fmt + naming

* test-runtime: WasmExecutor used

* helper / test-runtime: struct removed

* test-runtime: merge fixes

* Cargo.lock + test-utils/runtime/Cargo.toml updated

* doc fixed

* client/rpc: test fixed (new rt api)

* client/rpc-spec-v2: test fix

* doc fix

* test-runtime: disable-genesis-builder feature

* fix

* fix

* ".git/.scripts/commands/fmt/fmt.sh"

* test-runtime: rerun added to build script

---------

Co-authored-by: default avatarDavide Galassi <[email protected]>
Co-authored-by: parity-processbot <>
      53cbda1d
    • Sacha Lansky's avatar
      [fix lint warnings: Uniques pallet] fix clippy::doc_markdown warnings (#14592) · 7fdcb831
      Sacha Lansky authored 
      

* Fix clippy::doc_markdown warnings

* Remove accidental commit of script

* ".git/.scripts/commands/bench/bench.sh" pallet dev pallet_uniques

* Some more backticks

Signed-off-by: default avatarOliver Tale-Yazdi <[email protected]>

* ".git/.scripts/commands/bench/bench.sh" pallet dev pallet_uniques

---------

Signed-off-by: default avatarOliver Tale-Yazdi <[email protected]>
Co-authored-by: command-bot <>
Co-authored-by: default avatarOliver Tale-Yazdi <[email protected]>
      7fdcb831
    • Sacha Lansky's avatar
      [fix lint warnings: Uniques pallet] fix clippy::missing_docs_in_private_items warnings (#14591) · 18705986
      Sacha Lansky authored 
      * Fix clippy::missing_docs_in_private_items

* Fix clippy::missing_docs_in_private_items

---------

Co-authored-by: parity-processbot <>
      18705986
    • Gonçalo Pestana's avatar
      Do not include voters that have zero voter weight in the election snapshot (#14245) · 9f92437c
      Gonçalo Pestana authored 
      Co-authored-by: parity-processbot <>
      9f92437c
    • Aaro Altonen's avatar
      Accept only `--in-peers` many inbound full nodes in `SyncingEngine` (#14603) · f008e069
      Aaro Altonen authored 
      * Accept only `--in-peers` many inbound full nodes in `SyncingEngine`

Due to full and light nodes being stored in the same set, it's possible
that `SyncingEngine` accepts more than `--in-peers` many inbound full
nodes which leaves some of its outbound slots unoccupied.

`ProtocolController` still tries to occupy these slots by opening
outbound substreams. As these substreams are accepted by the remote peer,
the connection is relayed to `SyncingEngine` which rejects the node
because it's already full. This in turn results in the substream being
inactive and the peer getting evicted.

Fixing this properly would require relocating the light peer slot
allocation away from `ProtocolController` or alternatively moving entire
the substream validation there, both of which are epic refactorings and
not necessarily in line with other goals. As a temporary measure, verify
in `SyncingEngine` that it doesn't accept more than the specified amount
of inbound full peers.

* Fix tests

* Apply review comments
      f008e069
  3. Jul 23, 2023
  5. Jul 21, 2023
  7. Jul 20, 2023
  9. Jul 19, 2023
  11. Jul 18, 2023
  13. Jul 17, 2023
  15. Jul 14, 2023
  17. Jul 13, 2023