Skip to content
Snippets Groups Projects
  1. Jan 29, 2025
    • Valery Gantchev's avatar
      Use checked math in frame-balances named_reserve (#7365) · 99327559
      Valery Gantchev authored
      
      This PR modifies `named_reserve()` in frame-balances to use checked math
      instead of defensive saturating math.
      
      The use of saturating math relies on the assumption that the sum of the
      values will always fit in `u128::MAX`. However, there is nothing
      preventing the implementing pallet from passing a larger value which
      overflows. This can happen if the implementing pallet does not validate
      user input and instead relies on `named_reserve()` to return an error
      (this saves an additional read)
      
      This is not a security concern, as the method will subsequently return
      an error thanks to `<Self as ReservableCurrency<_>>::reserve(who,
      value)?;`. However, the `defensive_saturating_add` will panic in
      `--all-features`, creating false positive crashes in fuzzing operations.
      
      ---------
      
      Co-authored-by: default avatarcmd[bot] <41898282+github-actions[bot]@users.noreply.github.com>
      (cherry picked from commit f373af0d)
      99327559
  2. Jan 27, 2025
  3. Jan 23, 2025
  4. Jan 17, 2025
  5. Jan 16, 2025
  6. Jan 15, 2025
  7. Jan 14, 2025
  8. Jan 13, 2025
  9. Dec 20, 2024
  10. Dec 19, 2024
  11. Dec 17, 2024
  12. Dec 11, 2024
  13. Dec 10, 2024