Skip to content
  1. Mar 23, 2023
  3. Mar 21, 2023
    • ordian's avatar
      runtime/inclusion: fix availability_threshold (#6931) · 4ed39979
      ordian authored
      4ed39979
    • ordian's avatar
      kusama: enable dispute slashes (#5974) · 3b493f02
      ordian authored 
      

* disputes: runtime part of slashing

* disputes: reward winners

* disputes/slashing: validate_unsigned impl

* fmt

* disputes/slashing: report_dispute_lost_unsigned

* disputes/slashing: separate winners from losers and report winners

* disputes/slashing: refactoring

* impl HandleReports

* enable on Wenstend

* fmt

* add slashing pallet to the mock and test runtimes

* fix a bug in report_dispute_lost_unsigned

* fmt

* disputes: remove new_participants from summary

* disputes: remove punish_inconclusive

* impl SlashingHandler for Pallet for type-safety

* do not impl slashing::Config on mainnets yet

* teach spellcheck deduplication

* simplify interfaces and resolve some TODOs

* resolve some more TODOs

* minor typos

* move slashing into a folder

* remove unnecessary clone

* fix validator_set_count calculation

* introduce ValidatorSetCount

* store ValidatorSetCount

* fmt

* add the benchmark

* fmt

* unflatten slashing

* post-rebase fixes

* remove winners eagerly

* use real slashing weights for westend

* remove bench test suite

* zombinet: modify disputes test to check for an offence report

* zombinet: add a timeout

* add slashing pallet to Rococo

* zombienet: revert back to rococo-local

* fmt

* remove TODOs

* revert some accidental changes

* slashing is submodule of disputes

* Change the log target

Co-authored-by: default avatarKian Paimani <[email protected]>

* wrap comments with rustfmt, more docs, constants

* use Defensive trait

* cargo update -p sp-io

* merge offence types, remove rewards for now

* cargo update -p sp-io

* benchmark fixes

* fmt

* unused var

* fix block_author impl

* ressurect RewardValidators trait

* remove outdated comment

* more module docs

* introduce BenchmarkingConfig

* typo fix

* teach spellcheck unapplied

* use Weight::new()

* fix mocking rewards

* use RefTimeWeight

* ".git/.scripts/bench-bot.sh" runtime westend-dev runtime_parachains::disputes::slashing

* refactor maybe_identify_validators

* no more ticket in disguise

* remove outdated comments

* lower against valid to 0.1%

* bump zombienet version for debug

* use from_perthousand

* post-merge fixes

* another day, another Weight changes

* Revert "bump zombienet version for debug"

This reverts commit 371ab2dfdfd6b4ca46320a6106339bcd4a3a0b12.

* do not reward block authors

* fix outdated comment

* use Pays from frame_support::dispatch::Pays

* kusama: enable dispute slashing

* ".git/.scripts/bench-bot.sh" runtime kusama-dev runtime_parachains::disputes::slashing

* post merge fixes

* ".git/.scripts/commands/bench/bench.sh" runtime kusama-dev runtime_parachains::disputes::slashing

* ".git/.scripts/commands/bench/bench.sh" runtime kusama runtime_parachains::disputes::slashing

---------

Co-authored-by: default avatarKian Paimani <[email protected]>
Co-authored-by: command-bot <>
Co-authored-by: default avatarJavier Viola <[email protected]>
Co-authored-by: default avatarJavier Viola <[email protected]>
      3b493f02
    • Gavin Wood's avatar
      Introduce OpenGov into Polkadot (#6701) · 7beeba5f
      Gavin Wood authored 
      

* OpenGov for Polkadot

* Integrate OpenGov into XCM

* Formatting

* Missing files

* Remove Gov1 from Kusama

* Fixes

* Update runtime/polkadot/src/governance/origins.rs

Co-authored-by: default avatarAnkan <[email protected]>

* Revert scheduler origin changes

* Fixes

* Docs

* Remove todo

* Docs

* Move Fellowship to Collectives  (#6718)

* FellowshipAdmin origin over xcm

* accept Fellows origin from Collectives

* remove Fellowship

* remove unreachable arm

* define benchmarks

* correct comment for DOLLARS constant

* Add OpenGov Calls to Proxy Definitions (#6729)

* add opengov calls to proxy definitions

* fix build

* Update runtime/polkadot/src/governance/mod.rs

Co-authored-by: default avatarjoe petrowski <[email protected]>

* Update runtime/polkadot/src/governance/tracks.rs

Co-authored-by: default avatarjoe petrowski <[email protected]>

* Update runtime/polkadot/src/lib.rs

Co-authored-by: default avatarjoe petrowski <[email protected]>

* Update runtime/polkadot/src/governance/origins.rs

Co-authored-by: default avatarjoe petrowski <[email protected]>

* Update runtime/polkadot/src/governance/mod.rs

Co-authored-by: default avatarjoe petrowski <[email protected]>

* Update old.rs

* Update old.rs

* weights with new api

* XCM tweaks for OpenGov (#6855)

* pass xcm origin, allow unpaid form Collectives and Fellows, whitelist call

* unpaid execution only for Fellows

* Apply suggestions from code review

Co-authored-by: default avatarjoe petrowski <[email protected]>

* rename const namespace to system_parachains

* remove prod_or_fast

---------

Co-authored-by: default avatarjoe petrowski <[email protected]>

* remove unused import

---------

Co-authored-by: default avatarAnkan <[email protected]>
Co-authored-by: parity-processbot <>
Co-authored-by: default avatarMuharem Ismailov <[email protected]>
Co-authored-by: default avatarjoe petrowski <[email protected]>
      7beeba5f
    • Chris Sosnin's avatar
      introduce new well known key (#6915) · 2e5da3cb
      Chris Sosnin authored
      2e5da3cb
  5. Mar 20, 2023
  7. Mar 17, 2023
    • Davide Galassi's avatar
      [Companion #13615] Keystore overhaul (#6892) · 46c36e5a
      Davide Galassi authored 
      * Remove not required async calls

* Fixed missing renaming

* make_keystore can be sync

* More fixes

* Trivial nitpicks

* Cherry pick test fix from master

* Fixes after master merge

* update lockfile for {"substrate"}

---------

Co-authored-by: parity-processbot <>
      46c36e5a
    • Mara Broda's avatar
      update weights (#6897) · 4d904951
      Mara Broda authored 
      * polkadot: update weights

* westend: update weights

* kusama: update weights

* rococo: update weights
      4d904951
  9. Mar 16, 2023
  11. Mar 15, 2023
  13. Mar 14, 2023
  15. Mar 13, 2023
    • Vivek Pandya's avatar
      Remove use of Store trait (#6835) · 87db25ce
      Vivek Pandya authored 
      * Remove use of Store trait from runtime directory

* Remove Store trait usage from xcm directory

* Run cargo fmt

* update lockfile for {"substrate"}

---------

Co-authored-by: parity-processbot <>
      87db25ce
  17. Mar 11, 2023
  19. Mar 07, 2023
  21. Mar 06, 2023
  23. Mar 03, 2023
  25. Mar 02, 2023
  27. Feb 28, 2023
  29. Feb 27, 2023
  31. Feb 23, 2023
  33. Feb 22, 2023
    • Mara Broda's avatar
      clean up executed migrations (#6763) · c5b5276f
      Mara Broda authored 
      * kusama: clean up executed migrations

* polkadot: clean up executed migrations

* rococo: clean up executed migrations

* westend: clean up executed migrations
      c5b5276f
    • cheme's avatar
      Remove state migration from westend runtime. (#6737) · 94d24de1
      cheme authored 
      * clean state_trie_migration from westend

* update cargo.lock

* Revert "clean state_trie_migration from westend"

This reverts commit b1d55c688e9a8a2fbd155f0a9ddaba9766ad101c.

* cleanup.

* use storage_alias

* Revert "use storage_alias"

This reverts commit 5289745d1592a14db0063d9ee111137473993f41.

* Revert "Revert "use storage_alias""

This reverts commit d4c688acdddf29a09c79a4eef52ab4095128e5b3.

* Force alias.

* magic
      94d24de1
    • Ross Bulat's avatar
      polkadot companion #12608 (Pools claim permissions) (#6753) · 6bd19ac7
      Ross Bulat authored 
      * update weights functions

* + placeholder weight

* ".git/.scripts/commands/bench/bench.sh" runtime polkadot-dev pallet_nomination_pools

* update weights

* update lockfile for {"substrate"}

---------

Co-authored-by: command-bot <>
      6bd19ac7
    • Daniel Shiposha's avatar
      Companion for Substrate #13410: Introduce EnsureOrigin to democracy.propose (#6750) · 2f6e941c
      Daniel Shiposha authored 
      * feat: set SubmitOrigin in all affected runtimes

* update lockfile for {"substrate"}

---------

Co-authored-by: parity-processbot <>
      2f6e941c
  35. Feb 21, 2023
  37. Feb 20, 2023
  39. Feb 17, 2023
  41. Feb 16, 2023
    • Marcin S.'s avatar
      Use a `BoundedVec` in `ValidationResult` (#6603) · d5a79914
      Marcin S. authored 
      * Use a `BoundedVec` in `ValidationResult`

> Use a `BoundedVec` for `upward_messages` and `horizontal_messages` in order to
> limit the number of individual messages/memory allocations right at decoding
> time. The reason for this is that the `ValidationResult` may contain a code
> upgrade (including a full PVF binary), so the total size limit can't be set
> too low and this limit will still allow several millions of upward messages,
> which will (due to the memory allocator overhead) already have a
> non-negligible memory footprint in decoded form.

* List all fields when hashing so we don't miss one

* Define types for  `BoundedVec`s of messages

* Fix test compile errors

* Depend on `bounded-collections` 0.1.4 (fixes allocation issue)

* Fix compilation issue

* Derive `Hash` instead of manual `impl`

* Avoid use of unwrap
      d5a79914
  43. Feb 15, 2023
    • s0me0ne-unkn0wn's avatar
      Executor Environment parameterization (#6161) · dd0a5566
      s0me0ne-unkn0wn authored 
      

* Re-apply changes without Diener, rebase to the lastest master

* Cache pruning

* Bit-pack InstantiationStrategy

* Move ExecutorParams version inside the structure itself

* Rework runtime API and executor parameters storage

* Pass executor parameters through backing subsystem

* Update Cargo.lock

* Introduce `ExecutorParams` to approval voting subsys

* Introduce `ExecutorParams` to dispute coordinator

* `cargo fmt`

* Simplify requests from backing subsys

* Fix tests

* Replace manual config cloning with `.clone()`

* Move constants to module

* Parametrize executor performing PVF pre-check

* Fix Malus

* Fix test runtime

* Introduce session executor params as a constant defined by session info
pallet

* Use Parity SCALE codec instead of hand-crafted binary encoding

* Get rid of constants; Add docs

* Get rid of constants

* Minor typo

* Fix Malus after rebase

* `cargo fmt`

* Use transparent SCALE encoding instead of explicit

* Clean up

* Get rid of relay parent to session index mapping

* Join environment type and version in a single enum element

* Use default execution parameters if running an old runtime

* `unwrap()` -> `expect()`

* Correct API version

* Constants are back in town

* Use constants for execution environment types

* Artifact separation, first try

* Get rid of explicit version

* PVF execution queue worker separation

* Worker handshake

* Global renaming

* Minor fixes resolving discussions

* Two-stage requesting of executor params to make use of runtime API cache

* Proper error handling in pvf-checker

* Executor params storage bootstrapping

* Propagate migration to v3 network runtimes

* Fix storage versioning

* Ensure `ExecutorParams` serialization determinism; Add comments

* Rename constants to make things a bit more deterministic
Get rid of stale code

* Tidy up a structure of active PVFs

* Minor formatting

* Fix comment

* Add try-runtime hooks

* Add storage version write on upgrade

Co-authored-by: default avatarAndronik <[email protected]>

* Add pre- and post-upgrade assertions

* Require to specify environment type; Remove redundant `impl`s

* Add `ExecutorParamHash` creation from `H256`

* Fix candidate validation subsys tests

* Return splittable error from executor params request fn

* Revert "Return splittable error from executor params request fn"

This reverts commit a0b274177d8bb2f6e13c066741892ecd2e72a456.

* Decompose approval voting metrics

* Use more relevant errors

* Minor formatting fix

* Assert a valid environment type instead of checking

* Fix `try-runtime` hooks

* After-merge fixes

* Add migration logs

* Remove dead code

* Fix tests

* Fix tests

* Back to the strongly typed implementation

* Promote strong types to executor interface

* Remove stale comment

* Move executor params to `SessionInfo`: primitives and runtime

* Move executor params to `SessionInfo`: node

* Try to bump primitives and API version

* Get rid of `MallocSizeOf`

* Bump target API version to v4

* Make use of session index already in place

* Back to v3

* Fix all the tests

* Add migrations to all the runtimes

* Make use of existing `SessionInfo` in approval voting subsys

* Rename `TARGET` -> `LOG_TARGET`

* Bump all the primitives to v3

* Fix Rococo ParachainHost API version

* Use `RollingSessionWindow` to acquire `ExecutorParams` in disputes

* Fix nits from discussions; add comments

* Re-evaluate queue logic

* Rework job assignment in execution queue

* Add documentation

* Use `RuntimeInfo` to obtain `SessionInfo` (with blackjack and caching)

* Couple `Pvf` with `ExecutorParams` wherever possible

* Put members of `PvfWithExecutorParams` under `Arc` for cheap cloning

* Fix comment

* Fix CI tests

* Fix clippy warnings

* Address nits from discussions

* Add a placeholder for raw data

* Fix non exhaustive match

* Remove redundant reexports and fix imports

* Keep only necessary semantic features, as discussed

* Rework `RuntimeInfo` to support mock implementation for tests

* Remove unneeded bound

* `cargo fmt`

* Revert "Remove unneeded bound"

This reverts commit 932463f26b00ce290e1e61848eb9328632ef8a61.

* Fix PVF host tests

* Fix PVF checker tests

* Fix overseer declarations

* Simplify tests

* `MAX_KEEP_WAITING` timeout based on `BACKGING_EXECUTION_TIMEOUT`

* Add a unit test for varying executor parameters

* Minor fixes from discussions

* Add prechecking max. memory parameter (see paritytech/srlabs_findings#110)

* Fix and improve a test

* Remove `ExecutionEnvironment` and `RawData`

* New primitives versioning in parachain host API

* `disputes()` implementation for Kusama and Polkadot

* Move `ExecutorParams` from `vstaging` to stable primitives

* Move disputes from `vstaging` to stable implementation

* Fix `try-runtime`

* Fixes after merge

* Move `ExecutorParams` to the bottom of `SessionInfo`

* Revert "Move executor params to `SessionInfo`: primitives and runtime"

This reverts commit dfcfb85fefd1c5be6c8a8f72dc09fd1809cfa9ce.

* Always use fresh activated live hash in pvf precheck
(re-apply 34b09a4c20de17e7926ed942cd0d657d18f743fa)

* Fixing tests (broken commit)

* Fix candidate validation tests

* Fix PVF host test

* Minor fixes

* Address discussions

* Restore migration

* Fix `use` to only include what is needed instead of `*`

* Add comment to never touch `DEFAULT_CONFIG`

* Update migration to set default `ExecutorParams` for `dispute_period`
sessions back

* Use `earliest_stored_session` instead of calculations

* Nit

* Add logs

* Treat any runtime error as `NotSupported` again

* Always return default executor params if not available

* Revert "Always return default executor params if not available"

This reverts commit b58ac4482ef444c67a9852d5776550d08e312f30.

* Add paritytech/substrate#9997 workaround

* `cargo fmt`

* Remove migration (again!)

* Bump executor params to API v4 (backport from #6698)

---------

Co-authored-by: default avatarAndronik <[email protected]>
      dd0a5566
  45. Feb 13, 2023