1. May 17, 2022
  2. May 16, 2022
  3. May 15, 2022
  4. May 13, 2022
  5. May 12, 2022
  6. May 11, 2022
  7. May 10, 2022
    • Kian Paimani's avatar
      fix a few more things with nomination pools (#11373) · ce212479
      Kian Paimani authored
      
      
      * fix a few more things with nomination pools
      
      * add bench
      
      * use weight fn
      
      * cargo run --quiet --profile=production  --features=runtime-benchmarks --manifest-path=bin/node/cli/Cargo.toml -- benchmark pallet --chain=dev --steps=50 --repeat=20 --pallet=pallet_nomination_pools --extrinsic=* --execution=wasm --wasm-execution=compiled --heap-pages=4096 --output=./frame/nomination-pools/src/weights.rs --template=./.maintain/frame-weight-template.hbs
      
      * allow real root to also set roles
      
      * Update frame/nomination-pools/src/lib.rs
      
      Co-authored-by: default avatarOliver Tale-Yazdi <[email protected]>
      
      * Update frame/nomination-pools/src/lib.rs
      
      Co-authored-by: default avatarOliver Tale-Yazdi <[email protected]>
      
      * move out of the closure
      
      * fix a few more things
      
      Co-authored-by: default avatarParity Bot <[email protected]>
      Co-authored-by: default avatarOliver Tale-Yazdi <[email protected]>
      ce212479
    • Davide Galassi's avatar
      Sanity check for Babe's configuration (#11385) · 07098c7d
      Davide Galassi authored
      
      
      * Prevent div by zero in native babe code
      * Additional sanity check for babe config
      * Further sanity checks and postpone threshold computation
      * Apply suggestions from code review
      Co-authored-by: default avatarBastian Köcher <[email protected]>
      07098c7d
    • David's avatar
      jsonrpsee integration (#8783) · 29c0c6a4
      David authored
      
      
      * Add tokio
      
      * No need to map CallError to CallError
      
      * jsonrpsee proc macros (#9673)
      
      * port error types to `JsonRpseeError`
      
      * migrate chain module to proc macro api
      
      * make it compile with proc macros
      
      * update branch
      
      * update branch
      
      * update to jsonrpsee master
      
      * port system rpc
      
      * port state rpc
      
      * port childstate & offchain
      
      * frame system rpc
      
      * frame transaction payment
      
      * bring back CORS hack to work with polkadot UI
      
      * port babe rpc
      
      * port manual seal rpc
      
      * port frame mmr rpc
      
      * port frame contracts rpc
      
      * port finality grandpa rpc
      
      * port sync state rpc
      
      * resolve a few TODO + no jsonrpc deps
      
      * Update bin/node/rpc-client/src/main.rs
      
      * Update bin/node/rpc-client/src/main.rs
      
      * Update bin/node/rpc-client/src/main.rs
      
      * Update bin/node/rpc-client/src/main.rs
      
      * Port over system_ rpc tests
      
      * Make it compile
      
      * Use prost 0.8
      
      * Use prost 0.8
      
      * Make it compile
      
      * Ignore more failing tests
      
      * Comment out WIP tests
      
      * fix nit in frame system api
      
      * Update lockfile
      
      * No more juggling tokio versions
      
      * No more wait_for_stop ?
      
      * Remove browser-testing
      
      * Arguments must be arrays
      
      * Use same argument names
      
      * Resolve todo: no wait_for_stop for WS server
      Add todo: is parse_rpc_result used?
      Cleanup imports
      
      * fmt
      
      * log
      
      * One test passes
      
      * update jsonrpsee
      
      * update jsonrpsee
      
      * cleanup rpc-servers crate
      
      * jsonrpsee: add host and origin filtering (#9787)
      
      * add access control in the jsonrpsee servers
      
      * use master
      
      * fix nits
      
      * rpc runtime_version safe
      
      * fix nits
      
      * fix grumbles
      
      * remove unused files
      
      * resolve some todos
      
      * jsonrpsee more cleanup (#9803)
      
      * more cleanup
      
      * resolve TODOs
      
      * fix some unwraps
      
      * remove type hints
      
      * update jsonrpsee
      
      * downgrade zeroize
      
      * pin jsonrpsee rev
      
      * remove unwrap nit
      
      * Comment out more tests that aren't ported
      
      * Comment out more tests
      
      * Fix tests after merge
      
      * Subscription test
      
      * Invalid nonce test
      
      * Pending exts
      
      * WIP removeExtrinsic test
      
      * Test remove_extrinsic
      
      * Make state test: should_return_storage work
      
      * Uncomment/fix the other non-subscription related state tests
      
      * test: author_insertKey
      
      * test: author_rotateKeys
      
      * Get rest of state tests passing
      
      * asyncify a little more
      
      * Add todo to note #msg change
      
      * Crashing test for has_session_keys
      
      * Fix error conversion to avoid stack overflows
      Port author_hasSessionKeys test
      fmt
      
      * test author_hasKey
      
      * Add two missing tests
      Add a check on the return type
      Add todos for James's concerns
      
      * RPC tests for state, author and system (#9859)
      
      * Fix test runner
      
      * Impl Default for SubscriptionTaskExecutor
      
      * Keep the minimul amount of code needed to compile tests
      
      * Re-instate `RpcSession` (for now)
      
      * cleanup
      
      * Port over RPC tests
      
      * Add tokio
      
      * No need to map CallError to CallError
      
      * Port over system_ rpc tests
      
      * Make it compile
      
      * Use prost 0.8
      
      * Use prost 0.8
      
      * Make it compile
      
      * Ignore more failing tests
      
      * Comment out WIP tests
      
      * Update lockfile
      
      * No more juggling tokio versions
      
      * No more wait_for_stop ?
      
      * Remove browser-testing
      
      * Arguments must be arrays
      
      * Use same argument names
      
      * Resolve todo: no wait_for_stop for WS server
      Add todo: is parse_rpc_result used?
      Cleanup imports
      
      * fmt
      
      * log
      
      * One test passes
      
      * Comment out more tests that aren't ported
      
      * Comment out more tests
      
      * Fix tests after merge
      
      * Subscription test
      
      * Invalid nonce test
      
      * Pending exts
      
      * WIP removeExtrinsic test
      
      * Test remove_extrinsic
      
      * Make state test: should_return_storage work
      
      * Uncomment/fix the other non-subscription related state tests
      
      * test: author_insertKey
      
      * test: author_rotateKeys
      
      * Get rest of state tests passing
      
      * asyncify a little more
      
      * Add todo to note #msg change
      
      * Crashing test for has_session_keys
      
      * Fix error conversion to avoid stack overflows
      Port author_hasSessionKeys test
      fmt
      
      * test author_hasKey
      
      * Add two missing tests
      Add a check on the return type
      Add todos for James's concerns
      
      * offchain rpc tests
      
      * Address todos
      
      * fmt
      
      Co-authored-by: default avatarJames Wilson <[email protected]>
      
      * fix drop in state test
      
      * update jsonrpsee
      
      * fix ignored system test
      
      * fix chain tests
      
      * remove some boiler plate
      
      * Port BEEFY RPC (#9883)
      
      * Merge master
      
      * Port beefy RPC (ty @niklas!)
      
      * trivial changes left over from merge
      
      * Remove unused code
      
      * Update jsonrpsee
      
      * fix build
      
      * make tests compile again
      
      * beefy update jsonrpsee
      
      * fix: respect rpc methods policy
      
      * update cargo.lock
      
      * update jsonrpsee
      
      * update jsonrpsee
      
      * downgrade error logs
      
      * update jsonrpsee
      
      * Fix typo
      
      * remove unused file
      
      * Better name
      
      * Port Babe RPC tests
      
      * Put docs back
      
      * Resolve todo
      
      * Port tests for System RPCs
      
      * Resolve todo
      
      * fix build
      
      * Updated jsonrpsee to current master
      
      * fix: port finality grandpa rpc tests
      
      * Move .into() outside of the match
      
      * more review grumbles
      
      * jsonrpsee: add `rpc handlers` back (#10245)
      
      * add back RpcHandlers
      
      * cargo fmt
      
      * fix docs
      
      * fix grumble: remove needless alloc
      
      * resolve TODO
      
      * fmt
      
      * Fix typo
      
      * grumble: Use constants based on BASE_ERROR
      
      * grumble: DRY whitelisted listening addresses
      grumble: s/JSONRPC/JSON-RPC/
      
      * cleanup
      
      * grumbles: Making readers aware of the possibility of gaps
      
      * review grumbles
      
      * grumbles
      
      * remove notes from niklasad1
      
      * Update `jsonrpsee`
      
      * fix: jsonrpsee features
      
      * jsonrpsee: fallback to random port in case the specified port failed (#10304)
      
      * jsonrpsee: fallback to random port
      
      * better comment
      
      * Update client/rpc-servers/src/lib.rs
      
      Co-authored-by: default avatarMaciej Hirsz <[email protected]>
      
      * Update client/rpc-servers/src/lib.rs
      
      Co-authored-by: default avatarMaciej Hirsz <[email protected]>
      
      * address grumbles
      
      * cargo fmt
      
      * addrs already slice
      
      Co-authored-by: default avatarMaciej Hirsz <[email protected]>
      
      * Update jsonrpsee to 092081a0a2b8904c6ebd2cd99e16c7bc13ffc3ae
      
      * lockfile
      
      * update jsonrpsee
      
      * fix warning
      
      * Don't fetch jsonrpsee from crates
      
      * make tests compile again
      
      * fix rpc tests
      
      * remove unused deps
      
      * update tokio
      
      * fix rpc tests again
      
      * fix: test runner
      
      `HttpServerBuilder::builder` fails unless it's called within tokio runtime
      
      * cargo fmt
      
      * grumbles: fix subscription aliases
      
      * make clippy happy
      
      * update remaining subscriptions alias
      
      * cleanup
      
      * cleanup
      
      * fix chain subscription: less boiler plate (#10285)
      
      * fix chain subscription: less boiler plate
      
      * fix bad merge
      
      * cargo fmt
      
      * Switch to jsonrpsee 0.5
      
      * fix build
      
      * add missing features
      
      * fix nit: remove needless Box::pin
      
      * Integrate jsonrpsee metrics (#10395)
      
      * draft metrics impl
      
      * Use latest api
      
      * Add missing file
      
      * Http server metrics
      
      * cleanup
      
      * bump jsonrpsee
      
      * Remove `ServerMetrics` and use a single middleware for both connection counting (aka sessions) and call metrics.
      
      * fix build
      
      * remove needless Arc::clone
      
      * Update to jsonrpsee 0.6
      
      * lolz
      
      * fix metrics
      
      * Revert "lolz"
      
      This reverts commit eed6c6a56e78d8e307b4950f4c52a1c3a2322ba1.
      
      * fix: in-memory rpc support subscriptions
      
      * commit Cargo.lock
      
      * Update tests to 0.7
      
      * fix TODOs
      
      * ws server: generate subscriptionIDs as Strings
      
      Some libraries seems to expect the subscription IDs to be Strings, let's not break
      this in this PR.
      
      * Increase timeout
      
      * Port over tests
      
      * cleanup
      
      * Using error codes from the spec
      
      * fix clippy
      
      * cargo fmt
      
      * update jsonrpsee
      
      * fix nits
      
      * fix: rpc_query
      
      * enable custom subid gen through spawn_tasks
      
      * remove unsed deps
      
      * unify tokio deps
      
      * Revert "enable custom subid gen through spawn_tasks"
      
      This reverts commit 5c5eb70328fe39d154fdb55c56e637b4548cf470.
      
      * fix bad merge of `test-utils`
      
      * fix more nits
      
      * downgrade wasm-instrument to 0.1.0
      
      * [jsonrpsee]: enable custom RPC subscription ID generatation (#10731)
      
      * enable custom subid gen through spawn_tasks
      
      * fix nits
      
      * Update client/service/src/builder.rs
      
      Co-authored-by: default avatarDavid <[email protected]>
      
      * add Poc; needs jsonrpsee pr
      
      * update jsonrpsee
      
      * add re-exports
      
      * add docs
      
      Co-authored-by: default avatarDavid <[email protected]>
      
      * cargo fmt
      
      * fmt
      
      * port RPC-API dev
      
      * Remove unused file
      
      * fix nit: remove async trait
      
      * fix doc links
      
      * fix merge nit: remove jsonrpc deps
      
      * kill namespace on rpc apis
      
      * companion for jsonrpsee v0.10 (#11158)
      
      * companion for jsonrpsee v0.10
      
      * update versions v0.10.0
      
      * add some fixes
      
      * spelling
      
      * fix spaces
      
      Co-authored-by: default avatarNiklas Adolfsson <[email protected]>
      
      * send error before subs are closed
      
      * fix unsubscribe method names: chain
      
      * fix tests
      
      * jsonrpc server: print binded local address
      
      * grumbles: kill SubscriptionTaskExecutor
      
      * Update client/sync-state-rpc/src/lib.rs
      
      Co-authored-by: default avatarBastian Köcher <[email protected]>
      
      * Update client/rpc/src/chain/chain_full.rs
      
      Co-authored-by: default avatarBastian Köcher <[email protected]>
      
      * Update client/rpc/src/chain/chain_full.rs
      
      Co-authored-by: default avatarBastian Köcher <[email protected]>
      
      * sync-state-rpc: kill anyhow
      
      * no more anyhow
      
      * remove todo
      
      * jsonrpsee:  fix bad params in subscriptions. (#11251)
      
      * update jsonrpsee
      
      * fix error responses
      
      * revert error codes
      
      * dont do weird stuff in drop impl
      
      * rpc servers: remove needless clone
      
      * Remove silly constants
      
      * chore: update jsonrpsee v0.12
      
      * commit Cargo.lock
      
      * deps: downgrade git2
      
      * feat: CLI flag max subscriptions per connection
      
      * metrics: use old logging format
      
      * fix: read WS address from substrate output (#11379)
      
      Co-authored-by: default avatarNiklas Adolfsson <[email protected]>
      Co-authored-by: default avatarJames Wilson <[email protected]>
      Co-authored-by: default avatarMaciej Hirsz <[email protected]>
      Co-authored-by: default avatarMaciej Hirsz <[email protected]>
      Co-authored-by: default avatarBastian Köcher <[email protected]>
      29c0c6a4
    • Sasha Gryaznov's avatar
  8. May 09, 2022
  9. May 06, 2022
  10. May 05, 2022
  11. May 04, 2022
  12. May 03, 2022
  13. May 02, 2022
  14. Apr 30, 2022
  15. Apr 29, 2022
  16. Apr 28, 2022
  17. Apr 27, 2022
    • Zeke Mostov's avatar
      Nomination Pools (#10694) · 247f33dc
      Zeke Mostov authored
      
      
      * Update frame/nomination-pools/src/lib.rs
      
      Co-authored-by: default avatarKian Paimani <[email protected]>
      
      * Add admin roles and make some calls permissionless
      
      * Destroy pool in withdraw unbonded
      
      * Add docs on pool admin
      
      * Fixup tests
      
      * Test unbond_other permissionless scenarios
      
      * Test withdraw unbonded permissionless
      
      * Test only can join open pools
      
      * Move unsafe set state to mock
      
      * Test: nominate_works
      
      * Add bounds: MinJoinBond, MinCreateBond, MaxPools
      
      * Test MinCreateBond, MinJoinBond, MaxPools
      
      * Add post checks to tests
      
      * Remove some TODOs
      
      * Setup weight infrastructure
      
      * Benchmark claim_payout
      
      * Benchmark create
      
      * Benchmark nominate
      
      * Benchmark join
      
      * Benchmark unbond_other
      
      * Refactor join benchmark to use scenario setup
      
      * Clean up and address warnings
      
      * Basic withdraw unbonded benchmarks
      
      * Refactor nominate benchmark
      
      * Refactor claim payout
      
      * Add feature sp-staking/runtime-benchmarks
      
      * Get node runtime to compile
      
      * Get node to run
      
      * Make claim_payout bench work with node
      
      * Make pool_withdraw_unbonded bench work with node
      
      * Make withdraw_unbonded_other work with node runtime'
      
      * Make create benchmark work with node
      
      * Make nominate benchmark work with node runtime
      
      * WiP new benchmark crate
      
      * Implement initial mock for benchmarks
      
      * Establish benchmark setup logic
      
      * Get claim payout and nominate benchmarks working
      
      * Remove pool bench utils; make struct fields pub insteaad
      
      * Get more benchmarks to work; trim interface trait
      
      * Some more top level docs
      
      * Finish tranistion benchmarks to crate
      
      * Hook up benchmark pallet to node runtime
      
      * Get benches to work with node runtime
      
      * cargo run --quiet --profile=production  --features=runtime-benchmarks --manifest-path=bin/node/cli/Cargo.toml -- benchmark --chain=dev --steps=50 --repeat=20 --pallet=pallet_nomination_pools --extrinsic=* --execution=wasm --wasm-execution=compiled --heap-pages=4096 --output=./frame/nomination-pools/src/weights.rs --template=./.maintain/frame-weight-template.hbs
      
      * Benchmark withdraw_unbonded_other_kill
      
      * Delete old benchmarking files
      
      * Refunds for withdraw_unbonded
      
      * Remove some TODOs
      
      * 'Don't return an option for the current_era'
      
      * Streamline extrinsic docs
      
      * small docs tweaks
      
      * Refactor ledger::slash
      
      * Add on_slash impl for nomination pools
      
      * slash refactor wip
      
      * WIP slash working
      
      * DRY Ledger::stash
      
      * Fix slash saturation
      
      * Remove unused param from slash
      
      * Docs and warnings
      
      * Test ledger::slash
      
      * save progress
      
      * Introduce counter for delegators
      
      * Add tests for max delegator errors
      
      * Reproducible account ids
      
      * Adapt tests to new account id format
      
      * Simplify create_accounts api
      
      * Fix staking tests
      
      * Save PerBill slash impl before removing
      
      * Rever ledger slash test
      
      * Get node runtime to work
      
      * Organize sub pools by unbond era, not curren era
      
      * staking: Proportional ledger slashing
      
      * Some comment cleanup
      
      * Add more test post checks
      
      * Update frame/staking/src/pallet/mod.rs
      
      Co-authored-by: default avatarKian Paimani <[email protected]>
      
      * Tests: account for storing unbond era
      
      * Improve docs for staking interface
      
      * Add events Created, Destroyed
      
      * withdraw_unbonded: Remove useless withdraw dust check
      
      * Test: withdraw_unbonded_other_handles_faulty_sub_pool_accounting
      
      * Add extrinsics: set_state_other, set_metadata
      
      * Test: set_state_other_works
      
      * Test: set_metadata_works
      
      * Add benchmarks for set_state_other, set_metadata
      
      * Fix benchmarks
      
      * Add weight info for new extrinsics
      
      * Some feedback
      
      * duo feedback
      
      * Incorporate some more feedback
      
      * integrate more kian feedback
      
      * integrate more kian feedback
      
      * More improvements
      
      * Add destroying_mul
      
      * Make do_reward_payout take refs
      
      * Remove some TODOs
      
      * Add test for saturating
      
      * feedback
      
      * Fix join test
      
      * use `inner` for nested types in nomination pools (#11030)
      
      * Use nested inner type for pool
      
      * make tests and benchmarks work
      
      * remove feat
      
      * all tests work now
      
      * fix node-runtime
      
      * nomination-pools: update benches for new account format (#11033)
      
      * Update benches to new account format
      
      * More sensible seeds
      
      * bring back rward account sanity check
      
      * Comment
      
      * Add extrinsic set_configs (#11038)
      
      * Better sanity checks for nomination pools  (#11042)
      
      * new sanity checks, few other changes
      
      * Update frame/nomination-pools/src/lib.rs
      
      Co-authored-by: default avatarZeke Mostov <[email protected]>
      
      * nomination-pools: Fix state event regression + benches (#11045)
      
      * new sanity checks, few other changes
      
      * Fix benches, improve sanity check
      
      * Remove useless clear storage in benchmarking
      
      * Set state
      
      * Save
      
      * Doc
      
      * Update frame/nomination-pools/src/lib.rs
      
      Co-authored-by: default avatarkianenigma <[email protected]>
      
      * FMT
      
      * Try fill in all staking configs
      
      * Fix build
      
      * More changes to nomination pools (#11050)
      
      * new sanity checks, few other changes
      
      * some last touches as a whole
      
      * Apply suggestions from code review
      
      * Remove redundant event
      
      * Improve unbond_other error handling
      
      * Remove comment
      
      Co-authored-by: default avatarZeke Mostov <[email protected]>
      Co-authored-by: default avataremostov <[email protected]>
      
      * Remove sanity module and some TODOs
      
      * round of feedback and imp from kian
      
      * Add TODO for ED QoL at reward pool creation
      
      * Make sure reward pool never gets dusted
      
      * Improve error type
      
      * demonstrate per_thing usage
      
      * Update sanity check & fix create_works
      
      * Improve test ext pool creation & fix some more tests
      
      * Try revert
      
      * Revert "Try revert"
      
      This reverts commit c044c94730e1a370eecd8f5b2c4f632835913063.
      
      * Revert "Improve test ext pool creation & fix some more tests"
      
      This reverts commit 1e862a64a7423479260c6e5ad1bd4c8c95651f3a.
      
      * Revert "Update sanity check & fix create_works"
      
      This reverts commit 568a7b727687e4d585e2796afc638df97b83c632.
      
      Roll back reward account funding
      
      * Revert "Improve error type"
      
      This reverts commit 4b993ee601a037e7a44e4a49bbfd60cf45b38b78.
      
      * Revert "Make sure reward pool never gets dusted"
      
      This reverts commit e7a3eb45bdfd156d3f6d94d194e988032ebbc593.
      
      revert
      
      * Update some tests
      
      * FMT
      
      * Test that era offset works correctly
      
      * Update mocks
      
      * Remove unnescary docs
      
      * Doc updates
      
      * Update calculate_delegator_payout_works_with_a_pool_of_1
      
      * Fix test: claim_payout_works
      
      * do_reward_payout_correctly_sets_pool_state_to_destroying
      
      * Remove test do_reward_payout_errors_correctly
      
      * Fix test: do_reward_payout_works
      
      * Fix test: create_errors_correctly
      
      * Fix test: create works
      
      * Fix test: unbond_other_of_3_works
      
      * Ensure that ED is transferred into reward pool upon creation
      
      * WIP pool lifecycle test
      
      * Fix benchmarks
      
      * Add sanity check for ED + reward pools
      
      * `bond_extra` for nomination pools (#11100)
      
      * bond_extra for nomination pools
      
      * Update frame/nomination-pools/src/lib.rs
      
      * Update frame/nomination-pools/src/lib.rs
      
      * Update frame/nomination-pools/src/lib.rs
      
      Co-authored-by: default avatarZeke Mostov <[email protected]>
      
      * Update frame/nomination-pools/src/lib.rs
      
      Co-authored-by: default avatarZeke Mostov <[email protected]>
      
      * add benchmarks
      
      * remove the min logic of bond_extra
      
      Co-authored-by: default avatarZeke Mostov <[email protected]>
      
      * FMT
      
      * Update frame/nomination-pools/src/lib.rs
      
      Co-authored-by: default avatarKian Paimani <[email protected]>
      
      * Update frame/nomination-pools/src/lib.rs
      
      Co-authored-by: default avatarKian Paimani <[email protected]>
      
      * Update frame/nomination-pools/src/lib.rs
      
      Co-authored-by: default avatarKian Paimani <[email protected]>
      
      * Update frame/nomination-pools/src/lib.rs
      
      Co-authored-by: default avatarKian Paimani <[email protected]>
      
      * make it compile end to end
      
      * Update some type viz
      
      * Update kick terminology
      
      * Update frame/nomination-pools/src/lib.rs
      
      Co-authored-by: default avatarKian Paimani <[email protected]>
      
      * Update frame/nomination-pools/src/lib.rs
      
      * Cache bonded account when creating pool
      
      * Add bond extra weight stuff
      
      * Update frame/nomination-pools/src/lib.rs
      
      Co-authored-by: default avatarKian Paimani <[email protected]>
      
      * Update docs for pool withdraw unbonded
      
      * Update docs for unbond
      
      * Improve Doc
      
      * Update frame/nomination-pools/src/lib.rs
      
      Co-authored-by: default avatarOliver Tale-Yazdi <[email protected]>
      
      * Update frame/nomination-pools/Cargo.toml
      
      Co-authored-by: default avatarOliver Tale-Yazdi <[email protected]>
      
      * Update frame/nomination-pools/src/lib.rs
      
      Co-authored-by: default avatarOliver Tale-Yazdi <[email protected]>
      
      * Update frame/nomination-pools/src/lib.rs
      
      Co-authored-by: default avatarOliver Tale-Yazdi <[email protected]>
      
      * Update frame/nomination-pools/src/lib.rs
      
      Co-authored-by: default avatarOliver Tale-Yazdi <[email protected]>
      
      * Improve Docs
      
      * Some docs improvements
      
      * fmt
      
      * Remove unlock_era
      
      * Fix accidental frame-support regression
      
      * Fix issue with transactions in tests
      
      * Fix doc links
      
      * Make sure result in test is used
      
      * Update frame/nomination-pools/src/lib.rs
      
      Co-authored-by: default avatarOliver Tale-Yazdi <[email protected]>
      
      * Fix can toggle state
      
      * Account for new_funds in ok to be open
      
      * Update docs: ok_to_withdraw_unbonded_other_with
      
      * Update frame/nomination-pools/src/lib.rs
      
      Co-authored-by: default avatarOliver Tale-Yazdi <[email protected]>
      
      * Update frame/nomination-pools/src/lib.rs
      
      Co-authored-by: default avatarOliver Tale-Yazdi <[email protected]>
      
      * Remove some staking comments
      
      * Rename SubPoolsWithEra to UnbondingPoolsWithEra
      
      * Use validators length for benchmarks
      
      * Use metadata length for benchmarks
      
      * Remove debug assert eq
      
      * docs
      
      * Fix test: withdraw_unbonded_other_errors_correctly
      
      * Fix check for having enough balance to create the pool
      
      * Bond event for pool creation
      
      * Ok to be open
      
      * FMT
      
      * Remove _other postfix
      
      * Update frame/staking/src/lib.rs
      
      * Adjust tests to account for only remove when < ED
      
      * Remove stale TODOs
      
      * Remove dupe test
      
      * Fix build
      
      * Make sure to convert to u256 so we don't saturate
      
      * Refund depositor with reward pool fee
      
      * FMT
      
      * Remove reachable defensive
      
      * Use compact encoding for relevant extrinsics
      
      * Remove unnescary make_free_be for cleaning reward account
      
      * Add not to maintainers for reward account accounting
      
      * Remove note to maintainers from public doc
      
      * Make sure all configs have currency balance
      
      * Avoid saturation in balance_to_unbond
      
      * Partial Unbonding for Nomination Pools (#11212)
      
      * first draft of partial unbonding for pools
      
      * remove option
      
      * Add some more tests and fix issues
      
      * Fix all tests
      
      * simplify some tests
      
      * Update frame/nomination-pools/src/mock.rs
      
      * remove clone
      
      * rename to delegator_unbonding_eras
      
      * Update frame/nomination-pools/src/tests.rs
      
      Co-authored-by: default avatarZeke Mostov <[email protected]>
      
      * Update frame/nomination-pools/src/tests.rs
      
      Co-authored-by: default avatarZeke Mostov <[email protected]>
      
      * Update frame/nomination-pools/src/tests.rs
      
      Co-authored-by: default avatarZeke Mostov <[email protected]>
      
      * remove pub
      
      * Update frame/nomination-pools/src/lib.rs
      
      Co-authored-by: default avatarZeke Mostov <[email protected]>
      
      * Update frame/nomination-pools/src/lib.rs
      
      Co-authored-by: default avatarZeke Mostov <[email protected]>
      
      * undo
      
      * Update frame/nomination-pools/src/lib.rs
      
      Co-authored-by: default avatarZeke Mostov <[email protected]>
      
      * Update frame/nomination-pools/src/lib.rs
      
      Co-authored-by: default avatarZeke Mostov <[email protected]>
      
      * leftovers
      
      * fix invariant
      
      * Fix the depositor assumption
      
      * round of self-review
      
      * little bit more cleanup
      
      * Update frame/nomination-pools/src/mock.rs
      
      * Apply suggestions from code review
      
      * Update frame/nomination-pools/src/lib.rs
      
      Co-authored-by: default avatarZeke Mostov <[email protected]>
      
      * Fix interpretation of MinCreateBond
      
      * controvesial refactor
      
      * rename
      
      * make everything build
      
      * add TODO about killing the reward account
      
      * Update frame/nomination-pools/src/lib.rs
      
      Co-authored-by: default avatarZeke Mostov <[email protected]>
      
      * Update frame/nomination-pools/src/lib.rs
      
      * last self-review
      
      Co-authored-by: default avatarZeke Mostov <[email protected]>
      
      * Update Cargo.lock
      
      * Rename Delegator to PoolMember
      
      * fmt
      
      * Get runtime to build with runtime-benchmarks feature
      
      * Update Cargo.lock
      
      * Fix asserts to work in more scenarios
      
      * gte not gt
      
      * cargo run --quiet --profile=production  --features=runtime-benchmarks --manifest-path=bin/node/cli/Cargo.toml -- benchmark pallet --chain=dev --steps=50 --repeat=20 --pallet=pallet_nomination_pools --extrinsic=* --execution=wasm --wasm-execution=compiled --heap-pages=4096 --output=./frame/nomination-pools/src/weights.rs --template=./.maintain/frame-weight-template.hbs
      
      * Update frame/staking/src/mock.rs
      
      * Update frame/nomination-pools/src/lib.rs
      
      * Update frame/staking/src/slashing.rs
      
      * Apply suggestions from code review
      
      * fmt
      
      * Fix some tests
      
      Co-authored-by: default avatarKian Paimani <[email protected]>
      Co-authored-by: default avatarParity Bot <[email protected]>
      Co-authored-by: default avatarkianenigma <[email protected]>
      Co-authored-by: default avatarOliver Tale-Yazdi <[email protected]>
      Co-authored-by: default avatarShawn Tabrizi <[email protected]>
      247f33dc
    • Chigozie Joshua's avatar
      Adds remove_approval feature to treasury pallet (#11243) · bdf55aab
      Chigozie Joshua authored
      
      
      * added remove_approval feature to treasury pallet
      
      * Update frame/treasury/src/lib.rs
      
      Co-authored-by: default avatarXiliang Chen <[email protected]>
      
      * treasury pallet refactoring: removed proposalId check in remove_approval call and trailing new line in tests file
      
      * fmt
      
      * cargo run --quiet --profile=production  --features=runtime-benchmarks --manifest-path=bin/node/cli/Cargo.toml -- benchmark pallet --chain=dev --steps=50 --repeat=20 --pallet=pallet_treasury --extrinsic=* --execution=wasm --wasm-execution=compiled --heap-pages=4096 --output=./frame/treasury/src/weights.rs --template=./.maintain/frame-weight-template.hbs
      
      * Update frame/treasury/src/lib.rs
      
      Co-authored-by: default avatarjoe petrowski <[email protected]>
      
      * remove_approval extrinsic in treasury pallet:added extra checks in test and extra documentation
      
      * refactored error logging on remove_approval extrinsic in treasury pallet
      
      Co-authored-by: default avatarXiliang Chen <[email protected]>
      Co-authored-by: default avatarShawn Tabrizi <[email protected]>
      Co-authored-by: default avatarParity Bot <[email protected]>
      Co-authored-by: default avatarjoe petrowski <[email protected]>
      bdf55aab