Skip to content
  1. Apr 04, 2023
    • Bastian Köcher's avatar
      Remove deprecated batch verification (#13799) · 846ec8cd
      Bastian Köcher authored
      This removes the deprecated batch verification. This was actually never really activated.
      Nevertheless, we need to keep the host functions around to support old runtimes which may import
      these host functions. However, we do not give access to these functions anymore. This means that any new
      runtime can not call them anymore. The host function implementations we keep will not do batch verification and will
      instead fall back to the always existing option of directly verifying the passed signature.
      `finish_batch_verification` will return the combined result of all the batch verify calls.
      
      This removes the `TaskExecutorExt` which only existed to support the batch verification. So, any
      code that used this extension can just remove the registration of them. It also removes
      `SignatureBatching` that was used by `frame-executive` to control the batch verification.
      However, there wasn't any `Verify` implementation that called the batch verification functions.
      846ec8cd
    • William Freudenberger's avatar
      refactor: inconsistent BalanceConversion fn (#13610) · 74bbae69
      William Freudenberger authored
      * refactor: inconsistent BalanceConversion fn
      
      * Revert "refactor: inconsistent BalanceConversion fn"
      
      This reverts commit 1177877631a11b64df6f019b5390a8a7018e3a3f.
      
      * refactor: rename BalanceConversion trait
      
      * feat: add ConversionFromAssetBalance
      74bbae69
  2. Apr 03, 2023
  3. Apr 01, 2023
  4. Mar 31, 2023
    • PG Herveou's avatar
      contracts: make test work with debugger (#13776) · 8d802eec
      PG Herveou authored
      * contracts: make test work with debugger
      
      * fix path
      
      * PR review
      
      * Add comment
      
      * space
      
      * Update frame/contracts/src/tests.rs
      
      * lint
      
      * spelling
      8d802eec
    • asynchronous rob's avatar
      Refactor: extract most aura logic out to standalone module, make use of these (#13764) · 2a44372e
      asynchronous rob authored
      
      
      * Extract most aura logic out to standalone module, make use of these
      
      * Update client/consensus/aura/src/standalone.rs
      
      improve docs
      
      Co-authored-by: default avatarBastian Köcher <[email protected]>
      
      * add slot_duration_at
      
      * ".git/.scripts/commands/fmt/fmt.sh"
      
      ---------
      
      Co-authored-by: default avatarBastian Köcher <[email protected]>
      Co-authored-by: parity-processbot <>
      2a44372e
    • PG Herveou's avatar
      [Contracts] Overflowing bounded `DeletionQueue` allows DoS against contract termination (#13702) · 1bd5d2f7
      PG Herveou authored
      
      
      * [Contracts review] Overflowing bounded `DeletionQueue` allows DoS against contract termination
      
      * wip
      
      * wip
      
      * wip
      
      * wip
      
      * wip
      
      * fix doc
      
      * wip
      
      * PR review
      
      * unbreak tests
      
      * fixes
      
      * update budget computation
      
      * PR comment: use BlockWeights::get().max_block
      
      * PR comment: Update queue_trie_for_deletion signature
      
      * PR comment: update deletion budget docstring
      
      * PR comment: impl Default with derive(DefaultNoBound)
      
      * PR comment: Remove DeletedContract
      
      * PR comment Add ring_buffer test
      
      * remove missed comment
      
      * misc comments
      
      * contracts: add sr25519_recover
      
      * Revert "contracts: add sr25519_recover"
      
      This reverts commit d4600e00934b90e5882cf5288f36f98911b51722.
      
      * ".git/.scripts/commands/bench/bench.sh" pallet dev pallet_contracts
      
      * PR comments update print_schedule
      
      * Update frame/contracts/src/benchmarking/mod.rs
      
      * Update frame/contracts/src/storage.rs
      
      * Update frame/contracts/src/storage.rs
      
      * rm temporary fixes
      
      * fix extra ;
      
      * Update frame/contracts/src/storage.rs
      
      Co-authored-by: default avatarjuangirini <[email protected]>
      
      * Update frame/contracts/src/storage.rs
      
      Co-authored-by: default avatarAlexander Theißen <[email protected]>
      
      * Update frame/contracts/src/lib.rs
      
      Co-authored-by: default avatarAlexander Theißen <[email protected]>
      
      * Update frame/contracts/src/lib.rs
      
      Co-authored-by: default avatarAlexander Theißen <[email protected]>
      
      * Support stable rust for compiling the runtime (#13580)
      
      * Support stable rust for compiling the runtime
      
      This pull request brings support for compiling the runtime with stable Rust. This requires at least
      rust 1.68.0 to work on stable. The code is written in a way that it is backwards compatible and
      should automatically work when someone compiles with 1.68.0+ stable.
      
      * We always support nightlies!
      
      * 🤦
      
      
      
      * Sort by version
      
      * Review feedback
      
      * Review feedback
      
      * Fix version parsing
      
      * Apply suggestions from code review
      
      Co-authored-by: default avatarKoute <[email protected]>
      
      ---------
      
      Co-authored-by: default avatarKoute <[email protected]>
      
      * github PR commit fixes
      
      * Revert "Support stable rust for compiling the runtime (#13580)"
      
      This reverts commit 0b985aa5ad114a42003519b712d25a6acc40b0ad.
      
      * Restore DeletionQueueMap
      
      * fix namings
      
      * PR comment
      
      * move comments
      
      * Update frame/contracts/src/storage.rs
      
      * Update frame/contracts/src/storage.rs
      
      * fixes
      
      ---------
      
      Co-authored-by: command-bot <>
      Co-authored-by: default avatarjuangirini <[email protected]>
      Co-authored-by: default avatarAlexander Theißen <[email protected]>
      Co-authored-by: default avatarBastian Köcher <[email protected]>
      Co-authored-by: default avatarKoute <[email protected]>
      1bd5d2f7
  5. Mar 30, 2023
    • Javier Viola's avatar
      bump zombienet version (#13772) · 2f3a8b9e
      Javier Viola authored
      2f3a8b9e
    • Bastian Köcher's avatar
      5d5cc9a0
    • Kian Paimani's avatar
      Fix nomiantion pools doc render (#13748) · 95da8d7a
      Kian Paimani authored
      Co-authored-by: parity-processbot <>
      95da8d7a
    • Adrian Catangiu's avatar
      BEEFY: gossip finality proofs (#13727) · 92c1229e
      Adrian Catangiu authored
      * sc-consensus-beefy: add justifications to gossip protocol
      
      * sc-consensus-beefy: voter gossips finality proofs
      
      * sc-consensus-beefy: add finality proof gossip test
      
      * sc-consensus-beefy: always gossip finality proof
      
      Gossip finality proof in _both_ cases of reaching finality threshold
      through votes:
      1. threshold reached through self vote,
      2. threshold reached through incoming vote.
      
      * address comments
      92c1229e
    • Alexander Theißen's avatar
      Build wasm for mvp cpu (#13758) · 25a616ce
      Alexander Theißen authored
      25a616ce
    • Roman Useinov's avatar
      [Enhancement] Throw an error when there are too many pallets (#13763) · cc3152bc
      Roman Useinov authored
      
      
      * [Enhancement] Throw an error when there are too many pallets
      
      * fix ui test
      
      * fix PR comments
      
      * Update frame/support/procedural/src/construct_runtime/mod.rs
      
      Co-authored-by: default avatarBastian Köcher <[email protected]>
      
      * Update frame/support/procedural/src/construct_runtime/mod.rs
      
      Co-authored-by: default avatarBastian Köcher <[email protected]>
      
      * ".git/.scripts/commands/fmt/fmt.sh"
      
      ---------
      
      Co-authored-by: default avatarBastian Köcher <[email protected]>
      Co-authored-by: command-bot <>
      cc3152bc
    • Aaro Altonen's avatar
      Attempt to relieve pressure on `mpsc_network_worker` (#13725) · 4240490d
      Aaro Altonen authored
      * Attempt to relieve pressure on `mpsc_network_worker`
      
      `SyncingEngine` interacting with `NetworkWorker` can put a lot of strain
      on the channel if the number of inbound connections is high. This is
      because `SyncingEngine` is notified of each inbound substream which it
      then can either accept or reject and this causes a lot of message
      exchange on the already busy channel.
      
      Use a direct channel pair between `Protocol` and `SyncingEngine`
      to exchange notification events. It is a temporary change to alleviate
      the problems caused by syncing being an independent protocol and the
      fix will be removed once `NotificationService` is implemented.
      
      * Apply review comments
      
      * fixes
      
      * trigger ci
      
      * Fix tests
      
      Verify that both peers have a connection now that the validation goes
      through `SyncingEngine`. Depending on how the tasks are scheduled,
      one of them might not have the peer registered in `SyncingEngine` at which
      point the test won't make any progress because block announcement received
      from an unknown peer is discarded.
      
      Move polling of `ChainSync` at the end of the function so that if a block
      announcement causes a block request to be sent, that can be sent in the
      same call to `SyncingEngine::poll()`.
      
      ---------
      
      Co-authored-by: parity-processbot <>
      4240490d
    • Davide Galassi's avatar
      Application Crypto cleanup (#13746) · 7985495b
      Davide Galassi authored
      
      
      * Adjust application crypto docs
      
      * Blanket implementation for 'RuntimeAppPublic' trait
      
      * Blanket implementation for 'BoundToRuntimeAppPublic' for 'RuntimeAppPublic'
      
      * Relax type bounds
      
      * Docs fix
      
      * restore MaybeHash
      
      * Commit suggestion
      
      Co-authored-by: default avatarAnton <[email protected]>
      
      ---------
      
      Co-authored-by: default avatarAnton <[email protected]>
      7985495b
  6. Mar 29, 2023
  7. Mar 28, 2023
  8. Mar 27, 2023
  9. Mar 26, 2023