- Nov 14, 2023
-
-
jserrat authored
Co-authored-by:
Marcin S <[email protected]>
-
Marcin S. authored
-
- Nov 13, 2023
-
-
Marcin S. authored
Co-authored-by:
Bastian Köcher <[email protected]>
-
- Nov 09, 2023
-
-
Lulu authored
The staging- rename commit was missing from the last PR for some reason.
-
- Nov 03, 2023
-
-
s0me0ne-unkn0wn authored
-
- Nov 01, 2023
-
-
Julian Eager authored
-
jserrat authored
Co-authored-by:
Marcin S <[email protected]>
-
- Oct 31, 2023
-
-
Marcin S. authored
-
- Oct 24, 2023
-
-
Marcin S. authored
-
- Oct 15, 2023
-
-
Julian Eager authored
closes #695 Could potentially be helpful to preserving caches when applicable, as discussed in #685 kusama address: FvpsvV1GQAAbwqX6oyRjemgdKV11QU5bXsMg9xsonD1FLGK
-
- Oct 14, 2023
-
-
Julian Eager authored
closes #622 Pros: * simpler interface, just functions: `create_runtime_from_artifact_bytes()` and `execute_artifact()` Cons: * extra overhead of constructing executor semantics each time I could make it a combination of * `create_runtime_config(params)` (such that we could clone the constructed semantics) * `create_runtime(blob, config)` * `execute_artifact(blob, config, params)` Not sure if it's worth it though. --------- Co-authored-by:
Bastian Köcher <[email protected]>
-
- Oct 13, 2023
-
-
Julian Eager authored
Co-authored-by:
Marcin S <[email protected]>
-
- Oct 12, 2023
-
-
Anton Vilhelm Ásgeirsson authored
# Description In a couple of cases, there were links pointing to the w3f github pages domain. In other instances, there were links pointing to the old polkadot repo's github pages. Both of these are now pointing to the relevant links in https://paritytech.github.io/polkadot-sdk/book/index.html. These changes were made specifically because the w3f github pages returns a 404, and while fixing the links, the old polkadot repo links were touched up as well even if they do redirect properly. This shouldn't affect anything as these are documentation link changes only.
-
- Oct 11, 2023
-
-
Marcin S. authored
-
- Oct 05, 2023
-
-
Marcin S. authored
-
- Sep 28, 2023
-
-
Marcin S. authored
-
- Sep 18, 2023
-
-
yjh authored
It seems the old strategy have been depracted more than one year. So maybe it's time to clean up old strategy for wasm executor. --- polkadot address: 15ouFh2SHpGbHtDPsJ6cXQfes9Cx1gEFnJJsJVqPGzBSTudr --------- Co-authored-by:
Bastian Köcher <[email protected]> Co-authored-by:
Koute <[email protected]>
-
- Sep 12, 2023
-
-
Bastian Köcher authored
-
- Sep 11, 2023
-
-
s0me0ne-unkn0wn authored
Closes #583 After the separation of PVF worker binaries, dedicated puppet workers are not needed for tests anymore. The production workers can be used instead, avoiding some code duplication and decreasing complexity. The changes also make it possible to further refactor the code to isolate workers completely.
-
- Sep 08, 2023
-
-
dependabot[bot] authored
Bumps [hex-literal](https://github.com/RustCrypto/utils) from 0.3.4 to 0.4.1. - [Commits](https://github.com/RustCrypto/utils/compare/hex-literal-v0.3.4...hex-literal-v0.4.1 ) --- updated-dependencies: - dependency-name: hex-literal dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by:
dependabot[bot] <[email protected]> Co-authored-by:
dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by:
Bastian Köcher <[email protected]>
-
- Sep 01, 2023
-
-
s0me0ne-unkn0wn authored
* Import changes from archieved repo * Revert erroneous changes * Fix more tests * Resolve discussions * Fix MORE tests * approval-voting: launch_approval better interface (#1355) --------- Co-authored-by:
Javier Viola <[email protected]> Co-authored-by:
ordian <[email protected]> Co-authored-by:
ordian <[email protected]>
-
- Aug 31, 2023
-
-
Bastian Köcher authored
* Rename `polkadot-parachain` to `polkadot-parachain-primitives` While doing this it also fixes some last `rustdoc` issues and fixes another Cargo warning related to `pallet-paged-list`. * Fix compilation * ".git/.scripts/commands/fmt/fmt.sh" * Fix XCM docs --------- Co-authored-by: command-bot <>
-
Lulu authored
* Fix polkadot-node-core-pvf-prepare-worker build with jemalloc The jemalloc feature on polkadot-node-core-pvf-prepare-worker depended on some feature gated code in polkadot-node-core-pvf-common but there way no way to enable this feature gate. This commit adds the feature and makes prepare-worker enable it. * More jemalloc-allocator fixes * Fix jemalloc-allocator feature dep * Run `zepter format features` --------- Co-authored-by:
Marcin S <[email protected]>
-
Marcin S. authored
-
- Aug 29, 2023
-
-
Bastian Köcher authored
* Fix `test-rustdoc` * ".git/.scripts/commands/fmt/fmt.sh" --------- Co-authored-by: command-bot <>
-
Oliver Tale-Yazdi authored
* Fix build profiles Closes https://github.com/paritytech/polkadot-sdk/issues/1155 Signed-off-by:
Oliver Tale-Yazdi <[email protected]> * Manually set version to 1.0.0 Signed-off-by:
Oliver Tale-Yazdi <[email protected]> * Use workspace repo Signed-off-by:
Oliver Tale-Yazdi <[email protected]> * 'Authors and Edition from workspace Signed-off-by:
Oliver Tale-Yazdi <[email protected]> --------- Signed-off-by:
Oliver Tale-Yazdi <[email protected]>
-
- Aug 25, 2023
-
-
Alexander Samusev authored
* Add CI for monorepo * fix frame tests * Format features Signed-off-by:
Oliver Tale-Yazdi <[email protected]> * add note for skipping tests and disable test-linux-stable-all * Fix tests and compile issues (#1152) * Fix feature dependant import Signed-off-by:
Oliver Tale-Yazdi <[email protected]> * Bump test timeout Signed-off-by:
Oliver Tale-Yazdi <[email protected]> * Remove feature gate Signed-off-by:
Oliver Tale-Yazdi <[email protected]> * Add resolver 2 Signed-off-by:
Oliver Tale-Yazdi <[email protected]> * Remove old lockfile Signed-off-by:
Oliver Tale-Yazdi <[email protected]> * Format features Signed-off-by:
Oliver Tale-Yazdi <[email protected]> --------- Signed-off-by:
Oliver Tale-Yazdi <[email protected]> * Fix check-dependency-rules Signed-off-by:
Oliver Tale-Yazdi <[email protected]> * rm test-runtime Signed-off-by:
Oliver Tale-Yazdi <[email protected]> * Actually fix script Signed-off-by:
Oliver Tale-Yazdi <[email protected]> * enable cargo-check-each-crate-macos * Run check-each-crate on 6 machines (#1163) --------- Signed-off-by:
Oliver Tale-Yazdi <[email protected]> Co-authored-by:
Oliver Tale-Yazdi <[email protected]>
-
Alexander authored
Signed-off-by:
alvicsam <[email protected]>
-
- Aug 21, 2023
-
-
Marcin S. authored
* PVF worker: random fixes - Fixes possible panic due to non-UTF-8 env vars (https://github.com/paritytech/polkadot/pull/7330#discussion_r1300101716) - Very small refactor of some duplicated code * Don't need `to_str()` for comparison between OsString and str * Check edge cases that can cause env::remove_var to panic In case of a key or value that would cause env::remove_var to panic, we first log a warning and then proceed to attempt to remove the env var. * Make warning message clearer for end users * Backslash was unescaped, but can just remove it from error messages
-
Marcin S. authored
-
- Aug 16, 2023
-
-
Oliver Tale-Yazdi authored
* Fix clippy check Signed-off-by:
Oliver Tale-Yazdi <[email protected]> * Autofix clippy Signed-off-by:
Oliver Tale-Yazdi <[email protected]> * Fix trivial Signed-off-by:
Oliver Tale-Yazdi <[email protected]> * fmt Signed-off-by:
Oliver Tale-Yazdi <[email protected]> * suppress warnings Signed-off-by:
Oliver Tale-Yazdi <[email protected]> * Quiet clippy
😌 Signed-off-by:Oliver Tale-Yazdi <[email protected]> --------- Signed-off-by:
Oliver Tale-Yazdi <[email protected]>
-
- Aug 15, 2023
-
-
Bastian Köcher authored
Remove superflous parameter `overseer_enable_anyways` and make parachain node type more explicit (#7617) * Remove superflous parameter `overseer_enable_anyways` We don't need this flag, as we don't need the overseer enabled when the node isn't a collator or validator. * Rename `IsCollator` to `IsParachainNode` `IsParachainNode` is more expressive and also encapsulates the state of the parachain node being a full node. Some functionality like the overseer needs to run always when the node runs alongside a parachain node. The parachain node needs the overseer to e.g. recover PoVs. Other things like candidate validation or pvf checking are only required for when the node is running as validator. * FMT * Fix CI
-
- Aug 14, 2023
-
-
Oliver Tale-Yazdi authored
* Use same rustfmt.toml as Substrate Signed-off-by:
Oliver Tale-Yazdi <[email protected]> * format format file Signed-off-by:
Oliver Tale-Yazdi <[email protected]> * Format with new config Signed-off-by:
Oliver Tale-Yazdi <[email protected]> * Add Substrate Clippy config Signed-off-by:
Oliver Tale-Yazdi <[email protected]> * Print Clippy version in CI Otherwise its difficult to reproduce locally. Signed-off-by:
Oliver Tale-Yazdi <[email protected]> * Make fmt happy Signed-off-by:
Oliver Tale-Yazdi <[email protected]> * Update node/core/pvf/src/error.rs Co-authored-by:
Tsvetomir Dimitrov <[email protected]> * Update node/core/pvf/src/error.rs Co-authored-by:
Tsvetomir Dimitrov <[email protected]> --------- Signed-off-by:
Oliver Tale-Yazdi <[email protected]> Co-authored-by:
Tsvetomir Dimitrov <[email protected]>
-
jserrat authored
* pvf: use test-utils feature to export test only * adding comment to test-utils feature * make prepare-worker and execute-worker as optional dependencies and add comments to test-utils * remove doc hidden from pvf testing * add prepare worker and execute worker entrypoints to test-utils feature * pvf: add sp_tracing as optional dependency of test-utils * add test-utils for polkadot and malus * add test-utils feature to prepare and execute workers script * remove required features from prepare and executing * Try to trigger CI again to fix broken jobs --------- Co-authored-by:
Marcin S <[email protected]>
-
- Aug 08, 2023
-
-
Marcin S. authored
-
- Aug 04, 2023
-
-
Lulu authored
* Add license to crates This is required to publish to crates.io * Add more licenses
-
- Jul 31, 2023
-
-
Marcin S. authored
* [WIP] PVF: Split out worker binaries * Address compilation problems and re-design a bit * Reorganize once more, fix tests * Reformat with new nightly to make `cargo fmt` test happy * Address `clippy` warnings * Add temporary trace to debug zombienet tests * Fix zombienet node upgrade test * Fix malus and its CI * Fix building worker binaries with malus * More fixes for malus * Remove unneeded cli subcommands * Support placing auxiliary binaries to `/usr/libexec` * Fix spelling * Spelling Co-authored-by:
Marcin S. <[email protected]> * Implement review comments (mostly nits) * Fix worker node version flag * Rework getting the worker paths * Address a couple of review comments * Minor restructuring * Fix CI error * Add tests for worker binaries detection * Improve tests; try to fix CI * Move workers module into separate file * Try to fix failing test and workers not printing latest version - Tests were not finding the worker binaries - Workers were not being rebuilt when the version changed - Made some errors easier to read * Make a bunch of fixes * Rebuild nodes on version change * Fix more issues * Fix tests * Pass node version from node into dependencies to avoid recompiles - [X] get version in CLI - [X] pass it in to service - [X] pass version along to PVF - [X] remove rerun from service - [X] add rerun to CLI - [X] don’t rerun pvf/worker’s (these should be built by nodes which have rerun enabled) * Some more improvements for smoother tests - [X] Fix tests - [X] Make puppet workers pass None for version and remove rerun - [X] Make test collators self-contained * Add back rerun to PVF workers * Move worker binaries into files in cli crate As a final optimization I've separated out each worker binary from its own crate into the CLI crate. Before, the worker bin shared a crate with the worker lib, so when the binaries got recompiled so did the libs and everything transitively depending on the libs. This commit fixes this regression that was causing recompiles after every commit. * Fix bug (was passing worker version for node version) * Move workers out of cli into root src/bin/ dir - [X] Pass in node version from top-level (polkadot) - [X] Add build.rs with rerun-git-head to root dir * Add some sanity checks for workers to dockerfiles * Update malus + [X] Make it self-contained + [X] Undo multiple binary changes * Try to fix clippy errors * Address `cargo run` issue - [X] Add default-run for polkadot - [X] Add note about installation to error * Update readme (installation instructions) * Allow disabling external workers for local/testing setups + [X] cli flag to enable single-binary mode + [X] Add message to error * Revert unnecessary Cargo.lock changes * Remove unnecessary build scripts from collators * Add back missing malus commands (should fix failing ZN job) * Some minor fixes * Update Cargo.lock * Fix some build errors * Undo self-contained binaries; cli flag to disable version check + [X] Remove --dont-run-external-workers + [X] Add --disable-worker-version-check + [X] Remove PVF subcommands + [X] Redo malus changes * Try to fix failing job and add some docs for local tests --------- Co-authored-by:
Dmitry Sinyavin <[email protected]> Co-authored-by:
s0me0ne-unkn0wn <[email protected]> Co-authored-by: parity-processbot <>
-
- Jul 22, 2023
-
-
jserrat authored
* add tests to worker common thread * fix formatting * move worker commons unit test from integration tests to worker file and do some improvements * fix import on it/worker_common * move worker commons unit test to test module * cargo fmt * move cpu_time_monitor_loop to test outside of thread module * change worker thread unit test to use assert_eq * fix formatting * adding new methods to WaitOucome, fix pvf worker unit test * fix formatting * remove is_finished and is_timeout methods from WaitOutcome * fix wait_for_threads_with_timeout_returns_outcome test * ".git/.scripts/commands/fmt/fmt.sh" * add common worker cond_notify_on_done_should_update_wait_outcome_when_panic test --------- Co-authored-by:
Marcin S <[email protected]> Co-authored-by: command-bot <>
-
- Jul 19, 2023
-
-
Francisco Aguirre authored
* Add polkadot XCM benchmarks * Add temp * ".git/.scripts/commands/bench/bench.sh" xcm polkadot pallet_xcm_benchmarks::fungible * ".git/.scripts/commands/bench/bench.sh" xcm polkadot pallet_xcm_benchmarks::generic * Add weights to XCM on Polkadot * Make CI fail on old files Signed-off-by:
Oliver Tale-Yazdi <[email protected]> * Update template Signed-off-by:
Oliver Tale-Yazdi <[email protected]> * Add reserve_asset_deposited benchmark * ".git/.scripts/commands/bench/bench.sh" xcm kusama pallet_xcm_benchmarks::generic * Update weights Signed-off-by:
Oliver Tale-Yazdi <[email protected]> * Change initiate_reserve_deposit in runtime weights * Update weights Signed-off-by:
Oliver Tale-Yazdi <[email protected]> * Remove trusted reserves from runtimes * Fix pallet-xcm-benchmarks mock * Fix test * Change pallet xcm weigher in kusama * Fix * Remove merge conflict artifact * Remove initiate_reserve_withdraw from generic benchmarks * Add missing implementation to XCM benchmark * Fix failing karura test * Remove dbg! Co-authored-by:
Keith Yeung <[email protected]> * Fix fmt * Revert "Fix fmt" This reverts commit 676f2d8db07d7427750c79f95494d4988d06fda5. * Fix fmt * Remove duplicated template code * Add back part of the template * ".git/.scripts/commands/bench-vm/bench-vm.sh" xcm polkadot pallet_xcm_benchmarks::fungible * Don't skip reserve asset deposited benchmark * Remove call to non-generated benchmark yet * Underscore unused parameter * Skip not supported benchmarks and hardcode value * Remove ReserveAssetDeposited benchmark * ".git/.scripts/commands/bench-vm/bench-vm.sh" xcm polkadot pallet_xcm_benchmarks::fungible * Add back ReserveAssetDeposited * ".git/.scripts/commands/bench-vm/bench-vm.sh" xcm polkadot pallet_xcm_benchmarks::fungible * Use default benchmark for ReserveAssetDeposited * Add missing parameter * Revert reserve asset deposited benchmark * ".git/.scripts/commands/bench-vm/bench-vm.sh" xcm kusama pallet_xcm_benchmarks::fungible * ".git/.scripts/commands/bench-vm/bench-vm.sh" xcm westend pallet_xcm_benchmarks::fungible * ".git/.scripts/commands/bench/bench.sh" xcm rococo pallet_xcm_benchmarks::fungible * Add 'real' benchmarks * Add TrustedReserve to actual XcmConfig * Add TrustedReserve to actual XcmConfig (fix) * Whitelist from benchmarking XCM storage keys read each block (#6871) * Whitelist from benchmarking XCM storage keys read each block * ".git/.scripts/commands/bench/bench.sh" runtime polkadot pallet_xcm * ".git/.scripts/commands/bench/bench.sh" runtime polkadot pallet_xcm * ".git/.scripts/commands/bench/bench.sh" runtime westend pallet_xcm * ".git/.scripts/commands/bench/bench.sh" runtime rococo pallet_xcm * Remove XcmPallet SupportedVersion from the benchmark whitelist * ".git/.scripts/commands/bench/bench.sh" runtime polkadot pallet_xcm * ".git/.scripts/commands/bench/bench.sh" runtime kusama pallet_xcm * ".git/.scripts/commands/bench/bench.sh" runtime westend pallet_xcm * ".git/.scripts/commands/bench/bench.sh" runtime rococo pallet_xcm * WIP * Add necessary traits, remove unnecessary whitelisted keys * Fix tests * Remove unused file * Remove unused import --------- Co-authored-by: command-bot <> * ".git/.scripts/commands/bench/bench.sh" xcm kusama pallet_xcm_benchmarks::fungible * ".git/.scripts/commands/bench/bench.sh" xcm kusama pallet_xcm_benchmarks::fungible * ".git/.scripts/commands/bench/bench.sh" xcm kusama pallet_xcm_benchmarks::fungible * ".git/.scripts/commands/bench/bench.sh" xcm rococo pallet_xcm_benchmarks::fungible * ".git/.scripts/commands/bench/bench.sh" xcm westend pallet_xcm_benchmarks::fungible * Fix spellchecker issues * Remove unused migration code --------- Signed-off-by:
Oliver Tale-Yazdi <[email protected]> Co-authored-by: command-bot <> Co-authored-by:
Oliver Tale-Yazdi <[email protected]> Co-authored-by:
Keith Yeung <[email protected]>
-
- Jul 06, 2023
-
-
s0me0ne-unkn0wn authored
* Introduce `ci-only-tests` feature * Add comment
-