Skip to content
Snippets Groups Projects
  1. Mar 15, 2025
  2. Mar 14, 2025
  3. Mar 13, 2025
    • tmpolaczyk's avatar
      Remove clones from block seal function (#7917) · 363bd6bd
      tmpolaczyk authored
      Shouldn't matter much, but this is run on every produced block so free
      performance
      363bd6bd
    • PG Herveou's avatar
      [pallet-revive] precompiles 2->9 (#7810) · 4c74a109
      PG Herveou authored
      
      Add missing pre-compiles 02 -> 09
      
      [weights
      changes](https://weights.tasty.limo/compare?repo=polkadot-sdk&threshold=10&path_pattern=substrate%2Fframe%2F**%2Fsrc%2Fweights.rs%2Cpolkadot%2Fruntime%2F*%2Fsrc%2Fweights%2F**%2F*.rs%2Cpolkadot%2Fbridges%2Fmodules%2F*%2Fsrc%2Fweights.rs%2Ccumulus%2F**%2Fweights%2F*.rs%2Ccumulus%2F**%2Fweights%2Fxcm%2F*.rs%2Ccumulus%2F**%2Fsrc%2Fweights.rs&method=asymptotic&ignore_errors=true&unit=time&old=master&new=pg%2Fprecompiles02_09&pallet=revive)
      
      ---------
      
      Co-authored-by: default avatarcmd[bot] <41898282+github-actions[bot]@users.noreply.github.com>
      4c74a109
    • Francisco Aguirre's avatar
      Use non-native token to benchmark xcm on asset hub (#7893) · c4b8ec12
      Francisco Aguirre authored
      
      Asset Hub was using the native token for benchmarking xcm instructions.
      This is not the best since it's cheaper than using something in
      `pallet-assets` for example.
      Had to remove some restrictive checks from `pallet-xcm-benchmarks`.
      
      I'll bring back the checks with a better framework in the future that
      allows for handling multiple assets (`fungibles::*` traits).
      
      ---------
      
      Co-authored-by: default avatarcmd[bot] <41898282+github-actions[bot]@users.noreply.github.com>
      c4b8ec12
    • Javier Viola's avatar
      [CI] bump timeout wait for build in zombienet workflows. (#7871) · 425d6188
      Javier Viola authored
      
      Set timeout to 60mins. Prevent failures like this one
      https://github.com/paritytech/polkadot-sdk/actions/runs/13651327605/job/38160444244?pr=7790
      
      
      Thanks!
      
      ---------
      
      Co-authored-by: default avatarBastian Köcher <git@kchr.de>
      425d6188
    • Iulian Barbu's avatar
      taplo: split long array line to multiline array (#7905) · d4155b6c
      Iulian Barbu authored
      
      # Description
      
      It is difficult to spot changes to umbrella features when reviewing,
      when defined on a long line, so made sure tomls formatting will be
      applied to long array lines by splitting them on multiple lines. This
      will be applied to any tomls in the monorepo that is not excluded from
      taplo.
      
      ## Integration
      
      N/A
      
      ## Review Notes
      
      Set global taplo config `array_auto_expand` to true.
      
      ---------
      
      Signed-off-by: default avatarIulian Barbu <iulian.barbu@parity.io>
      d4155b6c
    • PG Herveou's avatar
      [pallet-revive] fixture as dev dep (#7844) · 8265c65f
      PG Herveou authored
      
      Update pallet-revive-fixtures so that it can build without looking up
      dependencies from the workspace
      
      ---------
      
      Co-authored-by: default avatarcmd[bot] <41898282+github-actions[bot]@users.noreply.github.com>
      8265c65f
    • Alexandru Vasile's avatar
      notifications/libp2p: Punish notification protocol misbehavior on outbound substreams (#7781) · aa67d2ae
      Alexandru Vasile authored
      
      This PR punishes behaviors that deviate from the notification spec. When
      a peer misbehaves by writing data on an unidirectional read stream, the
      peer is banned and disconnected immediately.
      
      In this PR:
      - The `NotificationOutError` is enriched with termination reason and
      made publically available for higher levels
      - The protocol misbehavior is propagated through the `CloseDesired`
      events
      - The network behavior of the protocol is responsible for banning the
      peer.
      - The peer is banned immediately and, as a result, the reputation system
      disconnects the malicious / misbehaving peer
      - Logs are enriched with protocol names
      
      Closes: https://github.com/paritytech/polkadot-sdk/issues/7722
      
      
      cc @paritytech/networking
      
      ---------
      
      Signed-off-by: default avatarAlexandru Vasile <alexandru.vasile@parity.io>
      Co-authored-by: default avatarBastian Köcher <git@kchr.de>
      aa67d2ae
    • Egor_P's avatar
    • Matteo Muraca's avatar
      Remove `pallet::getter` usage from bridges/modules (#7120) · 66e3196a
      Matteo Muraca authored
      
      # Description
      
      Part of #3326 
      
      As per title, the `pallet:getter` usage has been removed from:
      - `pallet-bridge-beefy`
      - `pallet-bridge-grandpa`
      - `pallet-bridge-messages`
      - `pallet-bridge-relayers`
      - `pallet-xcm-bridge-hub-router`
      
      
      polkadot address: 12poSUQPtcF1HUPQGY3zZu2P8emuW9YnsPduA4XG3oCEfJVp
      
      ---------
      
      Co-authored-by: default avatarBranislav Kontur <bkontur@gmail.com>
      Co-authored-by: default avatarcmd[bot] <41898282+github-actions[bot]@users.noreply.github.com>
      66e3196a
    • PG Herveou's avatar
      [pallet-revive] Support blocktag in eth_getLogs RPC (#7879) · ab7c6080
      PG Herveou authored
      
      Support "latest" blocktag in ethGetLogs from_block and to_block
      parameters
      This is not in specs
      (https://github.com/ethereum/execution-apis/blob/main/src/schemas/filter.yaml#L17)
      
      but defined and used by 3rd parties and in some other reference docs 
      
      See 
      
      https://docs.metamask.io/services/reference/ethereum/json-rpc-methods/eth_getlogs/
      
      ---------
      
      Co-authored-by: default avatarcmd[bot] <41898282+github-actions[bot]@users.noreply.github.com>
      ab7c6080
    • thiolliere's avatar
      Improve error message in benchmark macro (#7873) · a71a701c
      thiolliere authored
      
      giving the wrong origin in `extrinsic_call` would result in:
      ```
         |
      43 | #[benchmarks]
         | ^^^^^^^^^^^^^
         | |
         | expected associated type, found `Result<RawOrigin<...>, ...>`
         | arguments to this function are incorrect
         |
         = note: expected associated type `<T as frame_system::Config>::RuntimeOrigin`
                               found enum `Result<RawOrigin<<T as frame_system::Config>::AccountId>, <T as frame_system::Config>::RuntimeOrigin>`
      note: method defined here
        --> $WORKSPACE/substrate/frame/support/src/traits/dispatch.rs
         |
         |     fn dispatch_bypass_filter(self, origin: Self::RuntimeOrigin) -> DispatchResultWithPostInfo;
         |        ^^^^^^^^^^^^^^^^^^^^^^
         = note: this error originates in the attribute macro `benchmarks` (in Nightly builds, run with -Z macro-backtrace for more info)
      ```
      
      Now it results in an error message with good span.
      
      ---------
      
      Co-authored-by: default avatarcmd[bot] <41898282+github-actions[bot]@users.noreply.github.com>
      a71a701c
    • ordian's avatar
      staking: add `manual_slash` extrinsic (#7805) · f8c90b2a
      ordian authored
      This PR adds a convenience extrinsic `manual_slash` for the governance
      to slash a validator manually.
      
      ## Changes
      
      * The `on_offence` implementation for the Staking pallet accepts a slice
      of `OffenceDetails` including the full validator exposure, however, it
      simply
      [ignores](https://github.com/paritytech/polkadot-sdk/blob/c8d33396
      
      /substrate/frame/staking/src/pallet/impls.rs#L1864)
      that part. I've extracted the functionality into an inherent
      `on_offence` method that takes `OffenceDetails` without the full
      exposure and this is called directly in `manual_slash`
      * `manual_slash` creates an offence for a validator with a given slash
      percentange
      
      ## Questions
      
      - [x] should `manual_slash` accept session instead of an era when the
      validator was in the active set? staking thinks in terms of eras and we
      can check out of bounds this way, which is why it was chosen for this
      implementation, but if there are arguments against, happy to change to
      session index
      - [X] should the accepted origin be something more than just root?
      Changed to `T::AdminOrigin` to align with `cancel_deferred_slash`
      - [X] should I adapt this PR also against
      https://github.com/paritytech/polkadot-sdk/pull/6996? looking at the
      changes, it should apply mostly without conflicts
      
      ---------
      
      Co-authored-by: default avatarTsvetomir Dimitrov <tsvetomir@parity.io>
      Co-authored-by: default avatarAnkan <10196091+Ank4n@users.noreply.github.com>
      f8c90b2a
  4. Mar 12, 2025
  5. Mar 11, 2025