Skip to content
  1. Sep 14, 2023
    • Branislav Kontur's avatar
      [xcm_builder]: Do not consume `msg` on `NotApplicable` for remote exporters (#1519) · 76724ce9
      Branislav Kontur authored 
      ## Summary

Implementations of `SendXcm`'s `validate` should not consume `dest`
and/or `msg` parameters in case of `NotApplicable` error.
This commit aligns expected behavior for `UnpaidRemoteExporter` and
`SovereignPaidRemoteExporter`.

## Testing

Added `remote_exporters_does_not_consume_dest_or_msg_on_not_applicable`
test which checks two possible cases:
- `dest` is local
- no configured exporter for `dest`
      76724ce9
  3. Sep 01, 2023
  5. Aug 31, 2023
  7. Aug 30, 2023
  9. Aug 29, 2023
  11. Aug 22, 2023
  13. Aug 19, 2023
    • Francisco Aguirre's avatar
      Add tests for PayOverXcm (#7319) · 85115402
      Francisco Aguirre authored 
      * PayOverXcm: Add test skeleton

* PayOverXcm: Add tests checking PayOverXcm generates correct message

* Add PayOverXcm and salary pallet integration test

* Fix XCM execution issue

* Fix documentation issues

* Add missing period at the end of comment

* Fix mock problems

* Add missing licenses

* Fix lints

* Fix more lints

* Add docs to mock

* Add transfer assertions

* Remove magic numbers

---------

Co-authored-by: parity-processbot <>
      85115402
  15. Aug 16, 2023
  17. Aug 14, 2023
  19. Aug 07, 2023
  21. Aug 03, 2023
  23. Aug 01, 2023
  25. Jul 19, 2023
    • Francisco Aguirre's avatar
      Change Fixed to WeightInfoBounds for Polkadot (#7077) · cc9f8129
      Francisco Aguirre authored 
      

* Add polkadot XCM benchmarks

* Add temp

* ".git/.scripts/commands/bench/bench.sh" xcm polkadot pallet_xcm_benchmarks::fungible

* ".git/.scripts/commands/bench/bench.sh" xcm polkadot pallet_xcm_benchmarks::generic

* Add weights to XCM on Polkadot

* Make CI fail on old files

Signed-off-by: default avatarOliver Tale-Yazdi <[email protected]>

* Update template

Signed-off-by: default avatarOliver Tale-Yazdi <[email protected]>

* Add reserve_asset_deposited benchmark

* ".git/.scripts/commands/bench/bench.sh" xcm kusama pallet_xcm_benchmarks::generic

* Update weights

Signed-off-by: default avatarOliver Tale-Yazdi <[email protected]>

* Change initiate_reserve_deposit in runtime weights

* Update weights

Signed-off-by: default avatarOliver Tale-Yazdi <[email protected]>

* Remove trusted reserves from runtimes

* Fix pallet-xcm-benchmarks mock

* Fix test

* Change pallet xcm weigher in kusama

* Fix

* Remove merge conflict artifact

* Remove initiate_reserve_withdraw from generic benchmarks

* Add missing implementation to XCM benchmark

* Fix failing karura test

* Remove dbg!

Co-authored-by: default avatarKeith Yeung <[email protected]>

* Fix fmt

* Revert "Fix fmt"

This reverts commit 676f2d8db07d7427750c79f95494d4988d06fda5.

* Fix fmt

* Remove duplicated template code

* Add back part of the template

* ".git/.scripts/commands/bench-vm/bench-vm.sh" xcm polkadot pallet_xcm_benchmarks::fungible

* Don't skip reserve asset deposited benchmark

* Remove call to non-generated benchmark yet

* Underscore unused parameter

* Skip not supported benchmarks and hardcode value

* Remove ReserveAssetDeposited benchmark

* ".git/.scripts/commands/bench-vm/bench-vm.sh" xcm polkadot pallet_xcm_benchmarks::fungible

* Add back ReserveAssetDeposited

* ".git/.scripts/commands/bench-vm/bench-vm.sh" xcm polkadot pallet_xcm_benchmarks::fungible

* Use default benchmark for ReserveAssetDeposited

* Add missing parameter

* Revert reserve asset deposited benchmark

* ".git/.scripts/commands/bench-vm/bench-vm.sh" xcm kusama pallet_xcm_benchmarks::fungible

* ".git/.scripts/commands/bench-vm/bench-vm.sh" xcm westend pallet_xcm_benchmarks::fungible

* ".git/.scripts/commands/bench/bench.sh" xcm rococo pallet_xcm_benchmarks::fungible

* Add 'real' benchmarks

* Add TrustedReserve to actual XcmConfig

* Add TrustedReserve to actual XcmConfig (fix)

* Whitelist from benchmarking XCM storage keys read each block (#6871)

* Whitelist from benchmarking XCM storage keys read each block

* ".git/.scripts/commands/bench/bench.sh" runtime polkadot pallet_xcm

* ".git/.scripts/commands/bench/bench.sh" runtime polkadot pallet_xcm

* ".git/.scripts/commands/bench/bench.sh" runtime westend pallet_xcm

* ".git/.scripts/commands/bench/bench.sh" runtime rococo pallet_xcm

* Remove XcmPallet SupportedVersion from the benchmark whitelist

* ".git/.scripts/commands/bench/bench.sh" runtime polkadot pallet_xcm

* ".git/.scripts/commands/bench/bench.sh" runtime kusama pallet_xcm

* ".git/.scripts/commands/bench/bench.sh" runtime westend pallet_xcm

* ".git/.scripts/commands/bench/bench.sh" runtime rococo pallet_xcm

* WIP

* Add necessary traits, remove unnecessary whitelisted keys

* Fix tests

* Remove unused file

* Remove unused import

---------

Co-authored-by: command-bot <>

* ".git/.scripts/commands/bench/bench.sh" xcm kusama pallet_xcm_benchmarks::fungible

* ".git/.scripts/commands/bench/bench.sh" xcm kusama pallet_xcm_benchmarks::fungible

* ".git/.scripts/commands/bench/bench.sh" xcm kusama pallet_xcm_benchmarks::fungible

* ".git/.scripts/commands/bench/bench.sh" xcm rococo pallet_xcm_benchmarks::fungible

* ".git/.scripts/commands/bench/bench.sh" xcm westend pallet_xcm_benchmarks::fungible

* Fix spellchecker issues

* Remove unused migration code

---------

Signed-off-by: default avatarOliver Tale-Yazdi <[email protected]>
Co-authored-by: command-bot <>
Co-authored-by: default avatarOliver Tale-Yazdi <[email protected]>
Co-authored-by: default avatarKeith Yeung <[email protected]>
      cc9f8129
  27. Jul 18, 2023
  29. Jul 03, 2023
  31. Jun 30, 2023
  33. Jun 28, 2023
    • Gabriel Facco de Arruda's avatar
      Introduce Tinkernet multisig XCM configs to Kusama/Rococo through xcm-builder (#7165) · af995205
      Gabriel Facco de Arruda authored 
      * Introduce Tinkernet multisig XCM configs

* fmt fix

* overflow handling, comments, clippy fixes

* Adding Tinkernet XCM configs to xcm-builder

* switching spaces to tab

* remove derivation.rs in favor of location_conversion.rs

* replace hardcoded literals with constants

* autoformat

* Fix for the unit test

* replacing expect with an error and renaming constants

* Resolving clippy warning

---------

Co-authored-by: parity-processbot <>
      af995205
  35. Jun 05, 2023
    • Keith Yeung's avatar
      Implement AliasOrigin processing in XCVM (#7245) · f2fe05a7
      Keith Yeung authored 
      

* Implement AliasOrigin processing in XCVM

* add builder types and first test

* switch to more general builder types

* clone target for RemovePrefixAccountId32

* change builder types

* change AliasForeignAccountId32 and add test for AliasCase

* add Aliasers type to xcm configs

* add benchmark

* benchmark fix

* add benchmark function for runtimes

* fix alias_origin result types

* fix benchmark test

* add runtime-benchmarks feature in pallet-xcm-benchmarks

* fmt

* remove AliasCase, add test and fmt

* address feedback

* ".git/.scripts/commands/bench/bench.sh" xcm kusama pallet_xcm_benchmarks::generic

* ".git/.scripts/commands/bench/bench.sh" xcm westend pallet_xcm_benchmarks::generic

* ".git/.scripts/commands/bench/bench.sh" xcm rococo pallet_xcm_benchmarks::generic

* address feedback

* lock

* ".git/.scripts/commands/bench/bench.sh" xcm kusama pallet_xcm_benchmarks::generic

* ".git/.scripts/commands/bench/bench.sh" xcm westend pallet_xcm_benchmarks::generic

* ".git/.scripts/commands/bench/bench.sh" xcm rococo pallet_xcm_benchmarks::generic

* change doc

* fmt

---------

Co-authored-by: default avatarJust van Stam <[email protected]>
Co-authored-by: default avatarJust van Stam <[email protected]>
Co-authored-by: command-bot <>
      f2fe05a7
    • Gavin Wood's avatar
      XCM: Remove & replace XCM `Convert` trait (#7329) · c8f9b1b7
      Gavin Wood authored 
      

* Introduce an extensible location-to-hash-account

* Convert becomes RevFallRefConvert

* Use ConvertLocation trait

* Remove Convert usage

* Builds

* Fix warnings

* Remove unused types

* Bump lock

* No need for aliasing

* Remove unused

* Deprecate legacy conversion

* Fixes

* Fixes

* Update Cargo.toml

Co-authored-by: default avatarMuharem Ismailov <[email protected]>

* Update xcm/xcm-builder/src/location_conversion.rs

Co-authored-by: default avatarLiam Aharon <[email protected]>

* Update xcm/xcm-builder/src/location_conversion.rs

Co-authored-by: default avatarLiam Aharon <[email protected]>

* Update xcm/xcm-builder/src/location_conversion.rs

Co-authored-by: default avatarLiam Aharon <[email protected]>

* Update xcm/xcm-builder/src/location_conversion.rs

Co-authored-by: default avatarLiam Aharon <[email protected]>

* Update xcm/xcm-builder/src/location_conversion.rs

Co-authored-by: default avatarLiam Aharon <[email protected]>

* Update xcm/xcm-builder/src/location_conversion.rs

Co-authored-by: default avatarLiam Aharon <[email protected]>

---------

Co-authored-by: default avatarMuharem Ismailov <[email protected]>
Co-authored-by: default avatarLiam Aharon <[email protected]>
      c8f9b1b7
    • Muharem Ismailov's avatar
      descend first (#7327) · 429b1e4d
      Muharem Ismailov authored
      429b1e4d
  37. Jun 02, 2023
  39. May 31, 2023
    • Francisco Aguirre's avatar
      XCM: PayOverXcm config (#6900) · a0e2aaad
      Francisco Aguirre authored 
      

* Move XCM query functionality to trait

* Fix tests

* Add PayOverXcm implementation

* fix the PayOverXcm trait to compile

* moved doc comment out of trait implmeentation and to the trait

* PayOverXCM documentation

* Change documentation a bit

* Added empty benchmark methods implementation and changed docs

* update PayOverXCM to convert AccountIds to MultiLocations

* Implement benchmarking method

* Change v3 to latest

* Descend origin to an asset sender (#6970)

* descend origin to an asset sender

* sender as tuple of dest and sender

* Add more variants to the QueryResponseStatus enum

* Change Beneficiary to Into<[u8; 32]>

* update PayOverXcm to return concrete errors and use AccountId as sender

* use polkadot-primitives for AccountId

* fix dependency to use polkadot-core-primitives

* force Unpaid instruction to the top of the instructions list

* modify report_outcome to accept interior argument

* use new_query directly for building final xcm query, instead of report_outcome

* fix usage of new_query to use the XcmQueryHandler

* fix usage of new_query to use the XcmQueryHandler

* tiny method calling fix

* xcm query handler (#7198)

* drop redundant query status

* rename ReportQueryStatus to OuterQueryStatus

* revert rename of QueryResponseStatus

* update mapping

* Update xcm/xcm-builder/src/pay.rs

Co-authored-by: default avatarGavin Wood <[email protected]>

* Updates

* Docs

* Fix benchmarking stuff

* Destination can be determined based on asset_kind

* Tweaking API to minimise clones

* Some repotting and docs

---------

Co-authored-by: default avatarAnthony Alaribe <[email protected]>
Co-authored-by: default avatarMuharem Ismailov <[email protected]>
Co-authored-by: default avatarAnthony Alaribe <[email protected]>
Co-authored-by: default avatarGavin Wood <[email protected]>
      a0e2aaad
  41. May 26, 2023
  43. May 25, 2023
    • Michal Kucharczyk's avatar
      xcm-builder: remove clone for clippy (#7291) · 6efbc1a4
      Michal Kucharczyk authored 
      fix for:
```
error: using `clone` on type `[u8; 32]` which implements the `Copy`
trait
  --> xcm/xcm-builder/src/routing.rs:44:28
   |
44 |             message.0.push(SetTopic(unique_id.clone()));
   |                                     ^^^^^^^^^^^^^^^^^ help: try
removing the `clone` call: `unique_id`
   |
   = help: for further information visit
https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy
   = note: `-D clippy::clone-on-copy` implied by `-D clippy::complexity`
```
      6efbc1a4
    • Gavin Wood's avatar
      XCM: Tools for uniquely referencing messages (#7234) · 85dfadff
      Gavin Wood authored 
      

* Tools for unique topic references

* Formatting

* Naming

* Repot into routing.rs.

* More things done

* Universal Exporter supports topic-as-reference

* Some tests for the topic routing

* More tests

* Paid bridge tests

* Add message ID to sending events

* Formatting

* fix and integrate into test nets

* Move DenyThenTry and friend from Cumulus

* Append SetTopic rather than prepend

* Docs

* Docs

* Work with new ProcessMessage ID API

* Formatting

* Fix build

* Fixes

* Formatting

* Update xcm/xcm-builder/src/barriers.rs

Co-authored-by: default avatarFrancisco Aguirre <[email protected]>

* Update xcm/xcm-builder/src/routing.rs

Co-authored-by: default avatarFrancisco Aguirre <[email protected]>

* Docs

* Rename message_hash

* Formatting

* ".git/.scripts/commands/fmt/fmt.sh"

* Rename

* Another Rename

* ".git/.scripts/commands/fmt/fmt.sh"

* ".git/.scripts/commands/fmt/fmt.sh"

* Update xcm/xcm-builder/src/routing.rs

Co-authored-by: default avatarKeith Yeung <[email protected]>

---------

Co-authored-by: default avatarFrancisco Aguirre <[email protected]>
Co-authored-by: command-bot <>
Co-authored-by: default avatarKeith Yeung <[email protected]>
      85dfadff
  45. May 21, 2023
  47. May 19, 2023
  49. May 17, 2023
  51. May 16, 2023
  53. May 15, 2023
  55. May 02, 2023
  57. Apr 27, 2023
    • Keith Yeung's avatar
      XCM: Implement a blocking barrier (#7098) · d20e3c11
      Keith Yeung authored 
      * Move XCM matcher to xcm-builder

* Use ProcessMessageError as the error type in MatchXcm and ShouldExecute

* Implement a blocking barrier

* Fixes

* Add benchmarking for force_suspension

* ".git/.scripts/commands/bench/bench.sh" runtime westend pallet_xcm

* ".git/.scripts/commands/bench/bench.sh" runtime rococo pallet_xcm

* ".git/.scripts/commands/bench/bench.sh" runtime kusama pallet_xcm

* ".git/.scripts/commands/bench/bench.sh" runtime polkadot pallet_xcm

* ".git/.scripts/commands/bench/bench.sh" runtime westend pallet_xcm

* ".git/.scripts/commands/bench/bench.sh" runtime rococo pallet_xcm

---------

Co-authored-by: command-bot <>
      d20e3c11
  59. Apr 24, 2023
    • Frederik Gartenmeister's avatar
      XCM: Remote account converter (#6662) · 3f3a0416
      Frederik Gartenmeister authored 
      * Draft remote account converter

* Tests and doc comments

* Adapt naming, tests fix

* Try with prefix in account

* Revert "Try with prefix in account"

This reverts commit 461759794cc9f59f768aad0e0899df6dc8cba747.

* Adapt code and test to review suggestions

* adapt to take into account parent in conversion

* fix: docs

* fix: try doc fix v2
      3f3a0416
  61. Apr 18, 2023
  63. Apr 17, 2023