Skip to content
  1. Apr 07, 2020
    • Web3 Philosopher's avatar
      sc-consensus-manual-seal uses Finalizer trait for finalization instead of Backend. (#5469) · 6a87e1d1
      Web3 Philosopher authored
      
      
      * manual-seal uses Finalizer trait for finalization instead of Backend
      
      * fix tests
      
      * use Transaction type
      
      * refactor import_queue
      
      * ugh
      
      * line-width
      
      * Update client/consensus/manual-seal/src/lib.rs
      
      Co-Authored-By: default avatarJoshy Orndorff <[email protected]>
      
      * fix tests
      
      * update docs
      
      * Update client/consensus/manual-seal/src/seal_new_block.rs
      
      Co-Authored-By: default avatarAndré Silva <[email protected]>
      
      * Don't auto-finalize on verification
      
      * Explicity don't finalize on import.
      
      Co-authored-by: default avatarJoshy Orndorff <[email protected]>
      Co-authored-by: default avatarJoshy Orndorff <[email protected]>
      Co-authored-by: default avatarAndré Silva <[email protected]>
      6a87e1d1
    • Bastian Köcher's avatar
      Fix compilation of service metrics on Windows (#5548) · f202c58b
      Bastian Köcher authored
      * Fix compilation of service metrics on Windows
      
      * Fix browser node
      
      * Ahh
      
      * Remove duplicate code...
      f202c58b
    • Gavin Wood's avatar
      More emoji (#5556) · 0253793d
      Gavin Wood authored
      0253793d
    • Cecile Tonglet's avatar
      CLI: refactoring: remove Options from sc_service::Configuration's fields (#5271) · 3da069e3
      Cecile Tonglet authored
      * WIP
      
      Forked at: d6aa8e95
      Parent branch: origin/master
      
      * Rename IntoConfiguration to CliConfiguration
      
      * Renamed into_configuration to create_configuration
      
      * WIP
      
      Forked at: d6aa8e95
      Parent branch: origin/master
      
      * WIP
      
      Forked at: d6aa8e95
      Parent branch: origin/master
      
      * Move keystore params to its own module
      
      * Use in-memory keystore even for build-spec
      
      * Enforce proper value for node name
      
      * dev_key_seed
      
      * Telemetry endpoints
      
      * rustfmt
      
      * Converted all RunCmd
      
      * rustfmt
      
      * Added export-blocks
      
      * Missed something
      
      * Removed config_path in NetworkConfiguration (not used)
      
      * Fixed warnings
      
      * public_addresses is used but never set, keeping it
      
      * Merge Configuration.node and NetworkConfiguration.node_name
      
      ...because they are the same thing
      
      * Added: import-blocks
      
      * Adding a proc_macro to help impl SubstrateCli
      
      * WIP
      
      Forked at: d6aa8e95
      Parent branch: origin/master
      
      * WIP
      
      Forked at: d6aa8e95
      Parent branch: origin/master
      
      * WIP
      
      Forked at: d6aa8e95
      Parent branch: origin/master
      
      * Re-export spec_factory from sc_cli
      
      * Re-added all the commands
      
      * Refactored node_key_params
      
      * Fixed previous refucktoring
      
      * Clean-up and removed full_version()
      
      * Renamed get_is_dev to not confuse with Configuration field
      
      * Fixed sc-cli-derive example
      
      * Fixing tests
      
      * Fixing tests and removing some (will re-add later)
      
      * Fixing more tests
      
      * Removes the need of type parameter
      
      * Converting bin/node and simplifying API
      
      * Converting more
      
      * Converting last command
      
      * WIP
      
      Forked at: d6aa8e95
      
      
      Parent branch: origin/master
      
      * Fixing tests and added default for WasmExecutionMethod
      
      * Fixing stuff
      
      * Fixed something I broke oops
      
      * Update Cargo.lock
      
      * Moving things around
      
      * Convert everything to Result
      
      * Added new macros to simplify the impl of CliConfiguration
      
      * Added a macro to generate CliConfiguration automatically for subcommands
      
      * Revert... too many macros (this one is not really useful)
      
      This reverts commit 9c516dd38b40fbc420b02c1f8e61d5b2b1a4e434.
      
      * Renamed is_dev to get_is_dev
      
      Good enough for now
      
      * Fixed name roles (this is plural, not singular)
      
      * Clean-up
      
      * Re-export NodeKeyConfig and TelemetryEndpoints from sc_service
      
      * Improve styling/formatting
      
      * Added copyrights
      
      * Added doc and fixed warnings
      
      * Added myself to code owners
      
      * Yes it is needed according to the history
      
      * Revert formatting
      
      * Fixing conflict
      
      * Updated build.rs
      
      * Cargo.lock
      
      * Clean-up
      
      * Update client/cli-derive/Cargo.toml
      
      Co-Authored-By: default avatarSeun Lanlege <[email protected]>
      
      * Fail if using proc_macro and build.rs is not set properly
      
      * Dropped all get_ in front of methods
      
      * Clean-up
      
      * Fixing proc macro missing env var
      
      * Get the configuration inside the Runtime (needed for polkadot)
      
      * Clean-up
      
      * Get is_dev from argument like the others
      
      * Get chain ID instead of chain spec from shared params
      
      * &self is passed to spec_factory/load_spec
      
      * Wrong text
      
      * Fix example
      
      * Officialize macro and made a cool doc
      
      * Renamed spec_factory to load_spec (substrate_cli_configuration)
      
      * Removed not so useful ChainSpec
      
      * Renamed SubstrateCLI to SubstrateCli
      
      * Added changelog for impl_version being full now
      
      * Renamed Runtime to Runner
      
      * Update changelog to show example
      
      * Removed option on database cache size
      
      * WIP
      
      Forked at: d6aa8e95
      Parent branch: origin/master
      
      * Fix on removal of option
      
      * typo
      
      * Clean-up imports
      
      * Added info in Cargo.toml
      
      * typo
      
      * remarks
      
      * Moved function for build.rs to substrate-build-script-utils
      
      * Fixed example & test of cli-derive
      
      * Moved function for build.rs to substrate-build-script-utils
      
      * Renamed substrate_cli_configuration to substrate_cli oops
      
      It implements SubstrateCli not CliConfiguration!
      
      * Added documentation and wrapper macro
      
      * Removed option on database cache size
      
      * Removed option on database cache size
      
      * Clean-up
      
      * Reduce risk of errors due to typos
      
      * Removed option on database cache size
      
      * Added NOTE as suggested
      
      * Added doc as suggested
      
      * Fixed test
      
      * typo
      
      * renamed runtime to runner
      
      * Fixed weird argument
      
      * More commas
      
      * Moved client/cli-derive to client/cli/derive
      
      * Added 7 tests for the macros
      
      * Improve error message
      
      * Upgrade assert_cmd
      
      * Fixing missing stuff
      
      * Fixed unused import
      
      * Improve SubstrateCli doc
      
      * Applied suggestions
      
      * Fix and clean-up imports
      
      * Started replacing macros WIP
      
      * WIP
      
      Forked at: d6aa8e95
      Parent branch: origin/master
      
      * WIP
      
      Forked at: d6aa8e95
      Parent branch: origin/master
      
      * WIP
      
      Forked at: d6aa8e95
      Parent branch: origin/master
      
      * Started removing substrate_cli
      
      * WIP
      
      Forked at: d6aa8e95
      Parent branch: origin/master
      
      * WIP
      
      Forked at: d6aa8e95
      Parent branch: origin/master
      
      * WIP
      
      Forked at: d6aa8e95
      
      
      Parent branch: origin/master
      
      * fixed bug introduced while refactoring
      
      * Renamed NetworkConfigurationParams to NetworkParams for consistency sake
      
      * Fixed test
      
      * Update client/cli/src/commands/runcmd.rs
      
      Co-Authored-By: default avatarBastian Köcher <[email protected]>
      
      * Update client/cli/src/commands/runcmd.rs
      
      Co-Authored-By: default avatarBastian Köcher <[email protected]>
      
      * Update client/cli/src/commands/export_blocks_cmd.rs
      
      Co-Authored-By: default avatarBastian Köcher <[email protected]>
      
      * Update client/cli/src/commands/check_block_cmd.rs
      
      Co-Authored-By: default avatarBastian Köcher <[email protected]>
      
      * Update bin/node/cli/src/command.rs
      
      Co-Authored-By: default avatarBastian Köcher <[email protected]>
      
      * Update bin/node/cli/src/command.rs
      
      Co-Authored-By: default avatarBastian Köcher <[email protected]>
      
      * Update client/cli/src/commands/export_blocks_cmd.rs
      
      Co-Authored-By: default avatarBastian Köcher <[email protected]>
      
      * Revert "Update client/cli/src/commands/export_blocks_cmd.rs"
      
      This reverts commit 5906776953392c02beac6bc0bf50f8cbe1a12a01.
      
      * Revert "Update client/cli/src/commands/check_block_cmd.rs"
      
      This reverts commit f705f42b7f3d732be001141afee210fe46a1ef47.
      
      * Revert "Update client/cli/src/commands/export_blocks_cmd.rs"
      
      This reverts commit 8d57c0550164449e6eb2d3bacb04c750c714fcea.
      
      * Revert "Update client/cli/src/commands/runcmd.rs"
      
      This reverts commit 93e74cf5d2e1c0dc49cdff8608d59fc40fc59338.
      
      * Revert "Update client/cli/src/commands/runcmd.rs"
      
      This reverts commit 11d527ba345c0d79f0d3b5b071933d95474d0614.
      
      * Update client/cli/src/commands/export_blocks_cmd.rs
      
      Co-Authored-By: default avatarBastian Köcher <[email protected]>
      
      * Update client/cli/src/commands/import_blocks_cmd.rs
      
      Co-Authored-By: default avatarBastian Köcher <[email protected]>
      
      * Update client/cli/src/commands/purge_chain_cmd.rs
      
      Co-Authored-By: default avatarBastian Köcher <[email protected]>
      
      * Changed ::sc_cli to $crate in the macro
      
      * fixed tests
      
      * fixed conflicts
      
      * Fixing test
      
      * Update client/cli/src/commands/purge_chain_cmd.rs
      
      Co-Authored-By: default avatarBastian Köcher <[email protected]>
      
      * Update client/cli/src/params/pruning_params.rs
      
      Co-Authored-By: default avatarBastian Köcher <[email protected]>
      
      * Remove comment as suggested
      
      * Apply suggestion
      
      * Update client/cli/src/commands/purge_chain_cmd.rs
      
      Co-Authored-By: default avatarBastian Köcher <[email protected]>
      
      * Update client/cli/src/commands/purge_chain_cmd.rs
      
      Co-Authored-By: default avatarBastian Köcher <[email protected]>
      
      * Update client/cli/src/commands/purge_chain_cmd.rs
      
      Co-Authored-By: default avatarBastian Köcher <[email protected]>
      
      * Update utils/frame/benchmarking-cli/src/command.rs
      
      Co-Authored-By: default avatarBastian Köcher <[email protected]>
      
      * Update client/cli/src/runner.rs
      
      Co-Authored-By: default avatarBastian Köcher <[email protected]>
      
      * Update client/cli/src/runner.rs
      
      Co-Authored-By: default avatarBastian Köcher <[email protected]>
      
      * Update client/cli/src/runner.rs
      
      Co-Authored-By: default avatarBastian Köcher <[email protected]>
      
      * Update client/cli/src/params/pruning_params.rs
      
      Co-Authored-By: default avatarBastian Köcher <[email protected]>
      
      * Update client/cli/src/params/node_key_params.rs
      
      Co-Authored-By: default avatarBastian Köcher <[email protected]>
      
      * Update client/cli/src/params/network_params.rs
      
      Co-Authored-By: default avatarBastian Köcher <[email protected]>
      
      * Update client/cli/src/lib.rs
      
      Co-Authored-By: default avatarBastian Köcher <[email protected]>
      
      * Update client/cli/src/config.rs
      
      Co-Authored-By: default avatarBastian Köcher <[email protected]>
      
      * Added doc
      
      * Fixed error introduced after applying suggestion
      
      * Revert "Update client/cli/src/params/pruning_params.rs"
      
      This reverts commit 0574d06a4f1efd86e94c1214420a12e7a4be0099.
      
      * Print error
      
      * Apply suggestions from code review
      
      * Remove useless Results
      
      * Fixed CI failing on polkadot approval
      
      Co-authored-by: default avatarSeun Lanlege <[email protected]>
      Co-authored-by: default avatarBastian Köcher <[email protected]>
      3da069e3
  2. Apr 06, 2020
  3. Apr 05, 2020
  4. Apr 04, 2020
  5. Apr 03, 2020
  6. Apr 02, 2020
  7. Apr 01, 2020
  8. Mar 31, 2020
    • Nikolay Volf's avatar
      remove ws feature from json client (#5478) · 159d830d
      Nikolay Volf authored
      159d830d
    • Max Inden's avatar
      client/finality-grandpa: Instrument until-imported queue (#5438) · 09133578
      Max Inden authored
      
      
      * client/finality-grandpa: Instrument until-imported queue
      
      The `UntilImported` queue takes as input finality grandpa messages that
      depend on blocks that are not yet imported and holds them back until
      those blocks are imported.
      
      This commit adds a basic metric, the amount of messages waiting in the
      queue, to the module. For now this metric is only available for the
      global `UntilImported` queue awaiting blocks for commit and catch-up
      messages.
      
      * client/finality-grandpa/src/until_imported: Update metric help text
      
      Co-Authored-By: default avatarAshley <[email protected]>
      
      Co-authored-by: default avatarAshley <[email protected]>
      09133578
    • Pierre Krieger's avatar
      Increase limit on light client response size (#5461) · f04486e5
      Pierre Krieger authored
      * Increase limit on light client response size
      
      * Address review
      f04486e5
    • Bastian Köcher's avatar
      Implements mocking of runtime apis (#5448) · 954dca68
      Bastian Köcher authored
      
      
      * Implements mocking of runtime apis
      
      This pr adds support for easily mock runtime api implementations for
      tests by using the `mock_impl_runtime_apis!` macro. The syntax is
      similar to `impl_runtime_apis!`. The mocked implementation automatically
      implements `ApiExt`, `ApiErrorExt` and `Core` as these are required by
      the runtime api traits, but not required in tests or only a subset of them.
      
      * Fix warnings
      
      * Update primitives/api/proc-macro/src/utils.rs
      
      Co-Authored-By: default avatarNikolay Volf <[email protected]>
      
      * Review feedback
      
      Co-authored-by: default avatarNikolay Volf <[email protected]>
      954dca68
    • Nikolay Volf's avatar
      And one more fix to flaky tests (#5467) · b4d83a4b
      Nikolay Volf authored
      * imporoved intervallier version
      
      * remove extra event
      
      * use version 0.3.1
      
      * fix warning
      b4d83a4b
    • Cecile Tonglet's avatar
      Allow changing the behavior for imported blocks (#5236) · 439887a7
      Cecile Tonglet authored
      * Added option to disable default block announce
      
      * Added on_block_imported on NetworkService
      
      * Revert "Added on_block_imported on NetworkService"
      
      This reverts commit ba360cad96e0cb041d7047af30df2a35eb112449.
      
      * Do not announce block if set to not announce block
      
      * Revert fix
      
      * Moving default announce block to NetworkConfig
      
      * WIP
      
      Forked at: ad90ab7e
      Parent branch: origin/master
      
      * WIP
      
      Forked at: ad90ab7e
      Parent branch: origin/master
      
      * Removing boolean in favor of explicit call
      
      * Fixing tests
      
      * WIP
      
      Forked at: ad90ab7e
      Parent branch: origin/master
      
      * WIP
      
      Forked at: ad90ab7e
      Parent branch: origin/master
      
      * increase spec_version
      
      * increase spec_version
      
      * Fixed test
      
      * Fixing test
      
      * Renamed should_announce_imported_blocks to announce_imported_blocks
      
      * Updated assert_cmd
      439887a7
  9. Mar 30, 2020
    • Stanislav Tkach's avatar
    • Max Inden's avatar
      src/service/src/builder: Fix memory metric exposed in bytes not KiB (#5459) · c3c8552a
      Max Inden authored
      The library `sysinfo` exposes process memory as kibibytes and not bytes,
      thus the value needs to be multiplied by 1024 to comply with the metric
      name and the Prometheus base units [1].
      
      [1] https://prometheus.io/docs/practices/naming/#base-units
      c3c8552a
    • Pierre Krieger's avatar
      Fix tried to send handshake twice (#5413) · dbba4f89
      Pierre Krieger authored
      * Fix tried to send handshake twice
      
      * Fix wrong boolean
      
      * Change to debug
      dbba4f89
    • Rakan Alhneiti's avatar
      Introduce `sign_with` method in keystore (#4925) · e17a23e9
      Rakan Alhneiti authored
      
      
      * Add KEY_KIND_ID to the public trait
      
      This change is being introduced for the purpose of identifying a public
      key with it's identifier and algorithm "kind".
      
      * Use `sign_with` as implemented in BareCryptoStore
      
      * Implement `sign_with` in sc_keystore
      
      * Fix inconsistencies, use *_KIND_ID in sp_core testing
      
      * Rename KeyKindId to CryptoTypeId
      
      * Remove pair-returning functions from BareCryptoStore trait
      
      * Define CryptoTypeId in app-crypto macros
      
      * Add functions to get keys supported by keystore
      
      * Fix sign_with signature to include CryptoTypePublicPair
      
      * Add `sign_with_any` and `sign_with_all`
      
      * Use keystore.sign_with in auth_discovery
      
      * Rename get_supported_keys -> supported_keys
      
      * Added headers to function docstrings
      
      * Use chain instead of extending a temp vector
      
      * Fixed some code formatting
      
      * Restrict size of CryptoTypeId
      
      This is to be able to use Encode/Decode derives and the overcome having
      the size being unknown at compile-time.
      
      * Implement sign_with in the trait itself
      
      * Remove whitespace
      
      * Use key_type also as a CryptoTypeId in app_crypto macros
      
      * Rename `get_keys` to `keys` in BareCryptoStore
      
      * Remove usage of key_pair funcs in tests
      
      * Adjust docstring for *_CYPTO_ID constants
      
      * Fix failures
      
      * Simplify mapping on keys
      
      * Remove one let
      
      * Fixed typo
      
      * PR feedback
      
      * remove whitespace
      
      * Zip keys and signatures
      
      * Use into_iter & remove cloned
      
      * Pass index to MissingSignature
      
      * Use typed errors instead of strings for BareCryptoStore
      
      * Implement Debug for trait error
      
      * Use hashsets for better performance for supported_keys
      
      * Make sure keys are inserted into the keystore
      
      * Make sign_with_all return type consistent with `sign_with`
      
      * Rename Error to BareCryptoStoreError
      
      * Rename CRYPT_TYPE_ID -> CRYPTO_ID
      
      * Remove unnecessary CRYPTO_ID declaration in Public trait
      
      * Convert pub key to CryptoTypePublicPair
      
      * Fix use
      
      * Fix code style
      
      * Implement From on CryptoTypePublicPair in app_crypto macros
      
      * Change CryptoTypePublicPair to a struct
      
      * Implement Display on CryptoTypePublicPair
      
      * Pass CryptoTypePublicPair to MissingSignature error
      
      * Adjust docs according to function signature
      
      * Unify keys implementation
      
      * Fix RPC author tests
      
      * Fix stackoverflow
      
      * Tabify spaces
      
      * Pass KeyTypeId to error for easier debugging
      
      * Fix asserts
      
      * Use ToHex to format public key
      
      * Use constants from sp_core
      
      * Rename testing KeyTypeId constants
      
      * Please compiler
      
      * Restore KeyTypeId names
      
      apparently, they're not only used in tests
      
      * Use BareCryptoStoreError instead of String
      
      * Document return value
      
      * Fix borrow check
      
      * Convert to hashset internally
      
      * WIP - iter_keys
      
      * Return raw_public_keys
      
      * Address PR feedback
      
      * Address PR Feedback
      
      * Fix hexdisplay import error
      
      * Update primitives/core/src/traits.rs
      
      Co-authored-by: default avatarBastian Köcher <[email protected]>
      e17a23e9
    • Pierre Krieger's avatar
      Make transactions and block announces use notifications substre… (#5360) · 462eaa3f
      Pierre Krieger authored
      * Make transactions and block announces use notifications
      
      * Add documentation
      462eaa3f
    • pscott's avatar
      Build for only one target for docs.rs (#5427) · 408455f8
      pscott authored
      * Add docs.rs metadata to all cargo.toml files
      
      * Remove docs.rs metada in substrate's cargo.toml
      408455f8
  10. Mar 29, 2020
  11. Mar 28, 2020
  12. Mar 27, 2020
  13. Mar 26, 2020
    • Web3 Philosopher's avatar
      Adds state_queryStorageAt (#5362) · ab0f7d21
      Web3 Philosopher authored
      
      
      * adds state_queryStorageAt
      
      * make at param for query_storage_at optional
      
      * Update client/rpc/src/state/state_full.rs
      
      Co-Authored-By: default avatarTomasz Drwięga <[email protected]>
      
      * adds query_storage_at to StateBackend
      
      Co-authored-by: default avatarTomasz Drwięga <[email protected]>
      ab0f7d21
    • Max Inden's avatar
      client/finality-grandpa/src/until_imported: Refactor schedule_wait (#5386) · 2a67e6c4
      Max Inden authored
      
      
      * client/finality-grandpa/src/until_imported: Refactor schedule_wait
      
      Previously `BlockUntilImported::schedule_wait` took two closures, one to
      report ready items and one to report items to await. None of the implementors of
      `BlockUntilImported` call both closures. From a symantic perspective it
      would as well not make sense to both await something and state that it
      is ready.
      
      Instead with this commit `BlockUntilImported::schedule_wait` simply
      returns whether the given item needs waiting or is ready to be passed
      on.
      
      This reduces complexity by:
      
      - Removing side effects through the two closures.
      
      - Reducing borrowing given that `UntilImported` `ready` and `pending`
      don't need to be borrowed from within the two closures.
      
      - Removes the need for trait bounds for the two closures.
      
      * client/finality-grandpa/src/until_imported: Fix comments
      
      Co-Authored-By: default avatarAndré Silva <[email protected]>
      
      Co-authored-by: default avatarAndré Silva <[email protected]>
      2a67e6c4