Skip to content
  1. Jul 08, 2020
  2. Jul 07, 2020
  3. Jul 06, 2020
    • asynchronous rob's avatar
      Implement the Statement Distribution Subsystem (#1326) · ac8e1ca2
      asynchronous rob authored
      * set up data types and control flow for statement distribution
      
      * add some set-like methods to View
      
      * implement sending to peers
      
      * start fixing equivocation handling
      
      * Add a section to the statement distribution subsystem on equivocations and flood protection
      
      * fix typo and amend wording
      
      * implement flood protection
      
      * have peer knowledge tracker follow when peer first learns about a candidate
      
      * send dependents after circulating
      
      * add another TODO
      
      * trigger send in one more place
      
      * refactors from review
      
      * send new statements to candidate backing
      
      * instantiate active head data with runtime API values
      
      * track our view changes and peer view changes
      
      * apply a benefit to peers who send us statements we want
      
      * remove unneeded TODO
      
      * add some comments and improve Hash implementation
      
      * start tests and fix `note_statement`
      
      * test active_head seconding logic
      
      * test that the per-peer tracking logic works
      
      * test per-peer knowledge tracker
      
      * test that peer view updates lead to messages being sent
      
      * test statement circulation
      
      * address review comments
      
      * have view set methods return references
      ac8e1ca2
    • Bastian Köcher's avatar
      Companion for #6576 (#1351) · 72d0f096
      Bastian Köcher authored
      * Companion for #6576
      
      * 'Update substrate'
      
      Co-authored-by: parity-processbot <>
      72d0f096
    • Shawn Tabrizi's avatar
      Companion for #6567 (Benchmark Writer CLI) (#1349) · 4af14c51
      Shawn Tabrizi authored
      * Update usage of macro
      
      * 'Update substrate'
      
      * cargo update -p sp-io
      
      Co-authored-by: parity-processbot <>
      4af14c51
  4. Jul 05, 2020
    • Peter Goodspeed-Niklaus's avatar
      implement custom proposer (#1320) · f2104562
      Peter Goodspeed-Niklaus authored
      
      
      * network bridge skeleton
      
      * move some primitives around and add debug impls
      
      * protocol registration glue & abstract network interface
      
      * add send_msgs to subsystemctx
      
      * select logic
      
      * transform different events into actions and handle
      
      * implement remaining network bridge state machine
      
      * start test skeleton
      
      * make network methods asynchronous
      
      * extract subsystem out to subsystem crate
      
      * port over overseer to subsystem context trait
      
      * fix minimal example
      
      * fix overseer doc test
      
      * update network-bridge crate
      
      * write a subsystem test-helpers crate
      
      * write a network test helper for network-bridge
      
      * set up (broken) view test
      
      * Revamp network to be more async-friendly and not require Sync
      
      * fix spacing
      
      * fix test compilation
      
      * insert side-channel for actions
      
      * Add some more message types to AllMessages
      
      * introduce a test harness
      
      * impl ProvideInherent for InclusionInherent
      
      * reduce import churn; correct expect message
      
      * move inclusion inherent identifier into primitives
      
      It's not clear precisely why this is desired, but it's a pattern
      I've seen in several places, so I'm going this to be on the
      safe side. Worst case, we can revert this commit pretty easily.
      
      * bump kusama spec_version to placate CI
      
      * copy sc_basic_authorship::{ProposerFactory, Proposer}
      
      We have from the problem description:
      
      > This Proposer will require an OverseerHandle to make requests via.
      
      That's next on the plate.
      
      * use polkadot custom proposer instead of basic-authorship one
      
      * add some tests
      
      * ensure service compiles and passes tests
      
      * fix typo
      
      * fix service-new compilation
      
      * Subsystem test helpers send messages synchronously
      
      * remove smelly action inspector
      
      * remove superfluous let binding
      
      * fix warnings
      
      * add license header
      
      * empty commit; maybe github will notice the one with changes
      
      * Update node/network/bridge/src/lib.rs
      
      Co-authored-by: default avatarPeter Goodspeed-Niklaus <[email protected]>
      
      * add sanity check to only include valid inherents
      
      * stub: encapsulate block production mechanics instead of copying them
      
      The goal is to end up with something like what's in
      validation::block_production::*, which encapsulates
      basic block production mechanics. This is a better idea than
      just straight-up copying those mechanics.
      
      * partial implementation of propose fn
      
      Doesn't actually compile yet; need to bring in some other
      commits to ensure ProvisionerMessage is a thing, and also
      figure out how to get the block hash given the current
      context.
      
      * fix compilation
      
      * clear a few more compile errors
      
      * finish fn propose
      
      * broken: add timeout to proposal
      
      * add timeout to proposal
      
      * guide: provisioner is responsible for selecting parachain candidates
      
      * implement ProvisionerMessage::RequestInherentData & update fn propose
      
      * impl CreateProposer::init; clean up
      
      * impl std::error::Error for Error
      
      * document error-handling rationale
      
      * cause polkadot-service-new to compile correctly
      
      * Move potentially-blocking call from fn init -> fn propose
      
      This means that we can wrap the delayed call into the same
      timeout check used elsewhere.
      
      * document struct Proposer
      
      * extract provisioner data fetch
      
      This satisfies two requirements:
      
      - only applies the timeout to actually fetching the provisioner data,
        not to constructing the block after
      - simplifies the problem of injecting default data if we could not
        get the real provisioner data in time.
      
      Co-authored-by: default avatarRobert Habermeier <[email protected]>
      Co-authored-by: default avatarGavin Wood <[email protected]>
      f2104562
  5. Jul 04, 2020
    • André Silva's avatar
      babe: enable equivocation reporting on all runtimes (#1330) · 19ef40a7
      André Silva authored
      
      
      * enable BABE equivocation reporting on all runtimes
      
      * runtime: fix parachains mock test runtime
      
      * cargo update -p sp-io
      
      Co-authored-by: default avatarShawn Tabrizi <[email protected]>
      19ef40a7
    • Bastian Köcher's avatar
      Make a collator send a collation as backup as well (#1353) · f77b8139
      Bastian Köcher authored
      Currently a collator will only send a collation to validators it is a
      primary for. While testing this could lead to the situation that the
      same collator was registered as prime for all Parachain validators but
      failed for other reasons to generate a PoVBlock. However no other
      collator was sending a collation, which stopped the Parachain until the
      faulty collator was stopped.
      
      This pr solves this problem by making sure that every collator sends a
      collation to one of his validators he is connected to, but registered as backup.
      f77b8139
  6. Jul 03, 2020
    • Gavin Wood's avatar
      Reduce Westend deposit requirements (#1341) · 79954ae5
      Gavin Wood authored
      
      
      * Switch branch
      
      * Return chain ops parts in new_chain_ops
      
      * Remove where param from new_chain_ops
      
      * Add task manager to new_chain_ops return
      
      * Revert branch switch
      
      * Revert "Revert branch switch"
      
      This reverts commit 7c7900c047abd794ddc759aa092811db4961a7a6.
      
      * network/test/src/lib: Adjust network worker polling
      
      Companion for https://github.com/paritytech/substrate/pull/6552.
      
      * Fix adder parachain
      
      * Fix collator tests
      
      * Revert branch switch
      
      * Bump everything
      
      - Remove old migration code
      - Reduce deposit requried for westend
      
      * Reapply fixes
      
      * Bump locl
      
      * Fix for #6550
      
      * Fix message
      
      Co-authored-by: default avatarAshley Ruglys <[email protected]>
      Co-authored-by: default avatarMax Inden <[email protected]>
      79954ae5
    • Bastian Köcher's avatar
      Check candidate signatures before including them in `set_heads` (#1335) · e7bb3aef
      Bastian Köcher authored
      * Check candidate signatures before including them in `set_heads`
      
      This work around the bug described in: https://github.com/paritytech/polkadot/issues/1327
      
      We check the candidate signatures in `create_inherent` to ensure that
      all are valid. If one isn't valid, we don't include any candidate for
      the current inherent.
      
      * Bump runtimes
      e7bb3aef
  7. Jul 02, 2020
  8. Jul 01, 2020
  9. Jun 30, 2020
    • asynchronous rob's avatar
      Subsystem::start takes self by-value (#1325) · 2a3e607d
      asynchronous rob authored
      * Subsystem::start takes self by-value
      
      * fix doc-test compilation
      2a3e607d
    • Cecile Tonglet's avatar
      Use spawner to spawn work task instead of tokio (#1328) · cb592450
      Cecile Tonglet authored
      * Use spawner to spawn work task instead of tokio
      
      This allows the caller to choose the runtime they want (instead of tokio).
      
      * Replace generic by actual type
      cb592450
    • Shawn Tabrizi's avatar
      Companion for #6511 (#1321) · b42d7ba4
      Shawn Tabrizi authored
      * Add custom runtime upgrade for retract tip
      
      * cargo update -p sp-io
      b42d7ba4
    • Bastian Köcher's avatar
      Companion for Substrate #6508 (#1329) · c8a03906
      Bastian Köcher authored
      * Companion for Substrate #6508
      
      * Update Cargo.lock
      c8a03906
    • asynchronous rob's avatar
      Implement Network Bridge (#1280) · d16e7485
      asynchronous rob authored
      
      
      * network bridge skeleton
      
      * move some primitives around and add debug impls
      
      * protocol registration glue & abstract network interface
      
      * add send_msgs to subsystemctx
      
      * select logic
      
      * transform different events into actions and handle
      
      * implement remaining network bridge state machine
      
      * start test skeleton
      
      * make network methods asynchronous
      
      * extract subsystem out to subsystem crate
      
      * port over overseer to subsystem context trait
      
      * fix minimal example
      
      * fix overseer doc test
      
      * update network-bridge crate
      
      * write a subsystem test-helpers crate
      
      * write a network test helper for network-bridge
      
      * set up (broken) view test
      
      * Revamp network to be more async-friendly and not require Sync
      
      * fix spacing
      
      * fix test compilation
      
      * insert side-channel for actions
      
      * Add some more message types to AllMessages
      
      * introduce a test harness
      
      * add some tests
      
      * ensure service compiles and passes tests
      
      * fix typo
      
      * fix service-new compilation
      
      * Subsystem test helpers send messages synchronously
      
      * remove smelly action inspector
      
      * remove superfluous let binding
      
      * fix warnings
      
      * Update node/network/bridge/src/lib.rs
      
      Co-authored-by: default avatarPeter Goodspeed-Niklaus <[email protected]>
      
      * fix compilation
      
      Co-authored-by: default avatarPeter Goodspeed-Niklaus <[email protected]>
      d16e7485
    • Peter Goodspeed-Niklaus's avatar
      impl ProvideInherent for InclusionInherent (#1318) · 90de5591
      Peter Goodspeed-Niklaus authored
      * impl ProvideInherent for InclusionInherent
      
      * reduce import churn; correct expect message
      
      * move inclusion inherent identifier into primitives
      
      It's not clear precisely why this is desired, but it's a pattern
      I've seen in several places, so I'm going this to be on the
      safe side. Worst case, we can revert this commit pretty easily.
      
      * bump kusama spec_version to placate CI
      
      * add license header
      
      * empty commit; maybe github will notice the one with changes
      
      * add sanity check to only include valid inherents
      90de5591
    • Ashley's avatar
      Companion PR for `Remove the service, replacing it with a struct of individual... · b26f6d08
      Ashley authored
      
      Companion PR for `Remove the service, replacing it with a struct of individual chain components` (#1288)
      
      * Switch branch
      
      * Fix service things
      
      * Fix browser node compilation
      
      * Update branch
      
      * fixed new service
      
      * Update for new branch
      
      * Fix browser node
      
      * Update branch
      
      * Revert "Switch branch"
      
      This reverts commit 3623adff7681124a1539a385a718c34e85931254.
      
      * Update cargo.lock
      
      Co-authored-by: default avatarBastian Köcher <[email protected]>
      b26f6d08
  10. Jun 27, 2020
  11. Jun 26, 2020
  12. Jun 25, 2020
  13. Jun 24, 2020
  14. Jun 23, 2020
    • Bastian Köcher's avatar
      Make `produce_candidate` return an `Option` (#1309) · 2dfe8ffc
      Bastian Köcher authored
      * Make `produce_candidate` return an `Option`
      
      Instead of `produce_candidate` returning a `Result`, it should return an
      `Option`. The only supported error was `InvalidHead` anyway and Cumulus
      will take care to print appropriate information on what failed and
      Polkadot can just ignore it.
      
      * Fix warning
      2dfe8ffc