Skip to content
  1. Jul 31, 2023
  2. Jul 30, 2023
  3. Jul 29, 2023
  4. Jul 28, 2023
  5. Jul 27, 2023
  6. Jul 26, 2023
    • Muharem Ismailov's avatar
      Pallets: Asset Rate - Rename AssetId to AssetKind, Introduce AssetKindFactory Trait (#14514) · 99fc51ce
      Muharem Ismailov authored
      
      
      * asset-rate rename asset_id to asset_kind
      
      * asset-rate pallet benchmarks asset kind factory
      
      * rename to SEED
      
      * fixes
      
      * Update frame/asset-rate/src/benchmarking.rs
      
      Co-authored-by: default avatarjoe petrowski <[email protected]>
      
      * sp-core optional dep
      
      * sp-core included for benchmarks
      
      * sp-core to dev dep
      
      * sp-core add dep prefix
      
      ---------
      
      Co-authored-by: default avatarjoe petrowski <[email protected]>
      99fc51ce
    • PG Herveou's avatar
      Contracts Add deposit for dependencies (#14079) · 5a5b1df6
      PG Herveou authored
      
      
      * wip
      
      * fixes
      
      * rm comment
      
      * join fns
      
      * clippy
      
      * Fix limits
      
      * reduce diff
      
      * fix
      
      * fix
      
      * fix typo
      
      * refactor store to  use self
      
      * refactor run to take self by value
      
      * pass tests
      
      * rm comment
      
      * fixes
      
      * fix typo
      
      * rm
      
      * fix fmt
      
      * clippy
      
      * ".git/.scripts/commands/bench/bench.sh" pallet dev pallet_contracts
      
      * Update frame/contracts/src/lib.rs
      
      Co-authored-by: default avatarSasha Gryaznov <[email protected]>
      
      * Update frame/contracts/src/wasm/mod.rs
      
      Co-authored-by: default avatarSasha Gryaznov <[email protected]>
      
      * Update frame/contracts/src/wasm/mod.rs
      
      Co-authored-by: default avatarSasha Gryaznov <[email protected]>
      
      * PR review, rm duplicate increment_refcount
      
      * PR review
      
      * Update frame/contracts/src/wasm/prepare.rs
      
      Co-authored-by: default avatarSasha Gryaznov <[email protected]>
      
      * Add test for failing storage_deposit
      
      * fix lint
      
      * wip
      
      * Delegate update take 2
      
      * update
      
      * fix migration
      
      * fix migration
      
      * doc
      
      * fix lint
      
      * update migration
      
      * fix warning
      
      * reformat comment
      
      * regenerate weightInfo trait
      
      * fix merge
      
      * PR review
      
      https://github.com/paritytech/substrate/pull/14079#discussion_r1255904563
      
      * PR review
      
      https://github.com/paritytech/substrate/pull/14079/files#r1257521373
      
      * PR review remove optimisation
      
      https://github.com/paritytech/substrate/pull/14079/files#r1263312237
      
      * PR review fix return type
      
      https://github.com/paritytech/substrate/pull/14079/files#r1263315804
      
      * Apply suggestions from code review
      
      Co-authored-by: default avatarAlexander Theißen <[email protected]>
      
      * PR review pass CodeInfo and update docstring
      
      https://github.com/paritytech/substrate/pull/14079/files#r1257522327
      
      * PR review add code_info to the executable
      
      https://github.com/paritytech/substrate/pull/14079/files#r1263309049
      
      * rename info -> contract_info
      
      * Update frame/contracts/src/exec.rs
      
      Co-authored-by: default avatarAlexander Theißen <[email protected]>
      
      * Update frame/contracts/fixtures/add_remove_delegate_dependency.wat
      
      Co-authored-by: default avatarAlexander Theißen <[email protected]>
      
      * Update frame/contracts/src/migration/v13.rs
      
      * fix tests
      
      * Fmt & fix tests
      
      * Test Result<(), _> return type
      
      * Update frame/contracts/src/migration.rs
      
      Co-authored-by: default avatarAlexander Theißen <[email protected]>
      
      * Revert "Test Result<(), _> return type"
      
      This reverts commit a876168f2054edf84d720c666387583ccbe78dcd.
      
      * add / update doc comments
      
      * fix backticks
      
      * Revert "Revert "Test Result<(), _> return type""
      
      This reverts commit 3cbb6161d1abd9520cd9f8519b4dfbf4f29a2998.
      
      * fix bench
      
      * fix bench
      
      * fix
      
      * Update frame/contracts/src/storage/meter.rs
      
      Co-authored-by: default avatarAlexander Theißen <[email protected]>
      
      * rm stale comments
      
      * Apply suggestions from code review
      
      Co-authored-by: default avatarSasha Gryaznov <[email protected]>
      
      * PR suggestion
      
      * Add missing doc
      
      * fx lint
      
      * ".git/.scripts/commands/bench/bench.sh" --subcommand=pallet --runtime=dev --target_dir=substrate --pallet=pallet_contracts
      
      * Update frame/contracts/src/lib.rs
      
      Co-authored-by: default avatarJuan <[email protected]>
      
      ---------
      
      Co-authored-by: command-bot <>
      Co-authored-by: default avatarSasha Gryaznov <[email protected]>
      Co-authored-by: default avatarAlexander Theißen <[email protected]>
      Co-authored-by: default avatarJuan <[email protected]>
      5a5b1df6
    • Cyrill Leutwiler's avatar
      A subtle bug in the bool predicate for checking against chain extension... · 47bb475d
      Cyrill Leutwiler authored
      
      A subtle bug in the bool predicate for checking against chain extension imports prevents importing the non-prefixed version even if chain extension are enabled are enabled (#14642)
      
      Signed-off-by: default avatarCyrill Leutwiler <[email protected]>
      47bb475d
  7. Jul 25, 2023
    • Marijn Schouten's avatar
      change HashFor to HashingFor (#14483) · c9b54e10
      Marijn Schouten authored
      * change HashFor to HashingFor
      
      * fmt
      
      * ".git/.scripts/commands/fmt/fmt.sh"
      
      ---------
      
      Co-authored-by: command-bot <>
      c9b54e10
    • Alexandru Vasile's avatar
      chainHead_storage: Iterate over keys (#14628) · 00787a10
      Alexandru Vasile authored
      
      
      * chainHead: Iterate over key,values and key,hashes
      
      Signed-off-by: default avatarAlexandru Vasile <[email protected]>
      
      * chainHead/tests: Multi query with iteration over keys
      
      Signed-off-by: default avatarAlexandru Vasile <[email protected]>
      
      * chainHead/events: Fix typo in StorageQuery
      
      Signed-off-by: default avatarAlexandru Vasile <[email protected]>
      
      * chainHead: Take 10 from key iterator
      
      Signed-off-by: default avatarAlexandru Vasile <[email protected]>
      
      ---------
      
      Signed-off-by: default avatarAlexandru Vasile <[email protected]>
      Co-authored-by: parity-processbot <>
      00787a10
    • Anton's avatar
      chore: update libp2p to 0.52.1 (#14429) · 59d8b864
      Anton authored
      * update libp2p to 0.52.0
      
      * proto name now must implement `AsRef<str>`
      
      * update libp2p version everywhere
      
      * ToSwarm, FromBehaviour, ToBehaviour
      
      also LocalProtocolsChange and RemoteProtocolsChange
      
      * new NetworkBehaviour invariants
      
      * replace `Vec<u8>` with `StreamProtocol`
      
      * rename ConnectionHandlerEvent::Custom to NotifyBehaviour
      
      * remove DialError & ListenError invariants
      
      also fix pending_events
      
      * use connection_limits::Behaviour
      
      See https://github.com/libp2p/rust-libp2p/pull/3885
      
      * impl `void::Void` for `BehaviourOut`
      
      also use `Behaviour::with_codec`
      
      * KademliaHandler no longer public
      
      * fix StreamProtocol construction
      
      * update libp2p-identify to 0.2.0
      
      * remove non-existing methods from PollParameters
      
      rename ConnectionHandlerUpgrErr to StreamUpgradeError
      
      * `P2p` now contains `PeerId`, not `Multihash`
      
      * use multihash-codetable crate
      
      * update Cargo.lock
      
      * reformat text
      
      * comment out tests for now
      
      * remove `.into()` from P2p
      
      * confirm observed addr manually
      
      See https://github.com/libp2p/rust-libp2p/blob/master/protocols/identify/CHANGELOG.md#0430
      
      * remove SwarmEvent::Banned
      
      since we're not using `ban_peer_id`, this can be safely removed.
      we may want to introduce `libp2p::allow_block_list` module in the future.
      
      * fix imports
      
      * replace `libp2p` with smaller deps in network-gossip
      
      * bring back tests
      
      * finish rewriting tests
      
      * uncomment handler tests
      
      * Revert "uncomment handler tests"
      
      This reverts commit 720a06815887f4e10767c62b58864a7ec3a48e50.
      
      * add a fixme
      
      * update Cargo.lock
      
      * remove extra From
      
      * make void uninhabited
      
      * fix discovery test
      
      * use autonat protocols
      
      confirming external addresses manually is unsafe in open networks
      
      * fix SyncNotificationsClogged invariant
      
      * only set server mode manually in tests
      
      doubt that we need to set it on node since we're adding public addresses
      
      * address @dmitry-markin comments
      
      * remove autonat
      
      * removed unused var
      
      * fix EOL
      
      * update smallvec and sha2
      
      in attempt to compile polkadot
      
      * bump k256
      
      in attempt to build cumulus
      
      ---------
      
      Co-authored-by: parity-processbot <>
      59d8b864
    • Just van Stam's avatar
      changes to nfts pallet for xcm integration (#14395) · ae018a01
      Just van Stam authored
      
      
      * Use Incrementable from frame_support::traits
      
      * Chore
      
      * make incremental fallible and new nfts function for custom collection ids
      
      * fmt
      
      * fix benchmark tests nfts
      
      * add test
      
      * fmt
      
      * add safety comment to CollectionId
      
      * fmt
      
      * add comments to Incrementable
      
      * line wrapping
      
      * rewrap comments
      
      * address feedback
      
      * fmt
      
      * change unwrap for expect
      
      ---------
      
      Co-authored-by: default avatarJegor Sidorenko <[email protected]>
      Co-authored-by: parity-processbot <>
      ae018a01
  8. Jul 24, 2023
    • Sam Johnson's avatar
      upgrade to macro_magic 0.4.2 (#14627) · 5e6bbfa0
      Sam Johnson authored
      * upgrade to macro_magic 0.4.2
      
      * also change in Cargo.toml
      5e6bbfa0
    • Gonçalo Pestana's avatar
      Removes incorrect try-state check in staking (#14186) · 9ac344e6
      Gonçalo Pestana authored
      Co-authored-by: parity-processbot <>
      9ac344e6
    • Michal Kucharczyk's avatar
      `test-runtime`: `GenesisBuilder` runtime API impl + tests (#14310) · 53cbda1d
      Michal Kucharczyk authored
      
      
      * test-runtime: GenesisBuilder runtime API impl + tests
      
      This PR provides implementation of `GenesisBuilder` API for `substrate-test-runtime`, can be considered as reference imiplementation for other runtimes.
      The `GenesisBuilder` implementation is gated by `gensis-config` feature.
      
      Tested scenarios:
      - default `GenesisConfig` to JSON blob,
      - deserialization of `GenesisConfig` from custom JSON, and storing its keys into the Storage (genesis storage creation).
      - creation of genesis storage using partial JSON definition,
      - checking if invalid/renamed JSON files causes the runtime to panic,
      
      * missing file added
      
      * client: GenesisBuilder helper added
      
      * feature renamed: genesis-config -> genesis-builder
      
      * Update Cargo.toml
      
      * Update Cargo.toml
      
      * Update Cargo.toml
      
      * Update Cargo.toml
      
      * redundant function removed
      
      * genesis builder helper: introduced RuntimeGenesisBuild
      
      * test-runtime: get rid of unused T
      
      * redundant bound removed
      
      * helper: use GenesisBuild again
      
      * tests adjusted for on_genesis
      
      * test-runtime: support for BuildGenesisConfig
      
      * helper: BuildGenesisConfig support
      
      * Update client/genesis-builder/src/lib.rs
      
      Co-authored-by: default avatarDavide Galassi <[email protected]>
      
      * Update test-utils/runtime/src/test_json/readme.md
      
      Co-authored-by: default avatarDavide Galassi <[email protected]>
      
      * Update test-utils/runtime/src/test_json/readme.md
      
      Co-authored-by: default avatarDavide Galassi <[email protected]>
      
      * Update test-utils/runtime/src/genesismap.rs
      
      Co-authored-by: default avatarDavide Galassi <[email protected]>
      
      * jsons are now human-friendly
      
      * fix
      
      * improvements
      
      * jsons fixed
      
      * helper: no_defaults added
      
      * test-runtime: no_defaults added
      
      * test-runtime: patching fn removed
      
      * helper: patching fn removed
      
      * helper: moved to frame_support
      
      * test-runtime: fixes
      
      * Cargo.lock updated
      
      * fmt + naming
      
      * test-runtime: WasmExecutor used
      
      * helper / test-runtime: struct removed
      
      * test-runtime: merge fixes
      
      * Cargo.lock + test-utils/runtime/Cargo.toml updated
      
      * doc fixed
      
      * client/rpc: test fixed (new rt api)
      
      * client/rpc-spec-v2: test fix
      
      * doc fix
      
      * test-runtime: disable-genesis-builder feature
      
      * fix
      
      * fix
      
      * ".git/.scripts/commands/fmt/fmt.sh"
      
      * test-runtime: rerun added to build script
      
      ---------
      
      Co-authored-by: default avatarDavide Galassi <[email protected]>
      Co-authored-by: parity-processbot <>
      53cbda1d
    • Sacha Lansky's avatar
      [fix lint warnings: Uniques pallet] fix clippy::doc_markdown warnings (#14592) · 7fdcb831
      Sacha Lansky authored
      
      
      * Fix clippy::doc_markdown warnings
      
      * Remove accidental commit of script
      
      * ".git/.scripts/commands/bench/bench.sh" pallet dev pallet_uniques
      
      * Some more backticks
      
      Signed-off-by: default avatarOliver Tale-Yazdi <[email protected]>
      
      * ".git/.scripts/commands/bench/bench.sh" pallet dev pallet_uniques
      
      ---------
      
      Signed-off-by: default avatarOliver Tale-Yazdi <[email protected]>
      Co-authored-by: command-bot <>
      Co-authored-by: default avatarOliver Tale-Yazdi <[email protected]>
      7fdcb831
    • Sacha Lansky's avatar
      [fix lint warnings: Uniques pallet] fix clippy::missing_docs_in_private_items warnings (#14591) · 18705986
      Sacha Lansky authored
      * Fix clippy::missing_docs_in_private_items
      
      * Fix clippy::missing_docs_in_private_items
      
      ---------
      
      Co-authored-by: parity-processbot <>
      18705986
    • Gonçalo Pestana's avatar
      Do not include voters that have zero voter weight in the election snapshot (#14245) · 9f92437c
      Gonçalo Pestana authored
      Co-authored-by: parity-processbot <>
      9f92437c
    • Aaro Altonen's avatar
      Accept only `--in-peers` many inbound full nodes in `SyncingEngine` (#14603) · f008e069
      Aaro Altonen authored
      * Accept only `--in-peers` many inbound full nodes in `SyncingEngine`
      
      Due to full and light nodes being stored in the same set, it's possible
      that `SyncingEngine` accepts more than `--in-peers` many inbound full
      nodes which leaves some of its outbound slots unoccupied.
      
      `ProtocolController` still tries to occupy these slots by opening
      outbound substreams. As these substreams are accepted by the remote peer,
      the connection is relayed to `SyncingEngine` which rejects the node
      because it's already full. This in turn results in the substream being
      inactive and the peer getting evicted.
      
      Fixing this properly would require relocating the light peer slot
      allocation away from `ProtocolController` or alternatively moving entire
      the substream validation there, both of which are epic refactorings and
      not necessarily in line with other goals. As a temporary measure, verify
      in `SyncingEngine` that it doesn't accept more than the specified amount
      of inbound full peers.
      
      * Fix tests
      
      * Apply review comments
      f008e069
  9. Jul 23, 2023
  10. Jul 21, 2023
  11. Jul 20, 2023
  12. Jul 19, 2023
  13. Jul 18, 2023