Skip to content
Snippets Groups Projects
  1. Nov 16, 2020
  2. Nov 11, 2020
    • Wei Tang's avatar
      Export app-crypto specific keystore functions (#7489) · 2bd9486b
      Wei Tang authored
      * Export app-crypto specific keystore functions
      
      * Also add back the insert function
      
      * Switch KeystoreContainer to an enum
      
      * Only export the bare minimal for LocalKeystore and fix service compile
      
      * fix: should return Arc
      
      * Add docs stating that functions only available in local keystore
      
      * Remove insert and generate functions
      
      * fix: generate function should be available in test
      
      * Add keypair function to trait
      
      * Revert "Add keypair function to trait"
      
      This reverts commit ad921b09ca73d3c09298e3a51b562ef8e0067781.
      
      * Add note for local_keystore function in service
      2bd9486b
  3. Oct 26, 2020
  4. Oct 23, 2020
  5. Oct 21, 2020
    • Cecile Tonglet's avatar
      Add node name to the log lines (#7328) · 8cebbd14
      Cecile Tonglet authored
      * Initial commit
      
      Forked at: 601e2fa1
      Parent branch: origin/master
      
      * WIP
      
      Forked at: 601e2fa1
      Parent branch: origin/master
      
      * WIP
      
      Forked at: 601e2fa1
      Parent branch: origin/master
      
      * WIP
      
      Forked at: 601e2fa1
      Parent branch: origin/master
      
      * WIP
      
      Forked at: 601e2fa1
      Parent branch: origin/master
      
      * WIP
      
      Forked at: 601e2fa1
      Parent branch: origin/master
      
      * CLEANUP
      
      Forked at: 601e2fa1
      Parent branch: origin/master
      
      * Add notes to original source code
      
      * CLEANUP
      
      Forked at: 601e2fa1
      Parent branch: origin/master
      
      * CLEANUP
      
      Forked at: 601e2fa1
      Parent branch: origin/master
      
      * WIP
      
      Forked at: 601e2fa1
      Parent branch: origin/master
      
      * WIP
      
      Forked at: 601e2fa1
      Parent branch: origin/master
      
      * WIP
      
      Forked at: 601e2fa1
      Parent branch: origin/master
      
      * CLEANUP
      
      Forked at: 601e2fa1
      Parent branch: origin/master
      
      * WIP
      
      Forked at: 601e2fa1
      Parent branch: origin/master
      
      * Some doc
      
      * Test with trybuild
      
      * Revert "Test with trybuild" (issue with trybuild atm)
      
      This reverts commit 9055ec2206808ba3ddce6e3d87eb358907fa5e42.
      
      https://github.com/dtolnay/trybuild/issues/53
      
      * Apply suggestions
      
      * Rename derive to proc-macro
      
      * Remove "prefix" feature from informant
      
      * Blocking task should use SpawnHandle::spawn_blocking
      
      * Improve doc as suggested
      
      * Fixes
      
      Forked at: 601e2fa1
      
      
      Parent branch: origin/master
      
      * Apply suggestion
      
      * Update client/cli/proc-macro/src/lib.rs
      
      Co-authored-by: default avatarBastian Köcher <bkchr@users.noreply.github.com>
      
      * More suggestions
      
      * CLEANUP
      
      Forked at: 601e2fa1
      Parent branch: origin/master
      
      * Improve error message
      
      * CLEANUP
      
      Forked at: 601e2fa1
      Parent branch: origin/master
      
      * Fix async issue
      
      * CLEANUP
      
      Forked at: 601e2fa1
      Parent branch: origin/master
      
      * CLEANUP
      
      Forked at: 601e2fa1
      
      
      Parent branch: origin/master
      
      * Add test
      
      * fix doc test
      
      * Update client/cli/src/logging.rs
      
      Co-authored-by: default avatarBastian Köcher <bkchr@users.noreply.github.com>
      
      * Update client/basic-authorship/src/basic_authorship.rs
      
      Co-authored-by: default avatarBastian Köcher <bkchr@users.noreply.github.com>
      
      * Update client/basic-authorship/src/basic_authorship.rs
      
      Co-authored-by: default avatarBastian Köcher <bkchr@users.noreply.github.com>
      
      * Apply suggestions
      
      * Suggestions
      
      * Clarify doc
      
      * WIP
      
      Forked at: 601e2fa1
      
      
      Parent branch: origin/master
      
      Co-authored-by: default avatarBastian Köcher <bkchr@users.noreply.github.com>
      8cebbd14
  6. Oct 18, 2020
  7. Oct 15, 2020
    • Ashley's avatar
      Add missing fields to the light sync state (#7225) · d1ef8507
      Ashley authored
      * Initial draft
      
      * Add an iterator that helps us get most items
      
      * Revert changes to grandpa
      
      * Change fields to just be the grandpa authority set and babe epoch changes
      
      * Only use the fields we need from the shared authority set
      
      * Switch to RPC call
      
      * Revert "Only use the fields we need from the shared authority set"
      
      This reverts commit 6ede87b0c5fe53f251d7cb45951006a7dc8f9b83.
      
      * Add babe_finalized_block_weight from `ashley-improve-sync-state-WIP-loading`
      
      * Fix rpc test
      
      * Move sync state rpc stuff into sc-sync-state-rpc
      
      * Remove as_json_value and remove unwraps from sc-sync-state-rpc
      
      * Add clone_inner to SharedAuthoritySet
      d1ef8507
  8. Oct 13, 2020
  9. Oct 08, 2020
    • Rakan Alhneiti's avatar
      Async keystore + Authority-Discovery async/await (#7000) · 3aa4bfac
      Rakan Alhneiti authored
      
      * Asyncify sign_with
      
      * Asyncify generate/get keys
      
      * Complete BareCryptoStore asyncification
      
      * Cleanup
      
      * Rebase
      
      * Add Proxy
      
      * Inject keystore proxy into extensions
      
      * Implement some methods
      
      * Await on send
      
      * Cleanup
      
      * Send result over the oneshot channel sender
      
      * Process one future at a time
      
      * Fix cargo stuff
      
      * Asyncify sr25519_vrf_sign
      
      * Cherry-pick and fix changes
      
      * Introduce SyncCryptoStore
      
      * SQUASH ME WITH THE first commit
      
      * Implement into SyncCryptoStore
      
      * Implement BareCryptoStore for KeystoreProxyAdapter
      
      * authority-discovery
      
      * AURA
      
      * BABE
      
      * finality-grandpa
      
      * offchain-workers
      
      * benchmarking-cli
      
      * sp_io
      
      * test-utils
      
      * application-crypto
      
      * Extensions and RPC
      
      * Client Service
      
      * bin
      
      * Update cargo.lock
      
      * Implement BareCryptoStore on proxy directly
      
      * Simplify proxy setup
      
      * Fix authority-discover
      
      * Pass async keystore to authority-discovery
      
      * Fix tests
      
      * Use async keystore in authority-discovery
      
      * Rename BareCryptoStore to CryptoStore
      
      * WIP
      
      * Remote mutable borrow in CryptoStore trait
      
      * Implement Keystore with backends
      
      * Remove Proxy implementation
      
      * Fix service builder and keystore user-crates
      
      * Fix tests
      
      * Rework authority-discovery after refactoring
      
      * futures::select!
      
      * Fix multiple mut borrows in authority-discovery
      
      * Merge fixes
      
      * Require sync
      
      * Restore Cargo.lock
      
      * PR feedback - round 1
      
      * Remove Keystore and use LocalKeystore directly
      
      Also renamed KeystoreParams to KeystoreContainer
      
      * Join
      
      * Remove sync requirement
      
      * Fix keystore tests
      
      * Fix tests
      
      * client/authority-discovery: Remove event stream dynamic dispatching
      
      With authority-discovery moving from a poll based future to an `async`
      future Rust has difficulties propagating the `Sync` trade through the
      generated state machine.
      
      Instead of using dynamic dispatching, use a trait parameter to specify
      the DHT event stream.
      
      * Make it compile
      
      * Fix submit_transaction
      
      * Fix block_on issue
      
      * Use await in async context
      
      * Fix manual seal keystore
      
      * Fix authoring_blocks test
      
      * fix aura authoring_blocks
      
      * Try to fix tests for auth-discovery
      
      * client/authority-discovery: Fix lookup_throttling test
      
      * client/authority-discovery: Fix triggers_dht_get_query test
      
      * Fix epoch_authorship_works
      
      * client/authority-discovery: Remove timing assumption in unit test
      
      * client/authority-discovery: Revert changes to termination test
      
      * PR feedback
      
      * Remove deadcode and mark test code
      
      * Fix test_sync
      
      * Use the correct keyring type
      
      * Return when from_service stream is closed
      
      * Convert SyncCryptoStore to a trait
      
      * Fix line width
      
      * Fix line width - take 2
      
      * Remove unused import
      
      * Fix keystore instantiation
      
      * PR feedback
      
      * Remove KeystoreContainer
      
      * Revert "Remove KeystoreContainer"
      
      This reverts commit ea4a37c7d74f9772b93d974e05e4498af6192730.
      
      * Take a ref of keystore
      
      * Move keystore to dev-dependencies
      
      * Address some PR feedback
      
      * Missed one
      
      * Pass keystore reference - take 2
      
      * client/finality-grandpa: Use `Arc<dyn CryptoStore>` instead of SyncXXX
      
      Instead of using `SyncCryptoStorePtr` within `client/finality-grandpa`,
      which is a type alias for `Arc<dyn SyncCryptoStore>`, use `Arc<dyn
      CryptoStore>`. Benefits are:
      
      1. No additional mental overhead of a `SyncCryptoStorePtr`.
      
      2. Ability for new code to use the asynchronous methods of `CryptoStore`
      instead of the synchronous `SyncCryptoStore` methods within
      `client/finality-granpa` without the need for larger refactorings.
      
      Note: This commit uses `Arc<dyn CryptoStore>` instead of
      `CryptoStorePtr`, as I find the type signature more descriptive. This is
      subjective and in no way required.
      
      * Remove SyncCryptoStorePtr
      
      * Remove KeystoreContainer & SyncCryptoStorePtr
      
      * PR feedback
      
      * *: Use CryptoStorePtr whereever possible
      
      * *: Define SyncCryptoStore as a pure extension trait of CryptoStore
      
      * Follow up to SyncCryptoStore extension trait
      
      * Adjust docs for SyncCryptoStore as Ben suggested
      
      * Cleanup unnecessary requirements
      
      * sp-keystore
      
      * Use async_std::task::block_on in keystore
      
      * Fix block_on std requirement
      
      * Update primitives/keystore/src/lib.rs
      
      Co-authored-by: default avatarMax Inden <mail@max-inden.de>
      
      * Fix wasm build
      
      * Remove unused var
      
      * Fix wasm compilation - take 2
      
      * Revert async-std in keystore
      
      * Fix indent
      
      * Fix version and copyright
      
      * Cleanup feature = "std"
      
      * Auth Discovery: Ignore if from_service is cloed
      
      * Max's suggestion
      
      * Revert async-std usage for block_on
      
      * Address PR feedback
      
      * Fix example offchain worker build
      
      * Address PR feedback
      
      * Update Cargo.lock
      
      * Move unused methods to test helper functions
      
      * Restore accidentally deleted cargo.lock files
      
      * Fix unused imports
      
      Co-authored-by: default avatarMax Inden <mail@max-inden.de>
      Co-authored-by: default avatarShawn Tabrizi <shawntabrizi@gmail.com>
      3aa4bfac
  10. Sep 18, 2020
    • Anton Gavrilov's avatar
      Prometheus metrics for RPC calls (#7088) · 2c5a82f8
      Anton Gavrilov authored
      * WS and HTTP middlewares added
      
      * Prometheus endpoint added
      
      * Counters renamed
      
      * Proper style for inc
      
      * Metrics initialization re-written
      
      * Rework to handler middleware
      
      * Introduce transport prefix for metrics
      
      * String shortened
      
      * Commented code removed, new line inserted
      
      * One more string shortened
      
      * Wasm build fixed
      
      * Wasm build fixed once again
      
      * Rework to shared metrics
      
      * Added collectors label
      
      * Tilde removed from cargo
      
      * Switch to owned metrics in parameters
      2c5a82f8
  11. Sep 17, 2020
    • Wei Tang's avatar
      Use tracing-based subscriber logging (#6825) · 9fdd4672
      Wei Tang authored
      
      * init_logger: switch from log-based to tracing-based and add compatibility layer
      
      * Move tracing profiling subscriber related config realization
      
      * sp-tracing: change profiling to be a layer instead of a subscriber
      
      * Enable profiling layer in cli
      
      * Change all test env_logger init to sp_tracing::try_init_simple
      
      * Remove all local env_logger dependency
      
      * Add missing tracing-subscriber dependency
      
      * frame-sudo: fix tests
      
      * frame-support: fix tests
      
      * Fix frame/pallet and executor tests
      
      * Fix the remaining tests
      
      * Use subscriber's try_init as recommended by @davidbarsky
      
      * Be explict that the tracing-log feature is needed
      
      * Set subscriber writer to stderr
      
      * Shorter line width
      
      * Update cargo lock tracing version
      
      * Fix sc_tracing crate compile
      
      * Fix sc_authority_discovery crate test
      
      * unremove default-features
      
      * Leave enabled to default true
      
      * Warn if global default cannot be set
      
      * Fix unused import
      
      * Remove unused PROXY_TARGET
      
      * Change all reference from rc5 to rc6
      
      * Change all reference of rc2 to rc6
      
      * Fix styling
      
      * Fix typo
      
      * make logger init error'ing
      
      * re-fixing the test issue
      
      Co-authored-by: default avatarBenjamin Kampmann <ben@parity.io>
      9fdd4672
  12. Sep 16, 2020
    • Bastian Köcher's avatar
      Send import notification always for re-orgs (#7118) · 0a6f7b08
      Bastian Köcher authored
      
      * Send import notification always for re-orgs
      
      This pr changes the behavior of sending import notifications. Before we
      only send notifications when importing blocks on the tip of the chain or
      on similar conditions. However we did not send a notification when we
      for example being in a state where we import multiple blocks to catch
      up. If we re-org in this process, systems like the transaction pool
      would not be notified about this re-org. This means, that we would also
      not resubmit transactions of these retracted blocks. This pr fixes this,
      by always sending a notification on a re-org.
      
      See
      https://github.com/substrate-developer-hub/substrate-node-template/issues/82
      for some context about the bug.
      
      * Update client/service/src/client/client.rs
      
      Co-authored-by: default avatarAndré Silva <123550+andresilva@users.noreply.github.com>
      
      Co-authored-by: default avatarAndré Silva <123550+andresilva@users.noreply.github.com>
      0a6f7b08
  13. Sep 14, 2020
  14. Sep 11, 2020
  15. Sep 10, 2020
  16. Sep 06, 2020
    • Roman Borschel's avatar
      Refactor & detach network metrics. (#6986) · ec478772
      Roman Borschel authored
      * Refactor sc-network/service metrics.
      
        1. Aggregate sc-network metrics into a submodule, introducing
        two more sourced metrics to avoid duplicate atomics.
      
        2. Decouple periodic sc-service network metrics from other
        metrics, so that they can be updated independently.
      
      * Update client/service/src/metrics.rs
      
      * Update client/service/src/metrics.rs
      ec478772
  17. Aug 26, 2020
  18. Aug 24, 2020
  19. Aug 15, 2020
  20. Aug 14, 2020
    • Roman Borschel's avatar
      Update to libp2p-0.23. (#6870) · 327e0294
      Roman Borschel authored
      * Update to libp2p-0.23.
      
      Thereby incorporate bandwidth measurement along the
      lines previously done by libp2p itself.
      
      * Tweak dependencies for wasm32 compilation.
      
      For wasm32 we need to enable unstable features to
      make `task::Builder::local` available.
      
      * Simplify dependencies.
      
      * Simplify.
      
      Leave the calculation of bytes sent/received per second
      to the outer layers of the code, subject to their own
      individual update intervals.
      
      * Cleanup
      
      * Re-add lost dev dependency.
      
      * Avoid division by zero.
      
      * Remove redundant metric.
      
      * Enable sending of noise legacy handshakes.
      
      * Add comment about monotonic gauge.
      
      * CI
      327e0294
  21. Aug 10, 2020
    • Hernando Castano's avatar
      Add Subscription RPC for Grandpa Finality (#5732) · 433b7214
      Hernando Castano authored
      
      * Rough skeleton for what I think the RPC should look like
      
      * Create channel for sending justifications
      
      Sends finalized header and justification from Grandpa to the
      client. This lays the groundwork for hooking into the RPC module.
      
      * WIP: Add subscribers for justifications to Grandpa
      
      Adds the Sender end of a channel into Grandpa, through which notifications
      about block finality events can be sent.
      
      * WIP: Add a struct for managing subscriptions
      
      Slightly different approach from the last commit, but same
      basic idea. Still a rough sketch, very much doesn't compile yet.
      
      * Make naming more clear and lock data in Arc
      
      * Rough idea of what RPC would look like
      
      * Remove code from previous approach
      
      * Missed some things
      
      * Update client/rpc-api/src/chain/mod.rs
      
      Co-Authored-By: default avatarTomasz Drwięga <tomusdrw@users.noreply.github.com>
      
      * Update client/rpc-api/src/chain/mod.rs
      
      Co-Authored-By: default avatarTomasz Drwięga <tomusdrw@users.noreply.github.com>
      
      * Split justification subscription into sender and receiver halves
      
      * Replace RwLock with a Mutex
      
      * Add sample usage from the Service's point of view
      
      * Remove code that referred to "chain_" RPC
      
      * Use the Justification sender/receivers from Grandpa LinkHalf
      
      * Add some PubSub boilerplate
      
      * Add guiding comments
      
      * TMP: comment out to fix compilation
      
      * Return MetaIoHandler from PubSubHandler in create_full
      
      * Uncomment pubsub methods in rpc handler (fails to build)
      
      * node/rpc: make Metadata concrete in create_full to fix compilation
      
      * node: pass in SubscriptionManger to grandpa rpc handler
      
      * grandpa-rpc: use SubscriptionManger to add subscriber
      
      * grandpa-rpc: attempt at setting up the justification stream (fails to build)
      
      * grandpa-rpc: fix compilation of connecting stream to sink
      
      * grandpa-rpc: implement unsubscribe
      
      * grandpa-rpc: update older tests
      
      * grandpa-rpc: add full prefix to avoid confusing rust-analyzer
      
      * grandpa-rpc: add test for pubsub not available
      
      * grandpa-rpc: tidy up leftover code
      
      * grandpa-rpc: add test for sub and unsub of justifications
      
      * grandpa-rpc: minor stylistic changes
      
      * grandpa-rpc: split unit test
      
      * grandpa-rpc: minor stylistic changes in test
      
      * grandpa-rpc: skip returning future when cancelling
      
      * grandpa-rpc: reuse testing executor from sc-rpc
      
      * grandpa-rpc: don't need to use PubSubHandler in tests
      
      * node-rpc: use MetaIoHandler rather than PubSubHandler
      
      * grandpa: log if getting header failed
      
      * grandpa: move justification channel creation into factory function
      
      * grandpa: make the justification sender optional
      
      * grandpa: fix compilation warnings
      
      * grandpa: move justification notification types to new file
      
      * grandpa-rpc: move JustificationNotification to grandpa-rpc
      
      * grandpa-rpc: move JustificationNotification to its own file
      
      * grandpa: rename justification channel pairs
      
      * grandpa: rename notifier types
      
      * grandpa: pass justification as GrandpaJustification to the rpc module
      
      * Move Metadata to sc-rpc-api
      
      * grandpa-rpc: remove unsed error code
      
      * grandpa: fix bug for checking if channel is closed before sendind
      
      * grandpa-rpc: unit test for sending justifications
      
      * grandpa-rpc: update comments for the pubsub test
      
      * grandpa-rpc: update pubsub tests with more steps
      
      * grandpa-rpc: fix pubsub test
      
      * grandpa-rpc: minor indendation
      
      * grandpa-rpc: decode instead of encode in test
      
      * grandpa: fix review comments
      
      * grandpa: remove unused serde dependency
      
      Co-authored-by: default avatarTomasz Drwięga <tomusdrw@users.noreply.github.com>
      Co-authored-by: default avatarJon Häggblad <jon.haggblad@gmail.com>
      Co-authored-by: default avatarTomasz Drwięga <tomasz@parity.io>
      433b7214
  22. Aug 07, 2020
  23. Aug 06, 2020
  24. Aug 05, 2020
  25. Jul 31, 2020
  26. Jul 28, 2020
  27. Jul 26, 2020
  28. Jul 22, 2020
    • Ashley's avatar
      Remove the service builder (#6557) · ffa2177d
      Ashley authored
      
      * :)
      
      * Slight tidy
      
      * Remove ServiceBuilderCommand
      
      * Remove whitespace
      
      * Keep task manager alive for check_block/import_blocks
      
      * Pass task_manager to run_until_exit
      
      * WIP
      
      * WIP
      
      * Get rid of the macros
      
      * Simplify a few chain components creation APIs related to the service
      
      * Fix basic-authorship doc tests
      
      * Remove DefaultQueue
      
      * Update client/service/src/builder.rs
      
      Co-authored-by: default avatarAndré Silva <123550+andresilva@users.noreply.github.com>
      
      * Move ExecutionExtensions comment around
      
      * Remove unused BlakeTwo256
      
      * Add sc-prelude
      
      * Rename sc-prelude to sc-service-prelude
      
      * Rename to sc-service-types
      
      * Improve service types
      
      * Fix line widths
      
      * Remove sc-service-types and move type definitions to crates
      
      * Update bin/node-template/node/src/service.rs
      
      Co-authored-by: default avatarSeun Lanlege <seunlanlege@gmail.com>
      
      * Add TLightClientWithHash
      
      * Rework types
      
      Co-authored-by: default avatarAndré Silva <123550+andresilva@users.noreply.github.com>
      Co-authored-by: default avatarSeun Lanlege <seunlanlege@gmail.com>
      ffa2177d
    • Benjamin Kampmann's avatar
      Update to latest sysinfo prevents leaking fd-handlers (#6708) · 7c161ec1
      Benjamin Kampmann authored
      * Ensure we close old file handles hold by sysinfo
      
      * Dropping is needed unfortunately
      
      * enable process refreshing, ignore result from refresh_process
      
      * jumping to proposed patch
      
      * switch to latest sysinfo
      7c161ec1
    • Cecile Tonglet's avatar
      Graceful shutdown for the task manager (#6654) · de318107
      Cecile Tonglet authored
      * Initial commit
      
      Forked at: 74655ede
      
      
      Parent branch: origin/master
      
      * Move task_manager.rs to mod.rs
      
      * Graceful shutdown for the task manager
      
      * Await all background task JoinHandle at the same time
      
      * Add tests
      
      * Make future() wait also for exit signal + fix essential task failed
      
      Probably related to https://github.com/paritytech/cumulus/issues/111
      
      * add comments for non-obvious code
      
      * Use clean_shutdown() in sc-cli
      
      * Adapt code and upgrade tokio in sc-cli
      
      * cleanup spacing in doc
      
      * Add license
      
      * I guess actually running the clean shutdown would be a good idea
      
      * fix tests
      
      * Update client/cli/src/runner.rs
      
      Co-authored-by: default avatarBenjamin Kampmann <ben@gnunicorn.org>
      
      * Improve error logging
      
      * disable other tests (can't reproduce on my machine)
      
      * Revert "disable other tests (can't reproduce on my machine)"
      
      This reverts commit c133c590f33c253123ba0555ce719a71ededd60d.
      
      * It is possible that the tasks are ended first
      
      * Revert "It is possible that the tasks are ended first"
      
      This reverts commit 502aba4a49fb5d892e704c412b8a81768a3f2c71.
      
      * Use single threaded scheduler for more predictability
      
      * enable_time
      
      * Revert "enable_time"
      
      This reverts commit 4e152140764a4bddeedff06a4e36ec701909e8c7.
      
      * Revert "Use single threaded scheduler for more predictability"
      
      This reverts commit ee5e13c5f13ff71e012dcda13579dffeb15f8ffc.
      
      * Revert "Revert "It is possible that the tasks are ended first""
      
      This reverts commit 1b91a8ca3eebbdc18be199c8ca188e88669ae649.
      
      * This cannot be verified either with a threaded pool
      
      * Apply suggestions from code review
      
      Co-authored-by: default avatarBastian Köcher <bkchr@users.noreply.github.com>
      
      Co-authored-by: default avatarBenjamin Kampmann <ben@parity.io>
      Co-authored-by: default avatarBenjamin Kampmann <ben@gnunicorn.org>
      Co-authored-by: default avatarBastian Köcher <bkchr@users.noreply.github.com>
      de318107
  29. Jul 21, 2020
  30. Jul 16, 2020
  31. Jul 10, 2020
  32. Jul 09, 2020